When using "Dynamic gateway policy" on an interface, a route-to rule will omit the (unknown) address.
This logically means both protocols could be served by the same gateway entry.
To ease future migrations from PPP to MVC/API and reduce the
config field "localip" misuse we want to phase out PPTP and
reduce complexity of the implementation.
While L2TP may be still around the PPTP tunneling is very likely
not used anymore. A bit of a message to everyone still using this.
Only one way to find out.
PHP Warning: Undefined array key "localip" in /usr/local/etc/inc/interfaces.inc on line 1192
PHP Warning: Undefined array key "gateway" in /usr/local/etc/inc/interfaces.inc on line 1196
ErrorException: Using null as an array offset is deprecated, use an empty string instead in /usr/local/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php:162
Stack trace:
The function is called via $reload hook so adding another
hook makes no sense. This may have changed since the original
commit below and since we need to priv-sep these calls the
easiest way is to remove it. ;)
See also: https://github.com/pfsense/pfsense/commit/8e11b23f541d
As discussed internally, we want to aim for this to be the new standard,
but we will not migrate any existing setups just yet. This may need more
documentation/annotation for components (mostly legacy plugins) where this
won't work, but it's a very good start to root these out via user reports.
The local reconfigureAction() only started or reloaded monit when the
whole output of "monit -t" was exactly "Control file syntax OK", so the
first Apply on a new install ("New Monit id: ...") and any deprecation
warning left monit stopped or not reloaded while reporting "ok".
Drop it, and checkAction(), in favor of ApiMutableServiceControllerBase.
Move "set log" to the top of monitrc: monit only logs a parse error
after it has parsed "set log", so an invalid control file now leaves
its reason in the monit log, whether rc refused the reload or monit
refused to start.
Fixes https://github.com/opnsense/core/issues/10928
In e0e1401f87 we're enabling it always which also affects
assigned tunnels such as WireGuard which tend to avoid wanting
DAD so make room for leaving the flag unchanged and change it
everywhere else explicitly per type.
'newwanip' is misused sometimes and never called in static configurations.
The only consumer is the RFC2136 plugin but maybe that changes in the
future. The plugin also listens on "bootup" and "local" so simply making
a global event for use at the spots where it exists is enough.
As normalizedPort() is only used to pass values in nat rules, it's more consistent to replace 'any' with empty as that's what the firewall parser would also do.
Next we need to make sure only numeric values are being used in calculations and the upper bound [65535] is respected in all cases.
Ad Schellevis