pydantic/pydantic-ai
1
0
Fork 0
mirror of https://github.com/pydantic/pydantic-ai.git synced 2026-10-12 02:21:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make complete-partial-pr maintainer-neutral (#6464)

Browse Source
This commit is contained in:
David SF
2026-07-17 09:21:54 -05:00
committed by GitHub
parent 8481c72789
commit 9ffbcf732e
2 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.agents/skills/complete-partial-pr/SKILL.md
+2 -2
View File
@@ -143,7 +143,7 @@ Push back on expanding the PR only when the broader behavior is genuinely a sepa
If choosing broader scope or explicitly deferring an adjacent surface, append a concise entry to `.claude/skills/branch-context/pr-decisions.md` with the source that justified the decision.
If the broader fix changes public API, provider semantics, durable behavior, or safety posture in a non-obvious way, ask David before coding or draft a PR comment/proposal instead of silently expanding the branch.
If the broader fix changes public API, provider semantics, durable behavior, or safety posture in a non-obvious way, ask a maintainer before coding or draft a PR comment/proposal instead of silently expanding the branch.
### 8. Implement Conservatively
@@ -178,7 +178,7 @@ git branch -vv
git status --short --branch
```
If posting a GitHub comment, start with `David's AICA here: `. Summarize:
If posting a GitHub comment, summarize:
- What the original PR covered.
- What additional integration surfaces were checked.
tests/test_embeddings.py
+16 -6
View File
@@ -1681,8 +1681,7 @@ class TestGoogle:
@pytest.mark.skipif(not sentence_transformers_imports_successful(), reason='SentenceTransformers not installed')
class TestSentenceTransformers:
@pytest.fixture(scope='session')
def stsb_bert_tiny_model(self):
def _load_stsb_bert_tiny_model(self):
# The pinned commit revision lets huggingface_hub serve every model file
# straight from a warm cache without revalidating it against the Hub.
# Construction still fires a few metadata requests (model card, repo tree,
@@ -1691,12 +1690,10 @@ class TestSentenceTransformers:
# (see ci.yml); a cold cache downloads the model here on first use.
try:
model = SentenceTransformer(STSB_BERT_TINY_MODEL, revision=STSB_BERT_TINY_REVISION)
except (OSError, RuntimeError, httpx.HTTPError) as e: # pragma: lax no cover
except (OSError, RuntimeError, httpx.HTTPError) as e:
# Skip only when the Hub is unavailable (see `_hf_hub_unavailable`) so a
# HF outage never reds the whole suite; anything else (bad pin, auth
# problem, corrupt cache, dependency mismatch) fails loudly. `lax`
# because this path runs only during outages: coverage must tolerate
# both outcomes.
# problem, corrupt cache, dependency mismatch) fails loudly.
if not _hf_hub_unavailable(e):
raise
pytest.skip(f'sentence-transformers test model unavailable (HF Hub): {e}')
@@ -1707,6 +1704,19 @@ class TestSentenceTransformers:
model.model_card_data.generate_widget_examples = False # Disable widget examples generation for testing
return model
@pytest.fixture(scope='session')
def stsb_bert_tiny_model(self):
return self._load_stsb_bert_tiny_model()
def test_model_unavailable(self, monkeypatch: pytest.MonkeyPatch):
monkeypatch.setattr(f'{__name__}.SentenceTransformer', MagicMock(side_effect=httpx.ConnectTimeout('offline')))
skip = MagicMock(side_effect=RuntimeError('skipped'))
monkeypatch.setattr(pytest, 'skip', skip)
with pytest.raises(RuntimeError, match='skipped'):
self._load_stsb_bert_tiny_model()
skip.assert_called_once_with('sentence-transformers test model unavailable (HF Hub): offline')
@pytest.fixture
def embedder(self, stsb_bert_tiny_model: Any) -> Embedder:
return Embedder(SentenceTransformerEmbeddingModel(stsb_bert_tiny_model))