Commit Graph

2459 Commits

Author SHA1 Message Date
Graham Christensen
9aa947471f
Docs: Make builds reproducible by generating the same IDs from the same inputs 2019-02-07 17:33:59 -05:00
Jan Niklas Hasse
52ba207890 Fix Fuchsia typo 2019-02-05 18:07:20 +01:00
Jan Niklas Hasse
0c158431f3 mark this 1.9.0.git 2019-01-30 19:57:14 +01:00
Jan Niklas Hasse
908ca0eaaf
Merge pull request #1525 from avallee/patch-1
ninja_syntax.py: remove unused has_path argument
2019-01-30 15:31:22 +01:00
Alex Vallee
c6b67ac402
ninja_syntax.py: remove unused has_path argument
The usage of the parameter was removed a long time ago and was never cleaned up. The argument is not provided in the test.
2019-01-30 22:12:52 +08:00
Jan Niklas Hasse
6e02ebc4b5
Remove outdated part about Chrome download, fix #1338 2018-12-20 12:58:09 +01:00
Jan Niklas Hasse
b735f796cd
Remove dead Chromium link, fix #1263 2018-11-25 13:58:17 +01:00
Jan Niklas Hasse
a47ac5a77e
Merge pull request #1484 from smeenai/gyp-to-gn
Change gyp to gn
2018-11-25 13:57:08 +01:00
Nico Weber
0a2e2cae70
Merge pull request #1039 from bradking/improve-depfile-parser
Fix depfile parser handling of multiple rules
2018-11-21 13:31:22 -05:00
Brad King
8a9edb1103 Restore depfile toleration of multiple output paths on distinct lines
Prior to introduction of depfile parser handling of multiple rules,
ninja silently accepted a depfile of the form:

    out: in1 in2 in3
    other: otherIn1 otherIn2 otherIn3

and incorrectly treated `other` and `otherIn*` as additional inputs to
`out`.  Now we prefer to reject this just as we already do for a depfile
specifying multiple outputs on one line.  However, this can break
existing cases where such a depfile was silently tolerated.

Add a `-w depfilemulti={err,warn}` option to control this behavior,
and make it just a warning by default.
2018-11-19 10:23:51 -05:00
Brad King
4a4f9d40e1 Fix depfile parser handling of multiple rules
Currently we handle Makefile rules of the form:

    out: in1 in2 in3

and the form:

    out: in1 \
         in2 \
         in3

Teach the depfile parser to handle the additional form:

    out: in1
    out: in2
    out: in3

This is also valid Makefile syntax and is the depfile format
generated by the Intel Compiler for Windows.

Note that the `gcc -MP` option adds empty phony rules to the generated
Makefile fragment:

    out: in1 in2 in3
    in1:
    in2:
    in3:

Previously we tolerated these because they were treated as inputs, which
was accidentally correct.  Instead we must now tolerate these by
ignoring targets for which no dependencies are specified.
2018-11-19 10:23:45 -05:00
Brad King
6d6dfd17e8 Fix depfile parser test case line continuation
Escape newlines for line continuation in the SpecialChars test case.
Otherwise the test does not cover valid Makefile syntax.  The missing
line continuation was tolerated by our parser but is never (not)
produced by a real compiler.
2018-11-19 10:22:01 -05:00
Brad King
94f4153da9 Re-arrange depfile parser token processing logic
Re-arrange the existing logic to support later addition of post-token
code even for empty tokens.
2018-11-19 10:18:24 -05:00
Brad King
a02132dac4 Re-generate depfile parser with re2cc 1.0.1 2018-11-19 10:18:14 -05:00
Takuto Ikuta
5a78423193 Add OSX build on travis (#1502)
Also make test script works for OSX script command.
2018-11-17 18:23:28 +01:00
Jan Niklas Hasse
cfd74e54fa Fit --help output into 80 columns and move verbose up, fix #1500 2018-11-16 14:07:45 +01:00
Jan Niklas Hasse
845213a9cd
Merge pull request #1474 from mathstuf/win32-invalid-parameter-help
Win32 invalid parameter help
2018-11-16 12:46:56 +01:00
Jan Niklas Hasse
516f637504
Merge pull request #1462 from GoaLitiuM/win10color
Enable ANSI escape sequences on Windows 10 terminals
2018-11-16 10:58:11 +01:00
Nico Weber
d5091ee974
Merge pull request #1439 from Lekensteyn/threaded-browse-py
browse.py: fix delay with multiple connections
2018-11-15 16:14:52 -05:00
Nico Weber
1c34a1517e
Merge pull request #1496 from mathstuf/minor-fixes
Minor fixes
2018-11-15 14:36:09 -05:00
Jan Niklas Hasse
f95f51bc6e
Merge pull request #1196 from danw/ReadFile_opt
Optimize ReadFile allocations
2018-11-14 17:50:40 +01:00
Jan Niklas Hasse
a63fb13322 Improve error message when Python wasn't found for the browse tool
See #1306.
2018-11-14 16:57:12 +01:00
Jan Niklas Hasse
2108bb3103 Explain why there's no browse tool, fix #1478 2018-11-14 16:39:14 +01:00
Ben Boeckel
70017a9def HACKING: use Python for the project 2018-11-14 09:55:00 -05:00
Ben Boeckel
4fd00f2681 HACKING: fix some whitespace nits 2018-11-14 09:54:43 -05:00
Jan Niklas Hasse
65f5d9633b Fix rendering of code block, fix #955 2018-11-14 15:09:19 +01:00
Martell Malone
378486ba6e Make -j 0 run unlimited parallel builds, fix #1309 2018-11-14 13:46:53 +01:00
GoaLitiuM
1b8ab152ea Enable ANSI escape sequences on Windows 10 terminals 2018-11-14 11:00:45 +02:00
Jan Niklas Hasse
a65f0d42dc
Merge pull request #1264 from gahr/DirName-compile-time
DirName's separators and their length are known at compile time
2018-11-13 17:14:06 +01:00
Jan Niklas Hasse
bf7517505a Add --verbose as an alternative spelling for -v, fix #1310 2018-11-13 16:56:22 +01:00
Jan Niklas Hasse
d3ea98a8c3 Add unit test for #1491 2018-11-13 15:17:43 +01:00
Jan Niklas Hasse
16e3a45b87
Merge pull request #1491 from mathstuf/elision-off-by-n
util: don't add ellipses width when deciding if they're necessary
2018-11-13 15:17:00 +01:00
Jan Niklas Hasse
bf7107bb86 Allow disabling of escape code stripping, fix #1475
Don't strip colors when CLICOLOR_FORCE is set to a non-zero value. This
environment variable is also used by CMake's Make back-end.
2018-11-13 15:15:43 +01:00
Ben Boeckel
1463fdc0f7 subprocess-win32: add hint on ERROR_INVALID_PARAMETER
This is generally associated with the command line being too long. Give
a hint to this case in the error message.
2018-11-09 10:51:17 -05:00
Ben Boeckel
e2aa04fdef Win32Fatal: support a "hint" for the error
The callsite might have extra context which is helpful for interpreting
the error message.
2018-11-09 10:51:17 -05:00
Ben Boeckel
6a9411e784 manual: mention the "invalid parameter" case
This happens often enough and the error message is quite unhelpful.
Mention this error explicitly in the documentation.
2018-11-09 10:51:17 -05:00
Ben Boeckel
d81cb42a37 util: don't add ellipses width when deciding if they're necessary
If the string fits, just use it. If we need the ellipses, *then* we need
to compute the width based on that.
2018-11-09 10:47:27 -05:00
Jan Niklas Hasse
99c5c2287b
Merge pull request #1307 from moroten/fix-too-long-path-test-bug
Verify GetFullPathName return value
2018-11-08 15:24:49 +01:00
Fredrik Medley
ef46561561 Verify GetFullPathName return value
GetFullPathName previously failed silently on long path names resulting
in uninitialized path result.

Signed-off-by: Fredrik Medley <fredrik.medley@autoliv.com>
2018-11-08 14:56:52 +01:00
Jan Niklas Hasse
44ed3743af Make output_test.py independent of the environment 2018-11-07 18:20:07 +01:00
Jan Niklas Hasse
0858f2ee48
Merge pull request #1488 from maciej-pawlowski-opera/issue-1227-2
Fix parsing some special chars in depfiles (take 2)
2018-11-07 12:07:35 +01:00
ikifof
0db30f237c Fix older VS compatibility issues and PDB files generation issue. (#1435)
Fixes #1411.
2018-11-07 11:32:29 +01:00
Maciej Pawlowski
3edc4d4110 Fix parsing some special chars in depfiles
This allows paths with "[", "]" and "%" to appear in depfiles.
Previously, only "[" would be handled properly.
Fixes #1227.
2018-11-07 11:22:37 +01:00
Maciej Pawlowski
edb848dd6c Regenerate depfile_parser.cc and lexer.cc with newer re2c 2018-11-07 11:07:29 +01:00
Jan Niklas Hasse
cf51ff558f
Merge pull request #1473 from zdave/query-term-stdout
Query terminal width from STDOUT_FILENO
2018-11-06 00:51:28 +01:00
Jan Niklas Hasse
19c294671c Exclude broken DiskInterfaceTests from MSVC, see #1423 2018-11-05 21:46:34 +01:00
Jan Niklas Hasse
a3f284ac35
Merge pull request #1326 from 0-wiz-0/master
Two fixes for NetBSD
2018-11-05 20:47:30 +01:00
Jan Niklas Hasse
9342a7e5ff
Merge pull request #1457 from V-for-Vasili/AIX-support
Port to AIX platform
2018-11-05 20:07:05 +01:00
Jan Niklas Hasse
3841023a44 Add test for #1418 (edge output should match status) 2018-11-05 18:52:51 +01:00
Jan Niklas Hasse
4baea2b826 Revert "Fix confusing smart console output from concurrent builds"
This reverts commit 52c1d0c8f8.

Fixes #1418.
2018-11-05 18:51:08 +01:00