Add template type for netlink msg with CMD and POLICY as
arguments, it can be used for all sendmsg calls in this file.
Refactor the existing code.
Signed-off-by: Amit Cohen <amitc@mellanox.com>
Most likely reports without proper stack traces were caused by a bug in the
unwinder and are now fixed in 187b96db5ca7 "x86/unwind/orc: Fix
unwind_get_return_address_ptr() for inactive tasks".
Disable trying to use questionable frames for now.
Fixes#1834
Github started adding me as reviewer on all PRs.
This is quite inconvinient because I can't figure out
if author really wants my review, or I was added just because of
the * entry. And then I can't remove myself.
Since I am looking at all PRs anyway, let's try without the * entry.
Informational mode should always produce "pass" result:
https://docs.codecov.io/docs/commit-status#informational
I can't get anything useful of these notifications.
E.g. now we have patches that add 1 line,
which gives 0% patch coverage, which results in a failure.
But we have some packages/commands not tested at all,
so we can't require contributors to make that covered.
For overall project coverage I also have not seen
any useful pass/fail results. The criteria highly depends
on the nature of the change. If we set the threshold too low,
we will get lots of effectively false failures. The current 50%
setting effectively means "never fail" anyway.
These checks still fire episodically [on gvisor instance only?].
I've done several attempts to debug this/extend checks.
But so far I have no glue and we are still seeing them.
They are rare enough to be directly debuggable and to be
something trivial. This may be some memory corruption
(kernel or our race), or some very episodic condition.
They are rare enough to be a problem, so don't include
syscall name so that they all go into a single bug bucket.
Improve used terminology by using better verbs to express the effect of
the whitelist/blacklist.
This also changes executor to exclusively show respectful log messages,
and as per recent conversion, converts the last such case.
Currently we are specifically picky about what errors
during build process are reported and what are not reported.
E.g. if we fail to create some temp file due to ENOSPSC,
we don't want to send email to all kernel developers.
However, we have not seen lots of infra failures and
we've seen silent errors which were unnoticed and/or
caused confusion as to what happens and why kernels
are not updated.
Report all errors.
If needed later we may explicitly ignore some errors instead.
Fixes#1777
We patched name in struct object, but the dwarf package
caches then and then can return in subsequent invocations.
This causes a struct name to be overwritten by typedef name.
Don't mutate returned struct objects.
The -alsologtostderr flag is a noop if -panic-log is also set. So before
this change, debug logs were not included in the syzkaller output logs.
By setting -debug-log=/dev/stderr, all debug logs are sent to stderr,
which syzkaller scrapes and includes in the output logs.
