[PR #3] Replace assert statements with proper exception handling #3

New Issue

2026-02-16T04:16:32-05:00

yindo commented

2026-02-16 04:16:32 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/investments-review-agent/pull/3
Author: @DeanNeaht
Created: 2/5/2026
Status: 🔄 Open

Base: main ← Head: fix/replace-asserts-with-proper-errors

📝 Commits (1)

bd5effc Replace assert statements with proper exception handling

📊 Changes

3 files changed (+34 additions, -8 deletions)

View changed files

➕ src/investments_review/exceptions.py (+22 -0)
📝 src/investments_review/presentations/workflow.py (+5 -4)
📝 src/investments_review/sheets/workflow.py (+7 -4)

📄 Description

Hi!
Found assert being used. This is problematic because asserts get disabled when python runs with -O flag, which would silently skip these checks in production.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/investments-review-agent/pull/3 **Author:** [@DeanNeaht](https://github.com/DeanNeaht) **Created:** 2/5/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/replace-asserts-with-proper-errors` --- ### 📝 Commits (1) - [`bd5effc`](https://github.com/run-llama/investments-review-agent/commit/bd5effc107f90099ce7ba30075514610708c34bf) Replace assert statements with proper exception handling ### 📊 Changes **3 files changed** (+34 additions, -8 deletions) <details> <summary>View changed files</summary> ➕ `src/investments_review/exceptions.py` (+22 -0) 📝 `src/investments_review/presentations/workflow.py` (+5 -4) 📝 `src/investments_review/sheets/workflow.py` (+7 -4) </details> ### 📄 Description Hi! Found `assert` being used. This is problematic because asserts get disabled when python runs with `-O` flag, which would silently skip these checks in production. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 04:16:32 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: run-llama/investments-review-agent#3