[PR #342] [MERGED] feat: Migrate e2e test basic_workflow to new Client and port missing features from old client #406

New Issue

2026-02-16T01:17:12-05:00

yindo commented

2026-02-16 01:17:12 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/342
Author: @masci
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @masci

Base: main ← Head: massi/sessions

📝 Commits (4)

6554734 migrate e2e tests to Client
877f0a7 adjust unit tests
75cf65c fix test
bf5f165 more fixes

📊 Changes

4 files changed (+105 additions, -63 deletions)

View changed files

📝 e2e_tests/basic_workflow/test_run_client.py (+20 -38)
📝 e2e_tests/core/test_services.py (+7 -9)
📝 llama_deploy/client/models/core.py (+43 -12)
📝 tests/client/models/test_core.py (+35 -4)

📄 Description

Part of #335

Also in this PR:

implement the same strategy of "lazy connections" we introduced for SessionCollection to ServiceCollection. This way we can expose client.core.services as a property and save one await.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/342 **Author:** [@masci](https://github.com/masci) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/sessions` --- ### 📝 Commits (4) - [`6554734`](https://github.com/run-llama/llama_deploy/commit/6554734643680fcbe0b4969ed31b66a780e914f2) migrate e2e tests to Client - [`877f0a7`](https://github.com/run-llama/llama_deploy/commit/877f0a703c6cbec06edbc173ceb240535f720886) adjust unit tests - [`75cf65c`](https://github.com/run-llama/llama_deploy/commit/75cf65cda5975b24a9bfabe5e54803336ef68ebb) fix test - [`bf5f165`](https://github.com/run-llama/llama_deploy/commit/bf5f165d589126bdb7b1bcf5f24a8237e4479638) more fixes ### 📊 Changes **4 files changed** (+105 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `e2e_tests/basic_workflow/test_run_client.py` (+20 -38) 📝 `e2e_tests/core/test_services.py` (+7 -9) 📝 `llama_deploy/client/models/core.py` (+43 -12) 📝 `tests/client/models/test_core.py` (+35 -4) </details> ### 📄 Description Part of #335 Also in this PR: - implement the same strategy of "lazy connections" we introduced for `SessionCollection` to `ServiceCollection`. This way we can expose `client.core.services` as a property and save one `await`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 01:17:12 -05:00

yindo closed this issue

2026-02-16 01:17:12 -05:00

yindo referenced this issue

2026-02-16 01:17:21 -05:00

[PR #406] [MERGED] ci: try a different strategy for rabbit health check #441

Sign in to join this conversation.