run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #406] [MERGED] ci: try a different strategy for rabbit health check #441

New Issue
Closed
opened 2026-02-16 01:17:21 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:21 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/406
Author: @masci
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @masci

Base: main ← Head: massi/rabbit-test

📝 Commits (7)

📊 Changes

3 files changed (+9 additions, -4 deletions)

View changed files

📝 .github/workflows/e2e_test.yml (+2 -2)
📝 e2e_tests/message_queues/message_queue_rabbitmq/conftest.py (+1 -1)
📝 e2e_tests/message_queues/message_queue_rabbitmq/docker-compose.yml (+6 -1)

📄 Description

I suspect the healthcheck never really worked because the CMD-SHELL was missing from the test command. This would explain why with an interval of 30s it seemed to work (30 seconds are more than enough to boot rabbit and a falsely positive healthcheck would be fine at that point).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/406 **Author:** [@masci](https://github.com/masci) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/rabbit-test` --- ### 📝 Commits (7) - [`ae1f927`](https://github.com/run-llama/llama_deploy/commit/ae1f927d3baa5f2c1900b50223d3f09471bba098) try a different strategy - [`001b588`](https://github.com/run-llama/llama_deploy/commit/001b588452ab172eda6797c6b0735b4ca5569f09) try - [`a36131f`](https://github.com/run-llama/llama_deploy/commit/a36131f0918e09c1ca26c8290c4f336e5d247949) try - [`b34dac9`](https://github.com/run-llama/llama_deploy/commit/b34dac964666c9c72f414867442c2b1511c76f1d) try - [`d59b4b6`](https://github.com/run-llama/llama_deploy/commit/d59b4b6f75b85c7f2a0b51e4b0bfb3489eca5201) try - [`583750c`](https://github.com/run-llama/llama_deploy/commit/583750c17220e2a012b7b3fd9b500858617aa38f) try - [`950304f`](https://github.com/run-llama/llama_deploy/commit/950304fe639020ee3f113cab0da6db7b83ce8b4a) try ### 📊 Changes **3 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/e2e_test.yml` (+2 -2) 📝 `e2e_tests/message_queues/message_queue_rabbitmq/conftest.py` (+1 -1) 📝 `e2e_tests/message_queues/message_queue_rabbitmq/docker-compose.yml` (+6 -1) </details> ### 📄 Description I suspect the healthcheck never really worked because the `CMD-SHELL` was missing from the test command. This would explain why with an interval of 30s it seemed to work (30 seconds are more than enough to boot rabbit and a falsely positive healthcheck would be fine at that point). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:21 -05:00
yindo closed this issue 2026-02-16 01:17:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#441
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?