[PR #441] [MERGED] fix: avoid 409 errors on message queue when services restart #466

New Issue

2026-02-16T01:17:28-05:00

yindo commented

2026-02-16 01:17:28 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/441
Author: @masci
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @masci

Base: main ← Head: massi/fix-409

📝 Commits (5)

e4a167d fix: avoid 409 errors on message queue when services restart
5d1c1a4 removed leftovers
46013d9 fix unit tests
41c43db avoid port conflicts
c6deefd add some unit tests

📊 Changes

12 files changed (+216 additions, -38 deletions)

View changed files

📝 e2e_tests/deploy/test_deploy.py (+78 -2)
➕ e2e_tests/message_queues/simple/conftest.py (+28 -0)
📝 e2e_tests/message_queues/simple/test_message_queue.py (+24 -7)
➕ e2e_tests/message_queues/simple/test_server.py (+18 -0)
📝 llama_deploy/__init__.py (+2 -0)
📝 llama_deploy/deploy/deploy.py (+7 -6)
📝 llama_deploy/message_queues/simple/client.py (+26 -11)
📝 llama_deploy/message_queues/simple/server.py (+3 -7)
📝 llama_deploy/services/base.py (+7 -3)
📝 llama_deploy/services/workflow.py (+5 -1)
📝 tests/message_queues/simple/test_server.py (+1 -1)
📝 tests/services/test_workflow_service.py (+17 -0)

📄 Description

This PR addresses several issues:

creating a topic that already exists in SimpleMessageQueue now is a no-op instead of returning 409
deploy_workflow now cleans up asyncio tasks at shutdown
the SimpleMessageQueue client is now more resilient at shutdown, catching multiple exceptions
there was a bug in the payload sent for deregistering a consumer from the control plane
a method for deregistering consumers from message queues was added
the Workflow service now properly shuts down

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/441 **Author:** [@masci](https://github.com/masci) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/fix-409` --- ### 📝 Commits (5) - [`e4a167d`](https://github.com/run-llama/llama_deploy/commit/e4a167d67028f17c48d89319785d01a527883780) fix: avoid 409 errors on message queue when services restart - [`5d1c1a4`](https://github.com/run-llama/llama_deploy/commit/5d1c1a4c6ed0603061b117808aff1bfcf50aee01) removed leftovers - [`46013d9`](https://github.com/run-llama/llama_deploy/commit/46013d9e38d125754076ab05bbd41a35df1b74d7) fix unit tests - [`41c43db`](https://github.com/run-llama/llama_deploy/commit/41c43db365b5dccfcaa0c10bcc3b84e533d01bd4) avoid port conflicts - [`c6deefd`](https://github.com/run-llama/llama_deploy/commit/c6deefd712e7fb819bb5f2a8ef4cd533ef38b6e9) add some unit tests ### 📊 Changes **12 files changed** (+216 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `e2e_tests/deploy/test_deploy.py` (+78 -2) ➕ `e2e_tests/message_queues/simple/conftest.py` (+28 -0) 📝 `e2e_tests/message_queues/simple/test_message_queue.py` (+24 -7) ➕ `e2e_tests/message_queues/simple/test_server.py` (+18 -0) 📝 `llama_deploy/__init__.py` (+2 -0) 📝 `llama_deploy/deploy/deploy.py` (+7 -6) 📝 `llama_deploy/message_queues/simple/client.py` (+26 -11) 📝 `llama_deploy/message_queues/simple/server.py` (+3 -7) 📝 `llama_deploy/services/base.py` (+7 -3) 📝 `llama_deploy/services/workflow.py` (+5 -1) 📝 `tests/message_queues/simple/test_server.py` (+1 -1) 📝 `tests/services/test_workflow_service.py` (+17 -0) </details> ### 📄 Description This PR addresses several issues: - creating a topic that already exists in SimpleMessageQueue now is a no-op instead of returning 409 - `deploy_workflow` now cleans up asyncio tasks at shutdown - the SimpleMessageQueue client is now more resilient at shutdown, catching multiple exceptions - there was a bug in the payload sent for deregistering a consumer from the control plane - a method for deregistering consumers from message queues was added - the Workflow service now properly shuts down --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 01:17:28 -05:00

yindo closed this issue

2026-02-16 01:17:28 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#466