run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #394] [MERGED] fix: make SimpleMessageQueue server cancellable #435

New Issue
Closed
opened 2026-02-16 01:17:20 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/394
Author: @masci
Created: 11/29/2024
Status: ✅ Merged
Merged: 11/30/2024
Merged by: @masci

Base: main ← Head: massi/simplequeue-shutdown

📝 Commits (1)

  • 8dc684a fix: make SimpleMessageQueue server cancellable

📊 Changes

3 files changed (+28 additions, -11 deletions)

View changed files

➕ e2e_tests/message_queues/message_queue_simple/__init__.py (+0 -0)
➕ e2e_tests/message_queues/message_queue_simple/test_message_queue.py (+19 -0)
📝 llama_deploy/message_queues/simple.py (+9 -11)

📄 Description

Several services don't shutdown properly, and while this is not a problem when you tear down the whole process, it's becoming an issue while we start moving towards a more distributed architecture, where services are expected to come and go (think of orchestrators).

This PR makes SimpleMessageQueue.launch_server() cancellable, more to come.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/394 **Author:** [@masci](https://github.com/masci) **Created:** 11/29/2024 **Status:** ✅ Merged **Merged:** 11/30/2024 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/simplequeue-shutdown` --- ### 📝 Commits (1) - [`8dc684a`](https://github.com/run-llama/llama_deploy/commit/8dc684a760f657c2f776ed2d8b0059bc26ff1317) fix: make SimpleMessageQueue server cancellable ### 📊 Changes **3 files changed** (+28 additions, -11 deletions) <details> <summary>View changed files</summary> ➕ `e2e_tests/message_queues/message_queue_simple/__init__.py` (+0 -0) ➕ `e2e_tests/message_queues/message_queue_simple/test_message_queue.py` (+19 -0) 📝 `llama_deploy/message_queues/simple.py` (+9 -11) </details> ### 📄 Description Several services don't shutdown properly, and while this is not a problem when you tear down the whole process, it's becoming an issue while we start moving towards a more distributed architecture, where services are expected to come and go (think of orchestrators). This PR makes `SimpleMessageQueue.launch_server()` cancellable, more to come. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:20 -05:00
yindo closed this issue 2026-02-16 01:17:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#435
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?