run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #437] [MERGED] fix: properly support disable_control_plane in deploy() function #463

New Issue
Closed
opened 2026-02-16 01:17:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:28 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/437
Author: @masci
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @masci

Base: main ← Head: massi/435

📝 Commits (10+)

📊 Changes

4 files changed (+88 additions, -47 deletions)

View changed files

📝 .github/workflows/e2e_test.yml (+12 -1)
➕ e2e_tests/deploy/__init__.py (+0 -0)
➕ e2e_tests/deploy/test_deploy.py (+50 -0)
📝 llama_deploy/deploy/deploy.py (+26 -46)

📄 Description

Fixes #435

Also in this PR:

  • Split e2e tests by package. As we add more e2e tests the flakyness is increasing, and it's extremely difficult to debug since tests pass locally. By splitting the e2e tests by package we reduce the load of process and coroutine orchestration for each run and we also increase parallelism (with the new layout e2e tests pass in about 2 minutes on Github workflows)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/437 **Author:** [@masci](https://github.com/masci) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/435` --- ### 📝 Commits (10+) - [`3f72a73`](https://github.com/run-llama/llama_deploy/commit/3f72a73272192005acf82dbb60c45c97c850f768) fix: properly support disable_control_plane in deploy() function - [`d61fcfe`](https://github.com/run-llama/llama_deploy/commit/d61fcfe383f1891f26652ccdc4db52638ab11065) try - [`3517449`](https://github.com/run-llama/llama_deploy/commit/35174494ba489ffbb428381a1071cd5b1c7f931b) try - [`7f9745c`](https://github.com/run-llama/llama_deploy/commit/7f9745c9452c2c196b9e9e287b2f077253c6e466) try - [`3295b3f`](https://github.com/run-llama/llama_deploy/commit/3295b3f453dad998858c67e0086112a127e56742) try - [`270cff8`](https://github.com/run-llama/llama_deploy/commit/270cff8d5632393cbd436834940de799d0a22a91) try - [`e154572`](https://github.com/run-llama/llama_deploy/commit/e15457263ae12ce3e9f4a2823db5f06edd2d624f) add a timeout - [`a0428e9`](https://github.com/run-llama/llama_deploy/commit/a0428e9849631fffb915b85e5a07c53ecbcfe0c6) try - [`912431f`](https://github.com/run-llama/llama_deploy/commit/912431f1e976d1e68006c3cb89bb0eaf968c0f18) try - [`d921736`](https://github.com/run-llama/llama_deploy/commit/d92173667883125c38c68550cf968241fe35ca72) split tests by package ### 📊 Changes **4 files changed** (+88 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/e2e_test.yml` (+12 -1) ➕ `e2e_tests/deploy/__init__.py` (+0 -0) ➕ `e2e_tests/deploy/test_deploy.py` (+50 -0) 📝 `llama_deploy/deploy/deploy.py` (+26 -46) </details> ### 📄 Description Fixes #435 Also in this PR: - Split e2e tests by package. As we add more e2e tests the flakyness is increasing, and it's extremely difficult to debug since tests pass locally. By splitting the e2e tests by package we reduce the load of process and coroutine orchestration for each run and we also increase parallelism (with the new layout e2e tests pass in about 2 minutes on Github workflows) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:28 -05:00
yindo closed this issue 2026-02-16 01:17:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?