[PR #425] [MERGED] refact: remove BaseMessageQueue in favor of AbstractMessageQueue #457

New Issue

2026-02-16T01:17:26-05:00

yindo commented

2026-02-16 01:17:26 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/425
Author: @masci
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/10/2025
Merged by: @masci

Base: main ← Head: massi/queue-refactor

📝 Commits (2)

ab9ab5c refact: remove BaseMessageQueue in favor of AbstractMessageQueue
98038c4 fix unit tests

📊 Changes

17 files changed (+47 additions, -97 deletions)

View changed files

📝 docs/docs/api_reference/llama_deploy/message_queues/index.md (+1 -1)
📝 llama_deploy/apiserver/deployment.py (+8 -8)
📝 llama_deploy/control_plane/base.py (+2 -2)
📝 llama_deploy/control_plane/server.py (+4 -4)
📝 llama_deploy/deploy/deploy.py (+8 -8)
📝 llama_deploy/message_publishers/publisher.py (+2 -2)
📝 llama_deploy/message_queues/__init__.py (+1 -2)
📝 llama_deploy/message_queues/apache_kafka.py (+7 -11)
📝 llama_deploy/message_queues/aws.py (+1 -9)
📝 llama_deploy/message_queues/base.py (+2 -13)
📝 llama_deploy/message_queues/rabbitmq.py (+1 -8)
📝 llama_deploy/message_queues/redis.py (+1 -11)
📝 llama_deploy/message_queues/simple/client.py (+1 -3)
📝 llama_deploy/message_queues/solace.py (+1 -8)
📝 llama_deploy/services/workflow.py (+4 -4)
📝 tests/message_queues/simple/test_server.py (+2 -2)
📝 tests/message_queues/test_rabbitmq.py (+1 -1)

📄 Description

Fixes #359

Final step of the refactoring, removing BaseMessageQueue in favor of AbstractMessageQueue.
Also in this PR:

removed the optionality for topic that was for backward compatibility with BaseMessageQueue
removed the unused abstract method processing_loop

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/425 **Author:** [@masci](https://github.com/masci) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/queue-refactor` --- ### 📝 Commits (2) - [`ab9ab5c`](https://github.com/run-llama/llama_deploy/commit/ab9ab5cefd3a7e35bc2b71319e8cd4b82c1d90ff) refact: remove BaseMessageQueue in favor of AbstractMessageQueue - [`98038c4`](https://github.com/run-llama/llama_deploy/commit/98038c4bde5ab4fe992b529a1860596a148ec091) fix unit tests ### 📊 Changes **17 files changed** (+47 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `docs/docs/api_reference/llama_deploy/message_queues/index.md` (+1 -1) 📝 `llama_deploy/apiserver/deployment.py` (+8 -8) 📝 `llama_deploy/control_plane/base.py` (+2 -2) 📝 `llama_deploy/control_plane/server.py` (+4 -4) 📝 `llama_deploy/deploy/deploy.py` (+8 -8) 📝 `llama_deploy/message_publishers/publisher.py` (+2 -2) 📝 `llama_deploy/message_queues/__init__.py` (+1 -2) 📝 `llama_deploy/message_queues/apache_kafka.py` (+7 -11) 📝 `llama_deploy/message_queues/aws.py` (+1 -9) 📝 `llama_deploy/message_queues/base.py` (+2 -13) 📝 `llama_deploy/message_queues/rabbitmq.py` (+1 -8) 📝 `llama_deploy/message_queues/redis.py` (+1 -11) 📝 `llama_deploy/message_queues/simple/client.py` (+1 -3) 📝 `llama_deploy/message_queues/solace.py` (+1 -8) 📝 `llama_deploy/services/workflow.py` (+4 -4) 📝 `tests/message_queues/simple/test_server.py` (+2 -2) 📝 `tests/message_queues/test_rabbitmq.py` (+1 -1) </details> ### 📄 Description Fixes #359 Final step of the refactoring, removing `BaseMessageQueue` in favor of `AbstractMessageQueue`. Also in this PR: - removed the optionality for `topic` that was for backward compatibility with `BaseMessageQueue` - removed the unused abstract method `processing_loop` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 01:17:26 -05:00

yindo closed this issue

2026-02-16 01:17:26 -05:00

yindo referenced this issue

2026-02-16 02:15:02 -05:00

[PR #457] [MERGED] fix: raise an error in `llamactl run` when service doesn't exist #474

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#457