[PR #457] [MERGED] fix: raise an error in llamactl run when service doesn't exist #474

Closed
opened 2026-02-16 02:15:02 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/457
Author: @masci
Created: 2/12/2025
Status: Merged
Merged: 2/12/2025
Merged by: @masci

Base: mainHead: massi/456


📝 Commits (2)

  • 5e58db5 fix: raise an error in run() when service doesn't exist
  • 5648305 add unit tests, fix surfaced bug

📊 Changes

4 files changed (+67 additions, -11 deletions)

View changed files

📝 llama_deploy/apiserver/deployment.py (+25 -11)
📝 llama_deploy/apiserver/routers/deployments.py (+5 -0)
📝 tests/apiserver/routers/test_deployments.py (+14 -0)
📝 tests/apiserver/test_deployment.py (+23 -0)

📄 Description

Fixes #456


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/457 **Author:** [@masci](https://github.com/masci) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/456` --- ### 📝 Commits (2) - [`5e58db5`](https://github.com/run-llama/llama_deploy/commit/5e58db51039a39f186ccef877597c089a98aef92) fix: raise an error in run() when service doesn't exist - [`5648305`](https://github.com/run-llama/llama_deploy/commit/5648305b99e9b8083c27d2457b8d8744df82a3f5) add unit tests, fix surfaced bug ### 📊 Changes **4 files changed** (+67 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/apiserver/deployment.py` (+25 -11) 📝 `llama_deploy/apiserver/routers/deployments.py` (+5 -0) 📝 `tests/apiserver/routers/test_deployments.py` (+14 -0) 📝 `tests/apiserver/test_deployment.py` (+23 -0) </details> ### 📄 Description Fixes #456 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:15:02 -05:00
yindo closed this issue 2026-02-16 02:15:02 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#474