run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #438] [MERGED] fix: propagate the workflow timeout to its llama_deploy Client instance #464

New Issue
Closed
opened 2026-02-16 01:17:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:28 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/438
Author: @masci
Created: 1/24/2025
Status: ✅ Merged
Merged: 1/25/2025
Merged by: @masci

Base: main ← Head: massi/436

📝 Commits (1)

  • c3dd499 fix: propagate the workflow timeout to its llama_deploy Client instance

📊 Changes

5 files changed (+131 additions, -21 deletions)

View changed files

📝 llama_deploy/client/base.py (+1 -1)
📝 llama_deploy/client/models/core.py (+4 -1)
📝 llama_deploy/deploy/deploy.py (+1 -1)
📝 llama_deploy/deploy/network_workflow.py (+26 -18)
➕ tests/deploy/test_network_workflow.py (+99 -0)

📄 Description

Fixes #436

The Client instance used inside NetworkWorkflow to run nested workflows could not be set and it was timing out after the default 120s. With this PR the inner client will be set with the same timeout that was set for the NetworkWorkflow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/438 **Author:** [@masci](https://github.com/masci) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/25/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/436` --- ### 📝 Commits (1) - [`c3dd499`](https://github.com/run-llama/llama_deploy/commit/c3dd499eddb0f98aaffd5cedcca00eac43ed0d1f) fix: propagate the workflow timeout to its llama_deploy Client instance ### 📊 Changes **5 files changed** (+131 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/client/base.py` (+1 -1) 📝 `llama_deploy/client/models/core.py` (+4 -1) 📝 `llama_deploy/deploy/deploy.py` (+1 -1) 📝 `llama_deploy/deploy/network_workflow.py` (+26 -18) ➕ `tests/deploy/test_network_workflow.py` (+99 -0) </details> ### 📄 Description Fixes #436 The `Client` instance used inside `NetworkWorkflow` to run nested workflows could not be set and it was timing out after the default 120s. With this PR the inner client will be set with the same timeout that was set for the `NetworkWorkflow`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:28 -05:00
yindo closed this issue 2026-02-16 01:17:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#464
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?