run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #465] [MERGED] fix: raise an error when task.session_id doesn't match session_id #481

New Issue
Closed
opened 2026-02-16 02:15:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:15:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/465
Author: @masci
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/17/2025
Merged by: @masci

Base: main ← Head: massi/464

📝 Commits (2)

  • b4d6e70 fix: raise an error when task.session_id doesn't match session_id
  • 4016fe3 use a regex to make test pass on different Py versions

📊 Changes

4 files changed (+117 additions, -4 deletions)

View changed files

📝 llama_deploy/control_plane/server.py (+10 -4)
➕ tests/control_plane/conftest.py (+25 -0)
📝 tests/control_plane/test_config.py (+2 -0)
📝 tests/control_plane/test_server.py (+80 -0)

📄 Description

Related to #464

  • Make add_task_to_session return an error when the request is invalid
  • Make process_message more robust
  • Add a bunch of unit tests, some were low-hanging fruits unrelated to this PR

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/465 **Author:** [@masci](https://github.com/masci) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/17/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/464` --- ### 📝 Commits (2) - [`b4d6e70`](https://github.com/run-llama/llama_deploy/commit/b4d6e70ef9c5433bff5ac0933172ce4ca23e8c2b) fix: raise an error when task.session_id doesn't match session_id - [`4016fe3`](https://github.com/run-llama/llama_deploy/commit/4016fe3fadb375faf244f39d566c99d2fffcf508) use a regex to make test pass on different Py versions ### 📊 Changes **4 files changed** (+117 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/control_plane/server.py` (+10 -4) ➕ `tests/control_plane/conftest.py` (+25 -0) 📝 `tests/control_plane/test_config.py` (+2 -0) 📝 `tests/control_plane/test_server.py` (+80 -0) </details> ### 📄 Description Related to #464 - Make `add_task_to_session` return an error when the request is invalid - Make `process_message` more robust - Add a bunch of unit tests, some were low-hanging fruits unrelated to this PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:15:04 -05:00
yindo closed this issue 2026-02-16 02:15:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?