[PR #501] [MERGED] fix: use a global settings instance #503

Closed
opened 2026-02-16 02:15:22 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/501
Author: @masci
Created: 5/19/2025
Status: Merged
Merged: 5/19/2025
Merged by: @masci

Base: mainHead: massi/settings-refact


📝 Commits (2)

📊 Changes

12 files changed (+35 additions, -25 deletions)

View changed files

📝 docker/run_apiserver.py (+1 -3)
📝 docker/run_autodeploy.py (+1 -3)
📝 e2e_tests/apiserver/test_autodeploy.py (+0 -5)
📝 llama_deploy/apiserver/__init__.py (+2 -2)
📝 llama_deploy/apiserver/__main__.py (+1 -3)
📝 llama_deploy/apiserver/routers/status.py (+1 -2)
📝 llama_deploy/apiserver/server.py (+1 -2)
📝 llama_deploy/apiserver/settings.py (+3 -0)
llama_deploy/cli/serve.py (+19 -0)
📝 tests/apiserver/routers/test_status.py (+3 -1)
📝 tests/apiserver/test_server.py (+2 -3)
📝 tests/apiserver/test_settings.py (+1 -1)

📄 Description

Use a Pydantic settings singleton instance to avoid re-parsing environment variables at each usage


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/501 **Author:** [@masci](https://github.com/masci) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/19/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/settings-refact` --- ### 📝 Commits (2) - [`1073b1c`](https://github.com/run-llama/llama_deploy/commit/1073b1c6f8c649ff063856ba71f323d52edad002) fix: use a global settings instance - [`0ba20d6`](https://github.com/run-llama/llama_deploy/commit/0ba20d65b5686d6a0e8d9b91ec7e2d7d40cd17df) fix e2e tests ### 📊 Changes **12 files changed** (+35 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `docker/run_apiserver.py` (+1 -3) 📝 `docker/run_autodeploy.py` (+1 -3) 📝 `e2e_tests/apiserver/test_autodeploy.py` (+0 -5) 📝 `llama_deploy/apiserver/__init__.py` (+2 -2) 📝 `llama_deploy/apiserver/__main__.py` (+1 -3) 📝 `llama_deploy/apiserver/routers/status.py` (+1 -2) 📝 `llama_deploy/apiserver/server.py` (+1 -2) 📝 `llama_deploy/apiserver/settings.py` (+3 -0) ➕ `llama_deploy/cli/serve.py` (+19 -0) 📝 `tests/apiserver/routers/test_status.py` (+3 -1) 📝 `tests/apiserver/test_server.py` (+2 -3) 📝 `tests/apiserver/test_settings.py` (+1 -1) </details> ### 📄 Description Use a Pydantic settings singleton instance to avoid re-parsing environment variables at each usage --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:15:22 -05:00
yindo closed this issue 2026-02-16 02:15:22 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#503