run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #503] [MERGED] feat!: improve local source manager #505

New Issue
Closed
opened 2026-02-16 02:15:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:15:23 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/503
Author: @masci
Created: 5/21/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @masci

Base: main ← Head: massi/local-path

📝 Commits (7)

📊 Changes

29 files changed (+174 additions, -100 deletions)

View changed files

📝 docs/docs/module_guides/llama_deploy/10_getting_started.md (+4 -3)
📝 e2e_tests/apiserver/deployments/deployment2.yml (+3 -3)
📝 e2e_tests/apiserver/deployments/deployment_env_local.yml (+3 -3)
📝 e2e_tests/apiserver/deployments/deployment_hitl.yml (+2 -2)
📝 e2e_tests/apiserver/deployments/deployment_streaming.yml (+2 -2)
📝 e2e_tests/apiserver/test_deploy.py (+20 -5)
📝 e2e_tests/apiserver/test_env_vars_git.py (+3 -3)
📝 e2e_tests/apiserver/test_env_vars_local.py (+3 -3)
📝 e2e_tests/apiserver/test_hitl.py (+5 -3)
📝 e2e_tests/apiserver/test_reload.py (+10 -4)
📝 e2e_tests/apiserver/test_streaming.py (+6 -4)
📝 examples/llamacloud/google_drive/README.md (+2 -2)
📝 examples/llamacloud/google_drive/deployment.yml (+2 -2)
📝 examples/quick_start/README.md (+2 -2)
📝 examples/quick_start/quick_start.yml (+2 -2)
📝 llama_deploy/apiserver/deployment.py (+40 -19)
📝 llama_deploy/apiserver/deployment_config_parser.py (+0 -3)
📝 llama_deploy/apiserver/routers/deployments.py (+2 -1)
📝 llama_deploy/apiserver/server.py (+5 -3)
📝 llama_deploy/apiserver/source_managers/base.py (+3 -1)

...and 9 more files

📄 Description

There was a bit of confusion in the way local sources for a deployment are supposed to work, hopefully this should improve clarity. A few changes were made:

  • Removed base_path from the deployment configuration. That's the path that's supposed to tell where the config file is, it doesn't make sense to keep it in the config file itself.
  • Added base_path explicitly to the Deployment interface. Since a deployment configuration can be requested over the wire with no config file, in that case it's the user responsibility to define it
  • Renamed root_path to deployment_path in the Deployment api. This should help clarify that deployment_path is where the workflows code is copied at deploy time.
  • Changes to the Deployment class are breaking and this reflects on the Python client.
  • The CLI will try to infer base_path whenever possible.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/503 **Author:** [@masci](https://github.com/masci) **Created:** 5/21/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/local-path` --- ### 📝 Commits (7) - [`f68ff9f`](https://github.com/run-llama/llama_deploy/commit/f68ff9fd2bda1c2cb5ed2710b5e3e28266bc4041) fix deployments path management - [`0eaa7f9`](https://github.com/run-llama/llama_deploy/commit/0eaa7f93721dcb66d16e2c0cb06e9ff42ffde5e1) add a test for local deployments - [`74cd758`](https://github.com/run-llama/llama_deploy/commit/74cd75836cce3b3105f9b69a4cfad5f8b48645ba) extract base_path - [`fad8b4b`](https://github.com/run-llama/llama_deploy/commit/fad8b4b224ed011b2382b8f9c3585dcfb1f3a37f) fix unit tests - [`cc12a25`](https://github.com/run-llama/llama_deploy/commit/cc12a252744af5c508f6c4cf79e9b990f39caec8) give time to serve() to set internal state - [`5332573`](https://github.com/run-llama/llama_deploy/commit/5332573b4a25996b01983bed17db372dfdd5acf6) fix e2e tests - [`1015a26`](https://github.com/run-llama/llama_deploy/commit/1015a264e22fc468f46967aed5648a6fd7445580) docs ### 📊 Changes **29 files changed** (+174 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `docs/docs/module_guides/llama_deploy/10_getting_started.md` (+4 -3) 📝 `e2e_tests/apiserver/deployments/deployment2.yml` (+3 -3) 📝 `e2e_tests/apiserver/deployments/deployment_env_local.yml` (+3 -3) 📝 `e2e_tests/apiserver/deployments/deployment_hitl.yml` (+2 -2) 📝 `e2e_tests/apiserver/deployments/deployment_streaming.yml` (+2 -2) 📝 `e2e_tests/apiserver/test_deploy.py` (+20 -5) 📝 `e2e_tests/apiserver/test_env_vars_git.py` (+3 -3) 📝 `e2e_tests/apiserver/test_env_vars_local.py` (+3 -3) 📝 `e2e_tests/apiserver/test_hitl.py` (+5 -3) 📝 `e2e_tests/apiserver/test_reload.py` (+10 -4) 📝 `e2e_tests/apiserver/test_streaming.py` (+6 -4) 📝 `examples/llamacloud/google_drive/README.md` (+2 -2) 📝 `examples/llamacloud/google_drive/deployment.yml` (+2 -2) 📝 `examples/quick_start/README.md` (+2 -2) 📝 `examples/quick_start/quick_start.yml` (+2 -2) 📝 `llama_deploy/apiserver/deployment.py` (+40 -19) 📝 `llama_deploy/apiserver/deployment_config_parser.py` (+0 -3) 📝 `llama_deploy/apiserver/routers/deployments.py` (+2 -1) 📝 `llama_deploy/apiserver/server.py` (+5 -3) 📝 `llama_deploy/apiserver/source_managers/base.py` (+3 -1) _...and 9 more files_ </details> ### 📄 Description There was a bit of confusion in the way local sources for a deployment are supposed to work, hopefully this should improve clarity. A few changes were made: - Removed `base_path` from the deployment configuration. That's the path that's supposed to tell where the config file is, it doesn't make sense to keep it in the config file itself. - Added `base_path` explicitly to the Deployment interface. Since a deployment configuration can be requested over the wire with no config file, in that case it's the user responsibility to define it - Renamed `root_path` to `deployment_path` in the `Deployment` api. This should help clarify that `deployment_path` is where the workflows code is copied at deploy time. - Changes to the `Deployment` class are breaking and this reflects on the Python client. - The CLI will try to infer `base_path` whenever possible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:15:23 -05:00
yindo closed this issue 2026-02-16 02:15:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?