[PR #505] [MERGED] fix: add nodejs to the Docker image #507

Closed
opened 2026-02-16 02:15:24 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/505
Author: @masci
Created: 5/22/2025
Status: Merged
Merged: 5/22/2025
Merged by: @masci

Base: mainHead: massi/fix-docker


📝 Commits (3)

📊 Changes

4 files changed (+22 additions, -9 deletions)

View changed files

📝 docker/Dockerfile.base (+2 -1)
📝 llama_deploy/apiserver/deployment.py (+6 -4)
📝 llama_deploy/cli/deploy.py (+12 -2)
📝 tests/apiserver/test_deployment.py (+2 -2)

📄 Description

Also use pnpm instead of npm. Not sure if we should make this configurable, let's stay opinionanted for now.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/505 **Author:** [@masci](https://github.com/masci) **Created:** 5/22/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/fix-docker` --- ### 📝 Commits (3) - [`2f1f29c`](https://github.com/run-llama/llama_deploy/commit/2f1f29c9c4475add8014947dfd9d8317ca0e4cc6) fix: ship node with Docker image - [`5922ce6`](https://github.com/run-llama/llama_deploy/commit/5922ce6b993eb475da0f00c2c3c1fda24a496c7b) fix paths - [`fa04d4c`](https://github.com/run-llama/llama_deploy/commit/fa04d4cc985e81a2c61e42cf58d9c77518b5bab7) fix unit tests ### 📊 Changes **4 files changed** (+22 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `docker/Dockerfile.base` (+2 -1) 📝 `llama_deploy/apiserver/deployment.py` (+6 -4) 📝 `llama_deploy/cli/deploy.py` (+12 -2) 📝 `tests/apiserver/test_deployment.py` (+2 -2) </details> ### 📄 Description Also use `pnpm` instead of `npm`. Not sure if we should make this configurable, let's stay opinionanted for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:15:24 -05:00
yindo closed this issue 2026-02-16 02:15:24 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#507