The_E
f0d7aeae59
Fix for Mantis 2550: Text in multiplayer is rendered outside the textbox if custom fonts are in use
2011-12-18 16:00:26 +00:00
Echelon9
8d728672e2
Cases of commented out Int3() indicate areas of old, redundant code.
2011-11-17 11:07:53 +00:00
Echelon9
01a94b09fb
A few further changes for Windows support under the new jump_nodes STL refactor
2011-10-03 13:26:03 +00:00
Echelon9
24164e5fae
Use SCP_* types to access STL types wherever possible. This allows more complete memory monitoring
2011-10-03 09:06:56 +00:00
Echelon9
d182e281c7
PVS-Studio fix: V507 Pointer to local array 'title_str' is stored outside the scope of this array. Such a pointer will become invalid.
2011-10-01 06:54:43 +00:00
Zacam
bda6e7b7e3
Sync Drift: Apparently still some lingering ifdefs for OEM/Multiplayer_Beta and non-AP specific things not having made it to trunk for some reason.
2011-09-25 08:26:45 +00:00
Echelon9
9dbc352777
Code cleanup: We should be really careful with using these scoring struct elements, as the types were changed from ushort to int at some point.
2011-09-25 02:42:27 +00:00
Echelon9
1c105cec90
PVS-Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 2056, 2061 (multiteamselect.cpp)
2011-09-23 20:28:06 +00:00
Echelon9
c5a3819490
PVS-Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 2039, 2044 (multiteamselect.cpp)
2011-09-23 20:27:25 +00:00
Zacam
bc400c5d97
Part One: Synchronization pass of Trunk and Antipodes Differences.
...
Whitespace/tab mostly.
aicode does have a change of an Int3 to an Assertion.
bmpman has an update to bm_next_handle.
2011-09-09 09:37:45 +00:00
Echelon9
c978773027
Documentation: Code clean up of psnet2.cpp
2011-09-07 12:28:18 +00:00
Echelon9
ed4ccb54d2
PVS-Studio fix (courtesy of niffiwan): V512 A call of the 'memcpy' function will lead to underflow of the buffer (psnet2.cpp)
2011-09-07 11:58:47 +00:00
Zacam
3b9b3aca2e
PVS-Studio fix (courtesy of niffiwan): V512 - A call of the 'memcpy' function will lead to overflow of the buffer '& ip_addr.sin_addr'.
2011-09-07 10:00:03 +00:00
Echelon9
19e20754e2
PVS-Studio fix: V524 It is odd that the body of 'multi_xfer_reset' function is fully equivalent to the body of 'multi_xfer_close' function (multi_xfer.cpp, line 185).
...
Remove duplicate, unused function
2011-09-06 12:29:56 +00:00
Echelon9
b9b2517623
PVS-Studio fix (courtesy of niffiwan): V568It's odd that the argument of sizeof() operator is the '(short) method' expression.
2011-09-05 12:49:37 +00:00
The_E
013b94cf28
Another false alarm from PVS Studio
2011-09-04 12:33:00 +00:00
The_E
0e8c42356d
PVS Studio related: Mark false alarms as such
2011-09-04 09:35:08 +00:00
Echelon9
66cc873369
Documentation: A few documentation fixes
2011-09-03 09:06:00 +00:00
Goober5000
97c6167421
PVS-Studio fix: V804 Decreased performance. The 'strlen' function is called twice in the specified expression to calculate length of the same string.
2011-09-03 01:32:07 +00:00
Echelon9
265330ca80
Let's have another go at this one... around we go again
2011-09-01 13:08:32 +00:00
karajorma
f57fe25d48
Fix a mismatch.
2011-08-31 14:06:19 +00:00
Echelon9
1bc5249211
Undo my rather silly patch, apply niffiwan's patch as a temporary measure (at least).
2011-08-31 13:48:23 +00:00
Echelon9
d115a9317e
PVS-Studio fix: V523 The 'then' statement is equivalent to the 'else' statement (psnet2.cpp).
...
This one was particular bad as it code have lead to remotely induced crashes over the network with oversize packets.
2011-08-31 13:12:46 +00:00
The_E
6e17a7f6ae
PVS Studio related: Mark false alarms as such.
2011-08-30 17:46:49 +00:00
The_E
3e660d6bda
Removing the RELEASE_REAL define from ye olde ✌️ days. We really don't need it anymore.
2011-08-30 17:46:03 +00:00
Echelon9
afcfc3ba05
PVS-Studio fix: V576 Incorrect format. Consider checking the [third] actual argument of the 'sprintf' function. The SIGNED integer type argument is expected.
...
Fixes a number of this class of issue with sprintf formats.
2011-08-30 15:39:29 +00:00
karajorma
1e56c10d61
PVS-Studio fix: V512 A call of the 'memset' function will lead to underflow of the buffer 'type'.
...
Never really would matter but it's a waste of memory declaring an int buffer and then only using 1/4 of it
2011-08-30 11:50:23 +00:00
Goober5000
6f45a96d38
add fire-beam-at-coordinates, which is as awesome as it sounds
2011-08-30 07:29:57 +00:00
Goober5000
6a65e3cb11
waypoints and waypoint paths now have dynamic limits
2011-08-30 03:35:42 +00:00
karajorma
4868771688
Documentation for the Multiplayer SEXP system.
2011-08-30 00:18:32 +00:00
Echelon9
c099802bc1
Documentation: Code cleanup in multi_obj.cpp
2011-08-28 09:36:18 +00:00
Echelon9
d57496c74f
PVS-Studio fix: V519 The 'num_users' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 2296, 2297 (multi_pxo.cpp)
2011-08-28 09:34:09 +00:00
Echelon9
1cddeddc82
PVS-Studio fix: V519 The 'player_index' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1389, 1392 (multi_obj.cpp)
2011-08-28 09:32:55 +00:00
Echelon9
d8cd159129
PVS-Studio fix: V501 There are identical sub-expressions '(stricmp (szCmd, "372") == 0)' to the left and to the right of the '||' operator.
...
and
V501 There are identical sub-expressions '(stricmp (szCmd, "375") == 0)' to the left and to the right of the '||' operator.
2011-08-28 07:27:53 +00:00
Echelon9
20e79c6453
PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 50 to 48 bytes by rearranging the fields according to their sizes in decreasing order.
2011-08-28 07:08:40 +00:00
Goober5000
4768e4bda8
add infrastructure and parsing support for mission forks (vs. mission loops)
...
mission fork interface art and selection logic still needs to be written
2011-08-27 03:57:16 +00:00
Echelon9
98a9293520
PVS-Studio: Fix V805. Decreased performance. It is inefficient to identify an empty string by using 'strlen(str) > 0' construct
2011-08-24 13:37:01 +00:00
karajorma
defea5fa74
Fix several SEXPs for multiplayer use. This should fix Mantis issues 2401, 2483 and 2382.
...
In addition, fix a bug caused by SEXPs that do a callback but don't send any data.
2011-08-24 08:37:11 +00:00
Goober5000
931bdab721
add an option to fire-beam to force the beam to fire
...
combine fighter_beam flag into flags field
2011-08-21 01:11:24 +00:00
karajorma
bcd1144e9a
Add options to send objects, shorts and ushorts via the multiplayer SEXP system.
2011-08-19 08:09:50 +00:00
Echelon9
cce5ba7623
Documentation: General clean-up and function documentation
2011-08-18 16:47:54 +00:00
karajorma
a862f9e9f8
Doh, missed one!
2011-08-18 07:56:31 +00:00
karajorma
882bf001c9
Fixes and clean up for the multiplayer SEXP packet system.
...
- Make the system more robust against accidental attempts to write data to the packet without proper initialisation.
- Improve the error messages and function names to make clear the difference between the packet the game actually sends and the abstracted packets the coder seems to create and send in sexp.cpp
- Add a convenience methods to deal with SEXPs that don't need to write any data.
2011-08-18 07:48:59 +00:00
karajorma
f384d6cfa4
Fixes for the multiplayer SEXP packet to prevent errors caused by the coder taking too little data out of the packet before reporting that they are done.
2011-08-18 05:24:27 +00:00
Echelon9
052020fb45
PVS-Studio: The '&' operator is applied to bool type value. You've probably forgotten to include parentheses or intended to use the '&&' operator. In process_event_update_packet()
2011-08-11 14:56:43 +00:00
Echelon9
f01c40ba04
PVS-Studio: A call of the 'memset' function will lead to underflow of various buffers in multi code.
2011-08-11 14:53:11 +00:00
Echelon9
59a8f7d672
PVS-Studio fix: Incorrect logic within ping time colour indicator in multi_join_display_games() was overrepresenting yellow at the expense of red. Also replaced magic number with a definition.
2011-08-10 13:55:33 +00:00
Echelon9
12beca93ba
PVS-Studio fix: No need to set sinfo variable again immediately after first assignment to a different value in send_secondary_fired_packet()
2011-08-10 13:51:31 +00:00
The_E
682ca6fb76
Fix for Mantis 2424: Crashes in multiplayer when <Wingname> 1 is not a player ship
2011-06-28 19:24:13 +00:00
The_E
9320f86315
Adding a piece of sanity checking here, to avoid crashing the release build under certain strange circumstances
2011-06-27 22:16:41 +00:00
The_E