stoatchat/javascript-client-sdk
1
0
Fork 0
mirror of https://github.com/stoatchat/javascript-client-sdk.git synced 2026-07-19 09:05:59 -04:00
Code Issues 9 Packages Projects Releases 6 Wiki Activity

[PR #111] [CLOSED] BREAKING: use Deno tooling #112

New Issue
Closed
opened 2026-02-16 12:27:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 12:27:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/stoatchat/javascript-client-sdk/pull/111
Author: @williamhorning
Created: 3/14/2025
Status: ❌ Closed

Base: main ← Head: modernization

📝 Commits (10+)

  • 21b3447 BREAKING CHANGE: remove CJS build, polyfills, dependencies
  • 74b8a9e BREAKING CHANGE: simplify Collection interface
  • ee015e5 chore: add return types to all functions
  • a42f57f chore: use type-only imports in places
  • 3f4117e chore: replace eventemitter3 with vladfrangu/async_event_emitter
  • c682f71 BREAKING CHANGE: use Deno tooling
  • 02a5413 BREAKING CHANGE: remove solid.js dependency and redo collection interface
  • 78e7367 remove solid.js from package.json
  • 7b3899e Merge remote-tracking branch 'upstream/main' into bye-bye-solid
  • 6738be5 fix lockfile

📊 Changes

70 files changed (+1128 additions, -3553 deletions)

View changed files

📝 .github/workflows/codeql-analysis.yml (+29 -29)
📝 .github/workflows/docs.yml (+5 -13)
📝 .github/workflows/lint.yml (+7 -14)
➕ .github/workflows/publish.ts (+55 -0)
➕ .github/workflows/publish.yml (+31 -0)
📝 .gitignore (+2 -15)
➖ .prettierrc (+0 -13)
📝 .vscode/extensions.json (+1 -1)
📝 .vscode/settings.json (+5 -2)
📝 README.md (+9 -35)
➕ deno.json (+28 -0)
➖ eslint.config.js (+0 -23)
➖ package.json (+0 -48)
➖ pnpm-lock.yaml (+0 -2153)
📝 src/Client.ts (+68 -85)
📝 src/classes/BannedUser.ts (+2 -2)
📝 src/classes/Bot.ts (+4 -4)
📝 src/classes/Channel.ts (+76 -83)
📝 src/classes/ChannelUnread.ts (+2 -4)
📝 src/classes/ChannelWebhook.ts (+6 -6)

...and 50 more files

📄 Description

This pull request changes a lot about revolt.js, mostly in terms of dependencies and how to build it. Most of the changes here are done to both remove dependencies and support Deno more.

This includes changes from #112, #113, and #114 as well as the following:

  • BREAKING: use Deno tooling
  • chore: add support for both npm and JSR publishing

In addition to these changes, https://github.com/insertish/oapi/pull/3 removes the axios and lodash.defaultsdeep dependencies from oapi and revolt-api by proxy.

That combined with this PR should make for both Node, Deno, and browser support while publishing to both npm and JSR with just three dependencies:

  • @vladfrangu/async_event_emitter
  • revolt-api
  • ulid

This fixes #34

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

���� This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stoatchat/javascript-client-sdk/pull/111 **Author:** [@williamhorning](https://github.com/williamhorning) **Created:** 3/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `modernization` --- ### 📝 Commits (10+) - [`21b3447`](https://github.com/stoatchat/javascript-client-sdk/commit/21b34476339f27078a5b5cf3d77fe79cb7baf600) BREAKING CHANGE: remove CJS build, polyfills, dependencies - [`74b8a9e`](https://github.com/stoatchat/javascript-client-sdk/commit/74b8a9e9e9795734b53a6e9f819953590eb20039) BREAKING CHANGE: simplify Collection interface - [`ee015e5`](https://github.com/stoatchat/javascript-client-sdk/commit/ee015e55a8fd0dfb62daf6f10139d17f9a2f064b) chore: add return types to all functions - [`a42f57f`](https://github.com/stoatchat/javascript-client-sdk/commit/a42f57fc4be3080728239e46613e0031d98b4061) chore: use type-only imports in places - [`3f4117e`](https://github.com/stoatchat/javascript-client-sdk/commit/3f4117ece0efcbbcd6c439534ca0f1ef062c203d) chore: replace `eventemitter3` with `vladfrangu/async_event_emitter` - [`c682f71`](https://github.com/stoatchat/javascript-client-sdk/commit/c682f71125b2c118e5cdd188f07197a2beea6997) BREAKING CHANGE: use Deno tooling - [`02a5413`](https://github.com/stoatchat/javascript-client-sdk/commit/02a541339d22c836adf7ed27a51d000817dfc149) BREAKING CHANGE: remove solid.js dependency and redo collection interface - [`78e7367`](https://github.com/stoatchat/javascript-client-sdk/commit/78e736795e2fb5441db5a7fdaf5c7acb793c8326) remove solid.js from package.json - [`7b3899e`](https://github.com/stoatchat/javascript-client-sdk/commit/7b3899e8473a2d3046a0d3600bdf8dab38ac88a3) Merge remote-tracking branch 'upstream/main' into bye-bye-solid - [`6738be5`](https://github.com/stoatchat/javascript-client-sdk/commit/6738be5d9a95fa5532ce7cf40224c5de4c005ca8) fix lockfile ### 📊 Changes **70 files changed** (+1128 additions, -3553 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/codeql-analysis.yml` (+29 -29) 📝 `.github/workflows/docs.yml` (+5 -13) 📝 `.github/workflows/lint.yml` (+7 -14) ➕ `.github/workflows/publish.ts` (+55 -0) ➕ `.github/workflows/publish.yml` (+31 -0) 📝 `.gitignore` (+2 -15) ➖ `.prettierrc` (+0 -13) 📝 `.vscode/extensions.json` (+1 -1) 📝 `.vscode/settings.json` (+5 -2) 📝 `README.md` (+9 -35) ➕ `deno.json` (+28 -0) ➖ `eslint.config.js` (+0 -23) ➖ `package.json` (+0 -48) ➖ `pnpm-lock.yaml` (+0 -2153) 📝 `src/Client.ts` (+68 -85) 📝 `src/classes/BannedUser.ts` (+2 -2) 📝 `src/classes/Bot.ts` (+4 -4) 📝 `src/classes/Channel.ts` (+76 -83) 📝 `src/classes/ChannelUnread.ts` (+2 -4) 📝 `src/classes/ChannelWebhook.ts` (+6 -6) _...and 50 more files_ </details> ### 📄 Description This pull request changes a lot about revolt.js, mostly in terms of dependencies and how to build it. Most of the changes here are done to both remove dependencies and support Deno more. This includes changes from #112, #113, and #114 as well as the following: - **BREAKING**: use Deno tooling - chore: add support for both npm and [JSR](jsr.io) publishing In addition to these changes, https://github.com/insertish/oapi/pull/3 removes the `axios` and `lodash.defaultsdeep` dependencies from oapi and `revolt-api` by proxy. That combined with this PR should make for both Node, Deno, and browser support while publishing to both npm and JSR with just three dependencies: - `@vladfrangu/async_event_emitter` - `revolt-api` - `ulid` This fixes #34 ---- Please make sure to check the following tasks before opening and submitting a PR - [X] I understand and have followed the [contribution guide](https://github.com/revoltchat/.github/blob/master/.github/CONTRIBUTING.md) - [X] I have tested my changes locally and they are working as intended --- <sub>���� This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 12:27:03 -05:00
yindo closed this issue 2026-02-16 12:27:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stoatchat/javascript-client-sdk#112
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?