fix(cli): powershell crashing on SIGINT, closes #3997 (#4007)

This commit is contained in:
Lucas Fernandes Nogueira
2022-04-29 15:51:08 -07:00
committed by GitHub
parent d96805a7ac
commit 320484866b
2 changed files with 9 additions and 2 deletions

View File

@@ -0,0 +1,6 @@
---
"cli.rs": patch
"cli.js": patch
---
Fixes a Powershell crash when sending SIGINT to the dev command.

View File

@@ -25,7 +25,7 @@ use std::{
fs::FileType,
io::{BufReader, Write},
path::{Path, PathBuf},
process::{exit, Command},
process::{exit, Command, Stdio},
sync::{
atomic::{AtomicBool, Ordering},
mpsc::channel,
@@ -126,6 +126,7 @@ fn command_internal(options: Options) -> Result<()> {
.pipe()?; // development build always includes debug information
command
};
command.stdin(Stdio::piped());
let child = SharedChild::spawn(&mut command)
.unwrap_or_else(|_| panic!("failed to run `{}`", before_dev));
@@ -489,7 +490,7 @@ fn start_app(
}
command.stdout(os_pipe::dup_stdout().unwrap());
command.stderr(std::process::Stdio::piped());
command.stderr(Stdio::piped());
let child =
SharedChild::spawn(&mut command).with_context(|| format!("failed to run {}", runner))?;