[PR #16] [MERGED] Remove validation of the file_path parameter in file_reader #24

New Issue

2026-06-06T22:10:42-04:00

yindo commented

2026-06-06 22:10:42 -04:00

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/soldr-modules/pull/16
Author: @souryogurt
Created: 12/9/2022
Status: ✅ Merged
Merged: 12/9/2022
Merged by: @asdek

Base: master ← Head: remove-file_reader-log_files-ui-validation

📝 Commits (1)

b6f5fa5 Remove validation of the file_path parameter in file_reader

📊 Changes

1 file changed (+1 additions, -7 deletions)

View changed files

📝 file_reader/1.0.0/config/config_schema.json (+1 -7)

📄 Description

This parameter had been validating using a simple regexp that doesn't allow specifying absolute paths and other correct windows paths like network shares.

Checking the validity of the path for both Windows and Unix systems simultaneously seems unnecessary in UI since it is almost impossible to check all correct variants using just regexp. So instead of correcting the regexp - I deleted it.
Closes #10
Closes #11

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/soldr-modules/pull/16 **Author:** [@souryogurt](https://github.com/souryogurt) **Created:** 12/9/2022 **Status:** ✅ Merged **Merged:** 12/9/2022 **Merged by:** [@asdek](https://github.com/asdek) **Base:** `master` ← **Head:** `remove-file_reader-log_files-ui-validation` --- ### 📝 Commits (1) - [`b6f5fa5`](https://github.com/vxcontrol/soldr-modules/commit/b6f5fa510cc38ca79224d5b826f4bdd18892c29c) Remove validation of the file_path parameter in file_reader ### 📊 Changes **1 file changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `file_reader/1.0.0/config/config_schema.json` (+1 -7) </details> ### 📄 Description This parameter had been validating using a simple regexp that doesn't allow specifying absolute paths and other correct windows paths like network shares. Checking the validity of the path for both Windows and Unix systems simultaneously seems unnecessary in UI since it is almost impossible to check all correct variants using just regexp. So instead of correcting the regexp - I deleted it. Closes #10 Closes #11 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-06-06 22:10:42 -04:00

yindo closed this issue

2026-06-06 22:10:42 -04:00

yindo referenced this issue

2026-06-06 22:10:43 -04:00

[PR #24] [CLOSED] XDR-78: fix to upload files with cyrillic sympols in filename (on win… #27

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vxcontrol/soldr-modules#24