[PR #43] [MERGED] Feature/improve protocol #42

New Issue

2026-06-06T22:10:47-04:00

yindo commented

2026-06-06 22:10:47 -04:00

📋 Pull Request Information

Original PR: https://github.com/vxcontrol/soldr-modules/pull/43
Author: @NexoMichael
Created: 1/12/2023
Status: ✅ Merged
Merged: 1/16/2023
Merged by: @asdek

Base: master ← Head: feature/improve_protocol

📝 Commits (4)

d27d7a5 add args and sent msg validation for vxproto mock
eb9da4a fix linter config
5f3e5c0 remove unused/unpublished events for file_remover module
6d99b61 add 'data' messages proxying similar to actions

📊 Changes

12 files changed (+202 additions, -215 deletions)

View changed files

📝 .luacheckrc (+8 -4)
📝 file_remover/1.0.0/config/current_event_config.json (+0 -38)
📝 file_remover/1.0.0/config/default_event_config.json (+0 -38)
📝 file_remover/1.0.0/config/event_config_schema.json (+0 -76)
📝 file_remover/1.0.0/config/info.json (+0 -3)
📝 file_remover/1.0.0/config/locale.json (+0 -33)
📝 tests/file_remover_server_spec.lua (+2 -2)
📝 utils/mock/api.lua (+11 -3)
📝 utils/mock/core.lua (+7 -0)
📝 utils/protocol/cmodule.lua (+68 -5)
📝 utils/protocol/protocol.lua (+6 -1)
📝 utils/protocol/smodule.lua (+100 -12)

📄 Description

Introducing 'data' proxying implementation in common protocol implementation for modules.

Additionally small clean-ups here and there like cleaning of unused/unpublished events for file_remover module, linter configuration fixes and some additional validations in vxproto mock.

Description of the Change

How to test the Change

Changelog Entry

Added - 'data' messages proxying implementation
Removed - unused/unpublished events for file_remover module.
Fixed - small typos

Checklist:

I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/vxcontrol/soldr-modules/pull/43 **Author:** [@NexoMichael](https://github.com/NexoMichael) **Created:** 1/12/2023 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@asdek](https://github.com/asdek) **Base:** `master` ← **Head:** `feature/improve_protocol` --- ### 📝 Commits (4) - [`d27d7a5`](https://github.com/vxcontrol/soldr-modules/commit/d27d7a592e3442c7bfbab259d983bc20213a2293) add args and sent msg validation for vxproto mock - [`eb9da4a`](https://github.com/vxcontrol/soldr-modules/commit/eb9da4a4bf5b2839b63fa4f795766e6bfbd3353e) fix linter config - [`5f3e5c0`](https://github.com/vxcontrol/soldr-modules/commit/5f3e5c03cf1c95446700b5f0a2e350ae4f4c293e) remove unused/unpublished events for file_remover module - [`6d99b61`](https://github.com/vxcontrol/soldr-modules/commit/6d99b613ffa0da201af6c915d87d8ae546b9507a) add 'data' messages proxying similar to actions ### 📊 Changes **12 files changed** (+202 additions, -215 deletions) <details> <summary>View changed files</summary> 📝 `.luacheckrc` (+8 -4) 📝 `file_remover/1.0.0/config/current_event_config.json` (+0 -38) 📝 `file_remover/1.0.0/config/default_event_config.json` (+0 -38) 📝 `file_remover/1.0.0/config/event_config_schema.json` (+0 -76) 📝 `file_remover/1.0.0/config/info.json` (+0 -3) 📝 `file_remover/1.0.0/config/locale.json` (+0 -33) 📝 `tests/file_remover_server_spec.lua` (+2 -2) 📝 `utils/mock/api.lua` (+11 -3) 📝 `utils/mock/core.lua` (+7 -0) 📝 `utils/protocol/cmodule.lua` (+68 -5) 📝 `utils/protocol/protocol.lua` (+6 -1) 📝 `utils/protocol/smodule.lua` (+100 -12) </details> ### 📄 Description Introducing 'data' proxying implementation in common protocol implementation for modules. Additionally small clean-ups here and there like cleaning of unused/unpublished events for file_remover module, linter configuration fixes and some additional validations in vxproto mock. ### Description of the Change ### How to test the Change ### Changelog Entry > Added - 'data' messages proxying implementation > Removed - unused/unpublished events for file_remover module. > Fixed - small typos ### Checklist: - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my change. - [x] All new and existing tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-06-06 22:10:47 -04:00

yindo closed this issue

2026-06-06 22:10:47 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vxcontrol/soldr-modules#42