mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-23 19:49:43 +00:00
41742927ee
Currently the bitbang_i2c_init() function allocates a bitbang_i2c_interface struct which it returns. This is unfortunate because it means that if the function is used from a DeviceState init method then the memory will be leaked by an "init then delete" cycle, as used by the qmp/hmp commands that list device properties. Since three out of four of the uses of this function are in device init methods, switch the function to do an in-place initialization of a struct that can be embedded in the device state struct of the caller. This fixes LeakSanitizer leak warnings that have appeared in the patchew configuration (which only tries to run the sanitizers for the x86_64-softmmu target) now that we use the bitbang-i2c code in an x86-64 config. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> Tested-by: BALATON Zoltan <balaton@eik.bme.hu> Acked-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-id: 20190702163844.20458-1-peter.maydell@linaro.org Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> |
||
|---|---|---|
| .. | ||
| aspeed_i2c.c | ||
| bitbang_i2c.c | ||
| core.c | ||
| exynos4210_i2c.c | ||
| imx_i2c.c | ||
| Kconfig | ||
| Makefile.objs | ||
| microbit_i2c.c | ||
| mpc_i2c.c | ||
| omap_i2c.c | ||
| pm_smbus.c | ||
| ppc4xx_i2c.c | ||
| smbus_eeprom.c | ||
| smbus_ich9.c | ||
| smbus_master.c | ||
| smbus_slave.c | ||
| trace-events | ||
| versatile_i2c.c | ||