Knut Omang 9cf961bba7 sockets: Handle race condition between binds to the same port ... If an offset of ports is specified to the inet_listen_saddr function(), and two or more processes tries to bind from these ports at the same time, occasionally more than one process may be able to bind to the same port. The condition is detected by listen() but too late to avoid a failure. This function is called by socket_listen() and used by all socket listening code in QEMU, so all cases where any form of dynamic port selection is used should be subject to this issue. Add code to close and re-establish the socket when this condition is observed, hiding the race condition from the user. Also clean up some issues with error handling to allow more accurate reporting of the cause of an error. This has been developed and tested by means of the test-listen unit test in the previous commit. Enable the test for make check now that it passes. Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Reviewed-by: Girish Moodalbail <girish.moodalbail@oracle.com> Signed-off-by: Knut Omang <knut.omang@oracle.com> Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>		2017-10-16 16:55:31 +01:00
..
acl.c	Drop Emacs local variables lists redundant with .dir-locals.el	2016-07-12 16:19:16 +02:00
aio-posix.c	aio: fix assert when remove poll during destroy	2017-10-03 14:36:19 -04:00
aio-win32.c	util/aio-win32: Only select on what we are actually waiting for	2017-07-17 15:58:37 +01:00
aiocb.c	block: move AioContext, QEMUTimer, main-loop to libqemuutil	2017-02-21 11:14:07 +00:00
async.c	async: Introduce aio_co_enter	2017-04-11 20:07:15 +08:00
base64.c
bitmap.c	bitmap: provide to_le/from_le helpers	2017-09-22 14:11:25 +02:00
bitops.c	bitmap: remove BITOP_WORD()	2017-09-22 14:11:23 +02:00
buffer.c	qemu-common: stop including qemu/host-utils.h from qemu-common.h	2016-05-19 16:42:28 +02:00
bufferiszero.c	util: Introduce include/qemu/cpuid.h	2017-07-24 12:42:55 +01:00
cacheinfo.c	configure: Drop AIX host support	2017-09-07 19:02:30 +01:00
compatfd.c	cpus: remove ugly cast on sigbus_handler	2017-03-03 16:40:02 +01:00
coroutine-sigaltstack.c	coroutine-sigaltstack: use helper for allocating stack memory	2016-09-29 14:13:39 +02:00
coroutine-ucontext.c	coroutine-ucontext: use helper for allocating stack memory	2016-09-29 14:13:39 +02:00
coroutine-win32.c	coroutine: add a macro for the coroutine stack size	2016-09-29 14:13:39 +02:00
crc32c.c
cutils.c	Convert remaining single line fprintf() to warn_report()	2017-09-19 16:20:49 +02:00
envlist.c	util: Use g_malloc/g_free in envlist.c	2017-05-07 09:57:51 +03:00
error.c	error: Implement the warn and free Error functions	2017-07-13 13:50:19 +02:00
event_notifier-posix.c	Remove/replace sysemu/char.h inclusion	2017-06-02 11:33:52 +04:00
event_notifier-win32.c	event_notifier: prevent accidental use after close	2017-03-29 02:35:23 +03:00
fifo8.c	migration: consolidate VMStateField.start	2017-02-13 17:27:13 +00:00
getauxval.c
hbitmap.c	hbitmap: Rename serialization_granularity to serialization_align	2017-10-06 16:28:58 +02:00
hexdump.c
host-utils.c	host-utils: Implement unsigned quadword left/right shift and unit tests	2017-01-31 10:10:14 +11:00
id.c
iohandler.c	block: move AioContext, QEMUTimer, main-loop to libqemuutil	2017-02-21 11:14:07 +00:00
iov.c	util: Fix assertion in iov_copy() upon zero 'bytes' and non-zero 'offset'	2016-08-03 18:44:57 +02:00
keyval.c	qapi: Generate FOO_str() macro for QAPI enum FOO	2017-09-04 13:09:13 +02:00
lockcnt.c	qemu-thread: optimize QemuLockCnt with futexes on Linux	2017-01-16 13:25:18 +00:00
log.c	util/cutils: Rename qemu_strtoll(), qemu_strtoull()	2017-02-23 20:35:35 +01:00
main-loop.c	Convert multi-line fprintf() to warn_report()	2017-09-19 14:09:34 +02:00
Makefile.objs	util: move qemu_real_host_page_size/mask to osdep.h	2017-10-10 09:45:00 -07:00
memfd.c	os-posix: include sys/mman.h	2016-06-16 18:39:03 +02:00
mmap-alloc.c	exec, kvm, target-ppc: Move getrampagesize() to common code	2017-03-03 11:30:59 +11:00
module.c	module: Don't load the same module if requested multiple times	2016-10-07 14:14:06 +02:00
notify.c
osdep.c	osdep: Add runtime OFD lock detection	2017-08-11 14:12:44 +02:00
oslib-posix.c	oslib-posix: Print errors before aborting on qemu_alloc_stack()	2017-08-30 09:33:49 +01:00
oslib-win32.c	block: rip out all traces of password prompting	2017-07-11 17:44:56 +02:00
pagesize.c	util: move qemu_real_host_page_size/mask to osdep.h	2017-10-10 09:45:00 -07:00
path.c	util: Removed unneeded header from path.c	2017-03-14 13:26:37 +01:00
qdist.c	qdist: return "(empty)" instead of NULL when printing an empty dist	2016-08-03 18:44:56 +02:00
qemu-config.c	config: qemu_config_parse() return number of config groups	2017-10-09 23:21:52 -03:00
qemu-coroutine-io.c	coroutine: move entry argument to qemu_coroutine_create	2016-07-13 13:26:02 +02:00
qemu-coroutine-lock.c	coroutine-lock: add qemu_co_rwlock_downgrade and qemu_co_rwlock_upgrade	2017-07-17 11:28:15 +08:00
qemu-coroutine-sleep.c	block: explicitly acquire aiocontext in timers that need it	2017-02-21 11:14:08 +00:00
qemu-coroutine.c	coroutine-lock: do not touch coroutine after another one has been entered	2017-06-07 14:39:00 +01:00
qemu-error.c	error: Revert unwanted change of warning messages	2017-07-24 14:16:29 +02:00
qemu-openpty.c
qemu-option.c	qapi: merge QInt and QFloat in QNum	2017-06-20 14:31:31 +02:00
qemu-progress.c	progress: Show current progress on SIGINFO	2017-04-28 18:48:11 +02:00
qemu-sockets.c	sockets: Handle race condition between binds to the same port	2017-10-16 16:55:31 +01:00
qemu-thread-posix.c	util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT	2017-09-26 09:06:02 +03:00
qemu-thread-win32.c	qemu-thread: Assert locks are initialized before using	2017-07-04 14:39:28 +02:00
qemu-timer-common.c
qemu-timer.c	icount: process QEMU_CLOCK_VIRTUAL timers in vCPU thread	2017-03-14 13:51:34 +01:00
qht.c	qht: fix unlock-after-free segfault upon resizing	2016-10-06 18:04:13 +02:00
range.c	range: Replace internal representation of Range	2016-07-04 16:49:33 +03:00
rcu.c	Revert "rcu: do not create thread in pthread_atfork callback"	2017-08-08 10:40:19 +02:00
readline.c
stats64.c	util: add stats64 module	2017-06-16 07:55:00 +08:00
systemd.c	qemu-ga: obey LISTEN_PID when using systemd socket activation	2017-03-19 11:12:12 +01:00
thread-pool.c	thread-pool: add missing qemu_bh_cancel in completion function	2017-03-17 12:54:21 +01:00
throttle.c	throttle: Assert that bkt->max is valid in throttle_compute_wait()	2017-09-26 14:46:23 +02:00
timed-average.c	Fix some typos found by codespell	2016-05-18 15:04:27 +03:00
trace-events	docs: fix broken paths to docs/devel/tracing.txt	2017-07-31 13:12:53 +03:00
unicode.c
uri.c	Fix documentation and some comments (article, grammar)	2017-01-24 23:26:52 +03:00
uuid.c	uuid: Tighten uuid parse	2016-09-23 11:42:52 +08:00