refactor(insights): remove insight-colors feature flag (#37094)

frontend/src/lib/constants.tsx

@@ -210,7 +210,6 @@ export const FEATURE_FLAGS = {
     BILLING_SKIP_FORECASTING: 'billing-skip-forecasting', // owner: @zach
     CDP_ACTIVITY_LOG_NOTIFICATIONS: 'cdp-activity-log-notifications', // owner: #team-cdp
     COOKIELESS_SERVER_HASH_MODE_SETTING: 'cookieless-server-hash-mode-setting', // owner: @robbie-c #team-web-analytics
-    INSIGHT_COLORS: 'insight-colors', // owner: @thmsobrmlr #team-product-analytics
     WEB_ANALYTICS_FOR_MOBILE: 'web-analytics-for-mobile', // owner: @robbie-c #team-web-analytics
     LLM_OBSERVABILITY: 'llm-observability', // owner: #team-llm-analytics
     ONBOARDING_SESSION_REPLAY_SEPARATE_STEP: 'onboarding-session-replay-separate-step', // owner: @joshsny #team-growth

frontend/src/queries/nodes/InsightViz/InsightDisplayConfig.tsx

@@ -39,7 +39,6 @@ import { PathStepPicker } from 'scenes/insights/views/Paths/PathStepPicker'
 import { RetentionBreakdownFilter } from 'scenes/retention/RetentionBreakdownFilter'
 import { trendsDataLogic } from 'scenes/trends/trendsDataLogic'
 
-import { resultCustomizationsModalLogic } from '~/queries/nodes/InsightViz/resultCustomizationsModalLogic'
 import { isValidBreakdown } from '~/queries/utils'
 import { isTrendsQuery } from '~/queries/utils'
 import { ChartDisplayType } from '~/types'
@@ -75,7 +74,6 @@ export function InsightDisplayConfig(): JSX.Element {
     const { isTrendsFunnel, isStepsFunnel, isTimeToConvertFunnel, isEmptyFunnel } = useValues(
         funnelDataLogic(insightProps)
     )
-    const { hasInsightColors } = useValues(resultCustomizationsModalLogic(insightProps))
 
     const showCompare = (isTrends && display !== ChartDisplayType.ActionsAreaGraph) || isStickiness
     const showInterval =
@@ -111,7 +109,7 @@ export function InsightDisplayConfig(): JSX.Element {
                   },
               ]
             : []),
-        ...(supportsResultCustomizationBy && hasInsightColors
+        ...(supportsResultCustomizationBy
             ? [
                   {
                       title: (

frontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts

@@ -1,8 +1,6 @@
 import { actions, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'
 
 import { DataColorToken } from 'lib/colors'
-import { FEATURE_FLAGS } from 'lib/constants'
-import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
 import { funnelDataLogic } from 'scenes/funnels/funnelDataLogic'
 import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'
 import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'
@@ -28,8 +26,6 @@ export const resultCustomizationsModalLogic = kea<resultCustomizationsModalLogic
             ['resultCustomizationBy', 'resultCustomizations as trendsResultCustomizations', 'getTrendsColorToken'],
             funnelDataLogic(props),
             ['resultCustomizations as funnelsResultCustomizations', 'getFunnelsColorToken'],
-            featureFlagLogic,
-            ['featureFlags'],
         ],
         actions: [insightVizDataLogic, ['updateInsightFilter']],
     })),
@@ -61,10 +57,6 @@ export const resultCustomizationsModalLogic = kea<resultCustomizationsModalLogic
     }),
 
     selectors({
-        hasInsightColors: [
-            (s) => [s.featureFlags],
-            (featureFlags): boolean => !!featureFlags[FEATURE_FLAGS.INSIGHT_COLORS],
-        ],
         modalVisible: [(s) => [s.dataset], (dataset): boolean => dataset !== null],
         colorToken: [
             (s) => [s.localColorToken, s.colorTokenFromQuery],

frontend/src/scenes/insights/views/Funnels/FunnelStepsTable.tsx

@@ -36,7 +36,6 @@ export function FunnelStepsTable(): JSX.Element | null {
     )
     const { canOpenPersonModal } = useValues(funnelPersonsModalLogic(insightProps))
     const { openPersonsModalForSeries } = useActions(funnelPersonsModalLogic(insightProps))
-    const { hasInsightColors } = useValues(resultCustomizationsModalLogic(insightProps))
     const { openModal } = useActions(resultCustomizationsModalLogic(insightProps))
 
     const isOnlySeries = flattenedBreakdowns.length <= 1
@@ -56,7 +55,7 @@ export function FunnelStepsTable(): JSX.Element | null {
     in by experiments as a measure of detecting wether we are in an experiment context.
     Likely this can be done in a better way once experiments are re-written to use their own
     queries. */
-    const showCustomizationIcon = hasInsightColors && !insightProps.cachedInsight?.disable_baseline
+    const showCustomizationIcon = !insightProps.cachedInsight?.disable_baseline
 
     const columnsGrouped = [
         {

frontend/src/scenes/insights/views/InsightsTable/InsightsTable.tsx

@@ -16,7 +16,6 @@ import { IndexedTrendResult } from 'scenes/trends/types'
 import { cohortsModel } from '~/models/cohortsModel'
 import { propertyDefinitionsModel } from '~/models/propertyDefinitionsModel'
 import { extractExpressionComment } from '~/queries/nodes/DataTable/utils'
-import { resultCustomizationsModalLogic } from '~/queries/nodes/InsightViz/resultCustomizationsModalLogic'
 import { isValidBreakdown } from '~/queries/utils'
 import { ChartDisplayType, ItemMode } from '~/types'
 
@@ -90,7 +89,6 @@ export function InsightsTable({
     const { toggleResultHidden, toggleAllResultsHidden } = useActions(trendsDataLogic(insightProps))
     const { aggregation, allowAggregation } = useValues(insightsTableDataLogic(insightProps))
     const { setAggregationType } = useActions(insightsTableDataLogic(insightProps))
-    const { hasInsightColors } = useValues(resultCustomizationsModalLogic(insightProps))
     const { weekStartDay, timezone } = useValues(teamLogic)
 
     const handleSeriesEditClick = (item: IndexedTrendResult): void => {
@@ -232,7 +230,7 @@ export function InsightsTable({
         })
     }
 
-    if (hasInsightColors && !isMainInsightView) {
+    if (!isMainInsightView && !embedded) {
         columns.push({
             title: <ColorCustomizationColumnTitle />,
             render: (_, item) => <ColorCustomizationColumnItem item={item} />,

frontend/src/scenes/settings/SettingsMap.tsx

@@ -193,7 +193,6 @@ export const SETTINGS_MAP: SettingSection[] = [
                     </>
                 ),
                 component: <DataColorThemes />,
-                flag: 'INSIGHT_COLORS',
             },
             {
                 id: 'persons-on-events',