yindo/posthog
1
0
Fork 0
mirror of https://github.com/BillyOutlast/posthog.git synced 2026-02-04 03:01:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: improve validation failed error for max ai surveys (#37270)

Browse Source
This commit is contained in:
Lucas Faria
2025-08-28 19:05:39 -03:00
committed by GitHub
parent eb0e3cc220
commit 6601d047ce
4 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/scenes/surveys/Surveys.tsx
View File

@@ -80,7 +80,12 @@ function NewSurveyButton(): JSX.Element {
context={{
user_id: user.uuid,
}}
callback={(toolOutput: { survey_id?: string; survey_name?: string; error?: string }) => {
callback={(toolOutput: {
survey_id?: string
survey_name?: string
error?: string
error_message?: string
}) => {
addProductIntent({
product_type: ProductKey.SURVEYS,
intent_context: ProductIntentContext.SURVEY_CREATED,

6
frontend/src/scenes/surveys/components/empty-state/SurveysEmptyState.tsx
View File

@@ -120,7 +120,11 @@ export function SurveysEmptyState({ numOfSurveys }: Props): JSX.Element {
'Create a feedback survey asking about our new dashboard',
]}
context={{ user_id: user.uuid }}
callback={(toolOutput: { survey_id?: string; error?: string }) => {
callback={(toolOutput: {
survey_id?: string
error?: string
error_message?: string
}) => {
addProductIntent({
product_type: ProductKey.SURVEYS,
intent_context: ProductIntentContext.SURVEY_CREATED,

4
products/surveys/backend/max_tools.py
View File

@@ -88,7 +88,7 @@ class CreateSurveyTool(MaxTool):
if not result.questions:
return "❌ Survey must have at least one question", {
"error": "validation_failed",
"details": "No questions provided",
"error_message": "No questions were created from the survey instructions.",
}
# Apply appearance defaults and prepare survey data
@@ -110,7 +110,7 @@ class CreateSurveyTool(MaxTool):
except Exception as validation_error:
return f"❌ Survey validation failed: {str(validation_error)}", {
"error": "validation_failed",
"details": str(validation_error),
"error_message": str(validation_error),
}
except Exception as e:

2
products/surveys/backend/test_max_tools.py
View File

@@ -127,7 +127,7 @@ class TestSurveyCreatorTool(BaseTest):
# Verify error response
assert "❌ Survey must have at least one question" in content
assert artifact["error"] == "validation_failed"
assert "No questions provided" in artifact["details"]
assert "No questions were created from the survey instructions" in artifact["error_message"]
@patch.object(CreateSurveyTool, "_create_survey_from_instructions")
@pytest.mark.django_db