yindo/posthog
1
0
Fork 0
mirror of https://github.com/BillyOutlast/posthog.git synced 2026-02-04 03:01:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: filename is optional for java frames (#39457)

Browse Source
This commit is contained in:
Manoel Aranda Neto
2025-10-10 10:27:16 +02:00
committed by GitHub
parent 3e8e2289d7
commit 8872b1636a
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
rust/cymbal/src/langs/java.rs
View File

@@ -9,10 +9,10 @@ use crate::{
#[derive(Debug, Clone, Deserialize, Serialize)]
pub struct RawJavaFrame {
pub filename: String, // The relative path of the file the context line is in
pub function: String, // The name of the function the exception came from
pub lineno: Option<u32>, // The line number of the context line
pub module: Option<String>, // The java-import style module name the function is in
pub filename: Option<String>, // The relative path of the file the context line is in
pub function: String, // The name of the function the exception came from
pub lineno: Option<u32>, // The line number of the context line
pub module: String, // The java-import style module name the function is in
#[serde(flatten)]
pub meta: CommonFrameMetadata,
}
@@ -26,12 +26,12 @@ impl RawJavaFrame {
// files they're in are sufficiently similar we can consider
// them to be the same frame
let mut hasher = Sha512::new();
hasher.update(self.filename.as_bytes());
if let Some(filename) = &self.filename {
hasher.update(filename.as_bytes());
}
hasher.update(self.function.as_bytes());
hasher.update(self.lineno.unwrap_or_default().to_be_bytes());
self.module
.as_ref()
.inspect(|m| hasher.update(m.as_bytes()));
hasher.update(self.module.as_bytes());
format!("{:x}", hasher.finalize())
}
}
@@ -43,7 +43,7 @@ impl From<&RawJavaFrame> for Frame {
mangled_name: raw.function.clone(),
line: raw.lineno,
column: None,
source: Some(raw.filename.clone()),
source: raw.filename.clone(),
in_app: raw.meta.in_app,
resolved_name: Some(raw.function.clone()),
lang: "java".to_string(),