yindo/posthog
1
0
Fork 0
mirror of https://github.com/BillyOutlast/posthog.git synced 2026-02-04 03:01:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(logs): dont swallow query exceptions (#41456)

Browse Source
This commit is contained in:
Frank Hamand
2025-11-13 16:16:15 +00:00
committed by GitHub
parent 5edf651324
commit ef82c4b776
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
products/logs/backend/api.py
View File

@@ -12,7 +12,6 @@ from posthog.api.mixins import PydanticModelMixin
from posthog.api.routing import TeamAndOrgViewSetMixin
from posthog.clickhouse.client import sync_execute
from posthog.clickhouse.client.connection import Workload
from posthog.exceptions_capture import capture_exception
from posthog.hogql_queries.query_runner import ExecutionMode
from products.logs.backend.logs_query_runner import CachedLogsQueryResponse, LogsQueryResponse, LogsQueryRunner
@@ -140,11 +139,7 @@ class LogsViewSet(TeamAndOrgViewSetMixin, PydanticModelMixin, viewsets.ViewSet):
response = runner.run(ExecutionMode.CALCULATE_BLOCKING_ALWAYS)
yield from response.results
try:
results = list(itertools.islice(results_generator(query, logs_query_params), logs_query_params["limit"]))
except Exception as e:
capture_exception(e)
return Response({"error": "Something went wrong"}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)
results = list(itertools.islice(results_generator(query, logs_query_params), logs_query_params["limit"]))
return Response({"query": query, "results": results}, status=200)
@action(detail=False, methods=["POST"], required_scopes=["error_tracking:read"])
@@ -160,11 +155,7 @@ class LogsViewSet(TeamAndOrgViewSetMixin, PydanticModelMixin, viewsets.ViewSet):
)
runner = SparklineQueryRunner(team=self.team, query=query)
try:
response = runner.run(ExecutionMode.CALCULATE_BLOCKING_ALWAYS)
except Exception as e:
capture_exception(e)
return Response({"error": "Something went wrong"}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)
response = runner.run(ExecutionMode.CALCULATE_BLOCKING_ALWAYS)
assert isinstance(response, LogsQueryResponse | CachedLogsQueryResponse)
return Response(response.results, status=status.HTTP_200_OK)