It seems sensible to put some kind of limit on this to stop threads that have
marking work spending too much time donating when they could be making
progress.
Differential Revision: https://phabricator.services.mozilla.com/D171593
This implements some optimizations targeted at Canvas2D's putImageData:
1) Track whether the canvas is in the initially clear state so that we avoid
reading back from the WebGL framebuffer into the Skia framebuffer when a
fallback does occur or when a data snapshot is needed.
2) For surfaces that are too large to upload to a texture, directly use
glTexSubImage2D to draw data to the WebGL framebuffer, bypassing a separate
texture upload.
3) Disregard the surface size limits for SurfacePatterns containing a
compatible texture handle.
Differential Revision: https://phabricator.services.mozilla.com/D171773
Due to the sections being guarded by an `AutoFrameSelectionBatcher`,
no strong references are needed. Thus,
`MOZ_KnownLive()` can be used to suppress warnings.
Differential Revision: https://phabricator.services.mozilla.com/D171707
Also fix update-angle.py:
* Use shell=True to get ninja to run
* Don't record "/PDBSourcePath:" because it depends on configuration of
the vendoring machine and is otherwise unused, and so uselessly causes
blame noise.
Differential Revision: https://phabricator.services.mozilla.com/D171824
Otherwise, tests can take a very long time to run due to a bug without us realising that this is due to cache condition timeouts.
This patch also notifies observers of a cache update when state change events are received, as those do update the cache but aren't handled by RecvCache.
Some Mac tests depend on cache notifications for these instead of state change events, so these were hitting cache condition timeouts.
Differential Revision: https://phabricator.services.mozilla.com/D171417
`Poetry` version `1.4` depends on `jsonschema>=4.10.0`. Unfortunately, our current implementation of `./mach vendor python` cannot see that specific dependency, because it specific to the `vendor` site.
`glean-parser` depends on `jsonschema>=3.2`, and when the lockfile is generated, it pulls in `jsonschema==3.2`, which causes an incompatibility with `poetry` in the `vendor` site.
Fortunately the loose dependencies of `glean-parser` and `poetry` are compatible, the lockfile just doesn't know it. As such, if we explicitly specify `jsonschema==4.10.0`, the compatibility in the `vendor` site is resolved.
This is a temporary workaround and will be resolved by either vendoring `poetry` itself, or adding `lockfiles` to every site.
Differential Revision: https://phabricator.services.mozilla.com/D171760
The browser mochitest in this change causes a timeout without this fix since
the overscroll gutter gets stuck thus we will never get "APZ:TransformEnd".
Differential Revision: https://phabricator.services.mozilla.com/D171421
Automatic update from web-platform-tests
HTML: dialog form submission
For https://github.com/whatwg/html/pull/8943.
--
wpt-commits: bcaa9ec9eddd784b4cc90eb7ecb5c68dfd56a085
wpt-pr: 38819
Automatic update from web-platform-tests
Disallow breaks before trailing border/padding in table cells.
We normally allow a last-resort break between the content box block-end
and any block-end border/padding, if that can help avoid fragmentainer
overflow. Don't do this for table cells, as that upsets the row
stretching machinery. See how PlaceCells() is rerun in
NGTableRowLayoutAlgorithm::Layout() with a new row size.
This is a simple fix. A more elaborate fix would be to store a flag in
the break token, saying that we're past the content box (we already have
one for being past the *border* box), and just keep on allowing such
breaks before trailing border/padding. But it just doesn't seem worth it
at this point.
Bug: 1420637
Change-Id: Ie43f3af898bab5cbf9a062232383adf307376ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4303193
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1113046}
--
wpt-commits: d031b37d079e789288f76164cd44b8c556d79d68
wpt-pr: 38804
Automatic update from web-platform-tests
[CodeHealth] Misc cleaups in WPTs in pointerevents/ folder. (#38778)
This is a no-op change, fixes:
- redundant arrays in pointerevent_mouse-pointer-preventdefault.html
- inconsistent indentation in pointerevent_support.js
Bug: 1085647
Change-Id: Icd78e45c4f6c013d34d56b0866ed7676524660e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300670
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1111926}
Co-authored-by: Mustaq Ahmed <mustaq@google.com>
--
wpt-commits: 3a1026219a6b6d8d710abb0741bc1cb48ab33a67
wpt-pr: 38778
Automatic update from web-platform-tests
WPT: Update c-v top layer test expectation to not expect it to be relevant.
This patch changes the expectation of one of the tests. Previously, it
expected that a c-v element becomes relevant to the user if any of its
ancestors are in the top layer.
This patch changes that to not expect it to be relevant, as per
discussion in this issue:
https://github.com/w3c/csswg-drafts/issues/8514R=chrishtr@chromium.org
Change-Id: I92c831d4390250bfdcbefff3be93921221293168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304380
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1112989}
--
wpt-commits: 91f8f2ec59c3722bd19399a21cc560a7ccdd8a39
wpt-pr: 38790
Automatic update from web-platform-tests
Revert "Reland "Implement CSSTransitionDiscrete which enables transitions on discrete properties.""
This reverts commit 47bd2ac70e0ac720a1cbb87126b2d0174c43e23e.
Reason for revert:
blink_wpt_tests failed because of:
external/wpt/css/css-transitions/all-with-discrete.tentative.html
This is a testharness.js-based test.
FAIL all with an explicit discrete property should animate. assert_true: expected true got false
PASS all without an explicit discrete property should not animate.
Harness: the test ran to completion.
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/111789/overview
Original change's description:
> Reland "Implement CSSTransitionDiscrete which enables transitions on discrete properties."
>
> Original patch: https://crrev.com/c/4219315
> Revert: https://crrev.com/c/4305045
>
> The original patch was causing bots to fail because they were somehow
> making the tests marked as crashing fail instead of crash. I wasn't able
> to reproduce the fail instead of crashing even with dchecks turned off,
> but I am confident that relaxing the TestExpectations will make this
> work again.
>
> Bug: 1399631, 1413556
> Change-Id: Id444255e727dbfed0fa61846d9d98653aa8eed67
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304846
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Joey Arhar <jarhar@chromium.org>
> Auto-Submit: Joey Arhar <jarhar@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1112803}
Bug: 1399631, 1413556
Change-Id: I865c3b84e58d99c6e831ce9a67e1b4789e345c56
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307944
Auto-Submit: Robert Flack <flackr@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1112985}
--
wpt-commits: 21ee4c65f5cc6b7aea32e7f97d8dc3aa835c477f
wpt-pr: 38809
