Test was already migrated in Bug 1304003 to browser_webconsole_observer_notifications.js.
MozReview-Commit-ID: DyfVJ49ksSd
--HG--
extra : rebase_source : e2ec3f78e04f87e8951fde4de0e0d3ceabfa57c3
Now that we are using sibling divs for all the cells of the table,
we don't have the same notion of what is a row.
The console table test is adapted to the new component.
MozReview-Commit-ID: HcfzTaRVIcN
--HG--
extra : rebase_source : fdf95ccb5abf8fc9ed362e03d72dae2f03245300
Since table elements (th, tr) do not support sticky headers, the console table now
uses only sibling divs for the cells, with appropriate aria attributes and a CSS grid
to mimic an actual table.
MozReview-Commit-ID: J8hmy7H4GKL
--HG--
extra : rebase_source : 220368d50a36707f7114a4c69580614b79b955e9
In bug 1306892, we started fetching stylesheets from the network monitor when
possible. However, this only worked for short strings (< 10000 bytes). For
long strings, we need to also look up the long string actor that holds the
actual text.
MozReview-Commit-ID: 2M0OAioZnX5
--HG--
rename : devtools/client/styleeditor/test/doc_uncached.css => devtools/client/styleeditor/test/doc_short_string.css
extra : rebase_source : e0babac9bc162222dc207e9fba3c88b3c22aabfa
Remove the use of `Immutable.is` in Toolbar, this method should
map directly to `Object.is`. The props being passed to `is` were
already plain JS objects from what I understand.
Yarn was used to remove the Immutable JS package and webpack was
configured to not include webpack from shared assets.
***
Removed Immutable reference in yarn.lock
***
Generated yarn.lock file
By running `yarn install`.
***
Remove debugging statements
* * *
Bug 1428745 - Remove support for version parameter from script loader - fixing a broken depending test - CLOSED TREE, r=me
* * *
Bug 1428745 - Remove support for version parameter from script loader - fixing WPTs - CLOSED TREE, r=me
* * *
Bug 1428745 - Remove support for version parameter from script loader - fixing tests - CLOSED TREE, r=me
If the toolbox is open when a stylesheet is loaded, the network monitor should
have recorded the response content. When a tool asks for stylesheet text, try
asking the network monitor first before falling back to an extra fetch as a last
resort.
MozReview-Commit-ID: E2pQ04ARfQo
--HG--
extra : rebase_source : b10fb44e313ece5757961ca81a3bc0f76753ed8e
This changes the code of the test since it was relying on direct access to the content page.
In order to be able to interact with the element picker, the test-actor and test-actor-registery
files are loaded by head.js.
MozReview-Commit-ID: FyebIiyF31j
--HG--
extra : rebase_source : 83d7304303edc8e8a54cbcc2cc535987b8368207
This allows subclasses to override the implementation,a nd avoids leaking ColorPicker
specific implementation details to the base class.
MozReview-Commit-ID: 6KHaFPd5xHt
--HG--
extra : rebase_source : d6bddd7d65d6c384b5a5c66d7b646110ca90c8c6
When exiting RDM with a device applied, we clear the UA override, but we did not
force a refresh of the page. This means that the customized UA was still
accessible via `navigator.userAgent` and the page might have a non-default
layout if it tests the UA value.
To ensure there's no chance of confusion after exiting RDM, force a reload if
clearing emulation values determines it is needed.
MozReview-Commit-ID: Fkji12Utmis
--HG--
extra : rebase_source : a7ae8851165fae7aec5875d10f51cbb703b3f870
The patch changes how log we wait before polling again in waitFor, since the timeout
is happening here.
MozReview-Commit-ID: 4ZteEmMBOZk
--HG--
extra : rebase_source : 44078fa03df8ce7650d71ac0ad401a30827f2d83
The test was refactored in Bug 1408932, but it wasn't actually enabled.
MozReview-Commit-ID: 85vI9iX5p2V
--HG--
extra : rebase_source : 03182ab24bd057ad0be9d2e3f3e884c346d53d98
The problem with this bug was that it did not correspond to animations that
have multiple keyframes with the same offset.
In summary graph, although we were changing the resolution for the graph
creation by the distance of offset between keyframes, as the calculation of
resolution between keyframes with equivalent offset was infinite, generation
was not completed and it was in a state of freezing.
In here, in case of zero distance of offsets, we make avoiding to affect to
changing the resolution.
In addition, the detail graph did not display correctly.
For example, there is an animation below.
div.animate(
[
{
offset: 0,
opacity: 1,
},
{
offset: 0.5,
opacity: 0.5,
},
{
offset: 0.5,
opacity: 0.1,
},
{
offset: 1,
opacity: 1,
},
],
1000
);
In this animation, opacity changes from 1 to 0.5 during 0 - 499ms, from 0.1 to 1
after 500ms.
So, opacity at offset 0.5 behaves 0.5 during 0 - 499ms, 0.1 after 500ms.
Since current animation inspector creates the graph with computed value of the
time of offset, the opacity of offset 0.5 always is 0.1 in the example,
was not correct.
As a solution, same to the actual animation work, create the graph between each
keyframes with range that from start keyframe offset time to just before the
time of end keyframe offset time.
Also, in same offsets, connects between just before the time of the offset time
and the offset time.
So, in the example, we separate as below, then calculate the each coordinates,
then combine as graph shape.
1: 0 ~ 499.999ms
2: 499.999 ~ 500ms (same offsets)
3: 500 ~ 999.999ms
4: 1000ms
MozReview-Commit-ID: p4Cn2N9iFt
--HG--
extra : rebase_source : 0f175fa0b7a3c882171e59a6e4a94bb4802e96d2
The test was refactored in Bug 1408932, but it wasn't actually enabled.
MozReview-Commit-ID: 85vI9iX5p2V
--HG--
extra : rebase_source : 928c85e00e1b690129345a03c4741f1d8175a2ad
The problem with this bug was that it did not correspond to animations that
have multiple keyframes with the same offset.
In summary graph, although we were changing the resolution for the graph
creation by the distance of offset between keyframes, as the calculation of
resolution between keyframes with equivalent offset was infinite, generation
was not completed and it was in a state of freezing.
In here, in case of zero distance of offsets, we make avoiding to affect to
changing the resolution.
In addition, the detail graph did not display correctly.
For example, there is an animation below.
div.animate(
[
{
offset: 0,
opacity: 1,
},
{
offset: 0.5,
opacity: 0.5,
},
{
offset: 0.5,
opacity: 0.1,
},
{
offset: 1,
opacity: 1,
},
],
1000
);
In this animation, opacity changes from 1 to 0.5 during 0 - 499ms, from 0.1 to 1
after 500ms.
So, opacity at offset 0.5 behaves 0.5 during 0 - 499ms, 0.1 after 500ms.
Since current animation inspector creates the graph with computed value of the
time of offset, the opacity of offset 0.5 always is 0.1 in the example,
was not correct.
As a solution, same to the actual animation work, create the graph between each
keyframes with range that from start keyframe offset time to just before the
time of end keyframe offset time.
Also, in same offsets, connects between just before the time of the offset time
and the offset time.
So, in the example, we separate as below, then calculate the each coordinates,
then combine as graph shape.
1: 0 ~ 499.999ms
2: 499.999 ~ 500ms (same offsets)
3: 500 ~ 999.999ms
4: 1000ms
MozReview-Commit-ID: p4Cn2N9iFt
--HG--
extra : rebase_source : e4a89ebfbb409dede26a4aaf4a45cdd2e3a31d16
Replace `loader.lazyGetter` pattern with normal variable assignment
MozReview-Commit-ID: I08f8hnQ0nN
--HG--
extra : rebase_source : 18d9108d1b49aad92f0c9a2223c2fff58e1dddb1
The test differs a bit from the old one since we are now testing that there is
a button to jump to definition.
MozReview-Commit-ID: DnC5uJ3pAea
--HG--
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug_1050691_click_function_to_source.html => devtools/client/webconsole/new-console-output/test/mochitest/test-click-function-to-source.html
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug_1050691_click_function_to_source.js => devtools/client/webconsole/new-console-output/test/mochitest/test-click-function-to-source.js
extra : rebase_source : e0700658c4a88b0e16ebf8e14102dacd52aec71f
- sort-statics-last is no longer meaningful now non-static (ie template) items don't exist
- we don't use the 'resource' attribute anywhere in XUL.
- sortResource/sortResource2 are unused.
- we don't have meaningful consumers for sortSeparators
MozReview-Commit-ID: C31vC9MCrDo
--HG--
extra : rebase_source : 539fd84201eaeead62ac73b3213bfdf6f4333e9a
In the 0.16.0 bundle, we removed most of the ObjectInspector CSS custom properties
because they were being slow. This means that some of the styles we overrided in the
console weren't overriden anymore.
This patch fixes that so we get to the same style we have prior to the new bundle.
MozReview-Commit-ID: JP35pkX6PHZ
--HG--
extra : rebase_source : 194c90856730348e6b7ce6f9bbff52d9ae6c8151
Replace `loader.lazyGetter` pattern with normal variable assignment
MozReview-Commit-ID: I08f8hnQ0nN
--HG--
extra : rebase_source : 591cf97d4777207e6b6964d28f66ce61795d77d2
The test differs a bit from the old one since we are now testing that there is
a button to jump to definition.
MozReview-Commit-ID: DnC5uJ3pAea
--HG--
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug_1050691_click_function_to_source.html => devtools/client/webconsole/new-console-output/test/mochitest/test-click-function-to-source.html
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug_1050691_click_function_to_source.js => devtools/client/webconsole/new-console-output/test/mochitest/test-click-function-to-source.js
extra : rebase_source : 343e6d3828bdacf54d02c79a9e9116837f3b00f1
Borrowed code from onTreePopupShowing into onTablePopupShowing
MozReview-Commit-ID: 1IotAfqwlpg
--HG--
extra : rebase_source : bd1bc0256ccfbcaf508b319167cab9c21be7dbf2
This patch adds a few console.count stubs and check
that they all render as expected.
MozReview-Commit-ID: IejxMKnLTAz
--HG--
extra : rebase_source : a9df8bd9eb1b78c6f05106c16d48dd31d16087f6
The test was failing because we have more than one
networkUpdate in the store.
As it's not the purpose of this test case to assert the
number of updates, let's just check that we have some,
and that they are removed after MESSAGES_CLEAR.
MozReview-Commit-ID: FgZv8epfP0q
--HG--
extra : rebase_source : 269f8654fa0f9f06c8ece5fe6415f82385553e85
The tests were failing because all the sidebarToggle actions
were renamed to sideBarClose, which made the tests inacurate.
MozReview-Commit-ID: LBkqTzNhaqV
--HG--
extra : rebase_source : 5943924d6fb073cb2375df275665de206aaf857b
Changed CSS to fix selected row style and removed underline for tree headers
MozReview-Commit-ID: hnmnATPSAw
***
Bug 1421491 - Style fixes in Netmonitor
Updated CSS Styles to fix issues mentioned in the bug
MozReview-Commit-ID: 7ElhjWmTEgM
***
Bug 1421491 - Minor style fixes in netmonitor
Updated CSS to fix style issues in the Bug
--HG--
extra : rebase_source : d0f01d6bd7133b07c66a767d899d93e363dae857
The filter bar was already positioned before the console output visually.
However, accessibility clients such as screen readers rely on the semantic order, not the visual order, for positioning of content.
This makes it easier for screen reader users to quickly get to the bottom of the console output, which is important for efficiency when reading recent output.
MozReview-Commit-ID: Ae8z6H1k9np
--HG--
extra : rebase_source : 9a5a6cd3db4b5398e6e0f2a648721849e7c0fb78
The `getCurrentMatrix` function is used by grid and other highlighters to
account for the element's position, transforms, etc. Here we extend it with
extra logic to account for the element's writing mode and text direction.
MozReview-Commit-ID: AZT4cJySLwk
--HG--
extra : rebase_source : 55504705fba929f6209ac8c76a000fd26cd8dd3e
Most of the Shadow DOM related code are behind "dom.webcomponents.enabled" and
this pref is only used by Shadow DOM right now, so we should rename it to
"dom.webcomponents.shadowdom.enabled"
MozReview-Commit-ID: er1c7AsSSW
If the netmonitor hasn't had `npm install` ran, then running the webconsole tests fail,
because the webconsole depends on netmonitor, and the babel plugin "transform-object-rest-spread"
defined in netmonitor/.babelrc cannot be resolved unless if it's been installed.
MozReview-Commit-ID: KyQgja5rRpg
--HG--
extra : rebase_source : 9a8487fccd7c8641f47dcc405be3c8324bf8474c
Tests copied directly from older versions and adapted for React 16.
React source downloaded from https://github.com/facebook/react/releases/tag/v16.2.0
MozReview-Commit-ID: 80zwHIK16Cz
--HG--
extra : rebase_source : 0329b8407e38cf5757281456c62ff42c3846d8b2
There was an exception thrown by the netProviderEnhancer because it
retrieves the networkMessageUpdate and access a property on it.
On non-network message, the networkMessageUpdate is undefined, and
accessing the property throws.
We fix this by simply checking if message is not falsy before accessing
the property.
A couple of tests were added to make sure we don't regress this case. This
required changing the setupStore helper a bit to pass a hud stub to the
createStore function (the net enhancer is called only if the hud has a proxy
object). This made some test fail because they weren't dispatching enough
argument to the networkMessageUpdate action.
MozReview-Commit-ID: 7h35ebHSdbF
--HG--
extra : rebase_source : 089dce93d1de60e4b44936b514627803aa2c5100
Message icons now get the aria-live="off" attribute.
This stops screen readers from automaticaly reading icon descriptions, which might be interesting to read later but make things inefficient when automatically reading new output.
MozReview-Commit-ID: BQOUnTRVkBE
--HG--
extra : rebase_source : 47f1df96910a92961fc739582ffb49956735fdb3
Commands entered by the user now get the aria-live="off" attribute.
This stops screen readers from echoing commands the user typed, which is redundant and inefficient.
MozReview-Commit-ID: GJXiBPMe0W5
--HG--
extra : rebase_source : 9fac3b14115a9f2f54bc8180bed6c0442e0da3f0
Replace `loader.lazyGetter` pattern with normal variable assignment
MozReview-Commit-ID: JJTXKgXRgBZ
--HG--
extra : rebase_source : 91e63d7515573a3c55756fd04811fe61515b3cf8
The test was failing because it still had pending request to the server while shutting
down the toolbox. This request was probably the one to retrieve the properties of the
object we put in the sidebar.
By waiting the object properties to be fully loaded when opening the sidebar, we should
make the intermittent go away.
MozReview-Commit-ID: 7tY8hvbDVRp
--HG--
extra : rebase_source : cc5479f21c91df1fc0967900fb1022e3ec6dff3d