Paths for pushing files to Android devices were being constructed with
`PathBuf::push`, which uses the system file separator. On Windows, this results
in malformed paths like
`/data/local/tmp\org.mozilla.geckoview_example-geckoview-config.yml`.
Differential Revision: https://phabricator.services.mozilla.com/D60738
--HG--
extra : moz-landing-system : lando
This patch was generated with a script. It doesn't include all files:
- Files that use the preprocessor or fail to parse are skipped
- Files that are loaded as JSMs but don't use the .jsm extension are skipped (those will be renamed in Bug 1609269)
It was generated with the following command using d855222aa2/no-this-property-read.js:
```
hg revert --all &&
cp .gitignore .rgignore &&
rg --files-without-match -g '*.jsm' '^#endif|^#include|^#filter' | jscodeshift --stdin --transform ~/Code/jsm-rewrites/no-this-property-read.js --ignore-pattern ./mobile/android/modules/Sanitizer.jsm --ignore-pattern ./js/xpconnect/tests/unit/syntax_error.jsm &&
./mach eslint `hg st | rg '^M ' | sed 's/^M //'`
```
Differential Revision: https://phabricator.services.mozilla.com/D60187
--HG--
extra : moz-landing-system : lando
The patch ensures we don't pass a nsIWebNavigation load flag to
nsIDocShell.defaultLoadFlags which is supposed to get nsLoadFlags (nsIRequest).
Differential Revision: https://phabricator.services.mozilla.com/D61168
--HG--
extra : moz-landing-system : lando
There is nothing clipping related in there anymore.
Differential Revision: https://phabricator.services.mozilla.com/D61178
--HG--
rename : gfx/wr/webrender/src/clip_scroll_tree.rs => gfx/wr/webrender/src/spatial_tree.rs
extra : moz-landing-system : lando
The ghost window checker examines windows in all sorts of weird states,
apparently including when the docshell on the outer is null. Add some
fallible variants of the tab group methods on inner and outer windows
so it can call one of those instead.
Differential Revision: https://phabricator.services.mozilla.com/D61203
--HG--
extra : moz-landing-system : lando
Sometimes `newTab` will get install notification first. But popup will not be
shown until newTab becmoes active in that case. Observes
"webextension-permission-prompt" to catch this.
Differential Revision: https://phabricator.services.mozilla.com/D59847
--HG--
extra : moz-landing-system : lando
I originally had this as a few patches, but the work to fix test
failures and get the whole thing into a complete working state
quickly tangled them up. Apologies for that. To summarize what's
going on here, however:
- We introduce two prefs: shutdown.fastShutdownStage and
shutdown.lateWriteChecksStage. The latter pref is set to 1, which
will leave the existing late write checking behavior unchanged.
However, we introduce this pref to make it simpler in the future
to bump the late write checks window earlier in the shutdown cycle.
- We introduce an AppShutdown class, which will house static methods
and a small amount of state for unifying some shutdown logic. Most
importantly, it will now manage the state for app initiated restarts,
as well as the logic for performing a safe fast shutdown.
- We refactored the existing restart code to call into the new
AppShutdown file, so that if we are configured to actually perform
a fast shutdown, we will be able to run the necessary restart logic
immediately before doing so. Previously, the restart logic occurred
later in the shutdown cycle than our late write checking, meaning
if we were to simply exit the process at that point in time, we
would never run the restart coe.
- Lastly, we updated two locations which called TerminateProcess and/or
_exit(0) to call into the AppShutdown method (DoFastShutdown).
Differential Revision: https://phabricator.services.mozilla.com/D59196
--HG--
extra : moz-landing-system : lando
Changes:
Since the image `debian10-test` is not being used to run unittests on CI, a lot of the dependencies installed can be removed.
Differential Revision: https://phabricator.services.mozilla.com/D60945
--HG--
extra : moz-landing-system : lando
The list of crash dumps in the dump directory appears as something like `['uuid.dmp, uuid-browser.dmp']`. When iterating over the list of files, the files are always sorted alphabetically, meaning any `uuid-<something>.dmp` goes before `uuid.dmp`. We only really care that `uuid.dmp` comes first, as the rest are just additional data not necessarily related to the crashing process, so iterating the list in reverse should put the right .dmp file first.
Differential Revision: https://phabricator.services.mozilla.com/D61166
--HG--
extra : moz-landing-system : lando
Restricted to Nightly so we can enable it by default in tandem with enabling
the same option in NumberFormat and DateTimeFormat.
Differential Revision: https://phabricator.services.mozilla.com/D60959
--HG--
extra : moz-landing-system : lando
`DragEvent::GetRangeParentContentAndOffset()` may return `nullptr`. Previously,
it was checked and returned `NS_ERROR_FAILURE` before landing bug 1610264.
This patch adds the null check which was accidentally removed.
Differential Revision: https://phabricator.services.mozilla.com/D61208
--HG--
extra : moz-landing-system : lando
In particular this avoids unqualified name lookup ambiguity between
::Request and mozilla::dom::Request (imported into the global namespace by
using namespace mozilla::dom).
Differential Revision: https://phabricator.services.mozilla.com/D61212
--HG--
extra : moz-landing-system : lando
ServiceWorkerShutdownState encapsulates the shutdown progress for a particular
ServiceWorker. The shutdown process involves a "shutdown message" passing
multiple threads in both parent/content processes; we report a progress update
when it's known that a shutdown message has reached a particular thread. The
idea is that in the event of a shutdown timeout, ServiceWorkerShutdownBlocker
will be able to provide diagnostics for where shutdown processes are stalled.
Differential Revision: https://phabricator.services.mozilla.com/D60791
--HG--
extra : moz-landing-system : lando
At shutdown, the stream transport service is not available and `free(aPtr)` happens synchronously. These warnings will always trigger and produce a lot of logspam.
Differential Revision: https://phabricator.services.mozilla.com/D61217
--HG--
extra : moz-landing-system : lando
The test suffers from a race condition, and shows frequest intermittent
failures. There already is is WPT test testing the same in
/testing/web-platform/tests/webmessaging/broadcastchannel/workers.html
test case 'BroadcastChannel works in workers', which does not seem
to suffer from this problem.
Differential Revision: https://phabricator.services.mozilla.com/D61103
--HG--
extra : moz-landing-system : lando
This patch mainly enables the pref for SharedArrayBuffer on early Beta. (We have
already enabled that on Nightly by default)
This change causes some tests to fail. This patch handles the failures for
a mochitest and web-platform-tests.
Differential Revision: https://phabricator.services.mozilla.com/D60965
--HG--
extra : moz-landing-system : lando
The proposal specifies class fields as follows:
FieldDefinition[Yield, Await]:
ClassElementName[?Yield, ?Await] Initializer[In, ~Yield, ~Await]opt
This means that await shouldn't be parsed according to the context
where the class is defined: it should always be parsed as an
identifier inside initializers.
Differential Revision: https://phabricator.services.mozilla.com/D58721
--HG--
extra : moz-landing-system : lando
musl libc defines these to pread and pwrite respectively, since its
off_t is always 64-bit. This causes unintended macro replacement
when defining the pread64/pwrite64 wrappers.
To prevent this, save the macro definitions at the start of the
header and restore them at the end. This is what is already done
to work around the same issue on Android NDK.
This is a cherry-pick of the following upstream change:
https://chromium.googlesource.com/linux-syscall-support/+/f70e2f1641e280e777edfdad7f73a2cfa38139c7%5E%21/
This change was also applied to google-breakpad here:
647158232b%5E%21/
Differential Revision: https://phabricator.services.mozilla.com/D61205
--HG--
extra : moz-landing-system : lando
The test suffers from a race condition, and shows frequest intermittent
failures. There already is is WPT test testing the same in
/testing/web-platform/tests/webmessaging/broadcastchannel/workers.html
test case 'BroadcastChannel works in workers', which does not seem
to suffer from this problem.
Differential Revision: https://phabricator.services.mozilla.com/D61103
--HG--
extra : moz-landing-system : lando
Some CI systems are very slow, so end up skipping short animations and
not firing iteration events for them. This commit changes
webkit-animation-iteration-event.html to have a very long iteration
duration, but uses a negative delay to position the start point right
before the end of the first iteration.
This is a cherry-pick of
fdc1a89a01
and was reviewed upstream.
Differential Revision: https://phabricator.services.mozilla.com/D61209
--HG--
extra : moz-landing-system : lando
Custom keyboard layout may set unusual character to each numpad key. In our
shortcut and acceleration key handling, we refer alternative char code values
stored in `eKeyDown` or `eKeyPress` and they may contain an alphabet which is
used by menubar but it shouldn't be performed while user inputs a Unicode
character with `Alt` + numpad keys because it's being handled by Windows.
(In strictly speaking, I think that we shouldn't dispatch key events of the
sequence, but Chrome does it so that we should keep dispatching for web-compat.)
This patch makes `NativeKey` stores same `mCommittedCharsAndModifiers`,
`mShiftedString` and `mUnshiftedString` values as usual keyboard layout
even active keyboard layout customized numpad key values.
Note that Windows handles the key sequence without virtual key code, meaning
that even if the numpad keys are shuffled by keyboard layout, typed numbers
are computed from physical key position. E.g., even if `Numpad7` is mapped
to `1`, it's treated as `7`. Therefore, this patch refers scan code in
some places.
Differential Revision: https://phabricator.services.mozilla.com/D60805
--HG--
extra : moz-landing-system : lando
LayoutFrameType::NumberControl is unused, and nsNumberControlFrame inherits now
from nsTextControlFrame. There are three places that check for
LayoutFrameType::TextInput. Two direct ones:
* ShouldApplyOverflowCLipping
* nsFontInflationData
And one indirect via IsTextInputFrame, the one mentioned in comment 2. For all
those three, it makes sense for nsNumberControlFrame to be handled in the same
way as nsTextControlFrame.
Long term we may want to get rid of the concept of frame types and just use
queryFrame or some sugar of that sort, as it's error prone. But for now this
fixes the bug.
Differential Revision: https://phabricator.services.mozilla.com/D61088
--HG--
extra : moz-landing-system : lando
Initializing OSCrypto can lead to a useless macOS Keychain prompt when there are no logins to import.
Differential Revision: https://phabricator.services.mozilla.com/D46616
--HG--
rename : browser/components/migration/tests/unit/AppData/Local/Google/Chrome/User Data/Default/Login Data => browser/components/migration/tests/unit/AppData/LocalWithNoData/Google/Chrome/User Data/Default/Login Data
rename : browser/components/migration/tests/unit/Library/Application Support/Google/Chrome/Default/Login Data => browser/components/migration/tests/unit/LibraryWithNoData/Application Support/Google/Chrome/Default/Login Data
rename : browser/components/migration/tests/unit/Library/Application Support/Google/Chrome/Local State => browser/components/migration/tests/unit/LibraryWithNoData/Application Support/Google/Chrome/Local State
rename : browser/components/migration/tests/unit/test_Chrome_passwords.js => browser/components/migration/tests/unit/test_Chrome_passwords_emptySource.js
extra : moz-landing-system : lando
