The information in it is always derivable from the values of mRepeatAutoStart
and mRepeatAutoEnd. Additionally, its value is used in some cases where it has
not yet been set properly (such as CalculateRepeatFillCount).
This works out currently because the default value is zero we only accept
repeat(auto-fill, ...) and repeat(auto-fit, ...) CSS values that have a single
element in the repeat. In that case, zero is the correct value for
RepeatEndDelta.
Differential Revision: https://phabricator.services.mozilla.com/D58871
--HG--
extra : moz-landing-system : lando
We should not attempt to shut down threads which we did not explicitly
remove from the image decode thread pool, when we want to shut down an
idle thread or otherwise. This behaviour would put us at risk of
shutting down a thread twice, which may trip assertions and/or cause
other issues. Now we assuming that any thread that is already removed
from the pool array has already been gracefully shutdown.
Differential Revision: https://phabricator.services.mozilla.com/D58827
--HG--
extra : moz-landing-system : lando
Styled the Outline pane filter to be consistent with the Event Breakpoint filter
Differential Revision: https://phabricator.services.mozilla.com/D50977
--HG--
extra : moz-landing-system : lando
This switches over one usage of `nsAutoPtr` that was just used to scope an allocation, a stack variable is used instead. The shutdown contexts array is switched over to hold `UniquePtr`s which required adding a helper to find elements in the array as `UniquePtr` does not auto-convert to its pointer type.
Differential Revision: https://phabricator.services.mozilla.com/D58317
--HG--
extra : moz-landing-system : lando
This converts straightforward `nsAutoPtr` usage over to `UniquePtr`.
`nsClassHashtable` is left alone for now as that will have a larger impact.
`nsThread` is left alone for now as it has non-trivial ownership concepts.
Differential Revision: https://phabricator.services.mozilla.com/D58284
--HG--
extra : moz-landing-system : lando
This removes various unused `#include "nsAutoPtr.h"` in `xpcom/`. Additionally
adds a few includes to the media stack.
Differential Revision: https://phabricator.services.mozilla.com/D58282
--HG--
extra : moz-landing-system : lando
It was being set to null before we tried to remove it, which left a dead
controller registered and consuming commands after a frameloader rebuild.
Differential Revision: https://phabricator.services.mozilla.com/D57556
--HG--
extra : moz-landing-system : lando
Changes:
For webrenderer tests, the scrollbar causes failures in the expected pixel difference values. Adjust the expectations of multiple tests that are affected.
Differential Revision: https://phabricator.services.mozilla.com/D58869
--HG--
extra : moz-landing-system : lando
Changes:
`gtkWidget&&webrender` has a slightly different pixel difference count (1496 vs 1498), so a second condition is added to cover this case.
The annotation is permissive but will be tightened once reftest is run with ubuntu1804.
Differential Revision: https://phabricator.services.mozilla.com/D58862
--HG--
extra : moz-landing-system : lando
Changes:
Remove the fail-if annotation for gtkWidget since the test passes in ubuntu1804.
This patch will need to land with D58816.
Differential Revision: https://phabricator.services.mozilla.com/D54851
--HG--
extra : moz-landing-system : lando
Gives a site specific browser window a custom model ID and adds the same model
ID to its shortcut. This makes the window appear distinct from the rest of
Firefox's windows in the taskbar and allows for pinning the new entry to the
taskbar.
Differential Revision: https://phabricator.services.mozilla.com/D56780
--HG--
extra : moz-landing-system : lando
Once we start supporting different model IDs for different windows of the same
application we need to make sure that the normal windows have a model ID and
the jump lists and recent documents are tagged with the same ID. We do this by
always having an app default model ID, when no window specific model ID is set
the app default is used.
At some point we may want to extend the jump list stuff to support using a
different model ID but that isn't needed right now.
Differential Revision: https://phabricator.services.mozilla.com/D57152
--HG--
extra : moz-landing-system : lando
This commit does two things:
- It exposes the error that caused the test to fail in our logs, so it would
appear like so:
```
TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.ExtensionActionTest.setIconSvg[#pageAction] | java.lang.AssertionError: We shouldn't get here
```
- It catches exceptions that are raised before any test code is run and outputs
a different message (since those failures do not depend on the test at all),
like so:
```
ERROR runjunit.py | The previous test failed because of an error in the test harness | org.mozilla.geckoview.test.rule.TestHarnessException: java.lang.RuntimeException: We shouldn't get here
```
This will hopefully help with spurious intermittents and understand when a
failure changes.
Differential Revision: https://phabricator.services.mozilla.com/D58022
--HG--
extra : moz-landing-system : lando
Changes:
This test is failing again permanently for ubuntu1804, not sure what changed. I won't change the annotation after this patch unless the author or someone from the team chimes in.
Differential Revision: https://phabricator.services.mozilla.com/D58839
--HG--
extra : moz-landing-system : lando
When EGL_LOSE_CONTEXT_ON_RESET is set by CreateContextFlags::PREFER_ROBUSTNESS flag, ANGLE avoids to release D3D resources when ANGLE detects device reset. It is necessary to avoid nullptr dereference in ANGLE.
Differential Revision: https://phabricator.services.mozilla.com/D58348
--HG--
extra : moz-landing-system : lando
Move the parser's calls to setFunName to before generating the actual script
for the function. This allows code-coverage to save the correct initial
function names when they are inferred. Off-thread parsing defers computing
the coverage metadata so it already has the right result.
Differential Revision: https://phabricator.services.mozilla.com/D58669
--HG--
extra : moz-landing-system : lando
