Gotta love C++... I missed the `break;` for that branch so we were always
falling back to the solid border rendering path (which we use if the border is
too small).
Differential Revision: https://phabricator.services.mozilla.com/D16977
--HG--
extra : moz-landing-system : lando
This commit adds categories to all markers. This way the profiler's
marker categories and frame label categories agree. There are a few
duplicate category properties on some of the marker payloads, but
this could be cleaned up in a follow-up if needed.
Differential Revision: https://phabricator.services.mozilla.com/D16864
--HG--
extra : moz-landing-system : lando
Not the prettiest, but it will work, and LengthPercentage will be 12 bytes which is pretty good (we could do better if wanted I guess):
* Au(i32) length;
* f32 percentage;
* AllowedNumericType(u8) clamping_mode;
* bool has_percentage;
* bool was_calc;
This will allow me to start moving C++ stuff to use this representation.
Differential Revision: https://phabricator.services.mozilla.com/D16929
--HG--
extra : moz-landing-system : lando
The restriction preventing fullscreen windows from being dragged is removed.
Differential Revision: https://phabricator.services.mozilla.com/D15075
--HG--
extra : moz-landing-system : lando
It looks like we can do initialization and destruction from the UI
thread before the bits that run on the Compositor thread have run. Avoid
this by synchronously waiting on the Compositor.
Differential Revision: https://phabricator.services.mozilla.com/D16596
--HG--
extra : moz-landing-system : lando
On CI we only want to log screenshots when something unexpected happens since anything
else is rather wasteful of resources. But locally getting screenshots for expected
failures seems helpful for debugging, so worth making the default. Hopefully this isn't
too confusing for people just checking if their patch regresses anything rather than
actively working on fixing failures.
Depends on D16973
Differential Revision: https://phabricator.services.mozilla.com/D16974
--HG--
extra : moz-landing-system : lando
When the logging setup moved to earlier in the setup we ended up setting the
option to enable tbpl-style screenshots from mach after the loggers were already
initalised. Move this to earlier in the command so this option starts working again.
Differential Revision: https://phabricator.services.mozilla.com/D16973
--HG--
extra : moz-landing-system : lando
Looking at the logs and the screenshots, it seems that the test fails
because the debugger is not paused anymore when evluating the await
expression, meaning that `foo` is undefined.
Here we try to wait for a small bit to give more time for the server
to evaluate before resuming.
Differential Revision: https://phabricator.services.mozilla.com/D16554
--HG--
extra : moz-landing-system : lando
The Learn More link navigates the user to an MDN page
explaining why we don't automatically invoke getters
on behalf of the user.
The link is opened either by clicking on it, or by
pressing the "?" key.
A test is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D16545
--HG--
extra : moz-landing-system : lando
Instead of focusing the input when a paste event is fired
on the scroller (which does not work on Firefox), we
dispatch the `paste` event from the scroller to the textarea.
We take this as an opportunity to update the package.json (we
probably don't need babel here, and we can update to latest
webpack).
Differential Revision: https://phabricator.services.mozilla.com/D16792
--HG--
extra : moz-landing-system : lando
This will allow me to (in different patches):
* Make the default style structs constructible without a pres context (default
color and co. would need to be faked or moved to Document as well, but that's
ok, since those cannot affect media queries, the default font-size does).
* Remove the nsPresContext pointer from ComputedStyle (moving it to nsFrame,
probably).
That would in turn allow me to have the default style computed without a pres
context, which allows us to fix both bug 1490401 and bug 1471231.
Differential Revision: https://phabricator.services.mozilla.com/D16926
--HG--
extra : moz-landing-system : lando
If the user selected some text in the console input
and opens the reverse search UI, we populate the
reverse search input with the selected text and do
a reverse search with this text.
A test is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D16843
--HG--
extra : moz-landing-system : lando
This patch enables the WebExtensions "browser.storage.local" IndexedDB backend
on non-Nightly channels.
Differential Revision: https://phabricator.services.mozilla.com/D16717
--HG--
extra : moz-landing-system : lando
This patch removes "Inspect Element" menu item from content context menu in
case that about:devtools-toolbox are opening.
However, we may be able to remove after fixing 1515265.
Depends on D16684
Differential Revision: https://phabricator.services.mozilla.com/D16685
--HG--
extra : moz-landing-system : lando
This implements the correct display of search matches, except for the fact that the "Search with" text should not be shown by default only on hover.
The actual selection of the result should work the same as for the quantum bar, and have the same telemetry hooked up.
Depends on D16617
Differential Revision: https://phabricator.services.mozilla.com/D16697
--HG--
extra : moz-landing-system : lando
GitLab's comment calls scrollTop on input event handler. The scollTop may cause
reflow. When causing reflow, editor is destroyed and initialized again. Then
nsTextEditorState will set current value to editor. But this is failure.
By bug 1465702, selection is cached in edit action. When initializing editor,
selection controller is updated, so selection into cache becomes invalid. It
means that all selection methods will return error since document is different.
So we should update selection cache when initializing editor.
Also, I cannot create test case for this situation since we have to cause reflow
in input and/or composition event. Do you have any idea?
Differential Revision: https://phabricator.services.mozilla.com/D16944
--HG--
extra : moz-landing-system : lando
