Commit Graph

854661 Commits

Author SHA1 Message Date
ganna
912571dec7 Bug 1849192 - Replace hbox.panel-footer with moz-button-group in popupnotification r=hjones,desktop-theme-reviewers,dao,reusable-components-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D183231
2023-09-07 17:47:57 +00:00
Cristina Horotan
963c8ec383 Backed out 2 changesets (bug 1851777, bug 1851775) for causing multiple failures on CLOSED TREE
Backed out changeset dd328595264f (bug 1851777)
Backed out changeset d14be9a2baa6 (bug 1851775)
2023-09-07 21:43:08 +03:00
Perry McManis
8707af158b Bug 1849779 - Send an event when a user clicks the fakespot quality explainer url r=Gijs,TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D186672
2023-09-07 17:17:28 +00:00
Julien Cristau
49d78591ae Bug 1852100 - fix release-partner-repack-chunking-dummy tasks after from_deps conversion. r=ahal,releng-reviewers,bhearsum DONTBUILD
Both the from_deps and release_deps transforms were adding the same task
as a dependency but under different keys.  We don't actually need
release_deps for anything else here as far as I can tell, so skip it.

Differential Revision: https://phabricator.services.mozilla.com/D187691
2023-09-07 17:15:42 +00:00
Adam Brouwers-Harries
f2287f3ca8 Bug 1421651 - Integrate animation triggered restyle counter into tests r=emilio
This commits integrates the new animation triggered restyle counter into the existing tests to ensure that the counter matches the expected marker count.

Depends on D186714

Differential Revision: https://phabricator.services.mozilla.com/D186715
2023-09-07 16:59:55 +00:00
Emilio Cobos Álvarez
0cfa3eed35 Bug 1851465 - Remove dead code in message_pump_glib. r=nika,ipc-reviewers
This was added for plugins in bug 544882 and has been dead code for a
while.

Differential Revision: https://phabricator.services.mozilla.com/D187381
2023-09-07 16:59:30 +00:00
Dão Gottwald
65565a6d2a Bug 1852033 - Make wrap a standard boolean attribute. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D187671
2023-09-07 16:56:32 +00:00
Gijs Kruitbosch
2c489adb25 Bug 1851840 - add a border to the shopping sidebar everywhere, r=desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D187687
2023-09-07 16:37:35 +00:00
serge-sans-paille
b695c06adf Bug 1850948 - Use std::string::data() as strtok param in GetMemoryMappings, avoiding a buffer copy in the process r=emilio
This is both beneficial for the actual code and an enhancement wrt.
-ftrivial-auto-var-init as it gets rid of a usage of nsAutoCString.

Differential Revision: https://phabricator.services.mozilla.com/D187198
2023-09-07 16:36:38 +00:00
negin
afc42aa17c Bug 1850801 - The onboarding Shopping sidebar is not easily discoverable with a screen reader r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D187294
2023-09-07 16:18:32 +00:00
andrej
1f4fea0034 Bug 1850665 - Alter location URL and request headers to not be blocked when requesting location queue. r=perftest-reviewers,kshampur
A week ago we got a permafail when requesting to know the location queue for certain data centres for webpagetest
I investigated and found the request was being blocked by cloudflare for some security reasons
Modifying the request URL and modifying headers resolved the issue

Differential Revision: https://phabricator.services.mozilla.com/D187497
2023-09-07 16:12:48 +00:00
Johannes J. Schmidt
6ca58e70d8 Bug 1777035 - re-enable test_autocomplete_password_generation_confirm.html on linux - r=credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D183870
2023-09-07 16:04:21 +00:00
Johannes J. Schmidt
fb9438d74c Bug 1777035 - check all other password fields to be masked - r=credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D183869
2023-09-07 16:04:21 +00:00
Johannes J. Schmidt
0e4ebef4c9 Bug 1777035 - test in between password field - r=credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D183866
2023-09-07 16:04:21 +00:00
Johannes J. Schmidt
e9cbc9a22f Bug 1777035 - flatten function calls - r=credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D183795
2023-09-07 16:04:21 +00:00
Johannes J. Schmidt
4fcb7d6b20 Bug 1777035 - fix intermittent test_autocomplete_password_generation_confirm.html - r=credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D183772
2023-09-07 16:04:21 +00:00
Emily McMinn
efb742617d Bug 1849365 - Apply active styles to about:welcome secondary buttons r=desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D187594
2023-09-07 16:02:59 +00:00
Yifan Zhu
b6643828b5 Bug 148624 - only show tooltip when document has focus. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D187418
2023-09-07 15:55:38 +00:00
Butkovits Atila
ef58dad0ea Backed out changeset fb19de542f01 (bug 1320607) for causing python failures complaining about test_devtools_database_parsing . CLOSED TREE 2023-09-07 18:58:05 +03:00
Ben Hearsum
2a59fdc445 Bug 1850045: replace command-context with task-context r=taskgraph-reviewers,releng-reviewers,gabriel
Most of this patch is ripping `command-context` out from Gecko. The other parts are the fairly straightforward conversions from `command-context` to `task-context`.

Differential Revision: https://phabricator.services.mozilla.com/D186822
2023-09-07 15:42:09 +00:00
Ben Hearsum
4cbb9f1ad0 Bug 1850045: fix bustage introduced by taskgraph 6.2.1 update r=ahal,taskgraph-reviewers,releng-reviewers
This is only sortof a new issue - it's come up because we longer allow `group_by` functions to be overridden, and the taskgraph version of the `single` group doesn't handle the `only-for` blocks that we use all over the place.

This patch provides a quick fix -- renaming the Gecko `single` group-by to `single-with-filters`, and using that in most places. (There were a couple of places that switching to `with-attributes` was simple enough - but in many cases we cannot yet replicate this functionality with `from-deps` alone AFAIK.)

Differential Revision: https://phabricator.services.mozilla.com/D186821
2023-09-07 15:42:09 +00:00
Ben Hearsum
6ff7df4e0e Bug 1850045: Upgrade vendored taskgraph module to 6.2.1 r=taskgraph-reviewers,mach-reviewers,gabriel,ahal
Differential Revision: https://phabricator.services.mozilla.com/D186820
2023-09-07 15:42:09 +00:00
Geoff Brown
8f7c8e399d Bug 1851715 - Use subprocess in mozbuild unit test r=hneiva
Differential Revision: https://phabricator.services.mozilla.com/D187562
2023-09-07 15:34:43 +00:00
Ryan Hunt
b3b912f859 Bug 1851468 - wasm: Set ContextOptions defaults to help consumers that don't read preferences. r=yury
WorkletThread does not read from preferences to initialize JS::ContextOptions
and relies on the default values it has. This lead to a regression from
bug 1832378 where certain wasm features had their field's default change.
This didn't affect other globals because we read preferences from those
and so the default value is ignored.

This commit fixes the default value for wasm features in JS::ContextOptions
as a temporary fix, and adds a quick test in worklets.

Ideally worklets will read from preferences for consistency and to allow
us to force enable/disable features. But that's a bigger change.

Differential Revision: https://phabricator.services.mozilla.com/D187583
2023-09-07 15:30:57 +00:00
Geoff Brown
f94a0c60d5 Bug 1850789 - Use subprocess to launch mochitest ssl server r=hneiva
Differential Revision: https://phabricator.services.mozilla.com/D187143
2023-09-07 15:13:07 +00:00
Jared Hirsch
65716884ce Bug 1837696 - Expose shopping strings to localization r=shopping-reviewers,fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D186574
2023-09-07 14:37:46 +00:00
Andrew Halberstadt
fd2a365b88 Bug 1850536 - [ci] Enable mochitest-webgl1-core with Wayland, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D187304
2023-09-07 14:27:03 +00:00
Andrew Halberstadt
c95759f9cc Bug 1850536 - Triage mochitest-webgl1-core tests, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D187303
2023-09-07 14:27:03 +00:00
Andrew Halberstadt
040ecaaf84 Bug 1850536 - [ci] Enable mochitest-webgl{1,2}-ext suites with Wayland, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D187135
2023-09-07 14:27:02 +00:00
Andrew Halberstadt
5a4d8fdb9e Bug 1850536 - Mark some tests mochitest-webgl tests as passing with Wayland, r=jmaher,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D187134
2023-09-07 14:27:02 +00:00
Emilio Cobos Álvarez
f0b07713f6 Bug 1843044 - Make the default theme work with dark color schemes. r=dao,pbz
This builds on the light-dark() function added in bug 1845679 to provide
custom colors for both the default light and dark themes, and remove the
"default theme in dark mode" bits.

This is all to be landed after the soft-freeze in any case. Untested on
macOS for now, but no reason it shouldn't work. Will test later today.

On the light theme we were relying on Field / FieldText being black /
white for toolbar-field-focus, so make that explicit too:

  InspectorUtils.colorToRGBA("Field", document) // Object { a: 1, b: 255, g: 255, r: 255 }
  InspectorUtils.colorToRGBA("FieldText", document) // Object { a: 1, b: 0, g: 0, r: 0 }.

Differential Revision: https://phabricator.services.mozilla.com/D184708
2023-09-07 14:22:21 +00:00
Joel Maher
22e0817cab Bug 1850575 - fix env var type from int to string. r=aryx,taskgraph-reviewers,releng-reviewers,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D187502
2023-09-07 14:00:28 +00:00
Jared Hirsch
0f2b94ad33 Bug 1847307 - Insert final shopping copy r=shopping-reviewers,fluent-reviewers,desktop-theme-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D186540
2023-09-07 13:57:39 +00:00
Perry McManis
661de760db Bug 1849244 - Send an event when a user clicks to analyze reviews when no Review Reliability is Available.r=TravisLong,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D186707
2023-09-07 13:51:27 +00:00
Dale Harvey
3bd515f621 Bug 1806090 - Split up quickactions screenshot tests. r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D187598
2023-09-07 13:43:48 +00:00
Emilio Cobos Álvarez
95c77f8243 Bug 1851502 - Remove useless calls to NotifyThemeChanged. r=stransky
Font DPI is explicitly observed here already, and it's the only thing
that affects system font sizes:

  https://searchfox.org/mozilla-central/rev/8a1e1397c48c7419533dec707fd86dc2d8bf6bf9/widget/gtk/nsLookAndFeel.cpp#140

I found these because we get an extra notification here, which can slow
down our startup time on Wayland:

  https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6375

I'll see if there's a reasonable way to work around it, because the
event is posted async so it doesn't seem trivial to distinguish the fake
event from an actually useful change...

Differential Revision: https://phabricator.services.mozilla.com/D187390
2023-09-07 13:26:40 +00:00
Emilio Cobos Álvarez
993da03774 Bug 1851777 - Minor clean-ups to transparency handling in nsWindowGfx. r=win-reviewers,mhowell
Depends on D187534

Differential Revision: https://phabricator.services.mozilla.com/D187535
2023-09-07 13:26:08 +00:00
Emilio Cobos Álvarez
f7fc01c0a8 Bug 1851775 - Make sure calls to BeginPaint/EndPaint are balanced. r=rkraesig
As mentioned in previous review comments, there were various error cases
which could end up with unbalanced calls.

Differential Revision: https://phabricator.services.mozilla.com/D187534
2023-09-07 13:26:07 +00:00
Gabriele Svelto
e09be9657c Bug 1852031 - Remove unused crash annotations from bug 1821972 r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D187670
2023-09-07 13:13:05 +00:00
Alexandre Poirot
622b937669 Bug 1320607 - [devtools] Remove the generated CSS Properties database. r=devtools-reviewers,nchevobbe
This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.

Differential Revision: https://phabricator.services.mozilla.com/D187492
2023-09-07 13:08:37 +00:00
Norisz Fay
2ce1ba4497 Backed out 2 changesets (bug 1849972) as requested by whimboo CLOSED TREE
Backed out changeset d8ac28803dd6 (bug 1849972)
Backed out changeset 57929c2e184a (bug 1849972)
2023-09-07 16:39:36 +03:00
Yury Delendik
fd29b97c09 Bug 1851568 - Improve validation of tail call result types. r=bvisness
Differential Revision: https://phabricator.services.mozilla.com/D187501
2023-09-07 12:29:34 +00:00
Jan de Mooij
e3cea5c34e Bug 1851872 part 2 - Use weak GetterSetter pointer for GuardHasGetterSetter. r=iain
Differential Revision: https://phabricator.services.mozilla.com/D187580
2023-09-07 12:29:08 +00:00
Jan de Mooij
58cf76e4be Bug 1851872 part 1 - Use weak BaseScript pointer for GuardFunctionScript. r=iain
This just follows the `WeakShape` and `WeakObject` field types.

Differential Revision: https://phabricator.services.mozilla.com/D187579
2023-09-07 12:29:08 +00:00
Tim Huang
0911e83551 Bug 1841104 - Update the string copy of the fingerprinters in the ETP strict section in about:preferences#privacy page. r=pbz,fluent-reviewers,settings-reviewers,flod
Depends on D187383

Differential Revision: https://phabricator.services.mozilla.com/D187384
2023-09-07 12:11:18 +00:00
Tim Huang
04ee22eb32 Bug 1841104 - Add fingerprinting protection to ETP Strict. r=pbz,settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D187383
2023-09-07 12:11:18 +00:00
ffxbld
4a0d68ade5 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - r=release-managers,dmeehan
Differential Revision: https://phabricator.services.mozilla.com/D187661
2023-09-07 12:04:47 +00:00
Emilio Cobos Álvarez
52d097c513 Bug 1851868 - Refactor nsIFrame::Destroy to pass a single DestroyContext parameter. r=dholbert
This shouldn't change behavior, but it packs the two arguments to
DestroyFrom into a single thing, and makes nsIFrame::Destroy not so easy
to call without a previous context.

This is a prerequisite to pass aDestroyContext to various things that
right now just mint one, which can cause badness, see bug 1851787 and
related bugs.

It's also a bit nicer to add things there if we need to in the future.

Differential Revision: https://phabricator.services.mozilla.com/D187578
2023-09-07 11:46:30 +00:00
Emilio Cobos Álvarez
f17a0754ab Bug 1812488 - Drive-by clean-ups. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D187664
2023-09-07 11:16:47 +00:00
Mike Kaply
8b1a6e539b Bug 1850385 - Handle cases where sync "worked" but we have no devices. r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D186957
2023-09-07 10:44:01 +00:00