Refactors the actions and assertions around page navigation
to be more declarative within the Translations test suite.
Depends on D187080
Differential Revision: https://phabricator.services.mozilla.com/D186908
Refactors clicking the change-source-language button to
be more declarative within the Translations test suite.
Depends on D186907
Differential Revision: https://phabricator.services.mozilla.com/D187080
Refactors clicking the dmismiss-error button to be more
delcarative within the Translations test suite.
Depends on D186905
Differential Revision: https://phabricator.services.mozilla.com/D186906
Refactors clicking the restore-page button to be more
declarative within the Translations test suite.
Depends on D186904
Differential Revision: https://phabricator.services.mozilla.com/D186905
Once per TranslationsParent Process, we will schedule
a requestIdleCallback to sync our RemoteSettings records.
This will ensure that users get updates promptly when we push
new changes to Remote Settings, or change which Remote Settings
channel we are pulling from.
Differential Revision: https://phabricator.services.mozilla.com/D187300
Priving an accessible role to the `moz-five-star-rating` wrapper to ensure its `title`/`aria-label` is not ignored by the Accessibility API and that its value will be announced on hover when a screen reader like NVDA is running too.
Differential Revision: https://phabricator.services.mozilla.com/D187525
`ConvertNALUTo4BytesAVCC` converts all kinds of given AVCC data into
4-byte-header AVCC after varifying their data. However, if the header of
the given data is already 4-byte, there is no need to do the conversion.
The 4-byte-header AVCC data only need to check if the data is corrupt.
This patch addes a shortcut for 4-byte AVCC data to skip convesion
(replacing its internal data) and do the corrupt-check only.
Differential Revision: https://phabricator.services.mozilla.com/D186062
Instead of ignoring the conversion error, `ConvertAVCCTo4BytesAVCC`
should only return `Ok` when the given AVCC data can be converted.
When converting H264 data in AVCC format into AnnexB format, the first
step is to convert the AVCC data into 4-byte-header AVCC data. In this
step, `ConvertAVCCTo4BytesAVCC` ignores the error if it fails to read
the NAL body in the length that header claims to be. In order to check
if the given data is corrupt, it needs to return an error in this case.
Without returning an error, it can surprisingly return a `Ok` when no
conversion is done, if the first NAL header gives an incorrect NAL body
length.
In addition, to check if 4-byte AVCC data is corrupt, we should not
early return a `Ok` when the extra data claims the length is 4-byte. We
still need to read the NAL body to ensure the body length matches the
length claimed in the NAL header.
Depends on D185971
Differential Revision: https://phabricator.services.mozilla.com/D185972
Using `--in-content-box-border-color` since it resoves to the `CanvasText` and is using the same variable pair applied to the `#shopping-container` by default.
Differential Revision: https://phabricator.services.mozilla.com/D187526
This didn't work properly for non-native key bindings because:
https://hg.mozilla.org/mozilla-central/rev/8934e6e6ccb6
Moved the DetachedFromEditorOrDefaultPrevented() check before the "hide
cursor" check, rather than after. This was a quick fix, because if we're
detached from the editor, then GetPresContext would assert. But I didn't
realize at the time (since it was a long time since I wrote the patch)
that most events there actually are default-prevented.
To fix this, split the checks. Checks for DetachedFromEditor() first,
and only after potentially hiding the cursor check whether the event is
default-prevented.
Differential Revision: https://phabricator.services.mozilla.com/D187536
Only them may run script. Therefore, they need to use `PostContentIterator`
and `SimpleRange` instead of `UnsafePreContentIterator` and `UnsafeSimpleRange`.
Additionally, they use `ContentEventHandler::ConvertFlatTextOffsetToDOMRange`
which returns `DOMRangeAndAdjustedOffsetInFlattenedText` but it stores a range
and a text node with raw pointers. Therefore, it needs to be a template
class to store them with or without strong pointers. Therefore, this patch
makes it and name `UnsafeDOMRangeAndAdjustedOffsetInFlattenedText` for the
raw pointers version.
Then, `ConvertFlatTextOffsetToDOMRange` needs to be a template method too
since it returns `DOMRangeAndAdjustedOffsetInFlattenedText` or
`UnsafeDOMRangeAndAdjustedOffsetInFlattenedText`.
Finally, `GetFirstFrameInRangeForTextRect` and `GetLastFrameInRangeForTextRect`
need to be template methods too because they need to take `SimpleRange` in
the methods, but `UnsafeSimpleRange` in the other methods.
Differential Revision: https://phabricator.services.mozilla.com/D187423
Most of this patch is ripping `command-context` out from Gecko. The other parts are the fairly straightforward conversions from `command-context` to `task-context`.
Differential Revision: https://phabricator.services.mozilla.com/D186822
This is only sortof a new issue - it's come up because we longer allow `group_by` functions to be overridden, and the taskgraph version of the `single` group doesn't handle the `only-for` blocks that we use all over the place.
This patch provides a quick fix -- renaming the Gecko `single` group-by to `single-with-filters`, and using that in most places. (There were a couple of places that switching to `with-attributes` was simple enough - but in many cases we cannot yet replicate this functionality with `from-deps` alone AFAIK.)
Differential Revision: https://phabricator.services.mozilla.com/D186821
We've created a new, dev bouncer instance as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1819405 / https://mozilla-hub.atlassian.net/browse/SVCSE-1186. The main difference between it and the stage instance is that dev points at ftp.stage.mozaws.net. This happens to be the place that try releases are uploaded to - which means that we can get bouncer-check and final verify to finally pass on try releases by using it.
(bouncer stage points at archive.mozilla.org - so even though we can successfully submit releases to its admin endpoint, what we submit does not often line up with what is served when we query the public endpoint.)
Differential Revision: https://phabricator.services.mozilla.com/D186634
