Commit Graph

26977 Commits

Author SHA1 Message Date
shindli
14c2437eec Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-27 00:57:23 +03:00
shindli
a8d55dae12 Merge inbound to mozilla-central. a=merge 2018-09-27 00:52:12 +03:00
Botond Ballo
022d2224d5 Bug 1476221 - Keep the bounding client rect of the 'FormAssist:AutoCompleteResults' message relative to the visual viewport. r=mstange
Depends on D6090

Differential Revision: https://phabricator.services.mozilla.com/D6091

--HG--
extra : moz-landing-system : lando
2018-09-20 19:31:54 +00:00
Alexandre Poirot
1255c658b2 Bug 1473513 - Backed out changeset d72f6ff37ca6 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: LKPmFrhaQ5q

Depends on D6807

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6808
2018-09-25 19:34:26 +03:00
yulia
e857119004 Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
MozReview-Commit-ID: 3GsXRxcIKfx

Depends on D6473

Differential Revision: https://phabricator.services.mozilla.com/D6474

--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : moz-landing-system : lando
2018-09-25 08:05:29 +00:00
Gabriele Svelto
ac8cdd6759 Bug 1127855 - Handle title highlighting properly in all locales r=nalexander
This patch uses a case-insensitive matcher to highlight the title of a history
entry that's been typed by the user. Previously the matching substring was
calculated manually as lowercase assuming that it's representation would have
the same number of characters as the original mixed case. In some locales
howerver this assumption is wrong leading to out-of-bound exceptions when
highlighting part of the title.

Differential Revision: https://phabricator.services.mozilla.com/D6661

--HG--
extra : moz-landing-system : lando
2018-09-24 20:37:01 +00:00
Andrea Marchesini
b958c6f170 Bug 1260399 - Remove deprecated messages in nsICookieManager methods - part 3 - nsICookieManager.cookieExists, r=ehsan 2018-09-24 11:37:57 +02:00
Andrea Marchesini
61a7f9a598 Bug 1260399 - Remove deprecated messages in nsICookieManager methods - part 1 - nsICookieManager.add(), r=ehsan 2018-09-24 11:37:56 +02:00
Eitan Isaacson
0206ea9620 Bug 1479034 - Make GeckoView's SessionAccessibility a JNIObject associated with a nsWindow. r=jchen 2018-09-21 16:03:35 -07:00
Zibi Braniecki
83ea94f5ba Bug 1491394 - Update callsites to use new mozILocaleService API. r=jfkthame
Depends on D5924

Differential Revision: https://phabricator.services.mozilla.com/D6339

--HG--
extra : moz-landing-system : lando
2018-09-21 15:30:37 +00:00
Luca Greco
792d7cbf1b Bug 1491272 - Require user_scripts manifest property to have access to the userScripts API namespace. r=robwu,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D6146

--HG--
extra : moz-landing-system : lando
2018-09-20 17:09:11 +00:00
Gabriele Svelto
adeb3e767c Bug 1492815 - Do not send the StackTraces field in crash reports r=jchen
This patch prevents Fennec/GeckoView crash reporters from sending the large,
useless StackTraces field when submitting a report. I've also taken the
liberty of removing an obsolete crash annotate that was being added to
Fennec's reports.

Differential Revision: https://phabricator.services.mozilla.com/D6389

--HG--
extra : moz-landing-system : lando
2018-09-20 15:25:31 +00:00
Thomas Wisniewski
2b8c515c76 Bug 1472220 - back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r=rhelmer
back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691

Differential Revision: https://phabricator.services.mozilla.com/D6065

--HG--
extra : moz-landing-system : lando
2018-09-20 14:58:42 +00:00
Xidorn Quan
ffdb7477c7 Bug 1491787 - Use document rather than event target to check fullscreen state in Android's browser.js. r=snorp
The content of e.target has been changed in bug 1375319 from document
to the fullscreen element, so the current code makes it never dispatch
DOMFullScreen:Start, so the Java side would not be aware of such state.

This code was initially added in bug 859683 for supporting scrolling
when the fullscreen element is the document element. Since then, it
seems that the related code had been refactored, and the only usage
of rootElement was removed in bug 1416330.

Because of that, it is no longer necessary to use event target, and
we can just use document directly, which would fix this issue.

Differential Revision: https://phabricator.services.mozilla.com/D6221

--HG--
extra : moz-landing-system : lando
2018-09-20 13:50:09 +00:00
Petru Lingurar
396478b1c5 Bug 1456110 - 3. Enable the "what's new" experiment when testing; r=sdaswani
This will allow to check that indeed, when a Notifications related experiment
is enabled, the "Notifications" setting will appear in the menu.

Depends on D5855

Differential Revision: https://phabricator.services.mozilla.com/D6136

--HG--
extra : moz-landing-system : lando
2018-09-18 16:09:50 +00:00
Petru Lingurar
1ad9714a40 Bug 1456110 - 2. Hide Notification settings if not actionable; r=jchen
Currently the Notification settings screen lets the user enable/disable
two types of notifications, both depending on Switchboard experiments.
If none of those experiments are available for the user, the entire settings
group will be hidden to avoid any confusion.

Depends on D5854

Differential Revision: https://phabricator.services.mozilla.com/D5855

--HG--
extra : moz-landing-system : lando
2018-09-18 11:54:57 +00:00
Petru Lingurar
ba2d5f79a6 Bug 1456110 - 1. Hide "what's new" notification settings if not in experiement; r=jchen
The "What's new" notification (bug 1004734) is based on an experiment which
currently is available to noone.
To avoid any confusions the settings entry for it will be hidden if the user
is not in an active "What's new" experiment.

Differential Revision: https://phabricator.services.mozilla.com/D5854

--HG--
extra : moz-landing-system : lando
2018-09-18 11:53:57 +00:00
Petru Lingurar
316fab8dbc Bug 1489634 - Use implicit Intents for Updater's inner Receiver; r=jchen
Cannot explicitly call a dynamically registered Receiver.

Differential Revision: https://phabricator.services.mozilla.com/D6126

--HG--
extra : moz-landing-system : lando
2018-09-18 17:43:47 +00:00
arthur.iakab
1ee75a928a Merge inbound to mozilla-central a=merge 2018-09-19 05:18:50 +03:00
Jim Chen
9d365405a5 Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen
Add some tests for hiding selection action during navigation, blurring,
or clearing delegate.
2018-09-18 15:20:03 -04:00
Jan Henning
2bf5c04c80 Bug 1491643 - Really disable updates when installed from the Play Store. r=jchen
So far, we've generally opted for a policy of disabling the Updater when we've
been installed from the Play Store, not least because this is not allowed by the
Play Store's terms of service.

While other references to the Updater in the Android app UI are already
completely hidden in that case and we don't do any automatic checking for up-
dates either, the "Check for Updates" button on about:firefox is only hidden via
the MOZ_UPDATER build define and therefore still visible on all Nightly builds.
Since dynamically hiding it might be more involved, we just make sure that the
Updater simply aborts and returns NOT_AVAILABLE when an Update request has been
triggered from Gecko on a Play Store-installed build.

That way, we should be able to avoid all situations where the Updater might want
to display a notification, which of course doesn't work when the corresponding
notification channel hasn't been registered.

Differential Revision: https://phabricator.services.mozilla.com/D6060

--HG--
extra : moz-landing-system : lando
2018-09-18 17:47:01 +00:00
Jim Chen
f5ce114ffa Bug 1475325 - Hide selection action in some scenarios; r=droeh
Hide the selection action toolbar when the session is unfocused, or when
changing the selection action delegate.

Differential Revision: https://phabricator.services.mozilla.com/D5807

--HG--
extra : moz-landing-system : lando
2018-09-17 23:15:17 +00:00
Jim Chen
fe39a234fe Bug 1449567 - Don't reattach compositor for the same compositor object; r=snorp
If we're trying to detach and reattach the same compositor object for
whatever reason, we should skip it so we don't inadvertently end up not
attaching the object at all.

Differential Revision: https://phabricator.services.mozilla.com/D5608

--HG--
extra : moz-landing-system : lando
2018-09-17 17:29:30 +00:00
Jan Henning
4d3821f569 Bug 1280184 - Turn off downloads integration on Android M and later. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D5948

--HG--
extra : moz-landing-system : lando
2018-09-17 15:01:03 +00:00
Csoregi Natalia
b473bf8cc9 Backed out 2 changesets (bug 1456110) for failures on testSettingsPages related to notifications. CLOSED TREE
Backed out changeset 6120e8aa1e3b (bug 1456110)
Backed out changeset b074e28cbaec (bug 1456110)
2018-09-17 19:05:05 +03:00
Jim Chen
9fe07597ab Bug 1442176 - 3. Use new toolbar pinning code in Fennec; r=petru
Send the new "GeckoView:PinToScreen" event in Fennec code so the Fennec
toolbar is pinned when dragging selection carets.

Differential Revision: https://phabricator.services.mozilla.com/D5191
2018-09-17 17:47:21 -04:00
Jim Chen
1499711f6e Bug 1442176 - 2. Add pinned-to-screen flag in GeckoSession; r=snorp r=droeh
Add a flag for whether the session should be pinned to the screen. The
app would check the flag and prevent scrolling of the session when it's
pinned.

Differential Revision: https://phabricator.services.mozilla.com/D5190
2018-09-17 17:47:21 -04:00
Jim Chen
e87c3096e6 Bug 1442176 - 1. Remove current pin-on-caret-drag code; r=snorp
Remove the current code that pins the toolbar on caret drag, which only
works for Fennec.

Differential Revision: https://phabricator.services.mozilla.com/D5189
2018-09-17 17:47:21 -04:00
Vlad Baicu
550968fbb9 Bug 1483993 - Check if profileDir is null before accessing it. r=jchen
In some scenarios profileDir is null which can cause a crash. Added a Nullable
annotation to warn of this possibility and a null check to prevent the exception
from happening.

Differential Revision: https://phabricator.services.mozilla.com/D5878

--HG--
extra : moz-landing-system : lando
2018-09-14 16:23:38 +00:00
Petru Lingurar
a577b719b0 Bug 1456110 - 2. Hide Notification settings if not actionable. r=jchen
Currently the Notification settings screen lets the user enable/disable
two types of notifications, both depending on Switchboard experiments.
If none of those experiments are available for the user, the entire settings
group will be hidden to avoid any confusion.

Depends on D5854

Differential Revision: https://phabricator.services.mozilla.com/D5855

--HG--
extra : amend_source : 87c1ca3c186725a607062784a35e02319d9c8107
extra : histedit_source : 476c3a1e658daa987c413038ef0087dffa52b07b
2018-09-17 10:17:42 -04:00
Petru Lingurar
316d673643 Bug 1456110 - 1. Hide "what's new" notification settings if not in experiement. r=jchen
The "What's new" notification (bug 1004734) is based on an experiment which
currently is available to noone.
To avoid any confusions the settings entry for it will be hidden if the user
is not in an active "What's new" experiment.

Differential Revision: https://phabricator.services.mozilla.com/D5854

--HG--
extra : histedit_source : 357a824de41260c09067143d87ad521ba36bdfd4
2018-09-17 12:40:48 +00:00
Petru Lingurar
7e5111af6f Bug 1490670 - Add telemetry for launching a PWA; r=sdaswani
Differential Revision: https://phabricator.services.mozilla.com/D5672

--HG--
extra : moz-landing-system : lando
2018-09-14 08:36:48 +00:00
Gurzau Raul
731a4bc641 Backed out 2 changesets (bug 1456110) for android-checkstyle failure on a CLOSED TREE
Backed out changeset 88cfcf384ffa (bug 1456110)
Backed out changeset 28443e4a57fb (bug 1456110)
2018-09-17 10:20:46 +03:00
Petru Lingurar
fc8ee26c40 Bug 1456110 - 2. Hide Notification settings if not actionable; r=jchen
Currently the Notification settings screen lets the user enable/disable
two types of notifications, both depending on Switchboard experiments.
If none of those experiments are available for the user, the entire settings
group will be hidden to avoid any confusion.

Depends on D5854

Differential Revision: https://phabricator.services.mozilla.com/D5855

--HG--
extra : moz-landing-system : lando
2018-09-14 16:17:35 +00:00
Petru Lingurar
7a412e8638 Bug 1456110 - 1. Hide "what's new" notification settings if not in experiement; r=jchen
The "What's new" notification (bug 1004734) is based on an experiment which
currently is available to noone.
To avoid any confusions the settings entry for it will be hidden if the user
is not in an active "What's new" experiment.

Differential Revision: https://phabricator.services.mozilla.com/D5854

--HG--
extra : moz-landing-system : lando
2018-09-14 16:16:18 +00:00
Luca Greco
381c9f816c Bug 1489261 - Enable delayed background page startup on Android. r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D5846

--HG--
extra : moz-landing-system : lando
2018-09-14 18:34:33 +00:00
Andreea Pavel
737bd284b4 Backed out changeset 52573727971b (bug 1449567) for braking android build bustages on a CLOSED TREE 2018-09-16 07:29:22 +03:00
Jim Chen
5055667930 Bug 1449567 - Don't reattach compositor for the same compositor object; r=snorp
If we're trying to detach and reattach the same compositor object for
whatever reason, we should skip it so we don't inadvertently end up not
attaching the object at all.

Differential Revision: https://phabricator.services.mozilla.com/D5608

--HG--
extra : moz-landing-system : lando
2018-09-13 16:25:26 +00:00
Hiroyuki Ikezoe
d879a93c1d Bug 1478505 - Run test_mq_prefers_reduced_motion_dynamic.html on Android. r=jchen
To make the test work properly, there needs two functions.  One is just setting
a value for testing and sending the notificaiton for the value changes, the
other one is to reset the state for testing.

The test itself will be introduced in bug 1486971, especially in
https://phabricator.services.mozilla.com/D5004

Depends on D5503

Differential Revision: https://phabricator.services.mozilla.com/D5504

--HG--
extra : moz-landing-system : lando
2018-09-15 10:05:37 +00:00
Hiroyuki Ikezoe
2948ca3af5 Bug 1478505 - Implement prefers-reduced-motion on Android. r=jchen
Depends on D5502

Differential Revision: https://phabricator.services.mozilla.com/D5503

--HG--
extra : moz-landing-system : lando
2018-09-15 10:03:42 +00:00
Hiroyuki Ikezoe
670b9b1d28 Bug 1478505 - Rename GeckoInputDeviceListener to GeckoSystemStateListener. r=jchen
Because we are going to use it for prefers-reduced-motion media feature which
is tied to a system setting.

Differential Revision: https://phabricator.services.mozilla.com/D5502

--HG--
rename : mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputDeviceListener.java => mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoSystemStateListener.java
rename : widget/android/GeckoInputDeviceListener.h => widget/android/GeckoSystemStateListener.h
extra : moz-landing-system : lando
2018-09-15 10:03:29 +00:00
Jim Chen
f4ae63803a Bug 1490493 - 2. Add tests for GeckoView saving/restoring state; r=droeh
Add some tests for all scenarios that GeckoView encounters when it is
saving/restoring state.

Differential Revision: https://phabricator.services.mozilla.com/D5607
2018-09-14 14:47:25 -04:00
Jim Chen
ba2897b9d9 Bug 1490493 - 1. Return early if same session is being restored; r=droeh
Restoring the same session that's already managed by the GeckoView
instance should be a no-op.

Differential Revision: https://phabricator.services.mozilla.com/D5606
2018-09-14 14:47:24 -04:00
Jim Chen
84e954756f Bug 1485810 - 2. Add GeckoViewAutoFill support in browser.js; r=petru
Make auto-fill work for the main Fennec activity by making calls to
GeckoViewAutoFill.

Differential Revision: https://phabricator.services.mozilla.com/D4804
2018-09-14 14:46:27 -04:00
Jim Chen
c603332d5d Bug 1485810 - 1. Move auto-fill code to GeckoViewAutoFill.jsm; r=droeh
Move all auto-fill code to GeckoViewAutoFill.jsm, so they can be shared
between GeckoView and Fennec.

Differential Revision: https://phabricator.services.mozilla.com/D4803
2018-09-14 14:46:25 -04:00
Jan Henning
5f8503a563 Bug 1480854 - Use classic icons again on platforms prior to Oreo. r=jchen
We want to use the classic, non-adaptive icon again as our launcher icon on
Android versions prior to Oreo, as well as to continue using it in various
places within our app.

Unfortunately this means that we still have to provide duplicate resources for
those two purposes:
Because we don't want to use the adaptive icon internally, we can't use the same
resource directly for both internal usage and our launcher icon, because other-
wise on Oreo and above we'd receive the adaptive icon that way.
One possible workaround would have been to use the PNG files of our classic icon
directly as a drawable for internal useage and then create a differently named
XML bitmap for our launcher icon, which in turn would be overridden by the
adaptive icon on Oreo and above.
Unfortunately, modern usage demands that the launcher icon should be provided as
a mipmap resource, where XML bitmaps
- aren't officially supported
- unofficially work with some devices/launchers, but not all.

Therefore, our only choice is to provide separate drawables for our internal
icon and our launcher icon, even if prior to Android O both will have the same
contents. We'll also get rid of the separate round icon again, since
- on Android O and above, both round and non-round icons were using the same
  adaptive icon anyway
- prior to Android O our normal icon is already round enough, but not round
  enough to pass the lint check

--HG--
extra : rebase_source : 6c06c903f4fed2ef4aee3c5a915e18c437c5b510
extra : amend_source : ab3eab8e4dc2523a336aef2a4d2889ab7dbc76b9
extra : intermediate-source : 56f9803240157892066fa5b1703b8fe50c28020d
extra : source : 6183adcbfc9d81ab0cb854a4734a98f10a897d6b
2018-09-08 18:30:30 +02:00
Narcis Beleuzu
3d1a1f1883 Backed out changeset 56f980324015 (bug 1480854) for lint bustage. CLOSED TREE 2018-09-14 19:22:52 +03:00
Jan Henning
2bcbde60fe Bug 1480854 - Use classic icons again on platforms prior to Oreo. r=jchen
We want to use the classic, non-adaptive icon again as our launcher icon on
Android versions prior to Oreo, as well as to continue using it in various
places within our app.

Unfortunately this means that we still have to provide duplicate resources for
those two purposes:
Because we don't want to use the adaptive icon internally, we can't use the same
resource directly for both internal usage and our launcher icon, because other-
wise on Oreo and above we'd receive the adaptive icon that way.
One possible workaround would have been to use the PNG files of our classic icon
directly as a drawable for internal useage and then create a differently named
XML bitmap for our launcher icon, which in turn would be overridden by the
adaptive icon on Oreo and above.
Unfortunately, modern usage demands that the launcher icon should be provided as
a mipmap resource, where XML bitmaps
- aren't officially supported
- unofficially work with some devices/launchers, but not all.

Therefore, our only choice is to provide separate drawables for our internal
icon and our launcher icon, even if prior to Android O both will have the same
contents. We'll also get rid of the separate round icon again, since
- on Android O and above, both round and non-round icon were using the same
  adaptive icon anyway
- prior to Android O our normal icon is already round enough (ignoring the
  Fennec icon for local developer builds)

--HG--
extra : source : 6183adcbfc9d81ab0cb854a4734a98f10a897d6b
extra : amend_source : dc14ea076aafd9d24fd5ee7aebcf71348812942c
2018-09-08 18:30:30 +02:00
Andrei Lazar
403853306a Bug 1480852 Crash in android.os.TransactionTooLargeException: data parcel size 1053364 bytes at android.os.BinderProxy.transactNative(Native Method) r=jchen
Added an extra check of bundle size due to some unexpected transactions sizes that exceed the limit.
The bundle gets lighter if the size exceeds the limit by removing the views' state as a last resort.

Differential Revision: https://phabricator.services.mozilla.com/D5682

--HG--
extra : moz-landing-system : lando
2018-09-14 11:24:33 +00:00
Noemi Erli
c2716211ca Merge inbound to mozilla-central. a=merge 2018-09-14 06:31:31 +03:00