The uninstaller was being built as a side-effect of building `setup.exe`. In
Bug 1385227, that was moved from "somewhere" to part of the windows installer
packaging, which happens after the zip and mar are generated. Since the
installer we ship is actually repackaged from the zip[1], we stopped shipping
translated uninstallers.
This changes things around so that the uninstaller gets translated:
- Explicitly build the uninstaller as part of the L10n repack step.
- Use the same logic to build the installer locally as we do to create the ones
we ship.
[1] Except on Thunderbird
Differential Revision: https://phabricator.services.mozilla.com/D672
--HG--
extra : rebase_source : 05fe935c1d2a9fbfeef786819bfe5913ed8ef862
extra : source : d6bf22099e2195dcb64c3c3d7700d3edd0850a3a
The uninstaller was being built as a side-effect of building `setup.exe`. In
Bug 1385227, that was moved from "somewhere" to part of the windows installer
packaging, which happens after the zip and mar are generated. Since the
installer we ship is actually repackaged from the zip[1], we stopped shipping
translated uninstallers.
This changes things around so that the uninstaller gets translated:
- Explicitly build the uninstaller as part of the L10n repack step.
- Use the same logic to build the installer locally as we do to create the ones
we ship.
[1] Except on Thunderbird
Differential Revision: https://phabricator.services.mozilla.com/D672
--HG--
extra : rebase_source : 2b28b9ff7196d12f4a188c8dddf750b9a5efac5b
extra : histedit_source : 9bc28891950ae8c226cfdefef6f8121ce0b51f58
Summary: Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website'
Reviewers: jaws, flod
Reviewed By: jaws, flod
Subscribers: Pike, flod
Bug #: 1451864
Differential Revision: https://phabricator.services.mozilla.com/D926
--HG--
extra : rebase_source : 7318a9bcbc8f1b511cc2e86636d6316b215feee9
extra : amend_source : cca9ef041295261bfea303b2e77ec35c89d93382
Cleanup of all localization notes that refer to entities
that are not listed in the corresponding localization file.
MozReview-Commit-ID: Bl0VU9HoPfa
--HG--
extra : rebase_source : 86680b8ae037783304f045e94c7af7053a0f69e9
cookies.xul is unused and mostly unmaintained and should be removed.
Equivalent functionality in a well-maintained interface can be found
in the storage manager or the devtools storage inspector.
MozReview-Commit-ID: ILSt83hwN34
--HG--
extra : rebase_source : 9aaec03b54128ef3ece1e96e46269457feb43546
This commit changes the way that the page info security section works
to not only consider cookies when answering the question "Is this website
storing information about me?".
The associated button used to open the cookie manager. We would like to
reduce the storage management UI surface (in the interest of having one
great central location for managing storage), so that button was replaced
with a simple "clear data" button that clears site data for all origins of
the base domain of the site.
Clearing for the entire range of that base domain is a trade off between
(implicit) user privacy and the risk that the user accidentally
deletes too much data. I prefer to choose increased privacy.
MozReview-Commit-ID: BUgxJHBeFcQ
--HG--
extra : rebase_source : f88772b2275c97d30480a626e23a9d1875339b2b
Currently, clicking the close button or otherwise trying to exit the Windows
stub installer always ends up canceling the installation. This patch prompts
the user to either continue or cancel the installation.
MozReview-Commit-ID: 4KMgCcyjTnv
--HG--
extra : rebase_source : 0c0636c9c02fabd32df37471033d8e847caea5d3
Also remove temporary string from preferences.ftl (search-input). This was added
to avoid removing the string when running migrations against mozilla-central
MozReview-Commit-ID: IDgTNoANPyV
--HG--
extra : rebase_source : a2fe06f2214dfb6189351cd9a0eef4e41869b639
l10n.toml files need to be valid across all channels, add back the
devtools/shim directory with a comment on when to remove it.
MozReview-Commit-ID: 8lOKRn3LwS
--HG--
extra : rebase_source : 035745f8ccf8a6542e364de3f6765ef11dfe6b25
extra : amend_source : 6c7221142591613b23cbca56cc3d3055fb2cede7
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
not set. This is fixed by setting it to the private title by default;
there is very little (if any) UI that allows users to even open
about:privatebrowsing in 'normal' windows so we care a lot less about
flicker there. To be able to include this title in the markup, we switched
to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
created. This has been updated to check for private windows, and default to
'Private Browsing' instead. This will obviously also affect other new tabs
in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
have a content title for (which can still happen while about:privatebrowsing
is loading because e10s), and so that is updated, too.
MozReview-Commit-ID: nVfXD2M6UZ
--HG--
extra : rebase_source : e5a698da70f215d8c7ccca242fbddc0fcaf9bf6b
When moving cookies to the site data section we forgot about some
searchkeywords which were left on the cookies exceptions dialog.
We also forgot to remove the status column label when removing the
status column.
Further, the search tooltip is not displayed correctly on the three
vertically aligned dialog buttons (it's always on the last button),
because we did not put each of them in its own hbox (which is just way
too easy to get wrong and needs a better mid term solution).
MozReview-Commit-ID: L6ZaocWsjYU
--HG--
extra : rebase_source : 209751545d50337d2eb4d16cc43c96c0258bd47c
This mostly changes "cookies" to "cookies and site data" and amends a few
other details.
MozReview-Commit-ID: 97xTSQPw2DA
--HG--
extra : rebase_source : 63ceb2e11cad77441dbf11b298d6035081a29123
Improves the UI for pages blocked by the enterprise policy manager. These improvements include a new image instead of the generic "info" image and updated, approved strings for the page.
MozReview-Commit-ID: 9d6V9onHGGg
--HG--
extra : rebase_source : d702947924f24d9440455a56b7e2f876ab634464
This changes the disk space notification to show the correct preferences path
and to use the correct openPreferences arguments.
MozReview-Commit-ID: BuKAUvDjp9T
--HG--
extra : rebase_source : 678f52801d100a980f529fc565d1009c38320ae4
* Removed the revertNoRestartButton entry from the migration script as this no longer exists after this change
MozReview-Commit-ID: AGJ2OfYVPok
--HG--
extra : rebase_source : df7f383f51e4d72c493e4cc43696eff2ee0034fa
After including cookies in the site data manager in bug 1421737, we would
like to move the cookies settings to the site data section to give them
more visibility and to unify site data and cookies.
Our UR has shown that our differentiation between site data and cookies
is not helpful to users and that they struggle with discovering the
cookie settings that are hidden in the "custom history" menu.
Since the cookie settings are quite powerful/potentially breaking,
we changed the top level preference from a checkbox to a radiogroup,
to be able to highlight the potential breakage associated with "deny".
This grouping is also recommended by the webstorage spec:
https://www.w3.org/TR/webstorage/#privacy
The cookies dialog is not removed yet, because it is still accessible from
Page Info, but bug 1348223 will likely remove it entirely.
MozReview-Commit-ID: Adisn70Ks2Q
--HG--
extra : rebase_source : 333d6165c74d6ff664cd3d603c5d834bfbde4326
Since the number of tabs is not actually displayed, having two separate strings from 1 vs many is preferable.
MozReview-Commit-ID: y1dgvsCxmC
--HG--
extra : rebase_source : ad694b2dc7bc44128f909e91a90c4822c0698770
We are no longer implicitly deleting cookies when removing site data because
cookies are now listed as part of the site data manager. We're also no longer
deleting cookies based on the base domain, which makes most of the UI in the
removal dialog unnecessary. Instead of a tree box with sub domains we're now
showing a simple listbox domains to be deleted.
MozReview-Commit-ID: GWv5QVxEiiy
--HG--
extra : rebase_source : bc202a92d62ff8d4ddfd40ff4096c9ad1fdb0735
This commit primarily intends to add cookies to the site data manager,
but while touching this code I transformed the siteListItem XBL binding to plain JS.
This also removes the #SiteDataRemoveSelectedDialog binding rule, because it is
unnecessary, <dialog> elements already have this binding.
MozReview-Commit-ID: EpTd2E0vPN9
--HG--
extra : rebase_source : 90e6666e565aaa74bd2545e13534bdebe8f090ee
This commit removes most of the cache section in about:preferences,
following the UX concept from bug 1421690. This is in the general
interest of de-cluttering privacy preferences and giving users controls
that are easier to understand and use.
The cache size is instead shown in the site data section and the cache
can be cleared using the "Clear Data" button in that same section.
MozReview-Commit-ID: 7PDTDgllFFI
--HG--
extra : rebase_source : 98eea84efb2b90068bf0d106321d8af64afd1f77
This is part of the work to remove XUL overlays. This overlay is only
used once and can be inlined.
MozReview-Commit-ID: 1SE1nobgehE
--HG--
extra : rebase_source : 33d73fa8538da9af626feb53267278ac97554710
Errors are collected via nsIConsoleService, shaped to a Sentry-compatible
format, and sent off. Reporting is on by default, and can be disabled using a
checkbox added to the privacy prefs in about:preferences.
Collected errors are sampled to avoid overloading the collection service; the
sample rate was determined by a previous Shield study that measured the number
of errors occurring in Nightly.
The feature is hard-disabled outside of Nightly and local builds, and the
preference is disabled by default in local builds. It is intended as a prototype
that will be evaluated and replaced by a more robust collection system if it
proves helpful.
Differential Revision: https://phabricator.services.mozilla.com/D561
MozReview-Commit-ID: 6aqUatXyuYs
--HG--
extra : rebase_source : 574aa329069f80e0beb52d1fd15f43e65a548c5c
extra : amend_source : a817fa4691c520eafaef808531b10581d09aeb14
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.
MozReview-Commit-ID: HKYPkg78IOK
--HG--
extra : rebase_source : bf5a52b39c40012058a22ed204ec947b5b8679da
extra : source : a1b90c54c94ca4fc81da9565bf0ef7fce661ce25
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.
MozReview-Commit-ID: HKYPkg78IOK
--HG--
extra : rebase_source : 07b660b7cf094b41ef4d3ca260a57341c349e488
extra : source : a1b90c54c94ca4fc81da9565bf0ef7fce661ce25
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.
This also updates some of the strings to use the phrase "is controlling" rather than "controls".
MozReview-Commit-ID: HKYPkg78IOK
--HG--
extra : rebase_source : 4ec0ce408eae2b654265a864d25a4d2078e86c05
extra : source : a1b90c54c94ca4fc81da9565bf0ef7fce661ce25
This adjusts both the new Tracking Protection UI and the old Tracking Protection UI on
about:preferences to indicate when an extension is controlling Tracking Protection. It
will disable the controls on about:preferences if an extension is in control, and provide
a button to disable the extension.
MozReview-Commit-ID: G04jWrS6Pr9
--HG--
extra : rebase_source : 4cdee73b00b74e25c074e62a872d7b50a984cf8f
On nightly and aurora we have supplemental strings about Telemetry in the About
dialog/section. However, we already open the data policy tab (Desktop) and
notification (Mobile) on nightly, aurora, -and beta- to more accurately tell
users about our data policies.
So let's remove the inconsistently-applied semi-hard-to-find strings.
MozReview-Commit-ID: 3zjXQwi9r7v
--HG--
extra : rebase_source : af9728dd1ff2161ff028f85ebf7f93c22eae0181
This patch moves us from using an old pref `general.useragent.locale`combined
with `intl.locale.matchOS` for retrieving user requested locale, to use a new
preference `intl.locale.requested` which stores a list of well-formed BCP47
language tags. If set to empty, the OS locales are used. If not set at all,
default locale is used.
We are also adding a piece of code to migrate from old to new system.
MozReview-Commit-ID: 854yQ1kC6Ee
--HG--
extra : rebase_source : c4a7171bc026f857f7878ee83d973ec01b536a84
addonsInstalled and addonsInstalledNeedsRestart currently abuse
plural forms, using the singular form to expose the name of the add-on.
While the first form is singular for English, it's used for other numbers
in other languages, and in others there's only one form available,
making these strings impossible to translate.
MozReview-Commit-ID: 6hVJnaqTGtc
--HG--
extra : rebase_source : b9f616eb816e364008d5ce3419ec521c5acbb979