Commit Graph

8024 Commits

Author SHA1 Message Date
Yura Zenevich
ede444df5b Bug 1543575 - add fission coverage for accessibility b-c e10s event tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48550

--HG--
extra : rebase_source : 99ab9d1b956a17dbd1d302ad9414885057bc4c90
extra : source : d7d27d08162d32b6b1c8fd048f918b50d40eabd6
2019-10-17 15:15:00 +00:00
Yura Zenevich
ac9730e94b Bug 1543575 - provide an option for running accessibility browser chrome e10s tests in fission process. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48549

--HG--
extra : rebase_source : 3e1061d9a4d41b55421d56456ba08febc09cb445
extra : source : 5b54e1361ca15904a429cc0da84d886b2567b3a6
2019-10-17 15:14:50 +00:00
Yura Zenevich
de89df5cc3 Bug 1543575 - stop using ContentTask across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47387

--HG--
extra : rebase_source : bb1618e0b351f48da2750a93c9f46842d79f2cbd
extra : source : 5e5a6ce39829f7a176fa2de181db7cef60534522
2019-10-17 15:14:41 +00:00
Yura Zenevich
7ad8ffc6bb Bug 1543575 - stop using frame scripts across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47386

--HG--
extra : rebase_source : 2b8af3317a182b5710a7e7dd61241503f2958285
extra : source : 472cbb99f5ceb3b466c393c0c5a40753dcec79ff
2019-10-17 15:14:34 +00:00
Dorel Luca
d08ef1bec1 Backed out 6 changesets (bug 1543575) for Mochitest failures in toolkit/content/tests/chrome/test_popup_button.xul. CLOSED TREE
Backed out changeset 2dbafadffbd9 (bug 1543575)
Backed out changeset 8b92e98ee616 (bug 1543575)
Backed out changeset d7d27d08162d (bug 1543575)
Backed out changeset 5b54e1361ca1 (bug 1543575)
Backed out changeset 5e5a6ce39829 (bug 1543575)
Backed out changeset 472cbb99f5ce (bug 1543575)
2019-10-17 23:18:13 +03:00
Yura Zenevich
4418b7b6c7 Bug 1543575 - add fission coverage for accessibility b-c e10s tree update tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48552

--HG--
extra : moz-landing-system : lando
2019-10-17 15:15:18 +00:00
Yura Zenevich
5ee679c147 Bug 1543575 - add fission coverage for accessibility b-c e10s caching tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48551

--HG--
extra : moz-landing-system : lando
2019-10-17 15:15:09 +00:00
Yura Zenevich
f8c46981a4 Bug 1543575 - add fission coverage for accessibility b-c e10s event tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48550

--HG--
extra : moz-landing-system : lando
2019-10-17 15:15:00 +00:00
Yura Zenevich
08b6f8ee1e Bug 1543575 - provide an option for running accessibility browser chrome e10s tests in fission process. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48549

--HG--
extra : moz-landing-system : lando
2019-10-17 15:14:50 +00:00
Yura Zenevich
85544e7033 Bug 1543575 - stop using ContentTask across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47387

--HG--
extra : moz-landing-system : lando
2019-10-17 15:14:41 +00:00
Yura Zenevich
beb9aa4e5f Bug 1543575 - stop using frame scripts across accessible/ browser chrome tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47386

--HG--
extra : moz-landing-system : lando
2019-10-17 15:14:34 +00:00
Coroiu Cristina
34a649cd21 Backed out changeset 8c0ed99d462c (bug 1578445) for browser-chrome failures at browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js on a CLOSED TREE 2019-10-17 20:29:23 +03:00
Harry Twyford
8347b171c4 Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
2019-10-17 16:49:38 +00:00
Morgan Reschenberg
1b8dfbb609 Bug 1579633: Update menu role, HTML spec tests. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49314

--HG--
extra : moz-landing-system : lando
2019-10-17 15:45:27 +00:00
Oana Pop Rus
e0fb2f2a1e Backed out changeset 62d172103a78 (bug 1578445) for bc failures in browser/browser_ext_urlbar.js on a CLOSED TREE 2019-10-17 17:28:29 +03:00
Harry Twyford
07dd6769fb Bug 1578445 - Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47980

--HG--
extra : moz-landing-system : lando
2019-10-17 10:48:26 +00:00
Emma Malysz
b806cbda1f Bug 1588918, rename .xul test files in accessible/ to .xhtml r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D49355

--HG--
rename : accessible/tests/browser/states/test_deck_has_out_of_process_iframe.xul => accessible/tests/browser/states/test_deck_has_out_of_process_iframe.xhtml
rename : accessible/tests/crashtests/471493.xul => accessible/tests/crashtests/471493.xhtml
rename : accessible/tests/crashtests/last_test_to_unload_testsuite.xul => accessible/tests/crashtests/last_test_to_unload_testsuite.xhtml
rename : accessible/tests/mochitest/actions/test_general.xul => accessible/tests/mochitest/actions/test_general.xhtml
rename : accessible/tests/mochitest/actions/test_keys_menu.xul => accessible/tests/mochitest/actions/test_keys_menu.xhtml
rename : accessible/tests/mochitest/actions/test_tree.xul => accessible/tests/mochitest/actions/test_tree.xhtml
rename : accessible/tests/mochitest/actions/test_treegrid.xul => accessible/tests/mochitest/actions/test_treegrid.xhtml
rename : accessible/tests/mochitest/attributes/test_obj_css.xul => accessible/tests/mochitest/attributes/test_obj_css.xhtml
rename : accessible/tests/mochitest/attributes/test_obj_group.xul => accessible/tests/mochitest/attributes/test_obj_group.xhtml
rename : accessible/tests/mochitest/attributes/test_obj_group_tree.xul => accessible/tests/mochitest/attributes/test_obj_group_tree.xhtml
rename : accessible/tests/mochitest/elm/test_listbox.xul => accessible/tests/mochitest/elm/test_listbox.xhtml
rename : accessible/tests/mochitest/events/test_focus_autocomplete.xul => accessible/tests/mochitest/events/test_focus_autocomplete.xhtml
rename : accessible/tests/mochitest/events/test_focus_contextmenu.xul => accessible/tests/mochitest/events/test_focus_contextmenu.xhtml
rename : accessible/tests/mochitest/events/test_focus_general.xul => accessible/tests/mochitest/events/test_focus_general.xhtml
rename : accessible/tests/mochitest/events/test_focus_listcontrols.xul => accessible/tests/mochitest/events/test_focus_listcontrols.xhtml
rename : accessible/tests/mochitest/events/test_focus_menu.xul => accessible/tests/mochitest/events/test_focus_menu.xhtml
rename : accessible/tests/mochitest/events/test_focus_tabbox.xul => accessible/tests/mochitest/events/test_focus_tabbox.xhtml
rename : accessible/tests/mochitest/events/test_focus_tree.xul => accessible/tests/mochitest/events/test_focus_tree.xhtml
rename : accessible/tests/mochitest/events/test_label.xul => accessible/tests/mochitest/events/test_label.xhtml
rename : accessible/tests/mochitest/events/test_menu.xul => accessible/tests/mochitest/events/test_menu.xhtml
rename : accessible/tests/mochitest/events/test_namechange.xul => accessible/tests/mochitest/events/test_namechange.xhtml
rename : accessible/tests/mochitest/events/test_scroll.xul => accessible/tests/mochitest/events/test_scroll.xhtml
rename : accessible/tests/mochitest/events/test_scroll_caret.xul => accessible/tests/mochitest/events/test_scroll_caret.xhtml
rename : accessible/tests/mochitest/events/test_selection.xul => accessible/tests/mochitest/events/test_selection.xhtml
rename : accessible/tests/mochitest/events/test_tree.xul => accessible/tests/mochitest/events/test_tree.xhtml
rename : accessible/tests/mochitest/focus/test_focus_radio.xul => accessible/tests/mochitest/focus/test_focus_radio.xhtml
rename : accessible/tests/mochitest/focus/test_takeFocus.xul => accessible/tests/mochitest/focus/test_takeFocus.xhtml
rename : accessible/tests/mochitest/hittest/test_menu.xul => accessible/tests/mochitest/hittest/test_menu.xhtml
rename : accessible/tests/mochitest/hittest/test_zoom_tree.xul => accessible/tests/mochitest/hittest/test_zoom_tree.xhtml
rename : accessible/tests/mochitest/hittest/zoom_tree.xul => accessible/tests/mochitest/hittest/zoom_tree.xhtml
rename : accessible/tests/mochitest/hyperlink/test_general.xul => accessible/tests/mochitest/hyperlink/test_general.xhtml
rename : accessible/tests/mochitest/name/test_browserui.xul => accessible/tests/mochitest/name/test_browserui.xhtml
rename : accessible/tests/mochitest/name/test_general.xul => accessible/tests/mochitest/name/test_general.xhtml
rename : accessible/tests/mochitest/name/test_tree.xul => accessible/tests/mochitest/name/test_tree.xhtml
rename : accessible/tests/mochitest/relations/test_embeds.xul => accessible/tests/mochitest/relations/test_embeds.xhtml
rename : accessible/tests/mochitest/relations/test_general.xul => accessible/tests/mochitest/relations/test_general.xhtml
rename : accessible/tests/mochitest/relations/test_tabbrowser.xul => accessible/tests/mochitest/relations/test_tabbrowser.xhtml
rename : accessible/tests/mochitest/relations/test_tree.xul => accessible/tests/mochitest/relations/test_tree.xhtml
rename : accessible/tests/mochitest/role/test_aria.xul => accessible/tests/mochitest/role/test_aria.xhtml
rename : accessible/tests/mochitest/role/test_general.xul => accessible/tests/mochitest/role/test_general.xhtml
rename : accessible/tests/mochitest/selectable/test_listbox.xul => accessible/tests/mochitest/selectable/test_listbox.xhtml
rename : accessible/tests/mochitest/selectable/test_menu.xul => accessible/tests/mochitest/selectable/test_menu.xhtml
rename : accessible/tests/mochitest/selectable/test_menulist.xul => accessible/tests/mochitest/selectable/test_menulist.xhtml
rename : accessible/tests/mochitest/selectable/test_tabs.xul => accessible/tests/mochitest/selectable/test_tabs.xhtml
rename : accessible/tests/mochitest/selectable/test_tree.xul => accessible/tests/mochitest/selectable/test_tree.xhtml
rename : accessible/tests/mochitest/states/test_aria.xul => accessible/tests/mochitest/states/test_aria.xhtml
rename : accessible/tests/mochitest/states/test_controls.xul => accessible/tests/mochitest/states/test_controls.xhtml
rename : accessible/tests/mochitest/states/test_expandable.xul => accessible/tests/mochitest/states/test_expandable.xhtml
rename : accessible/tests/mochitest/states/test_popup.xul => accessible/tests/mochitest/states/test_popup.xhtml
rename : accessible/tests/mochitest/states/test_tabs.xul => accessible/tests/mochitest/states/test_tabs.xhtml
rename : accessible/tests/mochitest/states/test_textbox.xul => accessible/tests/mochitest/states/test_textbox.xhtml
rename : accessible/tests/mochitest/states/test_tree.xul => accessible/tests/mochitest/states/test_tree.xhtml
rename : accessible/tests/mochitest/states/test_visibility.xul => accessible/tests/mochitest/states/test_visibility.xhtml
rename : accessible/tests/mochitest/table/test_headers_tree.xul => accessible/tests/mochitest/table/test_headers_tree.xhtml
rename : accessible/tests/mochitest/table/test_indexes_tree.xul => accessible/tests/mochitest/table/test_indexes_tree.xhtml
rename : accessible/tests/mochitest/table/test_sels_tree.xul => accessible/tests/mochitest/table/test_sels_tree.xhtml
rename : accessible/tests/mochitest/table/test_struct_tree.xul => accessible/tests/mochitest/table/test_struct_tree.xhtml
rename : accessible/tests/mochitest/text/test_general.xul => accessible/tests/mochitest/text/test_general.xhtml
rename : accessible/tests/mochitest/tree/test_applicationacc.xul => accessible/tests/mochitest/tree/test_applicationacc.xhtml
rename : accessible/tests/mochitest/tree/test_button.xul => accessible/tests/mochitest/tree/test_button.xhtml
rename : accessible/tests/mochitest/tree/test_combobox.xul => accessible/tests/mochitest/tree/test_combobox.xhtml
rename : accessible/tests/mochitest/tree/test_formctrl.xul => accessible/tests/mochitest/tree/test_formctrl.xhtml
rename : accessible/tests/mochitest/tree/test_groupbox.xul => accessible/tests/mochitest/tree/test_groupbox.xhtml
rename : accessible/tests/mochitest/tree/test_image.xul => accessible/tests/mochitest/tree/test_image.xhtml
rename : accessible/tests/mochitest/tree/test_tabbox.xul => accessible/tests/mochitest/tree/test_tabbox.xhtml
rename : accessible/tests/mochitest/tree/test_tabbrowser.xul => accessible/tests/mochitest/tree/test_tabbrowser.xhtml
rename : accessible/tests/mochitest/tree/test_tree.xul => accessible/tests/mochitest/tree/test_tree.xhtml
rename : accessible/tests/mochitest/tree/test_txtctrl.xul => accessible/tests/mochitest/tree/test_txtctrl.xhtml
rename : accessible/tests/mochitest/tree/wnd.xul => accessible/tests/mochitest/tree/wnd.xhtml
rename : accessible/tests/mochitest/treeupdate/test_contextmenu.xul => accessible/tests/mochitest/treeupdate/test_contextmenu.xhtml
rename : accessible/tests/mochitest/treeupdate/test_deck.xul => accessible/tests/mochitest/treeupdate/test_deck.xhtml
rename : accessible/tests/mochitest/treeupdate/test_listbox.xul => accessible/tests/mochitest/treeupdate/test_listbox.xhtml
rename : accessible/tests/mochitest/treeupdate/test_menu.xul => accessible/tests/mochitest/treeupdate/test_menu.xhtml
rename : accessible/tests/mochitest/treeupdate/test_menubutton.xul => accessible/tests/mochitest/treeupdate/test_menubutton.xhtml
rename : accessible/tests/mochitest/treeupdate/test_shutdown.xul => accessible/tests/mochitest/treeupdate/test_shutdown.xhtml
extra : moz-landing-system : lando
2019-10-16 16:59:02 +00:00
Emilio Cobos Álvarez
441f9a401b Bug 998590 - Prototype accessibility level changes for headings behind a pref. r=MarcoZ
I don't think these need invalidation of any sort since they only depend on
ancestors, and we recreate accessibles when the element's ancestor chain changes.

Differential Revision: https://phabricator.services.mozilla.com/D49408

--HG--
extra : moz-landing-system : lando
2019-10-16 12:31:21 +00:00
Emilio Cobos Álvarez
5ffa02e5a8 Bug 998590 - Factor out heading accessibility level into HTMLHeadingElement. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D49407

--HG--
extra : moz-landing-system : lando
2019-10-16 12:32:10 +00:00
James Teh
cb2f077062 Bug 1577381: Correct accessibility exposure for optgroups in content select dropdowns. r=eeejay,NeilDeakin
For remote content documents, select dropdowns (for <select size="1">) are rendered in the parent process using a XUL menupopup.
This means that the accessibility code for HTML selects doesn't apply.

In the menupopup, the optgroup is a sibling of its contained options.
For accessibility, we want to preserve the hierarchy such that the options are inside the optgroup.
We do this using aria-owns on the optgroup item.

This required some tweaks to XULMenuitemAccessible, as it couldn't previously handle grouping Accessibles between the menupopup and its items.

Differential Revision: https://phabricator.services.mozilla.com/D43901

--HG--
extra : moz-landing-system : lando
2019-10-16 06:10:32 +00:00
Morgan Reschenberg
83d56de89c Bug 1579750: Consider aria role before landmark role for xlm-roles attribute. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49178

--HG--
extra : moz-landing-system : lando
2019-10-14 21:54:35 +00:00
Morgan Reschenberg
c157ae77f0 Bug 822988: Create HyperTextAccessibleWrap for SVG text objects for correct role assignment. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D49202

--HG--
extra : moz-landing-system : lando
2019-10-14 21:51:58 +00:00
Alexander Surkov
5459de4426 Bug 1587512 - remove XBL dialog support bits; remove XBL support from TreeWalker; update XBL related comments and remove XBL mutation test r=MarcoZ,Jamie
Depends on D48964

Differential Revision: https://phabricator.services.mozilla.com/D48965

--HG--
extra : moz-landing-system : lando
2019-10-14 05:36:10 +00:00
Alexander Surkov
350c642a46 Bug 1587512 - remove nsIXBLAccessible interface r=MarcoZ,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48964

--HG--
extra : moz-landing-system : lando
2019-10-14 05:40:05 +00:00
James Teh
76247694a7 Bug 1588416: Reinstate the label for the search one-offs container. r=Standard8
The previous code relied on the header label having a value property.
However, after the conversion to Fluent in bug 1563026, this is no longer the case.
Instead, use aria-labelledby, which avoids label duplication and will work irrespective of the label's implementation.

Differential Revision: https://phabricator.services.mozilla.com/D49125

--HG--
extra : moz-landing-system : lando
2019-10-14 12:27:49 +00:00
James Teh
af76f6473c Bug 1585907 part 2: Allow A11yUtils.announce to take a Fluent id. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D49096

--HG--
extra : moz-landing-system : lando
2019-10-14 10:31:26 +00:00
Tim Nguyen
79c7f01c56 Bug 1588066 - Remove remaining references to textbox. r=surkov,emilio,webdriver-reviewers,bgrins,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D48958

--HG--
extra : moz-landing-system : lando
2019-10-14 07:41:35 +00:00
Morgan Reschenberg
5f968ff73a Bug 1557849: Check if a MenuPopupAccessible belongs to a context menu to determine its role assignment. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48394

--HG--
extra : moz-landing-system : lando
2019-10-10 20:33:29 +00:00
Alexander Surkov
ba43684bbe Bug 1587791 - remove XBL backed accessible relations support r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D48840

--HG--
extra : moz-landing-system : lando
2019-10-10 14:08:17 +00:00
Tim Nguyen
792b820aa5 Bug 1513325 - Remove some a11y tests that no longer apply in a post-XBL world. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D48701

--HG--
extra : moz-landing-system : lando
2019-10-09 12:45:03 +00:00
Tim Nguyen
822add064c Bug 1513325 - Remove textbox binding. r=emilio,dao
Differential Revision: https://phabricator.services.mozilla.com/D38955

--HG--
extra : moz-landing-system : lando
2019-10-09 09:27:28 +00:00
Brendan Dahl
c68cd30ef2 Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky
When XBL is disabled, no code in dom/xbl will be built. Also, adds ifdefs
to remove any of the XBL related code elsewhere. There's definitely more
that can be done here, but I think it's better to wait to do the rest of
the cleanup when we actually remove the code.

Depends on D45612

Differential Revision: https://phabricator.services.mozilla.com/D45613

--HG--
extra : moz-landing-system : lando
2019-10-08 23:52:14 +00:00
Alexander Surkov
9dc56a5bf5 Bug 1587104 - do not pick up accessible name from containing XUL toolbaritem r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48581

--HG--
extra : moz-landing-system : lando
2019-10-09 00:09:47 +00:00
Aaron Klotz
b256fc294a Bug 1586436: Ensure that mscom methods that accept variadic arguments use rvalue references in their arguments; r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D48435

--HG--
extra : moz-landing-system : lando
2019-10-08 20:43:38 +00:00
Alexander Surkov
7544bd8298 Bug 1586836 - remove <xul:textbox> from a11y tests r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D48576

--HG--
extra : moz-landing-system : lando
2019-10-08 17:29:16 +00:00
Andreea Pavel
ab8a9b521f Bug 1388256 - disabled browser_caching_name.js on debug mac and win, linux64 r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D48510

--HG--
extra : moz-landing-system : lando
2019-10-08 16:13:31 +00:00
Ricky Stewart
c010710916 Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=firefox-build-system-reviewers,mshal
(Same content as bad revision https://phabricator.services.mozilla.com/D48230, but with a very small change to config/external/icu/data/moz.build to fix the build breakage.)

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=833f6a69fcac689488a640b43e8e0bdaa086a56c

Differential Revision: https://phabricator.services.mozilla.com/D48409

--HG--
extra : moz-landing-system : lando
2019-10-07 21:15:19 +00:00
Daniel Varga
052ef806b5 Backed out changeset 8d95f2c8867b (bug 1586358) for build bustage with FATAL ERROR PROCESSING MOZBUILD FILE. On a CLOSED TREE
--HG--
extra : rebase_source : 325fbad2455afc7f693087e75fa57dba79f4d86b
2019-10-07 20:22:08 +03:00
Ricky Stewart
940d91af38 Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=nalexander
This patch doesn't remove all references to GENERATED_FILES, but does remove most of them, leaving only those which can't be trivially translated to the new template.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a25230c3992b9c5519ceb351fb37f6b2bf605e

Differential Revision: https://phabricator.services.mozilla.com/D48230

--HG--
extra : moz-landing-system : lando
2019-10-07 15:31:05 +00:00
Sylvestre Ledru
f12b9fa5c3 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D47737

--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Tim Nguyen
91976e6a66 Bug 1586018 - Remove a11y tree tests, reftests and crashtests only related to textbox. r=surkov,emilio
Differential Revision: https://phabricator.services.mozilla.com/D48080

--HG--
extra : moz-landing-system : lando
2019-10-03 18:01:08 +00:00
Alexander Surkov
e670b51391 Bug 1582590 - Clean up unused <textbox type='autocomplete'> platform code. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D46541

--HG--
extra : moz-landing-system : lando
2019-10-03 11:18:53 +00:00
Eitan Isaacson
cc288d94bb Bug 1582619 - Return DocAccessible if doc root element is passed to GetAccessibleOrDescendant. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47365

--HG--
extra : moz-landing-system : lando
2019-10-03 00:31:13 +00:00
Eitan Isaacson
18deeb8110 Bug 1582561 - Don't access lazily created descendants in GetAccessibleOrDescendant. r=Jamie
Lazily creating children might cause us to make layout calls at unsafe times.

Differential Revision: https://phabricator.services.mozilla.com/D47361

--HG--
extra : moz-landing-system : lando
2019-10-03 00:30:06 +00:00
James Teh
d9d82b8278 Bug 1576509: Add a function to announce a message to screen reader users. r=Gijs,yzen
Differential Revision: https://phabricator.services.mozilla.com/D47717

--HG--
extra : moz-landing-system : lando
2019-10-02 05:53:52 +00:00
Morgan Reschenberg
a20612a878 Bug 1584465: Null check parent accessible before attribute check to cover root case. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47488

--HG--
extra : moz-landing-system : lando
2019-09-30 16:23:30 +00:00
Eitan Isaacson
9b2ce1a83d Bug 1584297 - Simplify map element reflow whitespace test. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47325

--HG--
extra : moz-landing-system : lando
2019-09-27 01:51:07 +00:00
Coroiu Cristina
c094fff9aa Backed out changeset ea2c69779571 (bug 1577381) for a11y failures at accessible/tests/mochitest/attributes/test_obj_group.xul on a CLOSED TREE 2019-09-27 08:00:39 +03:00
James Teh
1adf6ac726 Bug 1577381: Correct accessibility exposure for optgroups in content select dropdowns. r=eeejay,NeilDeakin
For remote content documents, select dropdowns (for <select size="1">) are rendered in the parent process using a XUL menupopup.
This means that the accessibility code for HTML selects doesn't apply.

In the menupopup, the optgroup is a sibling of its contained options.
For accessibility, we want to preserve the hierarchy such that the options are inside the optgroup.
We do this using aria-owns on the optgroup item.

This required some tweaks to XULMenuitemAccessible, as it couldn't previously handle grouping Accessibles between the menupopup and its items.

Differential Revision: https://phabricator.services.mozilla.com/D43901

--HG--
extra : moz-landing-system : lando
2019-09-27 02:50:59 +00:00
Sean Feng
660aac23aa Bug 1467970 - Unsupport cross docGroup adoption r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D43135

--HG--
extra : moz-landing-system : lando
2019-09-14 00:09:44 +00:00
Andreea Pavel
51cabe74d0 Bug 1582775 - disabled browser_deck_has_out_of_process_iframe.js on win qr r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D47188

--HG--
extra : moz-landing-system : lando
2019-09-26 03:47:47 +00:00
Eitan Isaacson
b591abf5e0 Bug 1581589 - Return null in GetAccessibleOrContainer for text leafs of unrendered maps. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D47185

--HG--
extra : moz-landing-system : lando
2019-09-26 01:51:45 +00:00
Morgan Reschenberg
33381f2280 Bug 1177014: Modify TransformOffset to correctly report bullet offsets, despite incorrect return from PeekOffset. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D46490

--HG--
extra : moz-landing-system : lando
2019-09-25 02:10:08 +00:00
Hiroyuki Ikezoe
81918ac172 Bug 1582946 - Skip whole test cases in browser_deck_has_out_of_process_iframe.js if fission.autostart pref is locked. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D47031

--HG--
extra : moz-landing-system : lando
2019-09-25 21:17:51 +00:00
Yura Zenevich
710d2ef14f Bug 1503084 - add additional event logging to e10s name tests. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D46972

--HG--
extra : moz-landing-system : lando
2019-09-25 18:24:59 +00:00
Tim Nguyen
b0d1ddb586 Bug 1581956 - Make search-textbox not use the <textbox> tag. r=surkov,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D46219

--HG--
extra : moz-landing-system : lando
2019-09-25 19:12:48 +00:00
Eitan Isaacson
885a031613 Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45604

--HG--
extra : moz-landing-system : lando
2019-09-24 19:28:28 +00:00
Eitan Isaacson
cff449b020 Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45602

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:38 +00:00
Eitan Isaacson
967793da25 Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45601

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:40 +00:00
Eitan Isaacson
1bce54c7cc Bug 1564549 - Implement text navigation natively. r=geckoview-reviewers,Jamie,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45600

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:47 +00:00
Eitan Isaacson
0f147877cd Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45599

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:49 +00:00
Eitan Isaacson
c484dec9b9 Bug 1564549 - Introduce native traveral rule. r=yzen
The rule takes a granularity constant as an argument in the constructor.

Differential Revision: https://phabricator.services.mozilla.com/D45598

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:51 +00:00
Eitan Isaacson
f636c8855c Bug 1564549 - Add action forwarding macro. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45597

--HG--
extra : moz-landing-system : lando
2019-09-23 23:42:53 +00:00
Andrew Halberstadt
898dfb96b4 Bug 1567642 - [lint.flake8] Fix misc flake8 under Python 3 lint issues r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D45417

--HG--
extra : moz-landing-system : lando
2019-09-24 14:44:01 +00:00
Noemi Erli
ecdbbb2a1f Backed out 8 changesets (bug 1564549) for causing failures in browser_all_files_referenced.js CLOSED TREE
Backed out changeset a6b83802832c (bug 1564549)
Backed out changeset 7f38c6ddd009 (bug 1564549)
Backed out changeset 15a754fb192e (bug 1564549)
Backed out changeset 34441585469f (bug 1564549)
Backed out changeset aada27f6ad6e (bug 1564549)
Backed out changeset 103dbf465704 (bug 1564549)
Backed out changeset c38e72058869 (bug 1564549)
Backed out changeset aca91e9add16 (bug 1564549)
2019-09-24 02:38:39 +03:00
Eitan Isaacson
b7427e24a9 Bug 1564549 - Remove AccessFu. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45604

--HG--
extra : moz-landing-system : lando
2019-09-23 21:07:21 +00:00
Eitan Isaacson
11dd6681cd Bug 1564549 - Implement clipboard actions natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45602

--HG--
extra : moz-landing-system : lando
2019-09-23 21:07:08 +00:00
Eitan Isaacson
ef8c8bacd2 Bug 1564549 - Implement set selection natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45601

--HG--
extra : moz-landing-system : lando
2019-09-23 21:07:02 +00:00
Eitan Isaacson
ac01020042 Bug 1564549 - Implement text navigation natively. r=geckoview-reviewers,Jamie,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45600

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:58 +00:00
Eitan Isaacson
85d6a5f093 Bug 1564549 - Implement move and explore by touch natively. r=geckoview-reviewers,yzen,snorp
Differential Revision: https://phabricator.services.mozilla.com/D45599

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:51 +00:00
Eitan Isaacson
37c232bfbf Bug 1564549 - Introduce native traveral rule. r=yzen
The rule takes a granularity constant as an argument in the constructor.

Differential Revision: https://phabricator.services.mozilla.com/D45598

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:49 +00:00
Eitan Isaacson
874de5845e Bug 1564549 - Add action forwarding macro. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45597

--HG--
extra : moz-landing-system : lando
2019-09-23 21:06:40 +00:00
arthur.iakab
b6a627c094 Merge inbound to mozilla-central. a=merge
--HG--
extra : amend_source : 39c72a7f01f9afa5abf7587d732d1e63969cc9da
2019-09-21 13:00:40 +03:00
Dorel Luca
f5e74811ca Merge mozilla-central to mozilla-inbound 2019-09-21 00:58:45 +03:00
Kris Maglione
685d91c901 Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45828

MANUAL PUSH: Cannot update reopened Phabricator revisions.

--HG--
extra : source : 86b3d469b4ff9f22e5757f83450b956a4c769785
extra : histedit_source : 2bf945343632b15eb79cf6b2ddd3ce097ddf70de%2Caec93d9f11bc1c802b63793cd5818530b64e9b4b
2019-09-20 10:18:15 -07:00
Edgar Chen
5bc0854d2b Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45168

--HG--
extra : moz-landing-system : lando
2019-09-20 20:51:25 +00:00
Hiroyuki Ikezoe
5399adbf3a Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov
Differential Revision: https://phabricator.services.mozilla.com/D44951

--HG--
extra : source : 691c50b5729af881fff324bf68b739a3b8da5518
2019-09-20 11:33:00 +00:00
Andreea Pavel
1f18f66226 Backed out 2 changesets (bug 1541256) for failing browser_deck_has_out_of_process_iframe.js on a CLOSED TREE
Backed out changeset 691c50b5729a (bug 1541256)
Backed out changeset fc785139655e (bug 1541256)
2019-09-20 18:15:15 +03:00
Hiroyuki Ikezoe
d04cad22aa Bug 1541256 - Tests for elements' accessibility states in out-of-process iframes in a deck. r=tnikkel,surkov
Differential Revision: https://phabricator.services.mozilla.com/D44951

--HG--
extra : moz-landing-system : lando
2019-09-20 11:33:00 +00:00
Daniel Varga
bc19cdb06d Backed out 3 changesets (bug 1578355) for build bustage at build/src/dom/base/nsSyncLoadService.h:48:21. On a CLOSED TREE
Backed out changeset d50ad759f129 (bug 1578355)
Backed out changeset 339ab54ca471 (bug 1578355)
Backed out changeset 284299dac42c (bug 1578355)
2019-09-20 14:05:12 +03:00
Edgar Chen
5b6fe53148 Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45168

--HG--
extra : moz-landing-system : lando
2019-09-20 10:31:55 +00:00
James Teh
79314daf0b Bug 1316965: Give file inputs an a11y role of GROUPING so screen readers report their label when focus enters them. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D46375

--HG--
extra : moz-landing-system : lando
2019-09-19 04:39:21 +00:00
James Teh
90f724704e Bug 1582323: When a file input has DOM focus, focus the browse button inside it for a11y. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D46386

--HG--
extra : moz-landing-system : lando
2019-09-19 04:34:29 +00:00
Daniel Varga
f0411a344a Backed out 6 changesets (bug 1553804) for browser-chrome failure at browser/base/content/test/general/browser_fullscreen-window-open.js. On a CLOSED TREE
Backed out changeset 86b3d469b4ff (bug 1553804)
Backed out changeset 301e0d883a5f (bug 1553804)
Backed out changeset acff4a663671 (bug 1553804)
Backed out changeset 1574aecf3177 (bug 1553804)
Backed out changeset 3acf056e792e (bug 1553804)
Backed out changeset 1ed250faeb2e (bug 1553804)
2019-09-20 10:09:54 +03:00
Kris Maglione
136131d397 Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45828

--HG--
extra : moz-landing-system : lando
2019-09-20 04:44:02 +00:00
Eitan Isaacson
f7856fcbe6 Bug 1580019 - Refactor nsIAccessiblePivot to a stateless Pivot class. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45253

--HG--
extra : moz-landing-system : lando
2019-09-18 22:23:58 +00:00
Eitan Isaacson
db60a948f1 Bug 1580292 - Check for pruned descendants of reframed body. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45423

--HG--
extra : moz-landing-system : lando
2019-09-11 18:32:07 +00:00
Eitan Isaacson
4b3b42e7be Bug 1578416 - Don't allow children of list item to move before bullet. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45578

--HG--
extra : moz-landing-system : lando
2019-09-12 01:00:15 +00:00
Jonathan Kew
a8d927de19 Bug 1241631 - Don't trim leading whitespace from soft-wrapped lines when getting rendered text for a11y or .innerText. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D45157

--HG--
extra : moz-landing-system : lando
2019-09-17 17:36:13 +00:00
Tim Nguyen
e043df8d78 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 06:22:42 +00:00
Mihai Alexandru Michis
f9580519b8 Backed out changeset e859a5aebb5b (bug 1534455) for causing failures at test_bug437844.xul
--HG--
rename : toolkit/content/widgets/autocomplete-input.js => toolkit/content/widgets/autocomplete.xml
2019-09-17 07:51:36 +03:00
Tim Nguyen
5d8a3da397 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 01:35:25 +00:00
Morgan Reschenberg
6867a0ceea Bug 1580583: Remove faulty assert; not all details items have summaries r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45742

--HG--
extra : moz-landing-system : lando
2019-09-16 20:18:52 +00:00
Eitan Isaacson
16eb76a3c5 Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie
Ultimately Batch from PDocAccessible would be moved to here as well.

Differential Revision: https://phabricator.services.mozilla.com/D37954

--HG--
extra : moz-landing-system : lando
2019-09-13 16:55:05 +00:00
Eitan Isaacson
0293722fcc Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
This is an extension protocol that can be used for platform specific
API (ie. AccessibleWrap methods).

I'm not thrilled with the seperate constructor for the sub-protocol.
This means that the parent won't have the actor upon DocAccessibleParent
construction, and some timing bugs can arise because of the extra round
trip. It would be cool if both actors could be co-created, but that
would require ManagedEndpoint, and for PBrowser to manage them both. I
don't want to expose this to PBrowser.

Differential Revision: https://phabricator.services.mozilla.com/D37955

--HG--
extra : moz-landing-system : lando
2019-09-13 16:55:01 +00:00
Morgan Reschenberg
0b76713b25 Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie
Depends on D45402

Differential Revision: https://phabricator.services.mozilla.com/D45609

--HG--
extra : moz-landing-system : lando
2019-09-13 16:43:58 +00:00
Morgan Reschenberg
8a64fb0963 Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45402

--HG--
extra : moz-landing-system : lando
2019-09-13 16:43:49 +00:00
Masayuki Nakano
f521a40385 Bug 1574852 - part 104: Move TextEditRules::WillInsertText() to TextEditor and make HTMLEditor::WillInsertText() override it r=m_kato
And also this patch moves `TextEditRules::HandleNewLines()` and
`TextEditRules::DontEchoPassword()` to `TextEditor`.

Differential Revision: https://phabricator.services.mozilla.com/D45298

--HG--
extra : moz-landing-system : lando
2019-09-13 02:40:09 +00:00
Dorel Luca
c7aad775a7 Backed out 2 changesets (bug 1565728) for License failure. CLOSED TREE
Backed out changeset 6c30dad5259b (bug 1565728)
Backed out changeset 4369b7203266 (bug 1565728)
2019-09-13 03:16:23 +03:00
Eitan Isaacson
a058d4e8bc Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie
Ultimately Batch from PDocAccessible would be moved to here as well.

Differential Revision: https://phabricator.services.mozilla.com/D37954

--HG--
extra : moz-landing-system : lando
2019-09-12 23:02:01 +00:00
Eitan Isaacson
35496390cd Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
This is an extension protocol that can be used for platform specific
API (ie. AccessibleWrap methods).

I'm not thrilled with the seperate constructor for the sub-protocol.
This means that the parent won't have the actor upon DocAccessibleParent
construction, and some timing bugs can arise because of the extra round
trip. It would be cool if both actors could be co-created, but that
would require ManagedEndpoint, and for PBrowser to manage them both. I
don't want to expose this to PBrowser.

Differential Revision: https://phabricator.services.mozilla.com/D37955

--HG--
extra : moz-landing-system : lando
2019-09-12 23:01:59 +00:00
Dão Gottwald
a355f15d53 Bug 1580822 - a11y focus lost when selecting the first one-off search button or the search settings button. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D45692

--HG--
extra : moz-landing-system : lando
2019-09-12 21:07:39 +00:00
Dorel Luca
f6c45cc8c1 Backed out 2 changesets (bug 1563598) for Mochitest failures on accessible/tests/mochitest/tree/test_formctrl.html. CLOSED TREE
Backed out changeset 968ef845dc64 (bug 1563598)
Backed out changeset d647bd5b0b29 (bug 1563598)
2019-09-13 00:11:58 +03:00
Dorel Luca
7f5e96335e Backed out 2 changesets (bug 1565728) for License failure. CLOSED TREE
Backed out changeset 0d08e4b02c17 (bug 1565728)
Backed out changeset 4fe176e80602 (bug 1565728)
2019-09-12 23:48:50 +03:00
Morgan Reschenberg
5523b6c1ff Bug 1563598: Display 'container-live' attribute on descendents of implicitly-live elements. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45609

--HG--
extra : moz-landing-system : lando
2019-09-12 20:01:50 +00:00
Morgan Reschenberg
dd9d61742f Bug 1563598: Change output elements to have statusbar role instead of section role. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D45402

--HG--
extra : moz-landing-system : lando
2019-09-12 16:13:19 +00:00
Eitan Isaacson
28c79c116e Bug 1565728 - Introduce PDocAccessiblePlatformExt for Android. r=Jamie
Ultimately Batch from PDocAccessible would be moved to here as well.

Differential Revision: https://phabricator.services.mozilla.com/D37954

--HG--
extra : moz-landing-system : lando
2019-09-12 20:10:55 +00:00
Eitan Isaacson
82aa8a18ca Bug 1565728 - Introduce PDocAccessiblePlatformExt. r=Jamie
This is an extension protocol that can be used for platform specific
API (ie. AccessibleWrap methods).

I'm not thrilled with the seperate constructor for the sub-protocol.
This means that the parent won't have the actor upon DocAccessibleParent
construction, and some timing bugs can arise because of the extra round
trip. It would be cool if both actors could be co-created, but that
would require ManagedEndpoint, and for PBrowser to manage them both. I
don't want to expose this to PBrowser.

Differential Revision: https://phabricator.services.mozilla.com/D37955

--HG--
extra : moz-landing-system : lando
2019-09-12 20:10:51 +00:00
Yura Zenevich
10b6f4b09f Bug 1503084 - added a wait for NAME_CHANGE event after aria-label removal. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D45361

--HG--
extra : moz-landing-system : lando
2019-09-12 19:29:26 +00:00
Hiroyuki Ikezoe
6f114d0542 Bug 1541705 - Try to see whether the target frame is scrolled out of view in out-of-process iframe if we couldn't walk up the frame tree. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D44423

--HG--
extra : moz-landing-system : lando
2019-09-12 08:12:49 +00:00
Morgan Reschenberg
107633cba4 Bug 1277201: Fire a STATE_CHANGE event when a details element is opened or closed. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D44872

--HG--
extra : moz-landing-system : lando
2019-09-10 16:16:53 +00:00
Mike Shal
f8f5fce637 Bug 1496746 - Remove VPATH; r=glandium
Having a full VPATH for the srcdir sometimes causes make to grab the
wrong prerequisite for a rule, in particular if we have a file in the
srcdir and also generate a file of the same name in the objdir. We don't
really need VPATH anymore though, since most of the information comes
from mozbuild, where we can explicitly list the path to the srcdir or
objdir as necessary.

Differential Revision: https://phabricator.services.mozilla.com/D42968

--HG--
extra : moz-landing-system : lando
2019-09-09 17:44:47 +00:00
Toshihito Kikuchi
18aab300b5 Bug 1576697 - Use LauncherResult in WinHeaderOnlyUtils.h instead of WindowsErrorResult. r=aklotz
`WindowsErrorResult` is a class to hold either a value or a Windows error
code based on the `Result` template.  We also have `LauncherResult` for the
same purpose, which was introduced as a part of the launcher process feature
afterward.  The difference is `LauncherResult` holds a filename and line
number along with an error code.

This patch integrates LauncherResult.h into WinHeaderOnlyUtils.h so that we
can use `LauncherResult` more broadly.

Differential Revision: https://phabricator.services.mozilla.com/D44512

--HG--
extra : moz-landing-system : lando
2019-09-07 18:17:45 +00:00
Eitan Isaacson
0bf1f3d15c Bug 1578282 - Use flattened tree parent when getting inserted node container. r=Jamie
This assures that a node that has already been inserted in a shadow root
subtree does not get erroneously reinserted into the top container.

Differential Revision: https://phabricator.services.mozilla.com/D44880

--HG--
extra : moz-landing-system : lando
2019-09-06 00:24:21 +00:00
James Teh
0b797e7d2e Bug 1578604: accessible/tests/mochitest/actions/test_general.xul: Don't require the focus event on menulist to be unique. r=eeejay
focusChecker expects a unique focus event.
However, there might still be pending focus events not caught by previous tests.
Therefore, we specify our own checker so we can disable the uniqueness requirement.
This is a little ugly, but it's rather difficult to work around this within this declarative framework without potentially breaking other tests.

Differential Revision: https://phabricator.services.mozilla.com/D44615

--HG--
extra : moz-landing-system : lando
2019-09-05 20:38:32 +00:00
James Teh
43953a25a3 Bug 1578311: Don't prune a trailing HTML br child from the accessibility tree. r=eeejay
Pruning these meant that `<span><br></span>` wasn't represented in the tree or rendered text at all.
This meant that lines were merged together in NVDA browse mode; e.g. in CI build logs on Gitlab.

The reason we started pruning these is that they were causing invalid line offsets to be returned for affected lines (bug 899433).
This patch also fixes this problem in HyperTextAccessible::FindOffset.

Differential Revision: https://phabricator.services.mozilla.com/D44815

--HG--
extra : moz-landing-system : lando
2019-09-05 23:41:36 +00:00
Gerald Squelart
95f77c2409 Bug 1576819 - Use PROFILER_ADD_MARKER{,_WITH_PAYLOAD} everywhere - r=gregtatum
All calls to `profiler_add_marker()` (outside of the profilers code) are
now replaced by either:
- `PROFILER_ADD_MARKER(name, categoryPair)`
- `PROFILER_ADD_MARKER_WITH_PAYLOAD(name, categoryPair, TypeOfMarkerPayload,
                                    (payload, ..., arguments))`

This makes all calls consistent, and they won't need to prefix the category pair
with `JS::ProfilingCategoryPair::`.

Also it will make it easier to add (and later remove) internal-profiling
instrumentation (bug 1576550), and to replace heap-allocated payloads with
stack-allocated ones (bug 1576555).

Differential Revision: https://phabricator.services.mozilla.com/D43588

--HG--
extra : moz-landing-system : lando
2019-09-04 07:56:51 +00:00
James Teh
187e20b6ae Bug 1578140: Use nsXULElement::Click for DoAction on XULLabelAccessible so it works for labels inside buttons. r=eeejay
For labels inside buttons, The base implementation of DispatchClickEvent doesn't fire a command event on the button.
To fix this, override DispatchClickEvent to use nsXULElement::Click, which does fire a command event on the button.

Differential Revision: https://phabricator.services.mozilla.com/D44410

--HG--
extra : moz-landing-system : lando
2019-09-03 19:11:35 +00:00
Tom Ritter
7a1a59b4a2 Bug 1577288 - Re-enable the ally tests by backing out ff9a610b3793 r=jmaher
Depends on D43822

Differential Revision: https://phabricator.services.mozilla.com/D43823

--HG--
extra : moz-landing-system : lando
2019-08-28 19:26:12 +00:00
James Teh
49d8452868 Bug 1574286: When adding a remote child document, if the parent proxy doesn't exist yet, defer adding until it does. r=eeejay
For OOP iframes, sometimes, AddChildDoc gets called before the embedder sends us the OuterDocAccessible.
Previously, we crashed when this occurred.
Now, we add the child when the OuterDocAccessible proxy gets created later.

Differential Revision: https://phabricator.services.mozilla.com/D42798

--HG--
extra : moz-landing-system : lando
2019-08-30 03:32:55 +00:00
Eitan Isaacson
1a3b5051f6 Bug 1576549 - Use bounds in bundle argument instead of getter method. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D44041

--HG--
extra : moz-landing-system : lando
2019-08-30 01:29:31 +00:00
Emilio Cobos Álvarez
a98a4dc71b Bug 1577258 - Explicitly flush layout in an a11y test. r=eeejay
We have an optimization to avoid an expensive reflow from SetFullZoom, see
mSuppressResizeReflow[1].

That was done because we used to do a full synchronous reflow right after. We no
longer do that, but due to that member we also don't invalidate!

My second patch in this bug changes the behavior of that flag so that we don't
synchronously reflow, but we do invalidate. So in turn this test before the
change wasn't really testing the zoomed code-path since it was using the clean
layout from before the zoom operation.

a11y getBounds and co. don't flush layout (they probably should), but since with
my patch we dirty the frame tree, and dirty frames return bogus offsets, the
test starts failing.

Flush layout explicitly to ensure we're testing the zoomed code path.

[1]: https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/layout/base/nsPresContext.cpp#952

Differential Revision: https://phabricator.services.mozilla.com/D43952

--HG--
extra : moz-landing-system : lando
2019-08-29 21:25:12 +00:00
Eitan Isaacson
c7e39034b6 Bug 1576690 - Prune de-slotted accessibles, or relocate them to new slot. r=Jamie,emilio
This patch does several things:
 1. If there is a change to a host or a slot, check the slottable
    elements to see if they are rendered in the tree. Remove them if not.
 2. Check slot elements' fallback content if it is rendered and remove if
    not.
 3. Allow accessibles to be reinserted into a different parent or index.

Differential Revision: https://phabricator.services.mozilla.com/D43489

--HG--
extra : moz-landing-system : lando
2019-08-29 16:14:48 +00:00
Maliha Islam
f35ba542fb Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D43293

--HG--
extra : moz-landing-system : lando
2019-08-29 06:39:28 +00:00
Maliha Islam
829cc15e27 Bug 1522383 - Assign gridcell role to cells inside a table with grid role, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D43858

--HG--
extra : moz-landing-system : lando
2019-08-29 10:09:48 +00:00
Dorel Luca
efca664ecd Backed out changeset 7f1703036acf (bug 1357071) for Browser-chrome failures on accessible/tests/browser/e10s/browser_caching_value.js 2019-08-29 05:49:07 +03:00
Maliha Islam
ea886244a0 Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D43293

--HG--
extra : moz-landing-system : lando
2019-08-29 00:18:08 +00:00
Eitan Isaacson
df40116d6f Bug 1572829 - Remove explicit children too when node has a shadow root. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D43488

--HG--
extra : moz-landing-system : lando
2019-08-28 23:02:19 +00:00
Eitan Isaacson
b62f296126 Bug 1576709 - Add crash test for bug 1572811. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D43499

--HG--
extra : moz-landing-system : lando
2019-08-26 23:12:27 +00:00
Eitan Isaacson
8593d6d908 Bug 1576696 - Add a '0x' prefix to hex pointer values in logging nodes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D43485

--HG--
extra : moz-landing-system : lando
2019-08-27 02:02:01 +00:00
kriswright
be316b6bf9 Bug 1573992 - Convert 3 ui.key.* prefs to static prefs. r=njn
Converts ui.key.generalAccessKey, ui.key.chromeAccess, and ui.key.contentAccess to static prefs. Updates usages.

Differential Revision: https://phabricator.services.mozilla.com/D42392

--HG--
extra : moz-landing-system : lando
2019-08-26 20:25:42 +00:00
Emilio Cobos Álvarez
f4fb9ab137 Bug 1576194 - Remove kDisplayKTable. r=mats
It doesn't represent anything useful anymore.

Differential Revision: https://phabricator.services.mozilla.com/D43262

--HG--
extra : moz-landing-system : lando
2019-08-23 15:52:05 +00:00
Alex Vincent
cec0c5cbdb Bug 1508169, Remove performAction* from nsITreeView.idl in mozilla-central. r=peterv, johannh
performAction, performActionOnRow and performActionOnCell are methods of the
nsITreeView interface that are never called.  This is to remove these methods.
A comm-central patch will be along shortly.

Differential Revision: https://phabricator.services.mozilla.com/D39273
2019-08-24 00:49:55 +02:00
Gautham Velchuru
0b2b2ab7b2 Bug 1357100 - change implicit val for aria-level on a heading to 2 r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D35616

--HG--
extra : moz-landing-system : lando
2019-08-23 01:28:13 +00:00
Eitan Isaacson
47656aa608 Bug 1572811 - Don't fire text change events if container accessible has no frame. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42199

--HG--
extra : moz-landing-system : lando
2019-08-22 20:28:38 +00:00
Mike Hommey
66d7fe943e Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D42765

--HG--
extra : moz-landing-system : lando
2019-08-21 12:25:42 +00:00
Maliha Islam
f6e1118c76 Bug 1540813 - Support new ARIA roles insertion and deletion, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42911

--HG--
extra : moz-landing-system : lando
2019-08-21 20:36:39 +00:00
Olli Pettay
d6e4ed531f Bug 1547176, try to make browser_test_zoom_text.js more resilient to scheduling changes, r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D42486

--HG--
extra : moz-landing-system : lando
2019-08-21 15:51:24 +00:00
Samuel Thibault
55522b7f0f Bug 1574950 - atk: Set returned values to -1 in case of errors, as newly documented in atk r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42515

--HG--
extra : moz-landing-system : lando
2019-08-20 22:42:49 +00:00
Mats Palmgren
2525944e34 Bug 1574994 part 1 - Remove/replace display:-moz-inline-grid and -moz-inline-stack in tests. r=emilio
I replaced the values with -moz-inline-box in the crashtests
rather than removing them.  I think they are still valuable
after replacing the display value.

Differential Revision: https://phabricator.services.mozilla.com/D42551

--HG--
extra : moz-landing-system : lando
2019-08-19 21:19:04 +00:00
Dão Gottwald
26f3378b01 Bug 1561533 - Increase quantumbar input size on focus and visually integrate the view. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D42149

--HG--
extra : moz-landing-system : lando
2019-08-20 15:14:25 +00:00
James Teh
bda9b87fdb Bug 1574428: IAccessible2_2::relationTargetsOfType: Support 0 for all targets and fix off-by-one error. r=MarcoZ
1. As per the spec, if maxTargets is 0, return all targets.
2. Where maxTargets > 0, fix the loop condition so it doesn't incorrectly fetch one more target than requested.

Differential Revision: https://phabricator.services.mozilla.com/D42446

--HG--
extra : moz-landing-system : lando
2019-08-19 05:58:49 +00:00
Noemi Erli
6b80a780ed Backed out changeset 067d47e20a94 (bug 1572811) for causing failures in CharacterData.cpp CLOSED TREE 2019-08-15 20:30:45 +03:00
Eitan Isaacson
212dd05514 Bug 1572811 - Explicitly check for removed anonymous children in reframe. r=Jamie
The DOM mutation observer method is called during frame destruction
which is not a good state to be in when constructing and dispatching events.

Differential Revision: https://phabricator.services.mozilla.com/D41825

--HG--
extra : moz-landing-system : lando
2019-08-15 16:06:33 +00:00
Mats Palmgren
a74c7c2d43 Bug 1574123 - Use nsLayoutUtils::GetMarkerFrame() more to avoid manual null-checks. r=emilio
(This basically addresses the review comments that I missed in
bug 1105868 part 4. My bad.)

Differential Revision: https://phabricator.services.mozilla.com/D42134

--HG--
extra : moz-landing-system : lando
2019-08-15 14:23:37 +00:00
Alexander Surkov
cfb8c8aef7 Bug 1573337 - remove XBL anon content filtering support from accessible tree traversal r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42022

--HG--
extra : moz-landing-system : lando
2019-08-15 00:58:28 +00:00
Marco Zehe
de9c156fb7 Bug 1501182 - Expose WAI-ARIA landmarks as landmark roles through accessibility APIs, r=Jamie
This change will bring us on par with what Chrome does. However, if the author makes an error in applying a landmark role to an interactive element, or other element where the landmark role is illegal, as defined in the [WAI-ARIA in HTML specification section 2](https://www.w3.org/TR/html-aria/#document-conformance-requirements-for-use-of-aria-attributes-in-html), the accessible properties will now be that of the landmark role, no longer that of the native host language element. This might make some elements less accessible due to author error than before, but we currently do not know of examples in the wild that actually expose this problem. This could only be solved by applying the rules from said table also in the user agents, but that is not specified anywhere.

Differential Revision: https://phabricator.services.mozilla.com/D41923

--HG--
extra : moz-landing-system : lando
2019-08-15 01:25:56 +00:00
Mats Palmgren
53321dfa54 Bug 1105868 part 4 - Accessibility support for inline list-items. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D39833

--HG--
extra : moz-landing-system : lando
2019-08-14 14:37:16 +00:00
Marco Zehe
d30cbb2973 Bug 1573750 - If header or footer elements are descendants of the main element, do not expose them as landmarks, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D41893

--HG--
extra : moz-landing-system : lando
2019-08-14 06:10:24 +00:00
James Teh
a316be03d1 Bug 1567377: Correct a11y semantics for address bar. r=dao
For accessibility, the address bar is now exposed as a parent combo box which contains the input and the results list.
The combo box role on urlbarView-body-inner is no longer needed and has therefore been removed.
This means screen readers no longer report an extraneous combo box whenever the results list is opened.

Differential Revision: https://phabricator.services.mozilla.com/D40917

--HG--
extra : moz-landing-system : lando
2019-08-12 14:06:27 +00:00