This adds a new Suggest backend for ML-based suggestions called
`SuggestBackendMl`. Before, with the JS and Rust backends, only one backend was
enabled at a time, but both the ML and Rust backends can be enabled at the same
time since we will want to serve suggestions from both for the foreseeable
future. Features can support ML suggestions by implementing the new
`BaseFeature.mlIntent` getter and handling ML suggestions in `makeResult()`.
Each feature can decide whether it supports ML suggestions and whether they
should be preferred over Rust suggestions.
I've updated the Yelp feature to hook into this, since Yelp suggestions are
supported by the ML model that Chidam is working on. If ML is enabled, then the
feature will only serve ML suggestions. I'm not sure if that's what we want long
term, but for now that will make it clear to people which backend is being used
while we develop this feature.
The `quickSuggestMlEnabled` variable/pref determines whether the ML backend is
enabled. The `yelpMlEnabled` variable/pref determines whether Yelp ML
suggestions are enabled. We can create similar variable/prefs for each feature
that supports ML suggestions so that they can be toggled independently of each
other.
Other changes:
Move the `is_sponsored` logic out of the Rust backend and into the provider.
Otherwise it would need to be duplicated in the ML backend too.
Depends on D224523
Differential Revision: https://phabricator.services.mozilla.com/D226736
To fix the issues of the touch target for search engine icon
from edit toolbar the height changed from 40 to 48.
And to keep the same visual as before the top margin was changed
from 8 to 4.
Differential Revision: https://phabricator.services.mozilla.com/D220558
Based on the discussion in the bug, the specific behavior tested in this file is not reliable and might also change in the future.
We have cross browser tests already asserting simpler caching scenarios also added in D224506, which should be sufficient here.
Differential Revision: https://phabricator.services.mozilla.com/D226637
The SchemeSupported has been added to the org.freedesktop.portal.OpenURI interface.
That should fix problems with wrong uri scheme handling by checking whenever system
is able to open specified scheme.
Differential Revision: https://phabricator.services.mozilla.com/D225771
Automatic update from web-platform-tests
Bump maximum video frame size by one bit.
This increases the maximum canvas size from 268,435,456 or roughly
16384x16384 to 536,870,911 or roughly 23170x23170. This increase
still allows us to represent up to 8 bytes per pixel (which matches
our largest pixel formats) without overflowing a uint32_t.
This also updates the file to use inline constexpr per the
presubmit check and adds tests for these allocation limits.
Fixed: 374807001
Change-Id: I7eef8b488fa758bfcd0202917469d585724e23ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5955549
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372466}
--
wpt-commits: 9220b4d4810e89642f7b21609cee40de875ebce8
wpt-pr: 48766
Automatic update from web-platform-tests
Enforce Noopener on Cross-Site Blob URL Navigations
To align Chrome with WebKit behavior, Chromium will enforce noopener
on navigations to Blob URLs where the corresponding site is
cross-site to the top-level site performing the window.open.
This ensures that a null handle is returned when `window.open` is
performed regardless of if the navigation succeeded.
Design Doc:
https://docs.google.com/document/d/1Xk73RLlLgfVw1p2tYBGqlP7ROQxaMh6kxfusSMm9exM/edit?usp=sharing
Bug: 361751872
Change-Id: I62316cf979629f5be26bbec708c76057f1e2ad80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887349
Commit-Queue: Janice Liu <janiceliu@chromium.org>
Reviewed-by: Andrew Williams <awillia@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Janice Liu <janiceliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372255}
--
wpt-commits: 2f200e8682867cad45d67e6b78101f77308e055b
wpt-pr: 48759
Automatic update from web-platform-tests
webusb: Use [PassAsSpan] to handle BufferSource arguments
This change simplifies the implementation of WebUSB methods which accept
a BufferSource argument by using the [PassAsSpan] WebIDL attribute.
Using this requires a behavior change: Passing a detached buffer is now
no longer fatal (except when it causes other argument validation errors)
because a detached buffer turns into an empty span. I think this is a
safe change to make because it matches the WebIDL rules for handling
detached buffers (throwing a specific error was unspecified behavior)
and this case is developer error, so sites shouldn't be depending on it.
Change-Id: I8af158d51b1760625984f697eac880ecd808d13b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924242
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372209}
--
wpt-commits: e439383c09646be4bbdf037c5b5624aa91bf8dec
wpt-pr: 48613
Automatic update from web-platform-tests
Attempt to de-flake web-share and web-bluetooth tests.
These tests are flaking after a refactor to get them to work with
headless mode. This CL refactors them again to use remote context
executors. This CL also ensures that the frames are live before
attempting to give them user activation by clicking.
Bug: 374384731
Bug: 374376117
Change-Id: I0188d0117b6a7ba69e2ad30b2558e81e8c256f1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954504
Reviewed-by: Andrew Verge <averge@chromium.org>
Commit-Queue: Liam Brady <lbrady@google.com>
Cr-Commit-Position: refs/heads/main@{#1372175}
--
wpt-commits: be00d61dbd576e02219a010f3c4954c8fb541f21
wpt-pr: 48757
Automatic update from web-platform-tests
moveBefore: fire focusout/focusin when moving focused element
If the moved element has focus within its tree, we fire focusout on
the old parent, and focusin on the new parent.
Note that this focusin might be fired on an inert subtree. We rely on
the focus fixup during the rendering step to correct the focus in this
event, which would fire a subsequent focusout on the previously focused
element, all the way up the tree.
Bug: 40150299
Change-Id: I6ce0c489bd498a4a56067253be2d9c0c32d38387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937967
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372142}
--
wpt-commits: 1a169720a30eb368045c6c2febf1beeccd374b95
wpt-pr: 48754
Automatic update from web-platform-tests
webnn: Support scalar MLTensors on CoreML
Previously, passing a scalar MLTensor to dispatch() would hit a CHECK
A scalar MLTensor is now represented as a one-element MLMultiArray,
which matches what we do on Windows
Bug: 367755362
Change-Id: I72c1bf3abfc69de038554e69b4b8990e361d1bfe
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950527
Commit-Queue: Weizhong Xia <weizhong@google.com>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Auto-Submit: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372102}
--
wpt-commits: 9aab5a4f0591c4cf520b49f8bd810186a32a5ce8
wpt-pr: 48755
Automatic update from web-platform-tests
Fire input and change for customizable select
Calling HTMLOptionElement::SetSelected doesn't fire input or change
events, so this patch changes the mouse/keyboard code in
HTMLOptionElement to call other methods on HTMLSelectElement which fire
those events.
Fixed: 374241712
Change-Id: Ibb87f73ab570201e669960ea269f7e688fed6569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5943703
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372115}
--
wpt-commits: 6575bab107aec3b8a74ad03528081aacc69b0dbc
wpt-pr: 48739
Automatic update from web-platform-tests
[Partitioned Popins] Add third-party cookie blocked tests
Before we go ahead and add requestStorageAccess support, we should
verify behavior when 3pc are blocked.
Explainer: https://explainers-by-googlers.github.io/partitioned-popins/
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/ApU_zUmpQ2g/
Bug: 340606651
Change-Id: I65ce0ff708b8c44f34561fb104fc9e7891eb44e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954365
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Sandor «Alex» Major <sandormajor@google.com>
Reviewed-by: Sandor «Alex» Major <sandormajor@google.com>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372104}
--
wpt-commits: 19115773952525ad8ac3282b86d0477a50d0b59b
wpt-pr: 48753
