This is being used instead of a self-defined Browser.timeout.
MozReview-Commit-ID: 5zAqI38AdHs
--HG--
extra : rebase_source : 1d47dd27db65cde30f5b8b6e7fd38c18fc67243e
Provide some guidance on how to resolve the common
error: can't find crate for `std`
when cross-compiling rust code. This most commonly comes up
with the Android build.
MozReview-Commit-ID: 8PKKt7tf1KS
--HG--
extra : rebase_source : 5d18bb3a2ef8b3c4c5700b87c4a899b26160999d
`generateUUID()` returns an `nsID`, which is not exactly the same as a
UUID. `nsID`s can be converted to strings using `toString()`, but if
you use `JSON.stringify()`, they become `{}`. Object comparison in JS
performs identity comparison, which would be useless even if the UUIDs
were sensible, which they aren't. As a result, trying to sync keyrings
always failed, because it always seemed like UUIDs had changed, even
when they hadn't.
Because it never occurred to me that UUIDs wouldn't be strings, I
never even wrote a test for this. Correct this, and fix the test.
Thanks to :vasilica_mihasca and :markh for reporting and diagnosing this.
MozReview-Commit-ID: EthxkFFwRbQ
--HG--
extra : rebase_source : 7b2a258d85bf8aab2bf9895e3a8cac9d34ab8435
I didn't realize this file was here when I updated kinto.js to 6.0.0.
MozReview-Commit-ID: 4G1cplpz4r5
--HG--
extra : rebase_source : 228ce612db2c7d648d82b541f9b01a4e96e285b4
Change FirefoxAdapter definitively to require an externally-managed
Sqlite connection in order to function. This connection must be
produced by calling an openConnection() static method, which does the
work of initializing the tables and schema. Passing any other
connection is wrong, but won't be detected at runtime, and might even
work depending on the previous state of the database. Future work
might define a new KintoSqliteConnection type that can only be
produced by this method, so that it's impossible to create an
uninitialized Kinto database.
This change, since it moves Sqlite connections out of the
FirefoxAdapter, also means that the path option is no longer handled
or provided with a default. This means that the previous default,
"kinto.sqlite", is now preserved in a bunch of places all over the
codebase. This is unfortunate, but a migration is outside the scope of
this patch.
MozReview-Commit-ID: BKJqPR3jOTq
--HG--
extra : rebase_source : 91e0027890ac5fd0ba683abddc23e268f672d169
A subtest's cleanup function only runs at the very end, after *all* subtests have finished. This means that we cannot use it to close the test tabs if we want to reuse the tab variables during following subtests. If we did, we'd be leaking those previous tabs, meaning they remain open at the end of the test and cause possible problems for following tests as well as lots of "Unable to restore focus" messages in the log.
MozReview-Commit-ID: H87JQ5gcIAg
--HG--
extra : rebase_source : 5e870acba4c8ee05557f1ac0175bda12606b4e28
So far still cannot find the reason of causing exception. To add more
debug information to make sure it is not permssion problem.
MozReview-Commit-ID: 7hhU7Et64Qs
--HG--
extra : rebase_source : 84ac7c066468bf613afe0513b2ce00081e16f62c
Fennec has touch support, so enabling
"layout.accessiblecaret.enabled_on_touch" in all.js is sufficient.
MozReview-Commit-ID: 4Aa3g5eqt2F
--HG--
extra : rebase_source : c5fe085fe3d643dcf9f9a3732986954032566837
This introduces a new capability, `moz:profile`, which contains the path
to the currently used profile directory.
MozReview-Commit-ID: FKF4Hde3tF9
--HG--
extra : rebase_source : 207fce0eec9c74eb4d1218f0f088e6a05ae7a7ba
The WebDriver specification says that any proprietary capabilities
should be defined as so called extension capabilities, which means we
must prefix them with `moz:`.
Even though the `processId` capability is removed, this change is
backwards compatible because a new property `Marionette.process_id`
is introduced that looks for `moz:processID` and `processId` in order
when starting a new session.
MozReview-Commit-ID: ChkC6QTklzC
--HG--
extra : rebase_source : cffa52b1e6407edaf91bb21afebaa441a208f705
Notes:
* In CSSAlignUtils.h, I'm just adding a forward-decl for a type used there.
* RubyUtils.h needs to #include nsIFrame.h -- a forward-declare won't
suffice -- because it makes a nsIFrame method-call ("aFrame->GetType()").
* ScrollSnap.h uses the "Maybe" type and a unit defined in
nsIScrollableFrame.h; hence it needs both of those headers.
MozReview-Commit-ID: KuhJVh9RTjZ
--HG--
extra : rebase_source : 062c1abfe9a1efeb7e241f38302c140075d2ae88
These newly-included headers' types are all used directly in the affected files.
MozReview-Commit-ID: 5NEA1QhSJKN
--HG--
extra : rebase_source : 3a9244fcb2a074df1c929de800ddd6cbc1f730e8
(The only reason this isn't triggering a compile error is due to .cpp files'
"using namespace mozilla" getting haphazardly shared via unified builds.)
MozReview-Commit-ID: 1zhJueMWOav
--HG--
extra : rebase_source : d08f18573d823968f654491e61428aa70a4c217c
This adds 2 "using namespace mozilla" (to provide various types),
and 2 "using namespace mozilla::gfx" (to provide mozilla::gfx::DrawTarget).
MozReview-Commit-ID: 2bXbMlr4Dbn
--HG--
extra : rebase_source : 9884419f08529469f23e3fc306ce6e4c57640f0d
The class definition (in the header file) is already inside the namespace. But
the method implementations are not (until now), and they've only been compiling
successfully thanks to a "using namespace mozilla" that this file was picking
up from another .cpp file, via unified builds.
MozReview-Commit-ID: ImRBpAVA0en
--HG--
extra : rebase_source : 291e2777187ef9af17e17eecc5e48eb27dd111ec