2

.github/workflows/scripts/linux/build-dependencies-qt.sh

@@ -25,7 +25,7 @@ LIBBACKTRACE=ad106d5fdd5d960bd33fae1c48a351af567fd075
 LIBJPEGTURBO=3.1.2
 LIBPNG=1.6.53
 LIBWEBP=1.6.0
-NVENC=13.0.19.0
+NVENC=11.1.5.3
 SDL=SDL3-3.4.0
 QT=6.10.1
 QTAPNG=1.3.0
@@ -57,7 +57,7 @@ e4ab7009bf0629fd11982d4c2aa83964cf244cffba7347ecd39019a9e38c4564  libwebp-$LIBWE
 082cbf5f429e0d80820f68dc2b507a94d4cc1b4e70817b119bbb8ec6a69584b8  $SDL.tar.gz
 452a1a290bd0cf18737fad0057dc17b7fdf10a73eda2d6d4f31ba04fda25ef2c  libpng-$LIBPNG-apng.patch.gz
 537512904744b35e232912055ccf8ec66d768639ff3abe5788d90d792ec5f48b  lz4-$LZ4.tar.gz
-13da39edb3a40ed9713ae390ca89faa2f1202c9dda869ef306a8d4383e242bee  nv-codec-headers-$NVENC.tar.gz
+2974b91062197e0527dffa3aadd8fe3bfa6681ae45f5ff9181bc0ca6479abd59  nv-codec-headers-$NVENC.tar.gz
 c465aa56757e7746ac707f582b6e2d51546569a4a2488c1172fb543aa5fdfc2c  vulkan-sdk-$VULKAN.tar.gz
 eb33e51f49a15e023950cd7825ca74a4a2b43db8354825ac24fc1b7ee09e6fa3  zstd-$ZSTD.tar.gz
 5a6226f7e23db51fdc3223121eba53f3f5447cf0cc4d6cb82a3a2df7a65d265d  qtbase-everywhere-src-$QT.tar.xz

bin/resources/GameIndex.yaml

@@ -2075,8 +2075,6 @@ SCAJ-20128:
 SCAJ-20129:
   name: "Ponkotsu Roman Daikatsugeki Bumpy Trot"
   region: "NTSC-Unk"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -7616,8 +7614,6 @@ SCKA-20058:
   name: "액션 로망 범피 트롯"
   name-en: "Action Romance Bumpy Trot"
   region: "NTSC-K"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -24781,11 +24777,6 @@ SLES-53820:
 SLES-53821:
   name: "Radio Helicopter II"
   region: "PAL-E"
-  patches:
-    9A695202:
-      content: |-
-        comment=Patch that nops a branch instruction causing a freeze.
-        patch=1,EE,001799AC,word,00000000
 SLES-53824:
   name: "Trapt"
   region: "PAL-E"
@@ -25587,8 +25578,6 @@ SLES-54137:
 SLES-54138:
   name: "Steambot Chronicles"
   region: "PAL-E"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -26239,8 +26228,6 @@ SLES-54333:
 SLES-54335:
   name: "Steambot Chronicles"
   region: "PAL-F"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -35866,8 +35853,6 @@ SLPM-60255:
   name-sort: "ぽんこつろまんだいかつげきばんぴーとろっと [たいけんばん]"
   name-en: "Ponkotsu Roeman Daikatsugeki Bumpy Trot [Trial]"
   region: "NTSC-J"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -35939,8 +35924,6 @@ SLPM-60266:
   name-sort: "ぽんこつろまんだいかつげきばんぴーとろっと [たいけんばん]"
   name-en: "Ponkotsu Roeman Daikatsugeki Bumpy Trot [Trial]"
   region: "NTSC-J"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -40094,11 +40077,6 @@ SLPM-62624:
   name-sort: "ぷちこぷたー2"
   name-en: "Petit Copter 2"
   region: "NTSC-J"
-  patches:
-    9A695202:
-      content: |-
-        comment=Patch that nops a branch instruction causing a freeze.
-        patch=1,EE,001799B8,word,00000000
 SLPM-62625:
   name: "鬼浜爆走愚連隊 激闘編"
   name-sort: "おにはまばくそうぐれんたい げきとうへん"
@@ -59846,8 +59824,6 @@ SLPS-25457:
   name-sort: "ぽんこつろまんだいかつげきばんぴーとろっと"
   name-en: "Ponkotsu Roeman Daikatsugeki Bumpy Trot"
   region: "NTSC-J"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -61252,8 +61228,6 @@ SLPS-25683:
   name-sort: "ぽんこつろまんだいかつげきばんぴーとろっと [Irem COLLECTION]"
   name-en: "Ponkotsu Roman Daikatsugeki Bumpy Trot [Irem Collection]"
   region: "NTSC-J"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -71386,8 +71360,6 @@ SLUS-21344:
   name: "Steambot Chronicles"
   region: "NTSC-U"
   compat: 5
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -74929,8 +74901,6 @@ SLUS-28059:
 SLUS-28061:
   name: "Steambot Chronicles [Trade Demo]"
   region: "NTSC-U"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.
@@ -75709,8 +75679,6 @@ SLUS-29185:
 SLUS-29188:
   name: "Steambot Chronicles [Regular Demo]"
   region: "NTSC-U"
-  roundModes:
-    eeRoundMode: 0 # Fixes broken load triggers.
   gsHWFixes:
     getSkipCount: "GSC_IRem"
     halfPixelOffset: 2 # Aligns effects.

pcsx2-gsrunner/test_check_dumps.py

@@ -184,7 +184,7 @@ if __name__ == "__main__":
     args = parser.parse_args()
     MAX_DIFF_FRAMES = args.maxframes
 
-    outfile = open(args.outfile, "w", encoding="utf-8")
+    outfile = open(args.outfile, "w")
     write(FILE_HEADER)
 
     if not check_regression_tests(os.path.realpath(args.baselinedir), os.path.realpath(args.testdir)):

pcsx2-qt/Debugger/Breakpoints/BreakpointDialog.cpp

@@ -123,11 +123,6 @@ void BreakpointDialog::accept()
 			bp->cond.expression = expr;
 			bp->cond.expressionString = m_ui.txtCondition->text().toStdString();
 		}
-		else
-		{
-			bp->hasCond = false;
-			bp->cond = {};
-		}
 	}
 	if (auto* mc = std::get_if<MemCheck>(&m_bp_mc))
 	{
@@ -164,11 +159,6 @@ void BreakpointDialog::accept()
 			mc->cond.expression = expr;
 			mc->cond.expressionString = m_ui.txtCondition->text().toStdString();
 		}
-		else
-		{
-			mc->hasCond = false;
-			mc->cond = {};
-		}
 
 		int condition = 0;
 		if (m_ui.chkRead->isChecked())

pcsx2-qt/Settings/BIOSSettingsWidget.ui

@@ -135,7 +135,7 @@
    <item>
     <widget class="QGroupBox" name="groupBox_2">
      <property name="title">
-      <string>Fast Boot Options</string>
+      <string>Options and Patches</string>
      </property>
      <layout class="QVBoxLayout" name="verticalLayout">
       <item>

pcsx2/CMakeLists.txt

@@ -830,7 +830,6 @@ set(pcsx2HostHeaders
 
 set(pcsx2ImGuiSources
 	ImGui/FullscreenUI.cpp
-	ImGui/FullscreenUI_Settings.cpp
 	ImGui/ImGuiFullscreen.cpp
 	ImGui/ImGuiManager.cpp
 	ImGui/ImGuiOverlays.cpp
@@ -838,7 +837,6 @@ set(pcsx2ImGuiSources
 
 set(pcsx2ImGuiHeaders
 	ImGui/FullscreenUI.h
-	ImGui/FullscreenUI_Internal.h
 	ImGui/ImGuiAnimated.h
 	ImGui/ImGuiFullscreen.h
 	ImGui/ImGuiManager.h

pcsx2/Docs/GameIndex.md

@@ -139,15 +139,12 @@ The clamp modes are also numerically based.
 
 ### GS Hardware Mipmap Fixes
 
-* mipmap                     [`0` or `1`]    {Off, On}                   Default: On (looks up GameDB)
+* mipmap                     [`0` or `1` or `2`]    {Off, Basic, Full}                    Default: Automatic (No value, looks up GameDB)
 * trilinearFiltering         [`0` or `1` or `2`]    {None, Trilinear, Trilinear Ultra}    Default: None (`0`)
 
 ### GS Hardware General Fixes
 
 * beforeDraw                {`OI` with suffix }  {None unless specific game GSC}         Default: Automatic (No value, looks up GameDB) with valid variable name (ex. OI_BurnoutGames)
-
-* moveHandler                {`MV` with suffix }  {None unless specific game GSC}         Default: Automatic (No value, looks up GameDB) with valid variable name (ex. MV_Ico)
-
 * afterDraw                 {`OO` with suffix }  {None unless specific game GSC}         Default: Automatic (No value, looks up GameDB) with valid variable name
 * conservativeFramebuffer   [`0` or `1`]               {Off or On}                             Default: On (`1`)
 * texturePreloading         [`0` or `1` or `2`]        {None, Partial or Full Hash Cache}     Default: None (`0`)
@@ -156,17 +153,11 @@ The clamp modes are also numerically based.
 ### GS Hardware Renderer Fixes
 
 * autoFlush                   [`0` or `1` or `2`]          {Disabled, Enabled (Sprites Only), Enabled (All Primitives)}                            Default: Off (`0`)
-* partialTargetInvalidation         [`0` or `1`]          {Off, On}                               Default: Off (`0`)
-* PCRTCOffsets    [`0` or `1`]          {Off, On}                               Default: Off (`0`)
-
-* PCRTCOverscan    [`0` or `1`]          {Off, On}                               Default: Off (`0`)
-
 * disableDepthSupport         [`0` or `1`]          {Off, On}                               Default: Off (`0`)
 * disablePartialInvalidation  [`0` or `1`]          {Off, On}                               Default: Off (`0`)
 * cpuFramebufferConversion    [`0` or `1`]          {Off, On}                               Default: Off (`0`)
 * preloadFrameData            [`0` or `1`]          {Off, On}                               Default: Off (`0`)
-* textureInsideRT             [`0` or `1`or `2`]          {Disabled, Inside Targets, Merge Targets}                                            Default: Off (`0`)
-* PCRTCOverscan               [`0` or `1`]          {Off, On}                               Default: Off (`0`)
+* textureInsideRT             [`0` or `1`]          {Disabled, Inside Targets, Merge Targets}                                            Default: Off (`0`)
 * PCRTCOverscan               [`0` or `1`]          {Off, On}                               Default: Off (`0`)
 * cpuCLUTRender               [`0` or `1` or `2`]   {Disabled, Normal, Aggressive}           Default: Disabled (`0`)
 * cpuSpriteRenderBW           [Value between `0` to `10`]   {Disabled, 1 (64), 2 (128), 3 (192), 4 (256), 5 (320), 6 (384), 7 (448), 8 (512), 9 (576), 10 (640)} Default: Off (`0`)

pcsx2/Docs/gamedb-schema.json

@@ -229,6 +229,11 @@
               "minimum": 0,
               "maximum": 100000
             },
+            "halfBottomOverride": {
+              "type": "integer",
+              "minimum": 0,
+              "maximum": 1
+            },
             "halfPixelOffset": {
               "type": "integer",
               "minimum": 0,

pcsx2/GS/GSState.cpp

@@ -1899,30 +1899,6 @@ void GSState::FlushWrite()
 
 	r = m_tr.rect;
 
-	// If the end isn't where it said it would be, we need to calculate the end point.
-	// Star Wars - The Clone Wars just sets the rect to 16x4095 then YOLO's about half a page, then kills the transfer.
-	// If we just nuke the whole lot, even though nothing has been transferred, we risk killing data we don't mean to.
-	if (m_tr.end < m_tr.total && GSIsHardwareRenderer())
-	{
-		const GSLocalMemory::psm_t& psm_s = GSLocalMemory::m_psm[m_tr.m_blit.DPSM];
-		// Convert to nibbles then back to bytes after, in case trbpp is 4.
-		const u32 in_data_pixel_count = (((len * 2) + ((psm_s.trbpp / 4) - 1)) / (psm_s.trbpp / 4));
-		const u32 rect_pixel_count = r.width() * r.height();
-
-		if (rect_pixel_count > in_data_pixel_count)
-		{
-			const int calculated_height = ((in_data_pixel_count + (r.width() - 1)) / r.width());
-			
-			// Just setting the height should be okay...
-			r.w = std::max(r.y + calculated_height, psm_s.bs.y);
-
-			if (m_draw_transfers.size() > 0 && m_tr.m_blit.DBP == m_draw_transfers.back().blit.DBP)
-			{
-				m_draw_transfers.back().rect = r;
-			}
-		}
-	}
-
 	InvalidateVideoMem(m_env.BITBLTBUF, r);
 
 	const GSLocalMemory::writeImage wi = GSLocalMemory::m_psm[m_env.BITBLTBUF.DPSM].wi;

pcsx2/GS/Renderers/Common/GSDevice.cpp

@@ -244,7 +244,7 @@ const char* GSDevice::RenderAPIToString(RenderAPI api)
 
 bool GSDevice::GetRequestedExclusiveFullscreenMode(u32* width, u32* height, float* refresh_rate)
 {
-	const std::string mode = Host::GetStringSettingValue("EmuCore/GS", "FullscreenMode", "");
+	const std::string mode = Host::GetBaseStringSettingValue("EmuCore/GS", "FullscreenMode", "");
 	if (!mode.empty())
 	{
 		const std::string_view mode_view = mode;
@@ -899,13 +899,14 @@ void GSDevice::ShadeBoost()
 	if (ResizeRenderTarget(&m_target_tmp, m_current->GetWidth(), m_current->GetHeight(), false, false))
 	{
 		// predivide to avoid the divide (multiply) in the shader
-		const GSVector4 params(
+		const float params[4] = {
 			static_cast<float>(GSConfig.ShadeBoost_Brightness) * (1.0f / 50.0f),
 			static_cast<float>(GSConfig.ShadeBoost_Contrast) * (1.0f / 50.0f),
 			static_cast<float>(GSConfig.ShadeBoost_Saturation) * (1.0f / 50.0f),
-			static_cast<float>(GSConfig.ShadeBoost_Gamma) * (1.0f / 50.0f));
+			static_cast<float>(GSConfig.ShadeBoost_Gamma) * (1.0f / 50.0f),
+		};
 
-		DoShadeBoost(m_current, m_target_tmp, params.v);
+		DoShadeBoost(m_current, m_target_tmp, params);
 
 		m_current = m_target_tmp;
 	}

pcsx2/GS/Renderers/Common/GSDevice.h

@@ -433,7 +433,7 @@ struct alignas(16) GSHWDrawConfig
 		{
 			const u32 sw_blend_bits = blend_a | blend_b | blend_d;
 			const bool sw_blend_needs_rt = (sw_blend_bits != 0 && ((sw_blend_bits | blend_c) & 1u)) || ((a_masked & blend_c) != 0);
-			return channel_fb || tex_is_fb || fbmask || (date >= 5) || sw_blend_needs_rt;
+			return no_color == 0 && (channel_fb || tex_is_fb || fbmask || (date >= 5) || sw_blend_needs_rt);
 		}
 
 		/// Disables color output from the pixel shader, this is done when all channels are masked.
@@ -705,6 +705,7 @@ struct alignas(16) GSHWDrawConfig
 		Stencil,        ///< Emulate using read-only stencil
 		StencilOne,     ///< Emulate using read-write stencil (first write wins)
 		PrimIDTracking, ///< Emulate by tracking the primitive ID of the last pixel allowed through
+		Depth,          ///< Only depth is written, no need for barriers
 		Full,           ///< Full emulation (using barriers / ROV)
 	};
 

pcsx2/GS/Renderers/DX11/GSDevice11.cpp

@@ -1397,7 +1397,7 @@ void GSDevice11::PresentRect(GSTexture* sTex, const GSVector4& sRect, GSTexture*
 	const float right = dRect.z * 2 / ds.x - 1.0f;
 	const float bottom = 1.0f - dRect.w * 2 / ds.y;
 
-	const GSVertexPT1 vertices[] =
+	GSVertexPT1 vertices[] =
 	{
 		{GSVector4(left, top, 0.5f, 1.0f), GSVector2(sRect.x, sRect.y)},
 		{GSVector4(right, top, 0.5f, 1.0f), GSVector2(sRect.z, sRect.y)},
@@ -1427,14 +1427,13 @@ void GSDevice11::PresentRect(GSTexture* sTex, const GSVector4& sRect, GSTexture*
 void GSDevice11::UpdateCLUTTexture(GSTexture* sTex, float sScale, u32 offsetX, u32 offsetY, GSTexture* dTex, u32 dOffset, u32 dSize)
 {
 	// match merge cb
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		float scale;
 		float pad1[3];
 		u32 offsetX, offsetY, dOffset;
-		u32 pad2;
 	};
-	const Uniforms cb = {sScale, {}, offsetX, offsetY, dOffset, 0};
+	const Uniforms cb = {sScale, {}, offsetX, offsetY, dOffset};
 	m_ctx->UpdateSubresource(m_merge.cb.get(), 0, nullptr, &cb, 0, 0);
 
 	const GSVector4 dRect(0, 0, dSize, 1);
@@ -1445,15 +1444,14 @@ void GSDevice11::UpdateCLUTTexture(GSTexture* sTex, float sScale, u32 offsetX, u
 void GSDevice11::ConvertToIndexedTexture(GSTexture* sTex, float sScale, u32 offsetX, u32 offsetY, u32 SBW, u32 SPSM, GSTexture* dTex, u32 DBW, u32 DPSM)
 {
 	// match merge cb
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		float scale;
 		float pad1[3];
 		u32 SBW, DBW, SPSM;
-		u32 pad2;
 	};
 
-	const Uniforms cb = {sScale, {}, SBW, DBW, SPSM, 0};
+	const Uniforms cb = {sScale, {}, SBW, DBW, SPSM};
 	m_ctx->UpdateSubresource(m_merge.cb.get(), 0, nullptr, &cb, 0, 0);
 
 	const GSVector4 dRect(0, 0, dTex->GetWidth(), dTex->GetHeight());
@@ -1463,7 +1461,7 @@ void GSDevice11::ConvertToIndexedTexture(GSTexture* sTex, float sScale, u32 offs
 
 void GSDevice11::FilteredDownsampleTexture(GSTexture* sTex, GSTexture* dTex, u32 downsample_factor, const GSVector2i& clamp_min, const GSVector4& dRect)
 {
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		float weight;
 		float step_multiplier;
@@ -2065,13 +2063,13 @@ void GSDevice11::RenderImGui()
 
 	UpdateImGuiTextures();
 
-	constexpr float L = 0.0f;
+	const float L = 0.0f;
 	const float R = static_cast<float>(m_window_info.surface_width);
-	constexpr float T = 0.0f;
+	const float T = 0.0f;
 	const float B = static_cast<float>(m_window_info.surface_height);
 
 	// clang-format off
-	const GSVector4 ortho_projection[4] =
+  const float ortho_projection[4][4] =
 	{
 		{ 2.0f/(R-L),   0.0f,           0.0f,       0.0f },
 		{ 0.0f,         2.0f/(T-B),     0.0f,       0.0f },
@@ -2736,6 +2734,12 @@ void GSDevice11::RenderHW(GSHWDrawConfig& config)
 		SetupPS(config.ps, nullptr, config.sampler);
 		PSSetShaderResource(3, primid_texture);
 	}
+	else if (config.destination_alpha == GSHWDrawConfig::DestinationAlphaMode::Depth)
+	{
+		PSSetShaderResource(2, config.rt);
+		config.rt = (config.rt == m_state.cached_rt_view) ? nullptr : m_state.cached_rt_view;
+		OMSetRenderTargets(config.rt, config.ds, &config.scissor, read_only_dsv);
+	}
 
 	// Avoid changing framebuffer just to switch from rt+depth to rt and vice versa.
 	GSTexture* draw_rt = colclip_rt ? colclip_rt : config.rt;

pcsx2/GS/Renderers/DX12/GSDevice12.cpp

@@ -938,7 +938,6 @@ void GSDevice12::SetVSyncMode(GSVSyncMode mode, bool allow_present_throttle)
 
 	if (GetSwapChainBufferCount() != old_buffer_count)
 	{
-		ExecuteCommandList(true);
 		DestroySwapChain();
 		if (!CreateSwapChain())
 			pxFailRel("Failed to recreate swap chain after vsync change.");
@@ -1636,14 +1635,14 @@ void GSDevice12::UpdateCLUTTexture(
 	GSTexture* sTex, float sScale, u32 offsetX, u32 offsetY, GSTexture* dTex, u32 dOffset, u32 dSize)
 {
 	// match merge cb
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		float scale;
 		float pad1[3];
 		u32 offsetX, offsetY, dOffset;
 		u32 pad2;
 	};
-	const Uniforms cb = {sScale, {}, offsetX, offsetY, dOffset, 0};
+	const Uniforms cb = {sScale, {}, offsetX, offsetY, dOffset};
 	SetUtilityRootSignature();
 	SetUtilityPushConstants(&cb, sizeof(cb));
 
@@ -1657,15 +1656,14 @@ void GSDevice12::ConvertToIndexedTexture(
 	GSTexture* sTex, float sScale, u32 offsetX, u32 offsetY, u32 SBW, u32 SPSM, GSTexture* dTex, u32 DBW, u32 DPSM)
 {
 	// match merge cb
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		float scale;
 		float pad1[3];
 		u32 SBW, DBW, SPSM;
-		u32 pad2;
 	};
 
-	const Uniforms cb = {sScale, {}, SBW, DBW, SPSM, 0};
+	const Uniforms cb = {sScale, {}, SBW, DBW, SPSM};
 	SetUtilityRootSignature();
 	SetUtilityPushConstants(&cb, sizeof(cb));
 
@@ -1677,7 +1675,7 @@ void GSDevice12::ConvertToIndexedTexture(
 
 void GSDevice12::FilteredDownsampleTexture(GSTexture* sTex, GSTexture* dTex, u32 downsample_factor, const GSVector2i& clamp_min, const GSVector4& dRect)
 {
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		float weight;
 		float step_multiplier;
@@ -2186,7 +2184,7 @@ void GSDevice12::RenderImGui()
 	const float B = static_cast<float>(m_window_info.surface_height);
 
 	// clang-format off
-	const GSVector4 ortho_projection[4] =
+  const float ortho_projection[4][4] =
 	{
 		{ 2.0f/(R-L),   0.0f,           0.0f,       0.0f },
 		{ 0.0f,         2.0f/(T-B),     0.0f,       0.0f },
@@ -4144,6 +4142,17 @@ void GSDevice12::RenderHW(GSHWDrawConfig& config)
 			return;
 		}
 	}
+	else if (config.destination_alpha == GSHWDrawConfig::DestinationAlphaMode::Depth)
+	{
+		PSSetShaderResource(2, draw_rt, true);
+		if ((draw_rt == m_current_render_target))
+			Console.Warning("DATE RT SAME");
+		else
+			Console.Warning("DATE RT NOT SAME");
+
+		draw_rt = (draw_rt == m_current_render_target) ? nullptr : m_current_render_target;
+		OMSetRenderTargets(draw_rt, draw_ds, config.scissor, config.tex && config.tex == config.ds);
+	}
 
 	// Switch to colclip target for colclip hw rendering
 	if (pipe.ps.colclip_hw)

pcsx2/GS/Renderers/HW/GSHwHack.cpp

@@ -756,7 +756,7 @@ bool GSHwHack::GSC_PolyphonyDigitalGames(GSRendererHW& r, int& skip)
 		config.ps.channel = ChannelFetch_RGB;
 		config.colormask.wrgba = 1 | 2 | 4;
 		r.EndHLEHardwareDraw(false);
-		src->m_last_draw = r.s_n;
+
 		return true;
 	}
 	else
@@ -814,7 +814,6 @@ bool GSHwHack::GSC_PolyphonyDigitalGames(GSRendererHW& r, int& skip)
 			config.ps.channel = ChannelFetch_RED + channel;
 			config.colormask.wrgba = 8;
 			r.EndHLEHardwareDraw(false);
-			dst->m_last_draw = r.s_n;
 		}
 
 		return true;

pcsx2/GS/Renderers/HW/GSRendererHW.cpp

@@ -5910,7 +5910,6 @@ void GSRendererHW::EmulateBlending(int rt_alpha_min, int rt_alpha_max, const boo
 	{
 		case AccBlendLevel::Maximum:
 			sw_blending |= true;
-			accumulation_blend &= (GSLocalMemory::m_psm[m_cached_ctx.FRAME.PSM].bpp == 32);
 			[[fallthrough]];
 		case AccBlendLevel::Full:
 			sw_blending |= m_conf.ps.blend_a != m_conf.ps.blend_b && alpha_c0_high_max_one;
@@ -7355,6 +7354,7 @@ __ri void GSRendererHW::DrawPrims(GSTextureCache::Target* rt, GSTextureCache::Ta
 	bool DATE_PRIMID = false;
 	bool DATE_BARRIER = false;
 	bool DATE_one = false;
+	bool DATE_DEPTH = false;
 
 	ResetStates();
 
@@ -7769,7 +7769,7 @@ __ri void GSRendererHW::DrawPrims(GSTextureCache::Target* rt, GSTextureCache::Ta
 	}
 
 	// Similar to IsRTWritten(), check if the rt will change.
-	const bool no_rt = !rt || !(m_conf.colormask.wrgba || m_channel_shuffle);
+	const bool no_rt = !rt || m_conf.colormask.wrgba == 0;
 	const bool no_ds = !ds ||
 		// Depth will be written through the RT.
 		(!no_rt && m_cached_ctx.FRAME.FBP == m_cached_ctx.ZBUF.ZBP && !PRIM->TME && m_cached_ctx.ZBUF.ZMSK == 0 &&
@@ -7783,9 +7783,16 @@ __ri void GSRendererHW::DrawPrims(GSTextureCache::Target* rt, GSTextureCache::Ta
 		return;
 	}
 
+	// Always swap DATE with DATE_DEPTH if rt isn't written.
+	// Only depth is written so we can test without needing a barrier.
 	// Always swap DATE with DATE_BARRIER if we have barriers on when alpha write is masked.
 	// This is always enabled on vk/gl but not on dx11/12 as copies are slow so we can selectively enable it like now.
-	if (DATE && !m_conf.colormask.wa && (m_conf.require_one_barrier || m_conf.require_full_barrier))
+	if (DATE && no_rt)
+	{
+		DATE_DEPTH = true;
+		DATE_BARRIER = false;
+	}
+	else if (DATE && !m_conf.colormask.wa && (m_conf.require_one_barrier || m_conf.require_full_barrier))
 		DATE_BARRIER = true;
 
 	if ((m_conf.ps.tex_is_fb && rt && rt->m_rt_alpha_scale) || (tex && tex->m_from_target && tex->m_target_direct && tex->m_from_target->m_rt_alpha_scale))
@@ -7892,10 +7899,13 @@ __ri void GSRendererHW::DrawPrims(GSTextureCache::Target* rt, GSTextureCache::Ta
 
 	// No point outputting colours if we're just writing depth.
 	// We might still need the framebuffer for DATE, though.
-	if (!rt || m_conf.colormask.wrgba == 0)
+	if (no_rt)
 	{
 		m_conf.ps.DisableColorOutput();
 		m_conf.colormask.wrgba = 0;
+
+		m_conf.require_one_barrier = false;
+		m_conf.require_full_barrier = false;
 	}
 
 	if (m_conf.ps.scanmsk & 2)
@@ -7911,6 +7921,8 @@ __ri void GSRendererHW::DrawPrims(GSTextureCache::Target* rt, GSTextureCache::Ta
 		m_conf.destination_alpha = GSHWDrawConfig::DestinationAlphaMode::PrimIDTracking;
 	else if (DATE_BARRIER)
 		m_conf.destination_alpha = GSHWDrawConfig::DestinationAlphaMode::Full;
+	else if (DATE_DEPTH)
+		m_conf.destination_alpha = GSHWDrawConfig::DestinationAlphaMode::Depth;
 	else if (features.stencil_buffer)
 		m_conf.destination_alpha = GSHWDrawConfig::DestinationAlphaMode::Stencil;
 
@@ -8022,7 +8034,7 @@ __ri void GSRendererHW::DrawPrims(GSTextureCache::Target* rt, GSTextureCache::Ta
 	m_conf.ps.iip = (m_vt.m_primclass == GS_SPRITE_CLASS) ? 0 : PRIM->IIP;
 	m_conf.vs.iip = m_conf.ps.iip;
 
-	if (DATE_BARRIER)
+	if (DATE_DEPTH || DATE_BARRIER)
 	{
 		m_conf.ps.date = 5 + m_cached_ctx.TEST.DATM;
 	}

pcsx2/GS/Renderers/HW/GSTextureCache.cpp

@@ -2404,289 +2404,250 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 	};
 
 	Target* dst = nullptr;
-	Target* dst_match = nullptr;
-	auto* list = &m_dst[type];
+	auto& list = m_dst[type];
 
 	const GSVector4i min_rect = draw_rect.max_u32(GSVector4i(0, 0, draw_rect.x, draw_rect.y));
 	// TODO: Move all frame stuff to its own routine too.
 	if (!is_frame)
 	{
-		for (int iteration = 0; iteration < 2; iteration++)
+		for (auto i = list.begin(); i != list.end();)
 		{
-			if (dst != nullptr)
-				break;
-
-			auto& new_dst = iteration == 0 ? dst : dst_match;
-			list = &m_dst[iteration == 0 ? type : (1 - type)];
-			for (auto i = list->begin(); i != list->end();)
+			Target* t = *i;
+			if (bp == t->m_TEX0.TBP0)
 			{
-				Target* t = *i;
-				if (bp == t->m_TEX0.TBP0)
+				bool can_use = true;
+
+				if (dst && ((GSState::s_n - dst->m_last_draw) < (GSState::s_n - t->m_last_draw) && dst->m_TEX0.TBP0 <= bp))
 				{
-					bool can_use = true;
-
-					if (new_dst && ((GSState::s_n - new_dst->m_last_draw) < (GSState::s_n - t->m_last_draw) && new_dst->m_TEX0.TBP0 <= bp))
-					{
-						DevCon.Warning("Ignoring target at %x as one at %x is newer", t->m_TEX0.TBP0, new_dst->m_TEX0.TBP0);
-						i++;
-						continue;
-					}
-					
-					// If there's no valid RGB, it can't be interchanged between RT and Depth
-					if (iteration == 1)
-					{
-						const u32 valid_mask = (t->m_valid_rgb ? 0x7 : 0x0) | ((t->m_valid_alpha_low || t->m_valid_alpha_high) ? 0x8 : 0x0);
-						if ((!(valid_mask & GSUtil::GetChannelMask(TEX0.PSM)) || (!is_shuffle && TEX0.TBW < (t->m_TEX0.TBW / 2))) || 
-							(!is_shuffle && GSLocalMemory::m_psm[t->m_TEX0.PSM].bpp != GSLocalMemory::m_psm[TEX0.PSM].bpp))
-						{
-							if (!preserve_rgb && !preserve_alpha && (!src || src->m_from_target != t) && (valid_mask & GSUtil::GetChannelMask(TEX0.PSM)))
-							{
-								InvalidateSourcesFromTarget(t);
-								i = list->erase(i);
-								delete t;
-							}
-							else
-								i++;
-							continue;
-						}
-					}
-
-					// if It's an old target and it's being completely overwritten, kill it.
-					// Dragon Quest 8 reuses a render-target sized buffer as a single-page buffer, without clearing it. But,
-					// it does dirty it by writing over the 64x64 region. So while we can't use this heuristic for tossing
-					// targets at BW=1 because it breaks other games, we can when the *new* buffer area is completely dirty.
-					if (((!preserve_rgb && !preserve_alpha) || (t->m_was_dst_matched && fbmask == 0xffffff)) && TEX0.TBW != t->m_TEX0.TBW)
-					{
-						// Old targets or shrunk targets where Y draw height goes outside the page.
-						if (TEX0.TBW > 1 && (t->m_age >= 1 || (type == RenderTarget && draw_rect.w > GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y && TEX0.TBW < t->m_TEX0.TBW)))
-						{
-							can_use = false;
-						}
-						else if (!t->m_dirty.empty())
-						{
-							const GSVector4i size_rect = GSVector4i::loadh(size);
-							can_use = !t->m_dirty.GetTotalRect(TEX0, size).rintersect(size_rect).eq(size_rect);
-						}
-					}
-					else if (type == RenderTarget && (fbmask == 0xffffff && !t->m_was_dst_matched && TEX0.TBW != t->m_TEX0.TBW))
-					{
-						// When returning to being matched with the Z buffer in width, we need to make sure the RGB is up to date as it could get used later (Hitman Contracts).
-						auto& rev_list = m_dst[1 - type];
-						for (auto j = rev_list.begin(); j != rev_list.end(); ++j)
-						{
-							Target* ds = *j;
-
-							if (t->m_TEX0.TBP0 != ds->m_TEX0.TBP0 || !ds->m_valid_rgb || TEX0.TBW != ds->m_TEX0.TBW)
-								continue;
-
-							t->m_was_dst_matched = true;
-							t->m_valid_rgb = false;
-							break;
-						}
-					}
-					// TODO: What might be a nicer solution than this, is to rearrange the targets to match the new layout, however this comes with some caviets:
-					// 1. They can draw wider than the FBW
-					// 2. The dirty+valid rects will need to also be rearranged
-					// 3. This could mean larger targets hanging around more
-					// 4. Sources which reference a target may become invalid and will need to be removed
-					// 5. Potential performance implications from additional render passes/copying
-					//
-					// But the bonuses are:
-					// 1. Rearranging the page layout will fix quite a few games which do this
-					// 2. Preserved data will be in the correct place (in most cases)
-					// 3. Less deleting sources/targets
-					// 4. We can basically do clears in hardware, if they aren't insane ones
-					bool dirtied_area = t->m_dirty.size() >= 1;
-
-					// Check it covers the whole area of the new draw
-					if (!is_shuffle && dirtied_area)
-					{
-						const u32 draw_start = GSLocalMemory::GetStartBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, draw_rect);
-						const u32 draw_end = GSLocalMemory::GetEndBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, draw_rect);
-
-						const GSVector4i dirty_rect = t->m_dirty.GetTotalRect(t->m_TEX0, t->m_unscaled_size);
-						const u32 dirty_start = GSLocalMemory::GetStartBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, dirty_rect);
-						const u32 dirty_end = GSLocalMemory::GetEndBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, dirty_rect);
-
-						if (dirty_end < draw_end || dirty_start > draw_start)
-							dirtied_area = false;
-					}
-
-					if (can_use && ((!is_shuffle && dirtied_area) || (is_shuffle && src && GSLocalMemory::m_psm[src->m_TEX0.PSM].bpp == 8 && GSLocalMemory::m_psm[t->m_TEX0.PSM].bpp == 16)) && ((preserve_alpha && preserve_rgb) || (draw_rect.w > GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y && !possible_clear)) && TEX0.TBW != t->m_TEX0.TBW)
+					DevCon.Warning("Ignoring target at %x as one at %x is newer", t->m_TEX0.TBP0, dst->m_TEX0.TBP0);
+					i++;
+					continue;
+				}
+				// if It's an old target and it's being completely overwritten, kill it.
+				// Dragon Quest 8 reuses a render-target sized buffer as a single-page buffer, without clearing it. But,
+				// it does dirty it by writing over the 64x64 region. So while we can't use this heuristic for tossing
+				// targets at BW=1 because it breaks other games, we can when the *new* buffer area is completely dirty.
+				if (((!preserve_rgb && !preserve_alpha) || (t->m_was_dst_matched && fbmask == 0xffffff)) && TEX0.TBW != t->m_TEX0.TBW)
+				{
+					// Old targets or shrunk targets where Y draw height goes outside the page.
+					if (TEX0.TBW > 1 && (t->m_age >= 1 || (type == RenderTarget && draw_rect.w > GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y && TEX0.TBW < t->m_TEX0.TBW)))
 					{
 						can_use = false;
 					}
-
-					if (can_use)
+					else if (!t->m_dirty.empty())
 					{
-						if (used)
-							list->MoveFront(i.Index());
+						const GSVector4i size_rect = GSVector4i::loadh(size);
+						can_use = !t->m_dirty.GetTotalRect(TEX0, size).rintersect(size_rect).eq(size_rect);
+					}
+				}
+				else if (type == RenderTarget && (fbmask == 0xffffff && !t->m_was_dst_matched && TEX0.TBW != t->m_TEX0.TBW))
+				{
+					// When returning to being matched with the Z buffer in width, we need to make sure the RGB is up to date as it could get used later (Hitman Contracts).
+					auto& rev_list = m_dst[1 - type];
+					for (auto j = rev_list.begin(); j != rev_list.end(); ++j)
+					{
+						Target* ds = *j;
 
-						new_dst = t;
-						new_dst->m_32_bits_fmt |= (psm_s.bpp != 16);
+						if (t->m_TEX0.TBP0 != ds->m_TEX0.TBP0 || !ds->m_valid_rgb || TEX0.TBW != ds->m_TEX0.TBW)
+							continue;
+
+						t->m_was_dst_matched = true;
+						t->m_valid_rgb = false;
+						break;
+					}
+				}
+				// TODO: What might be a nicer solution than this, is to rearrange the targets to match the new layout, however this comes with some caviets:
+				// 1. They can draw wider than the FBW
+				// 2. The dirty+valid rects will need to also be rearranged
+				// 3. This could mean larger targets hanging around more
+				// 4. Sources which reference a target may become invalid and will need to be removed
+				// 5. Potential performance implications from additional render passes/copying
+				//
+				// But the bonuses are:
+				// 1. Rearranging the page layout will fix quite a few games which do this
+				// 2. Preserved data will be in the correct place (in most cases)
+				// 3. Less deleting sources/targets
+				// 4. We can basically do clears in hardware, if they aren't insane ones
+				bool dirtied_area = t->m_dirty.size() >= 1;
+
+				// Check it covers the whole area of the new draw
+				if (!is_shuffle && dirtied_area)
+				{
+					const u32 draw_start = GSLocalMemory::GetStartBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, draw_rect);
+					const u32 draw_end = GSLocalMemory::GetEndBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, draw_rect);
+
+					const GSVector4i dirty_rect = t->m_dirty.GetTotalRect(t->m_TEX0, t->m_unscaled_size);
+					const u32 dirty_start = GSLocalMemory::GetStartBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, dirty_rect);
+					const u32 dirty_end = GSLocalMemory::GetEndBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, dirty_rect);
+
+					if (dirty_end < draw_end || dirty_start > draw_start)
+						dirtied_area = false;
+				}
+
+				if (can_use && ((!is_shuffle && dirtied_area) || (is_shuffle && src && GSLocalMemory::m_psm[src->m_TEX0.PSM].bpp == 8 && GSLocalMemory::m_psm[t->m_TEX0.PSM].bpp == 16)) && ((preserve_alpha && preserve_rgb) || (draw_rect.w > GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y && !possible_clear)) && TEX0.TBW != t->m_TEX0.TBW)
+				{
+					can_use = false;
+				}
+
+				if (can_use)
+				{
+					if (used)
+						list.MoveFront(i.Index());
+					dst = t;
+
+					dst->m_32_bits_fmt |= (psm_s.bpp != 16);
+					break;
+				}
+				else if (!(src && src->m_from_target == t))
+				{
+					GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s due to change in target", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
+					InvalidateSourcesFromTarget(t);
+					i = list.erase(i);
+					delete t;
+
+					continue;
+				}
+			}
+			// Probably pointing to half way through the target
+			else if (!min_rect.rempty() && GSConfig.UserHacks_TextureInsideRt >= GSTextureInRtMode::InsideTargets)
+			{
+				// Some games misuse the scissor so it ends up valid 1 pixel over, which causes hell for us. So check if it still overlaps without the extra pixel.
+				const GSVector4i adjusted_valid = GSVector4i(t->m_valid.x, t->m_valid.y, std::min(t->m_valid.z, static_cast<int>(t->m_TEX0.TBW) * 64), t->m_valid.w - 1);
+				const u32 adjusted_endblock = GSLocalMemory::GetEndBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, adjusted_valid);
+				if (adjusted_endblock <= bp)
+				{
+					i++;
+					continue;
+				}
+
+				const u32 widthpage_offset = (std::abs(static_cast<int>(bp - t->m_TEX0.TBP0)) >> 5) % std::max(t->m_TEX0.TBW, 1U);
+				const bool is_aligned_ok = widthpage_offset == 0 || ((min_rect.width() <= static_cast<int>((t->m_TEX0.TBW - widthpage_offset) * 64) && (t->m_TEX0.TBW == TEX0.TBW || TEX0.TBW == 1)) && bp >= t->m_TEX0.TBP0);
+				const bool no_target_or_newer = (!dst || ((GSState::s_n - dst->m_last_draw) < (GSState::s_n - t->m_last_draw)));
+				const bool width_match = (t->m_TEX0.TBW == TEX0.TBW || (TEX0.TBW == 1 && draw_rect.w <= GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y));
+				const bool ds_offset = !ds || offset != 0;
+				const bool is_double_buffer = TEX0.TBP0 == ((((t->m_end_block + 1) - t->m_TEX0.TBP0) / 2) + t->m_TEX0.TBP0);
+				const bool source_match = src && src->m_TEX0.TBP0 <= bp && src->m_end_block > bp && src->m_TEX0.TBW == TEX0.TBW && src->m_from_target && src->m_from_target == t && t->Inside(bp, TEX0.TBW, TEX0.PSM, min_rect);
+				const bool was_used_last_draw = t->m_last_draw == (GSState::s_n - 1);
+				// if it's a shuffle, some games tend to offset back by a page, such as Tomb Raider, for no disernable reason, but it then causes problems.
+				// This can also happen horizontally (Catwoman moves everything one page left with shuffles), but this is too messy to deal with right now.
+				const bool overlaps = t->Overlaps(bp, TEX0.TBW, TEX0.PSM, min_rect) || (is_shuffle && src && GSLocalMemory::m_psm[src->m_TEX0.PSM].bpp == 8 && t->Overlaps(bp, TEX0.TBW, TEX0.PSM, min_rect + GSVector4i(0, 0, 0, 32)));
+				if (source_match || (no_target_or_newer && is_aligned_ok && width_match && overlaps && (is_shuffle || ds_offset || is_double_buffer || was_used_last_draw)))
+				{
+					const GSLocalMemory::psm_t& s_psm = GSLocalMemory::m_psm[TEX0.PSM];
+
+					// If it overlaps but the target is huge and the Z isn't offset, we need to split the buffer, so let's shrink this one down.
+					// 896 is just 448 * 2,just gives the buffer chance to be larger than normal, in case they do something like 640x640, or something ridiculous.
+					if (!is_shuffle && (ds && offset == 0 && (t->m_valid.w >= 896) && ((((t->m_end_block + 1) - t->m_TEX0.TBP0) >> 1) + t->m_TEX0.TBP0) <= bp))
+					{
+						const u32 local_offset = (((bp - t->m_TEX0.TBP0) >> 5) / std::max(t->m_TEX0.TBW, 1U)) * s_psm.pgs.y;
+						if ((dst = CreateTarget(TEX0, GSVector2i(t->m_valid.z, t->m_valid.w - local_offset), GSVector2i(t->m_valid.z, t->m_valid.w - local_offset), scale, type, true, fbmask, false, false, preserve_rgb || preserve_alpha, GSVector4i::zero(), src)))
+							dst->m_32_bits_fmt |= (psm_s.bpp != 16);
 
 						break;
 					}
-					else if (!(src && src->m_from_target == t))
+
+					// I know what you're thinking, and I hate the guy who wrote it too (me). Project Snowblind, Tomb Raider etc decide to offset where they're drawing using a channel shuffle, and this gets messy, so best just to kill the old target.
+					if (is_shuffle && src && src->m_TEX0.PSM == PSMT8 && GSRendererHW::GetInstance()->m_context->FRAME.FBW == 1 && t->m_last_draw != (GSState::s_n - 1) && src->m_from_target && (src->m_from_target->m_TEX0.TBP0 == src->m_TEX0.TBP0 || (((src->m_TEX0.TBP0 - src->m_from_target->m_TEX0.TBP0) >> 5) % std::max(src->m_from_target->m_TEX0.TBW, 1U) == 0)) && widthpage_offset && src->m_from_target != t)
 					{
-						GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s due to change in target", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
+						GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s offset overwrite shuffle", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
 						InvalidateSourcesFromTarget(t);
-						i = list->erase(i);
+						i = list.erase(i);
 						delete t;
 
 						continue;
 					}
-				}
-				// Probably pointing to half way through the target
-				else if (!min_rect.rempty() && GSConfig.UserHacks_TextureInsideRt >= GSTextureInRtMode::InsideTargets)
-				{
-					// Some games misuse the scissor so it ends up valid 1 pixel over, which causes hell for us. So check if it still overlaps without the extra pixel.
-					const GSVector4i adjusted_valid = GSVector4i(t->m_valid.x, t->m_valid.y, std::min(t->m_valid.z, static_cast<int>(t->m_TEX0.TBW) * 64), t->m_valid.w - 1);
-					const u32 adjusted_endblock = GSLocalMemory::GetEndBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, adjusted_valid);
-					if (adjusted_endblock <= bp)
+
+					if (!is_shuffle && (!GSUtil::HasSameSwizzleBits(t->m_TEX0.PSM, TEX0.PSM) ||
+										   ((widthpage_offset % std::max(t->m_TEX0.TBW, 1U)) != 0 && ((widthpage_offset + (min_rect.width() + (s_psm.pgs.x - 1)) / s_psm.pgs.x)) > t->m_TEX0.TBW)))
 					{
-						i++;
+						const int page_offset = TEX0.TBP0 - t->m_TEX0.TBP0;
+						const int number_pages = page_offset / 32;
+						const u32 tbw = std::max(t->m_TEX0.TBW, 1u);
+						const int row_offset = number_pages / tbw;
+						const int page_height = GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y;
+						const int vertical_position = row_offset * page_height;
+
+						if (src && src->m_from_target == t && src->m_target_direct && vertical_position >= t->m_valid.w / 2)
+						{
+							// Valids and drawn since last read doesn't match, keep the target but resize it.
+							src->m_valid_rect.w = std::min(vertical_position, src->m_valid_rect.w);
+							t->m_valid.w = std::min(vertical_position, t->m_valid.w);
+							t->ResizeValidity(t->m_valid);
+							t->ResizeDrawn(t->m_valid);
+							++i;
+						}
+						else
+						{
+							GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s due to change in target", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
+							InvalidateSourcesFromTarget(t);
+							i = list.erase(i);
+							delete t;
+						}
+
 						continue;
 					}
 
-					const u32 widthpage_offset = (std::abs(static_cast<int>(bp - t->m_TEX0.TBP0)) >> 5) % std::max(t->m_TEX0.TBW, 1U);
-					const bool is_aligned_ok = widthpage_offset == 0 || ((min_rect.width() <= static_cast<int>((t->m_TEX0.TBW - widthpage_offset) * 64) && (t->m_TEX0.TBW == TEX0.TBW || TEX0.TBW == 1)) && bp >= t->m_TEX0.TBP0);
-					const bool no_target_or_newer = (!new_dst || ((GSState::s_n - new_dst->m_last_draw) < (GSState::s_n - t->m_last_draw)));
-					const bool width_match = (t->m_TEX0.TBW == TEX0.TBW || (TEX0.TBW == 1 && draw_rect.w <= GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y));
-					const bool ds_offset = !ds || offset != 0;
-					const bool is_double_buffer = TEX0.TBP0 == ((((t->m_end_block + 1) - t->m_TEX0.TBP0) / 2) + t->m_TEX0.TBP0);
-					const bool source_match = src && src->m_TEX0.TBP0 <= bp && src->m_end_block > bp && src->m_TEX0.TBW == TEX0.TBW && src->m_from_target && src->m_from_target == t && t->Inside(bp, TEX0.TBW, TEX0.PSM, min_rect);
-					const bool was_used_last_draw = t->m_last_draw == (GSState::s_n - 1);
-					// if it's a shuffle, some games tend to offset back by a page, such as Tomb Raider, for no disernable reason, but it then causes problems.
-					// This can also happen horizontally (Catwoman moves everything one page left with shuffles), but this is too messy to deal with right now.
-					const bool overlaps = t->Overlaps(bp, TEX0.TBW, TEX0.PSM, min_rect) || (is_shuffle && src && GSLocalMemory::m_psm[src->m_TEX0.PSM].bpp == 8 && t->Overlaps(bp, TEX0.TBW, TEX0.PSM, min_rect + GSVector4i(0, 0, 0, 32)));
-					if (source_match || (no_target_or_newer && is_aligned_ok && width_match && overlaps && (is_shuffle || ds_offset || is_double_buffer || was_used_last_draw)))
+					GSVector4i lookup_rect = min_rect;
+
+					if (is_shuffle)
+						lookup_rect = lookup_rect & GSVector4i(~8);
+
+					const GSVector4i translated_rect = GSVector4i(0, 0, 0, 0).max_i32(TranslateAlignedRectByPage(t, TEX0.TBP0, TEX0.PSM, TEX0.TBW, lookup_rect));
+					const GSVector4i dirty_rect = t->m_dirty.empty() ? GSVector4i::zero() : t->m_dirty.GetTotalRect(t->m_TEX0, t->m_unscaled_size);
+					const bool all_dirty = dirty_rect.eq(t->m_valid);
+
+
+					if (!is_shuffle && !dirty_rect.rempty() && (!preserve_alpha && !preserve_rgb) && (GSState::s_n - 3) > t->m_last_draw)
 					{
-						const GSLocalMemory::psm_t& s_psm = GSLocalMemory::m_psm[TEX0.PSM];
+						GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s due to dirty areas not preserved (Likely change in target)", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
+						InvalidateSourcesFromTarget(t);
+						i = list.erase(i);
+						delete t;
 
-						// If it overlaps but the target is huge and the Z isn't offset, we need to split the buffer, so let's shrink this one down.
-						// 896 is just 448 * 2,just gives the buffer chance to be larger than normal, in case they do something like 640x640, or something ridiculous.
-						if (!is_shuffle && (ds && offset == 0 && (t->m_valid.w >= 896) && ((((t->m_end_block + 1) - t->m_TEX0.TBP0) >> 1) + t->m_TEX0.TBP0) <= bp))
+						continue;
+					}
+
+					if (!all_dirty && ((translated_rect.w <= t->m_valid.w) || widthpage_offset == 0 || (GSState::s_n - 3) <= t->m_last_draw))
+					{
+						if (TEX0.TBW == t->m_TEX0.TBW && !is_shuffle && widthpage_offset == 0 && ((min_rect.w + 63) / 64) > 1)
 						{
-							const u32 local_offset = (((bp - t->m_TEX0.TBP0) >> 5) / std::max(t->m_TEX0.TBW, 1U)) * s_psm.pgs.y;
-							if ((new_dst = CreateTarget(TEX0, GSVector2i(t->m_valid.z, t->m_valid.w - local_offset), GSVector2i(t->m_valid.z, t->m_valid.w - local_offset), scale, type, true, fbmask, false, false, preserve_rgb || preserve_alpha, GSVector4i::zero(), src)))
-								new_dst->m_32_bits_fmt |= (psm_s.bpp != 16);
+							// Beyond Good and Evil does this awful thing where it puts one framebuffer at 0xf00, with the first row of pages blanked out, and the whole thing goes down to 0x2080
+							// which is a problem, because it then puts the Z buffer at 0x1fc0, then offsets THAT by 1 row of pages, so it starts at, you guessed it, 2080.
+							// So let's check the *real* start.
+							u32 real_start_address = GSLocalMemory::GetStartBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, t->m_drawn_since_read);
+							u32 new_end_address = GSLocalMemory::GetEndBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, min_rect);
 
-							break;
-						}
-
-						// I know what you're thinking, and I hate the guy who wrote it too (me). Project Snowblind, Tomb Raider etc decide to offset where they're drawing using a channel shuffle, and this gets messy, so best just to kill the old target.
-						if (is_shuffle && src && src->m_TEX0.PSM == PSMT8 && GSRendererHW::GetInstance()->m_context->FRAME.FBW == 1 && t->m_last_draw != (GSState::s_n - 1) && src->m_from_target && (src->m_from_target->m_TEX0.TBP0 == src->m_TEX0.TBP0 || (((src->m_TEX0.TBP0 - src->m_from_target->m_TEX0.TBP0) >> 5) % std::max(src->m_from_target->m_TEX0.TBW, 1U) == 0)) && widthpage_offset && src->m_from_target != t)
-						{
-							if (iteration == 0)
+							// Not really overlapping.
+							if (real_start_address > new_end_address)
 							{
-								GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s offset overwrite shuffle", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
-								InvalidateSourcesFromTarget(t);
-								i = list->erase(i);
-								delete t;
-							}
-							else
 								i++;
-							continue;
-						}
-
-						if (!is_shuffle && (!GSUtil::HasSameSwizzleBits(t->m_TEX0.PSM, TEX0.PSM) ||
-											   ((widthpage_offset % std::max(t->m_TEX0.TBW, 1U)) != 0 && ((widthpage_offset + (min_rect.width() + (s_psm.pgs.x - 1)) / s_psm.pgs.x)) > t->m_TEX0.TBW)))
-						{
-							const int page_offset = TEX0.TBP0 - t->m_TEX0.TBP0;
-							const int number_pages = page_offset / 32;
-							const u32 tbw = std::max(t->m_TEX0.TBW, 1u);
-							const int row_offset = number_pages / tbw;
-							const int page_height = GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y;
-							const int vertical_position = row_offset * page_height;
-
-							if (src && src->m_from_target == t && src->m_target_direct && vertical_position >= t->m_valid.w / 2)
-							{
-								// Valids and drawn since last read doesn't match, keep the target but resize it.
-								src->m_valid_rect.w = std::min(vertical_position, src->m_valid_rect.w);
-								t->m_valid.w = std::min(vertical_position, t->m_valid.w);
-								t->ResizeValidity(t->m_valid);
-								t->ResizeDrawn(t->m_valid);
-								++i;
-							}
-							else
-							{
-								if (iteration == 0)
-								{
-									GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s due to change in target", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
-									InvalidateSourcesFromTarget(t);
-									i = list->erase(i);
-									delete t;
-								}
-								else
-									i++;
-							}
-
-							continue;
-						}
-
-						GSVector4i lookup_rect = min_rect;
-
-						if (is_shuffle)
-							lookup_rect = lookup_rect & GSVector4i(~8);
-
-						const GSVector4i translated_rect = GSVector4i(0, 0, 0, 0).max_i32(TranslateAlignedRectByPage(t, TEX0.TBP0, TEX0.PSM, TEX0.TBW, lookup_rect));
-						const GSVector4i dirty_rect = t->m_dirty.empty() ? GSVector4i::zero() : t->m_dirty.GetTotalRect(t->m_TEX0, t->m_unscaled_size);
-						const bool all_dirty = dirty_rect.eq(t->m_valid);
-
-
-						if (!is_shuffle && !dirty_rect.rempty() && (!preserve_alpha && !preserve_rgb) && (GSState::s_n - 3) > t->m_last_draw)
-						{
-							GL_INS("TC: Deleting RT BP 0x%x BW %d PSM %s due to dirty areas not preserved (Likely change in target)", t->m_TEX0.TBP0, t->m_TEX0.TBW, GSUtil::GetPSMName(t->m_TEX0.PSM));
-							InvalidateSourcesFromTarget(t);
-							i = list->erase(i);
-							delete t;
-
-							continue;
-						}
-
-						if (!all_dirty && ((translated_rect.w <= t->m_valid.w) || widthpage_offset == 0 || (GSState::s_n - 3) <= t->m_last_draw))
-						{
-							if (TEX0.TBW == t->m_TEX0.TBW && !is_shuffle && widthpage_offset == 0 && ((min_rect.w + 63) / 64) > 1)
-							{
-								// Beyond Good and Evil does this awful thing where it puts one framebuffer at 0xf00, with the first row of pages blanked out, and the whole thing goes down to 0x2080
-								// which is a problem, because it then puts the Z buffer at 0x1fc0, then offsets THAT by 1 row of pages, so it starts at, you guessed it, 2080.
-								// So let's check the *real* start.
-								u32 real_start_address = GSLocalMemory::GetStartBlockAddress(t->m_TEX0.TBP0, t->m_TEX0.TBW, t->m_TEX0.PSM, t->m_drawn_since_read);
-								u32 new_end_address = GSLocalMemory::GetEndBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, min_rect);
-
-								// Not really overlapping.
-								if (real_start_address > new_end_address)
-								{
-									i++;
-									continue;
-								}
-							}
-
-							//DevCon.Warning("Here draw %d wanted %x PSM %x got %x PSM %x offset of %d pages width %d pages draw width %d", GSState::s_n, bp, TEX0.PSM, t->m_TEX0.TBP0, t->m_TEX0.PSM, (bp - t->m_TEX0.TBP0) >> 5, t->m_TEX0.TBW, draw_rect.width());
-							new_dst = t;
-							new_dst->m_32_bits_fmt |= (psm_s.bpp != 16);
-
-							//Continue just in case there's a newer target
-							if (used)
-								list->MoveFront(i.Index());
-							if (t->m_TEX0.TBP0 <= bp || GSLocalMemory::GetStartBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, min_rect) >= bp)
-								break;
-							else
 								continue;
+							}
 						}
+
+						//DevCon.Warning("Here draw %d wanted %x PSM %x got %x PSM %x offset of %d pages width %d pages draw width %d", GSState::s_n, bp, TEX0.PSM, t->m_TEX0.TBP0, t->m_TEX0.PSM, (bp - t->m_TEX0.TBP0) >> 5, t->m_TEX0.TBW, draw_rect.width());
+						dst = t;
+
+						dst->m_32_bits_fmt |= (psm_s.bpp != 16);
+						//Continue just in case there's a newer target
+						if (used)
+							list.MoveFront(i.Index());
+						if (t->m_TEX0.TBP0 <= bp || GSLocalMemory::GetStartBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, min_rect) >= bp)
+							break;
+						else
+							continue;
 					}
 				}
-
-				i++;
 			}
+
+			i++;
 		}
 	}
 	else
 	{
 		pxAssert(type == RenderTarget);
 		// Let's try to find a perfect frame that contains valid data
-		for (auto i = list->begin(); i != list->end(); ++i)
+		for (auto i = list.begin(); i != list.end(); ++i)
 		{
 			Target* t = *i;
 
@@ -2712,7 +2673,7 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 						{
 							DevCon.Warning("Wanted %x psm %x bw %x, got %x psm %x bw %x, deleting", TEX0.TBP0, TEX0.PSM, TEX0.TBW, t->m_TEX0.TBP0, t->m_TEX0.PSM, t->m_TEX0.TBW);
 							InvalidateSourcesFromTarget(t);
-							i = list->erase(i);
+							i = list.erase(i);
 							delete t;
 							continue;
 						}
@@ -2730,7 +2691,7 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 		// 2nd try ! Try to find a frame at the requested bp -> bp + size is inside of (or equal to)
 		if (!dst)
 		{
-			for (auto i = list->begin(); i != list->end(); ++i)
+			for (auto i = list.begin(); i != list.end(); ++i)
 			{
 				Target* t = *i;
 				const u32 end_block = GSLocalMemory::GetEndBlockAddress(bp, TEX0.TBW, TEX0.PSM, GSVector4i(0, size.y, size.x, size.y + 1));
@@ -2750,7 +2711,7 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 						{
 							DevCon.Warning("2 Wanted %x psm %x bw %x, got %x psm %x bw %x, deleting", TEX0.TBP0, TEX0.PSM, TEX0.TBW, t->m_TEX0.TBP0, t->m_TEX0.PSM, t->m_TEX0.TBW);
 							InvalidateSourcesFromTarget(t);
-							i = list->erase(i);
+							i = list.erase(i);
 							delete t;
 							continue;
 						}
@@ -2770,7 +2731,7 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 		// 3rd try ! Try to find a frame that doesn't contain valid data (honestly I'm not sure we need to do it)
 		if (!dst)
 		{
-			for (auto i = list->begin(); i != list->end(); ++i)
+			for (auto i = list.begin(); i != list.end(); ++i)
 			{
 				Target* t = *i;
 				if (bp == t->m_TEX0.TBP0 && TEX0.TBW == t->m_TEX0.TBW)
@@ -2782,7 +2743,7 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 						{
 							DevCon.Warning("3 Wanted %x psm %x bw %x, got %x psm %x bw %x, deleting", TEX0.TBP0, TEX0.PSM, TEX0.TBW, t->m_TEX0.TBP0, t->m_TEX0.PSM, t->m_TEX0.TBW);
 							InvalidateSourcesFromTarget(t);
-							i = list->erase(i);
+							i = list.erase(i);
 							delete t;
 							continue;
 						}
@@ -3127,28 +3088,67 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 	}
 	else if (!is_frame && !GSConfig.UserHacks_DisableDepthSupport)
 	{
-		if (!dst_match)
+		const int rev_type = (type == DepthStencil) ? RenderTarget : DepthStencil;
+
+		// Depth stencil/RT can be an older RT/DS but only check recent RT/DS to avoid to pick
+		// some bad data.
+		auto& rev_list = m_dst[rev_type];
+		Target* dst_match = nullptr;
+		for (auto i = rev_list.begin(); i != rev_list.end(); ++i)
 		{
-			const int rev_type = (type == DepthStencil) ? RenderTarget : DepthStencil;
-			// Depth stencil/RT can be an older RT/DS but only check recent RT/DS to avoid to pick
-			// some bad data.
-			auto& rev_list = m_dst[rev_type];
-			for (auto i = rev_list.begin(); i != rev_list.end(); ++i)
+			Target* t = *i;
+			// Don't pull in targets without valid lower 24 bits unless the Z is 32bits and the alpha is valid, it makes no sense to convert them otherwise.
+			// FIXME: Technically the difference in size is fine, but if the target gets reinterpreted, the hw renderer doesn't rearrange the target.
+			// This does cause some extra uploads in some games (like Burnout), but without this, bad data gets displayed in games like Transformers.
+			if (bp != t->m_TEX0.TBP0 || (!t->m_valid_rgb && (!(GSUtil::GetChannelMask(TEX0.PSM) & 0x8) || !(t->m_valid_alpha_low || t->m_valid_alpha_high))) ||
+				(!is_shuffle && t->m_TEX0.TBW != TEX0.TBW && (possible_clear || ((~GSLocalMemory::m_psm[t->m_TEX0.PSM].fmsk | fbmask) == 0xffffffff))))
 			{
-				Target* t = *i;
-				// Don't pull in targets without valid lower 24 bits unless the Z is 32bits and the alpha is valid, it makes no sense to convert them otherwise.
-				// FIXME: Technically the difference in size is fine, but if the target gets reinterpreted, the hw renderer doesn't rearrange the target.
-				// This does cause some extra uploads in some games (like Burnout), but without this, bad data gets displayed in games like Transformers.
-				if (bp != t->m_TEX0.TBP0 || (!t->m_valid_rgb && (!(GSUtil::GetChannelMask(TEX0.PSM) & 0x8) || !(t->m_valid_alpha_low || t->m_valid_alpha_high))) ||
-					(!is_shuffle && t->m_TEX0.TBW != TEX0.TBW && (possible_clear || ((~GSLocalMemory::m_psm[t->m_TEX0.PSM].fmsk | fbmask) == 0xffffffff))))
+				continue;
+			}
+			// If the format is completely different, but it's the same location, it's likely just overwriting it, so get rid.
+			// Make sure it's not currently in use, that could be bad.
+			if (!is_shuffle && (!ds || (ds != t)) &&
+				t->m_TEX0.TBW != TEX0.TBW && TEX0.TBW != 1 && !preserve_rgb && min_rect.w > GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y)
+			{
+				if (src && src->m_target && src->m_from_target == t && src->m_target_direct)
 				{
-					continue;
+					src->m_target_direct = false;
+					src->m_shared_texture = false;
+					t->m_texture = nullptr;
 				}
-				// If the format is completely different, but it's the same location, it's likely just overwriting it, so get rid.
-				// Make sure it's not currently in use, that could be bad.
-				if (!is_shuffle && (!ds || (ds != t)) &&
-					t->m_TEX0.TBW != TEX0.TBW && TEX0.TBW != 1 && !preserve_rgb && min_rect.w > GSLocalMemory::m_psm[t->m_TEX0.PSM].pgs.y)
+
+				GL_CACHE("TC: Deleting Z draw %d", GSState::s_n);
+				InvalidateSourcesFromTarget(t);
+				i = rev_list.erase(i);
+				delete t;
+				continue;
+			}
+			const GSLocalMemory::psm_t& t_psm_s = GSLocalMemory::m_psm[t->m_TEX0.PSM];
+			if (t_psm_s.bpp != psm_s.bpp)
+			{
+				bool remove_target = possible_clear || (used && !is_shuffle);
+
+				// If we have a BW change, and it's not a multiple of 2 (for a shuffle), the game's going to get a jigsaw
+				// puzzle of pages and can't be expecting to have legitimate data. Tokimeki Memorial 3 reuses a BW 17
+				// buffer as BW 10, and if we don't discard the BW 17 buffer, the BW 10 buffer ends up twice the size.
+				const u32 shuffle_bw = (psm_s.bpp > t_psm_s.bpp) ? (TEX0.TBW / 2u) : (TEX0.TBW * 2u);
+				if (t->m_TEX0.TBW != TEX0.TBW && (t->m_TEX0.TBW != shuffle_bw && !is_shuffle))
 				{
+					// But we'll make sure the whole existing target's actually being drawn over to be safe.
+					const u32 end_block = GSLocalMemory::GetUnwrappedEndBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, draw_rect);
+					if (end_block >= t->UnwrappedEndBlock())
+					{
+						GL_CACHE("TC: Not converting %s at %x TBW %u with end block of %x when we're drawing through %x",
+							to_string(rev_type), t->m_TEX0.TBP0, t->m_TEX0.TBW, t->UnwrappedEndBlock(), end_block);
+						remove_target = true;
+					}
+				}
+
+				// Probably an old target, get rid of it.
+				if (remove_target)
+				{
+					// DT Racer hits this path and causes a crash when RT in RT is disabled,
+					// so let's make sure source and target texture isn't linked/shared before deleting the target.
 					if (src && src->m_target && src->m_from_target == t && src->m_target_direct)
 					{
 						src->m_target_direct = false;
@@ -3156,68 +3156,26 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 						t->m_texture = nullptr;
 					}
 
-					GL_CACHE("TC: Deleting Z draw %d", GSState::s_n);
 					InvalidateSourcesFromTarget(t);
 					i = rev_list.erase(i);
 					delete t;
 					continue;
 				}
-				const GSLocalMemory::psm_t& t_psm_s = GSLocalMemory::m_psm[t->m_TEX0.PSM];
-				if (t_psm_s.bpp != psm_s.bpp)
-				{
-					bool remove_target = possible_clear || (used && !is_shuffle);
+			}
 
-					// If we have a BW change, and it's not a multiple of 2 (for a shuffle), the game's going to get a jigsaw
-					// puzzle of pages and can't be expecting to have legitimate data. Tokimeki Memorial 3 reuses a BW 17
-					// buffer as BW 10, and if we don't discard the BW 17 buffer, the BW 10 buffer ends up twice the size.
-					const u32 shuffle_bw = (psm_s.bpp > t_psm_s.bpp) ? (TEX0.TBW / 2u) : (TEX0.TBW * 2u);
-					if (t->m_TEX0.TBW != TEX0.TBW && (t->m_TEX0.TBW != shuffle_bw && !is_shuffle))
-					{
-						// But we'll make sure the whole existing target's actually being drawn over to be safe.
-						const u32 end_block = GSLocalMemory::GetUnwrappedEndBlockAddress(TEX0.TBP0, TEX0.TBW, TEX0.PSM, draw_rect);
-						if (end_block >= t->UnwrappedEndBlock())
-						{
-							GL_CACHE("TC: Not converting %s at %x TBW %u with end block of %x when we're drawing through %x",
-								to_string(rev_type), t->m_TEX0.TBP0, t->m_TEX0.TBW, t->UnwrappedEndBlock(), end_block);
-							remove_target = true;
-						}
-					}
-
-					// Probably an old target, get rid of it.
-					if (remove_target)
-					{
-						// DT Racer hits this path and causes a crash when RT in RT is disabled,
-						// so let's make sure source and target texture isn't linked/shared before deleting the target.
-						if (src && src->m_target && src->m_from_target == t && src->m_target_direct)
-						{
-							src->m_target_direct = false;
-							src->m_shared_texture = false;
-							t->m_texture = nullptr;
-						}
-
-						InvalidateSourcesFromTarget(t);
-						i = rev_list.erase(i);
-						delete t;
-						continue;
-					}
-				}
-
-				if (t->m_age == 0)
-				{
-					dst_match = t;
-					break;
-				}
-				else if (t->m_age == 1 && (preserve_rgb || (preserve_alpha && (t->m_valid_alpha_low || t->m_valid_alpha_high))))
-				{
-					dst_match = t;
-				}
+			if (t->m_age == 0)
+			{
+				dst_match = t;
+				break;
+			}
+			else if (t->m_age == 1 && (preserve_rgb || (preserve_alpha && (t->m_valid_alpha_low || t->m_valid_alpha_high))))
+			{
+				dst_match = t;
 			}
 		}
-
+		// We only want to use a matched target if it's actually being used.
 		if (dst_match)
 		{
-			// dst_match, we only want to use a matched target if it's actually being used.
-
 			calcRescale(dst_match);
 
 			// If we don't need A, and the existing target doesn't have valid alpha, don't bother converting it.
@@ -3234,7 +3192,7 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 			// Clear instead of invalidating if there is anything which isn't touched.
 			clear |= (!preserve_target && fbmask != 0);
 			GIFRegTEX0 new_TEX0;
-			new_TEX0.TBP0 = GSConfig.UserHacks_TextureInsideRt >= GSTextureInRtMode::InsideTargets ? dst_match->m_TEX0.TBP0 : TEX0.TBP0;
+			new_TEX0.TBP0 = TEX0.TBP0;
 			new_TEX0.TBW = (!half_width) ? dst_match->m_TEX0.TBW : TEX0.TBW;
 			new_TEX0.PSM = is_shuffle ? dst_match->m_TEX0.PSM : TEX0.PSM;
 
@@ -3249,7 +3207,8 @@ GSTextureCache::Target* GSTextureCache::LookupTarget(GIFRegTEX0 TEX0, const GSVe
 			dst->m_valid_alpha_low = dst_match->m_valid_alpha_low; //&& psm_s.trbpp != 24;
 			dst->m_valid_alpha_high = dst_match->m_valid_alpha_high; //&& psm_s.trbpp != 24;
 			dst->m_valid_rgb = dst_match->m_valid_rgb && (dst->m_TEX0.TBW == TEX0.TBW || min_rect.w <= GSLocalMemory::m_psm[dst_match->m_TEX0.PSM].pgs.y);
-			dst->m_was_dst_matched = !dst_match->m_was_dst_matched;
+			dst->m_was_dst_matched = true;
+			dst_match->m_was_dst_matched = true;
 			dst_match->m_valid_rgb = preserve_rgb;
 
 			if (GSLocalMemory::m_psm[dst->m_TEX0.PSM].bpp == 16 && GSLocalMemory::m_psm[dst_match->m_TEX0.PSM].bpp > 16)
@@ -4418,7 +4377,6 @@ void GSTextureCache::InvalidateContainedTargets(u32 start_bp, u32 end_bp, u32 wr
 			t->m_valid_alpha_low &= preserve_alpha;
 			t->m_valid_alpha_high &= preserve_alpha;
 			t->m_valid_rgb &= (fb_mask & 0x00FFFFFF) != 0;
-			t->m_was_dst_matched = false;
 
 			// Don't keep partial depth buffers around.
 			if ((!t->m_valid_alpha_low && !t->m_valid_alpha_high && !t->m_valid_rgb) || type == DepthStencil)
@@ -4429,22 +4387,7 @@ void GSTextureCache::InvalidateContainedTargets(u32 start_bp, u32 end_bp, u32 wr
 					Target* const rev_t = *j;
 					if (rev_t->m_TEX0.TBP0 == t->m_TEX0.TBP0 && GSLocalMemory::m_psm[rev_t->m_TEX0.PSM].bpp == GSLocalMemory::m_psm[t->m_TEX0.PSM].bpp)
 					{
-						if (t->m_last_draw > rev_t->m_last_draw && GSUtil::GetChannelMask(t->m_TEX0.PSM) == GSUtil::GetChannelMask(rev_t->m_TEX0.PSM))
-						{
-							if (type == DepthStencil && GSUtil::GetChannelMask(t->m_TEX0.PSM) == 0x7)
-							{
-								rev_t->m_valid_rgb = false;
-								rev_t->m_was_dst_matched = false;
-							}
-							else
-							{
-								GL_CACHE("TC: InvalidateContainedTargets: Remove Target %s[%x, %s]", to_string(1 - type), rev_t->m_TEX0.TBP0, GSUtil::GetPSMName(rev_t->m_TEX0.PSM));
-								rev_list.erase(j);
-								delete rev_t;
-							}
-						}
-						else
-							rev_t->m_was_dst_matched = false;
+						rev_t->m_was_dst_matched = false;
 						break;
 					}
 					++j;
@@ -5148,14 +5091,14 @@ bool GSTextureCache::Move(u32 SBP, u32 SBW, u32 SPSM, int sx, int sy, u32 DBP, u
 	// We use dx/dy == 0 and the TBW check as a safeguard to make sure these go through to local memory.
 	// We can also recreate the target if it's previously been created in the height cache with a valid size.
 	// Good test case for this is the Xenosaga I cutscene transitions, or Gradius V.
-	if (src && !dst && ((((dx == 0 && dy == 0) || (dx == sx && dy == sy && DBW == src->m_TEX0.TBW)) && ((static_cast<u32>(w) + 63) / 64) <= DBW) || HasTargetInHeightCache(DBP, DBW, DPSM, 10)))
+	if (src && !dst && ((dx == 0 && dy == 0 && ((static_cast<u32>(w) + 63) / 64) <= DBW) || HasTargetInHeightCache(DBP, DBW, DPSM, 10)))
 	{
 		GIFRegTEX0 new_TEX0 = {};
 		new_TEX0.TBP0 = DBP;
 		new_TEX0.TBW = DBW;
 		new_TEX0.PSM = DPSM;
 
-		const GSVector2i target_size = (dx == 0 && dy == 0) ? GetTargetSize(DBP, DBW, DPSM, Common::AlignUpPow2(w, 64), h) : GSVector2i(src->m_valid.z, src->m_valid.w);
+		const GSVector2i target_size = GetTargetSize(DBP, DBW, DPSM, Common::AlignUpPow2(w, 64), h);
 		dst = LookupTarget(new_TEX0, target_size, src->m_scale, src->m_type);
 		if (!dst)
 		{

pcsx2/GS/Renderers/OpenGL/GSDeviceOGL.cpp

@@ -2628,6 +2628,12 @@ void GSDeviceOGL::RenderHW(GSHWDrawConfig& config)
 		SetupPipeline(psel);
 		PSSetShaderResource(3, primid_texture);
 	}
+	else if (config.destination_alpha == GSHWDrawConfig::DestinationAlphaMode::Depth)
+	{
+		PSSetShaderResource(2, config.rt);
+		config.rt = (config.rt == GLState::rt) ? nullptr : GLState::rt;
+		OMSetRenderTargets(config.rt, config.ds, &config.scissor);
+	}
 
 	if (config.blend.IsEffective(config.colormask))
 	{

pcsx2/GS/Renderers/Vulkan/GSDeviceVK.cpp

@@ -3131,7 +3131,7 @@ void GSDeviceVK::UpdateCLUTTexture(
 	GSTexture* sTex, float sScale, u32 offsetX, u32 offsetY, GSTexture* dTex, u32 dOffset, u32 dSize)
 {
 	// Super annoying, but apparently NVIDIA doesn't like floats/ints packed together in the same vec4?
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		u32 offsetX, offsetY, dOffset, pad1;
 		float scale;
@@ -3150,7 +3150,7 @@ void GSDeviceVK::UpdateCLUTTexture(
 void GSDeviceVK::ConvertToIndexedTexture(
 	GSTexture* sTex, float sScale, u32 offsetX, u32 offsetY, u32 SBW, u32 SPSM, GSTexture* dTex, u32 DBW, u32 DPSM)
 {
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		u32 SBW;
 		u32 DBW;
@@ -3171,7 +3171,7 @@ void GSDeviceVK::ConvertToIndexedTexture(
 
 void GSDeviceVK::FilteredDownsampleTexture(GSTexture* sTex, GSTexture* dTex, u32 downsample_factor, const GSVector2i& clamp_min, const GSVector4& dRect)
 {
-	struct alignas(16) Uniforms
+	struct Uniforms
 	{
 		GSVector2i clamp_min;
 		int downsample_factor;
@@ -4434,13 +4434,16 @@ void GSDeviceVK::RenderImGui()
 
 	UpdateImGuiTextures();
 
-	const GSVector4 uniforms(
-		2.0f / static_cast<float>(m_window_info.surface_width),
-		2.0f / static_cast<float>(m_window_info.surface_height),
-		-1.0f,
-		-1.0f);
+	const float uniforms[2][2] = {{
+									  2.0f / static_cast<float>(m_window_info.surface_width),
+									  2.0f / static_cast<float>(m_window_info.surface_height),
+								  },
+		{
+			-1.0f,
+			-1.0f,
+		}};
 
-	SetUtilityPushConstants(&uniforms, sizeof(uniforms));
+	SetUtilityPushConstants(uniforms, sizeof(uniforms));
 	SetPipeline(m_imgui_pipeline);
 
 	if (m_utility_sampler != m_linear_sampler)
@@ -5711,6 +5714,12 @@ void GSDeviceVK::RenderHW(GSHWDrawConfig& config)
 		case GSHWDrawConfig::DestinationAlphaMode::Stencil:
 			SetupDATE(draw_rt, config.ds, config.datm, config.drawarea);
 			break;
+
+		case GSHWDrawConfig::DestinationAlphaMode::Depth:
+			PSSetShaderResource(2, draw_rt, true);
+			draw_rt = (draw_rt == m_current_render_target) ? nullptr : m_current_render_target;
+			OMSetRenderTargets(draw_rt, draw_ds, config.scissor, static_cast<FeedbackLoopFlag>(pipe.feedback_loop_flags));
+			break;
 	}
 
 	// Switch to colclip target for colclip hw rendering

pcsx2/GameDatabase.cpp

@@ -380,6 +380,7 @@ static const char* s_gs_hw_fix_names[] = {
 	"trilinearFiltering",
 	"skipDrawStart",
 	"skipDrawEnd",
+	"halfBottomOverride",
 	"halfPixelOffset",
 	"roundSprite",
 	"nativeScaling",

pcsx2/GameDatabase.h

@@ -65,6 +65,7 @@ namespace GameDatabaseSchema
 		TrilinearFiltering,
 		SkipDrawStart,
 		SkipDrawEnd,
+		HalfBottomOverride,
 		HalfPixelOffset,
 		RoundSprite,
 		NativeScaling,

pcsx2/ImGui/FullscreenUI_Internal.h

@@ -1,496 +0,0 @@
-// SPDX-FileCopyrightText: 2002-2026 PCSX2 Dev Team
-// SPDX-License-Identifier: GPL-3.0+
-
-#pragma once
-
-#include "FullscreenUI.h"
-#include "ImGuiFullscreen.h"
-
-#include "common/Timer.h"
-#include "Input/InputManager.h"
-
-#define TR_CONTEXT "FullscreenUI"
-
-template <size_t L>
-class IconStackString : public SmallStackString<L>
-{
-public:
-	__fi IconStackString(const char* icon, const char* str)
-	{
-		SmallStackString<L>::format("{} {}", icon, Host::TranslateToStringView(TR_CONTEXT, str));
-	}
-	__fi IconStackString(const char8_t* icon, const char* str)
-	{
-		SmallStackString<L>::format("{} {}", reinterpret_cast<const char*>(icon), Host::TranslateToStringView(TR_CONTEXT, str));
-	}
-	__fi IconStackString(const char* icon, const char* str, const char* suffix)
-	{
-		SmallStackString<L>::format("{} {}##{}", icon, Host::TranslateToStringView(TR_CONTEXT, str), suffix);
-	}
-	__fi IconStackString(const char8_t* icon, const char* str, const char* suffix)
-	{
-		SmallStackString<L>::format("{} {}##{}", reinterpret_cast<const char*>(icon), Host::TranslateToStringView(TR_CONTEXT, str), suffix);
-	}
-};
-
-#define FSUI_ICONSTR(icon, str) IconStackString<256>(icon, str).c_str()
-#define FSUI_ICONSTR_S(icon, str, suffix) IconStackString<256>(icon, str, suffix).c_str()
-#define FSUI_STR(str) Host::TranslateToString(TR_CONTEXT, str)
-#define FSUI_CSTR(str) Host::TranslateToCString(TR_CONTEXT, str)
-#define FSUI_VSTR(str) Host::TranslateToStringView(TR_CONTEXT, str)
-#define FSUI_FSTR(str) fmt::runtime(Host::TranslateToStringView(TR_CONTEXT, str))
-#define FSUI_NSTR(str) str
-
-using ImGuiFullscreen::ActiveButton;
-using ImGuiFullscreen::AddNotification;
-using ImGuiFullscreen::BeginFullscreenColumns;
-using ImGuiFullscreen::BeginFullscreenColumnWindow;
-using ImGuiFullscreen::BeginFullscreenWindow;
-using ImGuiFullscreen::BeginHorizontalMenu;
-using ImGuiFullscreen::BeginMenuButtons;
-using ImGuiFullscreen::BeginNavBar;
-using ImGuiFullscreen::CenterImage;
-using ImGuiFullscreen::CloseChoiceDialog;
-using ImGuiFullscreen::CloseFileSelector;
-using ImGuiFullscreen::EndFullscreenColumns;
-using ImGuiFullscreen::EndFullscreenColumnWindow;
-using ImGuiFullscreen::EndFullscreenWindow;
-using ImGuiFullscreen::EndHorizontalMenu;
-using ImGuiFullscreen::EndMenuButtons;
-using ImGuiFullscreen::EndNavBar;
-using ImGuiFullscreen::EnumChoiceButton;
-using ImGuiFullscreen::FloatingButton;
-using ImGuiFullscreen::FocusResetType;
-using ImGuiFullscreen::ForceKeyNavEnabled;
-using ImGuiFullscreen::g_large_font;
-using ImGuiFullscreen::g_layout_padding_left;
-using ImGuiFullscreen::g_layout_padding_top;
-using ImGuiFullscreen::g_medium_font;
-using ImGuiFullscreen::GetCachedSvgTexture;
-using ImGuiFullscreen::GetCachedSvgTextureAsync;
-using ImGuiFullscreen::GetCachedTexture;
-using ImGuiFullscreen::GetCachedTextureAsync;
-using ImGuiFullscreen::GetPlaceholderTexture;
-using ImGuiFullscreen::GetQueuedFocusResetType;
-using ImGuiFullscreen::HorizontalMenuItem;
-using ImGuiFullscreen::HorizontalMenuSvgItem;
-using ImGuiFullscreen::InputFilterType;
-using ImGuiFullscreen::IsFocusResetQueued;
-using ImGuiFullscreen::IsGamepadInputSource;
-using ImGuiFullscreen::LAYOUT_FOOTER_HEIGHT;
-using ImGuiFullscreen::LAYOUT_LARGE_FONT_SIZE;
-using ImGuiFullscreen::LAYOUT_MEDIUM_FONT_SIZE;
-using ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT;
-using ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT_NO_SUMMARY;
-using ImGuiFullscreen::LAYOUT_MENU_BUTTON_X_PADDING;
-using ImGuiFullscreen::LAYOUT_MENU_BUTTON_Y_PADDING;
-using ImGuiFullscreen::LAYOUT_SCREEN_HEIGHT;
-using ImGuiFullscreen::LAYOUT_SCREEN_WIDTH;
-using ImGuiFullscreen::LayoutScale;
-using ImGuiFullscreen::LoadSvgTexture;
-using ImGuiFullscreen::LoadTexture;
-using ImGuiFullscreen::MenuButton;
-using ImGuiFullscreen::MenuButtonFrame;
-using ImGuiFullscreen::MenuButtonWithoutSummary;
-using ImGuiFullscreen::MenuButtonWithValue;
-using ImGuiFullscreen::MenuHeading;
-using ImGuiFullscreen::MenuHeadingButton;
-using ImGuiFullscreen::MenuImageButton;
-using ImGuiFullscreen::ModAlpha;
-using ImGuiFullscreen::MulAlpha;
-using ImGuiFullscreen::NavButton;
-using ImGuiFullscreen::NavTitle;
-using ImGuiFullscreen::OpenChoiceDialog;
-using ImGuiFullscreen::OpenConfirmMessageDialog;
-using ImGuiFullscreen::OpenFileSelector;
-using ImGuiFullscreen::OpenInfoMessageDialog;
-using ImGuiFullscreen::OpenInputStringDialog;
-using ImGuiFullscreen::PopPrimaryColor;
-using ImGuiFullscreen::PushPrimaryColor;
-using ImGuiFullscreen::QueueResetFocus;
-using ImGuiFullscreen::ResetFocusHere;
-using ImGuiFullscreen::RightAlignNavButtons;
-using ImGuiFullscreen::SetFullscreenFooterText;
-using ImGuiFullscreen::ShowToast;
-using ImGuiFullscreen::SvgScaling;
-using ImGuiFullscreen::ThreeWayToggleButton;
-using ImGuiFullscreen::ToggleButton;
-using ImGuiFullscreen::UIBackgroundColor;
-using ImGuiFullscreen::UIBackgroundHighlightColor;
-using ImGuiFullscreen::UIBackgroundLineColor;
-using ImGuiFullscreen::UIBackgroundTextColor;
-using ImGuiFullscreen::UIDisabledColor;
-using ImGuiFullscreen::UIPopupBackgroundColor;
-using ImGuiFullscreen::UIPrimaryColor;
-using ImGuiFullscreen::UIPrimaryDarkColor;
-using ImGuiFullscreen::UIPrimaryLightColor;
-using ImGuiFullscreen::UIPrimaryLineColor;
-using ImGuiFullscreen::UIPrimaryTextColor;
-using ImGuiFullscreen::UISecondaryColor;
-using ImGuiFullscreen::UISecondaryStrongColor;
-using ImGuiFullscreen::UISecondaryTextColor;
-using ImGuiFullscreen::UISecondaryWeakColor;
-using ImGuiFullscreen::UITextHighlightColor;
-using ImGuiFullscreen::WantsToCloseMenu;
-
-namespace FullscreenUI
-{
-	enum class MainWindowType
-	{
-		None,
-		Landing,
-		StartGame,
-		Exit,
-		GameList,
-		GameListSettings,
-		Settings,
-		PauseMenu,
-		Achievements,
-		Leaderboards,
-	};
-
-	enum class PauseSubMenu
-	{
-		None,
-		Exit,
-		Achievements,
-	};
-
-	enum class SettingsPage
-	{
-		Summary,
-		Interface,
-		BIOS,
-		Emulation,
-		Graphics,
-		Audio,
-		MemoryCard,
-		NetworkHDD,
-		Folders,
-		Achievements,
-		Controller,
-		Hotkey,
-		Advanced,
-		Patches,
-		Cheats,
-		GameFixes,
-		Count
-	};
-
-	enum class GameListView
-	{
-		Grid,
-		List,
-		Count
-	};
-
-	enum class IPAddressType
-	{
-		PS2IP,
-		SubnetMask,
-		Gateway,
-		DNS1,
-		DNS2,
-		Other
-	};
-
-	//////////////////////////////////////////////////////////////////////////
-	// Main
-	//////////////////////////////////////////////////////////////////////////
-	void UpdateGameDetails(std::string path, std::string serial, std::string title, u32 disc_crc, u32 crc);
-	bool AreAnyDialogsOpen();
-	void PauseForMenuOpen(bool set_pause_menu_open);
-	void ClosePauseMenu();
-	void OpenPauseSubMenu(PauseSubMenu submenu);
-	void DrawLandingTemplate(ImVec2* menu_pos, ImVec2* menu_size);
-	void DrawLandingWindow();
-	void DrawStartGameWindow();
-	void DrawExitWindow();
-	void DrawPauseMenu(MainWindowType type);
-	void ExitFullscreenAndOpenURL(const std::string_view url);
-	void CopyTextToClipboard(std::string title, const std::string_view text);
-	void DrawAboutWindow();
-	void OpenAboutWindow();
-	void GetStandardSelectionFooterText(SmallStringBase& dest, bool back_instead_of_cancel);
-	void ApplyLayoutSettings(const SettingsInterface* bsi = nullptr);
-
-	void DrawSvgTexture(GSTexture* padded_texture, ImVec2 unpadded_size);
-	void DrawCachedSvgTexture(const std::string& path, ImVec2 size, SvgScaling mode);
-	void DrawCachedSvgTextureAsync(const std::string& path, ImVec2 size, SvgScaling mode);
-	void DrawListSvgTexture(ImDrawList* drawList, GSTexture* padded_texture, const ImVec2& p_min, const ImVec2& p_unpadded_max);
-
-	inline MainWindowType s_current_main_window = MainWindowType::None;
-	inline PauseSubMenu s_current_pause_submenu = PauseSubMenu::None;
-	inline bool s_initialized = false;
-	inline bool s_tried_to_initialize = false;
-	inline bool s_pause_menu_was_open = false;
-	inline bool s_was_paused_on_quick_menu_open = false;
-	inline bool s_about_window_open = false;
-
-	// achievements login dialog state
-	inline bool s_achievements_login_open = false;
-	inline bool s_achievements_login_logging_in = false;
-	inline char s_achievements_login_username[256] = {};
-	inline char s_achievements_login_password[256] = {};
-	inline Achievements::LoginRequestReason s_achievements_login_reason = Achievements::LoginRequestReason::UserInitiated;
-
-	// local copies of the currently-running game
-	inline std::string s_current_game_title;
-	inline std::string s_current_game_subtitle;
-	inline std::string s_current_disc_serial;
-	inline std::string s_current_disc_path;
-	inline u32 s_current_disc_crc;
-
-	//////////////////////////////////////////////////////////////////////////
-	// Resources
-	//////////////////////////////////////////////////////////////////////////
-	bool LoadResources();
-	bool LoadSvgResources();
-	void DestroyResources();
-
-	inline std::array<std::shared_ptr<GSTexture>, static_cast<u32>(GameDatabaseSchema::Compatibility::Perfect)>
-		s_game_compatibility_textures;
-	inline std::shared_ptr<GSTexture> s_banner_texture;
-	inline std::vector<std::unique_ptr<GSTexture>> s_cleanup_textures;
-
-	//////////////////////////////////////////////////////////////////////////
-	// Landing
-	//////////////////////////////////////////////////////////////////////////
-	void SwitchToLanding();
-	ImGuiFullscreen::FileSelectorFilters GetOpenFileFilters();
-	ImGuiFullscreen::FileSelectorFilters GetDiscImageFilters();
-	ImGuiFullscreen::FileSelectorFilters GetAudioFileFilters();
-	ImGuiFullscreen::FileSelectorFilters GetImageFileFilters();
-	void DoVMInitialize(const VMBootParameters& boot_params, bool switch_to_landing_on_failure);
-	void DoStartPath(
-		const std::string& path, std::optional<s32> state_index = std::nullopt, std::optional<bool> fast_boot = std::nullopt);
-	void DoStartFile();
-	void DoStartBIOS();
-	void DoStartDisc(const std::string& drive);
-	void DoStartDisc();
-	void DoToggleFrameLimit();
-	void DoToggleSoftwareRenderer();
-	void RequestShutdown(bool save_state);
-	void DoShutdown(bool save_state);
-	void RequestReset();
-	void DoReset();
-	void DoChangeDiscFromFile();
-	void RequestChangeDisc();
-	void DoRequestExit();
-	void DoDesktopMode();
-	void DoToggleFullscreen();
-
-	void ConfirmShutdownIfMemcardBusy(std::function<void(bool)> callback);
-
-	bool ShouldDefaultToGameList();
-
-	//////////////////////////////////////////////////////////////////////////
-	// Save State List
-	//////////////////////////////////////////////////////////////////////////
-	struct SaveStateListEntry
-	{
-		std::string title;
-		std::string summary;
-		std::string path;
-		std::unique_ptr<GSTexture> preview_texture;
-		time_t timestamp;
-		s32 slot;
-	};
-
-	void InitializePlaceholderSaveStateListEntry(SaveStateListEntry* li, s32 slot);
-	bool InitializeSaveStateListEntry(
-		SaveStateListEntry* li, const std::string& title, const std::string& serial, u32 crc, s32 slot, bool backup = false);
-	void ClearSaveStateEntryList();
-	u32 PopulateSaveStateListEntries(const std::string& title, const std::string& serial, u32 crc);
-	bool OpenLoadStateSelectorForGame(const std::string& game_path);
-	bool OpenSaveStateSelector(bool is_loading);
-	void CloseSaveStateSelector();
-	void DrawSaveStateSelector(bool is_loading);
-	bool OpenLoadStateSelectorForGameResume(const GameList::Entry* entry);
-	void DrawResumeStateSelector();
-	void DoLoadState(std::string path, std::optional<s32> slot, bool backup);
-	void DoSaveState(s32 slot);
-
-	inline std::vector<SaveStateListEntry> s_save_state_selector_slots;
-	inline std::string s_save_state_selector_game_path;
-	inline s32 s_save_state_selector_submenu_index = -1;
-	inline bool s_save_state_selector_open = false;
-	inline bool s_save_state_selector_loading = true;
-	inline bool s_save_state_selector_resuming = false;
-
-	//////////////////////////////////////////////////////////////////////////
-	// Game List
-	//////////////////////////////////////////////////////////////////////////
-	void DrawGameListWindow();
-	void DrawGameList(const ImVec2& heading_size);
-	void DrawGameGrid(const ImVec2& heading_size);
-	void HandleGameListActivate(const GameList::Entry* entry);
-	void HandleGameListOptions(const GameList::Entry* entry);
-	void DrawGameListSettingsWindow();
-	void SwitchToGameList();
-	void PopulateGameListEntryList();
-	GSTexture* GetTextureForGameListEntryType(GameList::EntryType type, const ImVec2& size, SvgScaling mode = SvgScaling::Stretch);
-	GSTexture* GetGameListCover(const GameList::Entry* entry);
-	void DrawGameCover(const GameList::Entry* entry, const ImVec2& size);
-	void DrawGameCover(const GameList::Entry* entry, ImDrawList* draw_list, const ImVec2& min, const ImVec2& max);
-	// For when we have no GameList entry
-	void DrawFallbackCover(const ImVec2& size);
-	void DrawFallbackCover(ImDrawList* draw_list, const ImVec2& min, const ImVec2& max);
-
-	// Lazily populated cover images.
-	inline std::unordered_map<std::string, std::string> s_cover_image_map;
-	inline std::vector<const GameList::Entry*> s_game_list_sorted_entries;
-	inline GameListView s_game_list_view = GameListView::Grid;
-
-	//////////////////////////////////////////////////////////////////////////
-	// Background
-	//////////////////////////////////////////////////////////////////////////
-	void LoadCustomBackground();
-	void DrawCustomBackground();
-
-	inline std::shared_ptr<GSTexture> s_custom_background_texture;
-	inline std::string s_custom_background_path;
-	inline bool s_custom_background_enabled = false;
-
-	//////////////////////////////////////////////////////////////////////////
-	// Achievements
-	//////////////////////////////////////////////////////////////////////////
-	void SwitchToAchievementsWindow();
-	void SwitchToLeaderboardsWindow();
-	void DrawAchievementsLoginWindow();
-
-
-	//////////////////////////////////////////////////////////////////////////
-	// Settings
-	//////////////////////////////////////////////////////////////////////////
-	static constexpr double INPUT_BINDING_TIMEOUT_SECONDS = 5.0;
-	static constexpr u32 NUM_MEMORY_CARD_PORTS = 2;
-
-	void SwitchToSettings();
-	void SwitchToGameSettings();
-	void SwitchToGameSettings(const std::string& path);
-	void SwitchToGameSettings(const GameList::Entry* entry);
-	void SwitchToGameSettings(const std::string_view serial, u32 crc);
-	void DrawSettingsWindow();
-	void DrawSummarySettingsPage();
-	void DrawInterfaceSettingsPage();
-	void DrawBIOSSettingsPage();
-	void DrawEmulationSettingsPage();
-	void DrawGraphicsSettingsPage(SettingsInterface* bsi, bool show_advanced_settings);
-	void DrawAudioSettingsPage();
-	void DrawMemoryCardSettingsPage();
-	void DrawNetworkHDDSettingsPage();
-	void DrawFoldersSettingsPage();
-	void DrawAchievementsSettingsPage(std::unique_lock<std::mutex>& settings_lock);
-	void DrawControllerSettingsPage();
-	void DrawHotkeySettingsPage();
-	void DrawAdvancedSettingsPage();
-	void DrawPatchesOrCheatsSettingsPage(bool cheats);
-	void DrawGameFixesSettingsPage();
-
-	bool IsEditingGameSettings(SettingsInterface* bsi);
-	SettingsInterface* GetEditingSettingsInterface();
-	SettingsInterface* GetEditingSettingsInterface(bool game_settings);
-	bool ShouldShowAdvancedSettings(SettingsInterface* bsi);
-	void SetSettingsChanged(SettingsInterface* bsi);
-	bool GetEffectiveBoolSetting(SettingsInterface* bsi, const char* section, const char* key, bool default_value);
-	s32 GetEffectiveIntSetting(SettingsInterface* bsi, const char* section, const char* key, s32 default_value);
-	void DoCopyGameSettings();
-	void DoClearGameSettings();
-	void ResetControllerSettings();
-	void DoLoadInputProfile();
-	void DoSaveInputProfile();
-	void DoSaveInputProfile(const std::string& name);
-	void DoResetSettings();
-
-	bool DrawToggleSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		bool default_value, bool enabled = true, bool allow_tristate = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT,
-		std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawIntListSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		int default_value, const char* const* options, size_t option_count, bool translate_options, int option_offset = 0,
-		bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font,
-		std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawIntRangeSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		int default_value, int min_value, int max_value, const char* format = "%d", bool enabled = true,
-		float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawIntSpinBoxSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		int default_value, int min_value, int max_value, int step_value, const char* format = "%d", bool enabled = true,
-		float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawFloatRangeSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		float default_value, float min_value, float max_value, const char* format = "%f", float multiplier = 1.0f, bool enabled = true,
-		float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawFloatSpinBoxSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section,
-		const char* key, float default_value, float min_value, float max_value, float step_value, float multiplier,
-		const char* format = "%f", bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT,
-		std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawIntRectSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section,
-		const char* left_key, int default_left, const char* top_key, int default_top, const char* right_key, int default_right,
-		const char* bottom_key, int default_bottom, int min_value, int max_value, int step_value, const char* format = "%d",
-		bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font,
-		std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawStringListSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		const char* default_value, const char* const* options, const char* const* option_values, size_t option_count,
-		bool translate_options, bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font,
-		std::pair<ImFont*, float> summary_font = g_medium_font, const char* translation_ctx = "FullscreenUI");
-	void DrawStringListSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		const char* default_value, SettingInfo::GetOptionsCallback options_callback, bool enabled = true,
-		float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawIPAddressSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		const char* default_value, bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT,
-		std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font,
-		IPAddressType ip_type = IPAddressType::Other);
-	void DrawFloatListSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,
-		float default_value, const char* const* options, const float* option_values, size_t option_count, bool translate_options,
-		bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font,
-		std::pair<ImFont*, float> summary_font = g_medium_font);
-	template <typename DataType, typename SizeType>
-	void DrawEnumSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section,
-		const char* key, DataType default_value,
-		std::optional<DataType> (*from_string_function)(const char* str),
-		const char* (*to_string_function)(DataType value),
-		const char* (*to_display_string_function)(DataType value), SizeType option_count,
-		bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT,
-		std::pair<ImFont*, float> font = g_large_font, std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawFolderSetting(SettingsInterface* bsi, const char* title, const char* section, const char* key,
-		const std::string& runtime_var, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font,
-		std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawPathSetting(SettingsInterface* bsi, const char* title, const char* section, const char* key, const char* default_value,
-		bool enabled = true, float height = ImGuiFullscreen::LAYOUT_MENU_BUTTON_HEIGHT, std::pair<ImFont*, float> font = g_large_font,
-		std::pair<ImFont*, float> summary_font = g_medium_font);
-	void DrawClampingModeSetting(SettingsInterface* bsi, const char* title, const char* summary, int vunum);
-	void PopulateGraphicsAdapterList();
-	void PopulateGameListDirectoryCache(SettingsInterface* si);
-	void PopulatePatchesAndCheatsList(const std::string_view serial, u32 crc);
-	void BeginInputBinding(SettingsInterface* bsi, InputBindingInfo::Type type, const std::string_view section,
-		const std::string_view key, const std::string_view display_name);
-	void DrawInputBindingWindow();
-	void DrawInputBindingButton(SettingsInterface* bsi, InputBindingInfo::Type type, const char* section, const char* name, const char* display_name, const char* icon_name, bool show_type = true);
-	void ClearInputBindingVariables();
-	void StartAutomaticBinding(u32 port);
-	void DrawSettingInfoSetting(SettingsInterface* bsi, const char* section, const char* key, const SettingInfo& si,
-		const char* translation_ctx);
-	void OpenMemoryCardCreateDialog();
-	void DoCreateMemoryCard(std::string name, MemoryCardType type, MemoryCardFileType file_type, bool use_ntfs_compression = false);
-
-	inline SettingsPage s_settings_page = SettingsPage::Interface;
-	inline std::unique_ptr<INISettingsInterface> s_game_settings_interface;
-	inline std::unique_ptr<GameList::Entry> s_game_settings_entry;
-	inline std::vector<std::pair<std::string, bool>> s_game_list_directories_cache;
-	inline std::vector<GSAdapterInfo> s_graphics_adapter_list_cache;
-	inline std::vector<Patch::PatchInfo> s_game_patch_list;
-	inline std::vector<std::string> s_enabled_game_patch_cache;
-	inline std::vector<Patch::PatchInfo> s_game_cheats_list;
-	inline std::vector<std::string> s_enabled_game_cheat_cache;
-	inline u32 s_game_cheat_unlabelled_count = 0;
-	inline std::vector<const HotkeyInfo*> s_hotkey_list_cache;
-	inline std::atomic_bool s_settings_changed{false};
-	inline std::atomic_bool s_game_settings_changed{false};
-	inline InputBindingInfo::Type s_input_binding_type = InputBindingInfo::Type::Unknown;
-	inline std::string s_input_binding_section;
-	inline std::string s_input_binding_key;
-	inline std::string s_input_binding_display_name;
-	inline std::vector<InputBindingKey> s_input_binding_new_bindings;
-	inline std::vector<std::pair<InputBindingKey, std::pair<float, float>>> s_input_binding_value_ranges;
-	inline Common::Timer s_input_binding_timer;
-
-} // namespace FullscreenUI

pcsx2/SPU2/Debug.cpp

@@ -200,6 +200,7 @@ void SPU2::DoFullDump()
 				fprintf(dump, "  - Sound Start Address: %x\n", Cores[c].Voices[v].StartA);
 				fprintf(dump, "  - Next Data Address:   %x\n", Cores[c].Voices[v].NextA);
 				fprintf(dump, "  - Play Status:         %s\n", (Cores[c].Voices[v].ADSR.Phase > 0) ? "Playing" : "Not Playing");
+				fprintf(dump, "  - Block Sample:        %d\n", Cores[c].Voices[v].SCurrent);
 			}
 			fprintf(dump, "#### END OF DUMP.\n\n");
 		}

pcsx2/SPU2/Dma.cpp

@@ -163,7 +163,7 @@ void V_Core::StartADMAWrite(u16* pMem, u32 sz)
 	if ((AutoDMACtrl & (Index + 1)) == 0)
 	{
 		ActiveTSA = 0x2000 + (Index << 10);
-		DMAICounter = size * 48;
+		DMAICounter = size * 4;
 		LastClock = psxRegs.cycle;
 	}
 	else if (size >= 256)
@@ -191,7 +191,7 @@ void V_Core::StartADMAWrite(u16* pMem, u32 sz)
 		if (SPU2::MsgToConsole())
 			SPU2::ConLog("ADMA%c Error Size of %x too small\n", GetDmaIndexChar(), size);
 		InputDataLeft = 0;
-		DMAICounter = size * 48;
+		DMAICounter = size * 4;
 		LastClock = psxRegs.cycle;
 	}
 }
@@ -248,7 +248,7 @@ void V_Core::FinishDMAwrite()
 		DMA7LogWrite(DMAPtr, ReadSize << 1);
 #endif
 
-	u32 buff1end = ActiveTSA + std::min(ReadSize, (u32)0x100 + std::abs(DMAICounter / 48));
+	u32 buff1end = ActiveTSA + std::min(ReadSize, (u32)0x100 + std::abs(DMAICounter / 4));
 	u32 buff2end = 0;
 	if (buff1end > 0x100000)
 	{
@@ -343,7 +343,7 @@ void V_Core::FinishDMAwrite()
 	DMAPtr += TDA - ActiveTSA;
 	ReadSize -= TDA - ActiveTSA;
 
-	DMAICounter = (DMAICounter - ReadSize) * 48;
+	DMAICounter = (DMAICounter - ReadSize) * 4;
 
 	CounterUpdate(DMAICounter);
 
@@ -354,7 +354,7 @@ void V_Core::FinishDMAwrite()
 
 void V_Core::FinishDMAread()
 {
-	u32 buff1end = ActiveTSA + std::min(ReadSize, (u32)0x100 + std::abs(DMAICounter / 48));
+	u32 buff1end = ActiveTSA + std::min(ReadSize, (u32)0x100 + std::abs(DMAICounter / 4));
 	u32 buff2end = 0;
 
 	if (buff1end > 0x100000)
@@ -426,9 +426,9 @@ void V_Core::FinishDMAread()
 
 	// DMA Reads are done AFTER the delay, so to get the timing right we need to scheule one last DMA to catch IRQ's
 	if (ReadSize)
-		DMAICounter = std::min(ReadSize, (u32)0x100) * 48;
+		DMAICounter = std::min(ReadSize, (u32)0x100) * 4;
 	else
-		DMAICounter = 48;
+		DMAICounter = 4;
 
 	CounterUpdate(DMAICounter);
 
@@ -446,7 +446,7 @@ void V_Core::DoDMAread(u16* pMem, u32 size)
 	ReadSize = size;
 	IsDMARead = true;
 	LastClock = psxRegs.cycle;
-	DMAICounter = (std::min(ReadSize, (u32)0x100) * 48);
+	DMAICounter = std::min(ReadSize, (u32)0x100) * 4;
 	Regs.STATX &= ~0x80;
 	Regs.STATX |= 0x400;
 	//Regs.ATTR |= 0x30;
@@ -470,7 +470,7 @@ void V_Core::DoDMAwrite(u16* pMem, u32 size)
 	{
 		Regs.STATX &= ~0x80;
 		//Regs.ATTR |= 0x30;
-		DMAICounter = 1 * 48;
+		DMAICounter = 1 * 4;
 		LastClock = psxRegs.cycle;
 		return;
 	}

pcsx2/SPU2/Mixer.cpp

@@ -89,13 +89,55 @@ int g_counter_cache_ignores = 0;
 #define XAFLAG_LOOP (1ul << 1)
 #define XAFLAG_LOOP_START (1ul << 2)
 
-static __forceinline void GetNextDataBuffered(V_Core& thiscore, uint voiceidx)
+static __forceinline s32 GetNextDataBuffered(V_Core& thiscore, uint voiceidx)
 {
 	V_Voice& vc(thiscore.Voices[voiceidx]);
 
-	if (vc.SBuffer == nullptr)
+	if ((vc.SCurrent & 3) == 0)
 	{
-		const int cacheIdx = (vc.NextA & 0xFFFF8) / pcm_WordsPerBlock;
+		IncrementNextA(thiscore, voiceidx);
+
+		if ((vc.NextA & 7) == 0) // vc.SCurrent == 24 equivalent
+		{
+			if (vc.LoopFlags & XAFLAG_LOOP_END)
+			{
+				thiscore.Regs.ENDX |= (1 << voiceidx);
+				vc.NextA = vc.LoopStartA | 1;
+				if (!(vc.LoopFlags & XAFLAG_LOOP))
+				{
+					vc.Stop();
+
+					if (IsDevBuild)
+					{
+						if (SPU2::MsgVoiceOff())
+							SPU2::ConLog("* SPU2: Voice Off by EndPoint: %d \n", voiceidx);
+					}
+				}
+			}
+			else
+				vc.NextA++; // no, don't IncrementNextA here.  We haven't read the header yet.
+		}
+	}
+
+	if (vc.SCurrent == 28)
+	{
+		vc.SCurrent = 0;
+
+		// We'll need the loop flags and buffer pointers regardless of cache status:
+
+		for (int i = 0; i < 2; i++)
+			if (Cores[i].IRQEnable && Cores[i].IRQA == (vc.NextA & 0xFFFF8))
+				SetIrqCall(i);
+
+		s16* memptr = GetMemPtr(vc.NextA & 0xFFFF8);
+		vc.LoopFlags = *memptr >> 8; // grab loop flags from the upper byte.
+
+		if ((vc.LoopFlags & XAFLAG_LOOP_START) && !vc.LoopMode)
+		{
+			vc.LoopStartA = vc.NextA & 0xFFFF8;
+		}
+
+		const int cacheIdx = vc.NextA / pcm_WordsPerBlock;
 		PcmCacheEntry& cacheLine = pcm_cache_data[cacheIdx];
 		vc.SBuffer = cacheLine.Sampledata;
 
@@ -130,18 +172,46 @@ static __forceinline void GetNextDataBuffered(V_Core& thiscore, uint voiceidx)
 					g_counter_cache_misses++;
 			}
 
-
-			s16* memptr = GetMemPtr(vc.NextA & 0xFFFF8);
 			XA_decode_block(vc.SBuffer, memptr, vc.Prev1, vc.Prev2);
 		}
 	}
 
-	// Get the sample index for NextA, we have to subtract 1 to ignore the loop header
-	int sampleIdx = ((vc.NextA % pcm_WordsPerBlock) - 1) * 4;
-	for (int i = 0; i < 4; i++)
+	return vc.SBuffer[vc.SCurrent++];
+}
+
+static __forceinline void GetNextDataDummy(V_Core& thiscore, uint voiceidx)
+{
+	V_Voice& vc(thiscore.Voices[voiceidx]);
+
+	IncrementNextA(thiscore, voiceidx);
+
+	if ((vc.NextA & 7) == 0) // vc.SCurrent == 24 equivalent
 	{
-		vc.DecodeFifo[(vc.DecPosWrite + i) % 32] = vc.SBuffer[sampleIdx + i];
+		if (vc.LoopFlags & XAFLAG_LOOP_END)
+		{
+			thiscore.Regs.ENDX |= (1 << voiceidx);
+			vc.NextA = vc.LoopStartA | 1;
+		}
+		else
+			vc.NextA++; // no, don't IncrementNextA here.  We haven't read the header yet.
 	}
+
+	if (vc.SCurrent == 28)
+	{
+		for (int i = 0; i < 2; i++)
+			if (Cores[i].IRQEnable && Cores[i].IRQA == (vc.NextA & 0xFFFF8))
+				SetIrqCall(i);
+
+		vc.LoopFlags = *GetMemPtr(vc.NextA & 0xFFFF8) >> 8; // grab loop flags from the upper byte.
+
+		if ((vc.LoopFlags & XAFLAG_LOOP_START) && !vc.LoopMode)
+			vc.LoopStartA = vc.NextA & 0xFFFF8;
+
+		vc.SCurrent = 0;
+	}
+
+	vc.SP -= 0x1000 * (4 - (vc.SCurrent & 3));
+	vc.SCurrent += 4 - (vc.SCurrent & 3);
 }
 
 /////////////////////////////////////////////////////////////////////////////////////////
@@ -167,69 +237,6 @@ static __forceinline StereoOut32 ApplyVolume(const StereoOut32& data, const V_Vo
 		ApplyVolume(data.Right, volume.Right.Value));
 }
 
-static __forceinline void UpdateBlockHeader(V_Core& thiscore, uint voiceidx)
-{
-	V_Voice& vc(thiscore.Voices[voiceidx]);
-
-	for (int i = 0; i < 2; i++)
-		if (Cores[i].IRQEnable && Cores[i].IRQA == (vc.NextA & 0xFFFF8))
-			SetIrqCall(i);
-
-	s16* memptr = GetMemPtr(vc.NextA & 0xFFFF8);
-	vc.LoopFlags = *memptr >> 8; // grab loop flags from the upper byte.
-
-	if ((vc.LoopFlags & XAFLAG_LOOP_START) && !vc.LoopMode)
-	{
-		vc.LoopStartA = vc.NextA & 0xFFFF8;
-	}
-}
-
-static __forceinline void DecodeSamples(uint coreidx, uint voiceidx)
-{
-	V_Core& thiscore(Cores[coreidx]);
-	V_Voice& vc(thiscore.Voices[voiceidx]);
-
-	// Update the block header on every audio frame
-	UpdateBlockHeader(thiscore, voiceidx);
-
-	// When a voice is started at 0 pitch, NAX quickly advances to SSA + 5
-	// So that would mean the decode buffer holds around 12 samples
-	if (((int)(vc.DecPosWrite - vc.DecPosRead)) > 12) {
-		// Sufficient data buffered
-		return;
-	}
-
-	if (vc.ADSR.Phase > V_ADSR::PHASE_STOPPED)
-	{
-		GetNextDataBuffered(thiscore, voiceidx);
-	}
-
-	vc.DecPosWrite += 4;
-
-	IncrementNextA(thiscore, voiceidx);
-	if ((vc.NextA & 7) == 0)
-	{
-		if (vc.LoopFlags & XAFLAG_LOOP_END)
-		{
-			thiscore.Regs.ENDX |= (1 << voiceidx);
-			vc.NextA = vc.LoopStartA;
-			if (!(vc.LoopFlags & XAFLAG_LOOP))
-			{
-				vc.Stop();
-
-				if (IsDevBuild)
-				{
-					if (SPU2::MsgVoiceOff())
-						SPU2::ConLog("* SPU2: Voice Off by EndPoint: %d \n", voiceidx);
-				}
-			}
-		}
-
-		IncrementNextA(thiscore, voiceidx);
-		vc.SBuffer = nullptr;
-	}
-}
-
 static void __forceinline UpdatePitch(uint coreidx, uint voiceidx)
 {
 	V_Voice& vc(Cores[coreidx].Voices[voiceidx]);
@@ -271,27 +278,33 @@ static __forceinline void CalculateADSR(V_Core& thiscore, uint voiceidx)
 	pxAssume(vc.ADSR.Value >= 0); // ADSR should never be negative...
 }
 
-static __forceinline void ConsumeSamples(V_Core& thiscore, uint voiceidx)
+__forceinline static s32 GaussianInterpolate(s32 pv4, s32 pv3, s32 pv2, s32 pv1, s32 i)
 {
-	V_Voice& vc(thiscore.Voices[voiceidx]);
+	s32 out = 0;
+	out =  (interpTable[i][0] * pv4) >> 15;
+	out += (interpTable[i][1] * pv3) >> 15;
+	out += (interpTable[i][2] * pv2) >> 15;
+	out += (interpTable[i][3] * pv1) >> 15;
 
-	int consumed = vc.SP >> 12;
-	vc.SP &= 0xfff;
-	vc.DecPosRead += consumed;
+	return out;
 }
 
 static __forceinline s32 GetVoiceValues(V_Core& thiscore, uint voiceidx)
 {
 	V_Voice& vc(thiscore.Voices[voiceidx]);
 
-	int phase = (vc.SP & 0x0ff0) >> 4;
-	s32 out = 0;
-	out += (interpTable[phase][0] * vc.DecodeFifo[(vc.DecPosRead + 0) % 32]) >> 15;
-	out += (interpTable[phase][1] * vc.DecodeFifo[(vc.DecPosRead + 1) % 32]) >> 15;
-	out += (interpTable[phase][2] * vc.DecodeFifo[(vc.DecPosRead + 2) % 32]) >> 15;
-	out += (interpTable[phase][3] * vc.DecodeFifo[(vc.DecPosRead + 3) % 32]) >> 15;
+	while (vc.SP >= 0)
+	{
+		vc.PV4 = vc.PV3;
+		vc.PV3 = vc.PV2;
+		vc.PV2 = vc.PV1;
+		vc.PV1 = GetNextDataBuffered(thiscore, voiceidx);
+		vc.SP -= 0x1000;
+	}
 
-	return out;
+	const s32 mu = vc.SP + 0x1000;
+
+	return GaussianInterpolate(vc.PV4, vc.PV3, vc.PV2, vc.PV1, (mu & 0x0ff0) >> 4);
 }
 
 // This is Dr. Hell's noise algorithm as implemented in pcsxr
@@ -369,13 +382,21 @@ static __forceinline StereoOut32 MixVoice(uint coreidx, uint voiceidx)
 	V_Core& thiscore(Cores[coreidx]);
 	V_Voice& vc(thiscore.Voices[voiceidx]);
 
+	// If this assertion fails, it mans SCurrent is being corrupted somewhere, or is not initialized
+	// properly.  Invalid values in SCurrent will cause errant IRQs and corrupted audio.
+	pxAssertMsg((vc.SCurrent <= 28) && (vc.SCurrent != 0), "Current sample should always range from 1->28");
+
 	// Most games don't use much volume slide effects.  So only call the UpdateVolume
 	// methods when needed by checking the flag outside the method here...
 	// (Note: Ys 6 : Ark of Nephistm uses these effects)
 
 	vc.Volume.Update();
 
-	DecodeSamples(coreidx, voiceidx);
+	// SPU2 Note: The spu2 continues to process voices for eternity, always, so we
+	// have to run through all the motions of updating the voice regardless of it's
+	// audible status.  Otherwise IRQs might not trigger and emulation might fail.
+
+	UpdatePitch(coreidx, voiceidx);
 
 	StereoOut32 voiceOut(0, 0);
 	s32 Value = 0;
@@ -398,14 +419,11 @@ static __forceinline StereoOut32 MixVoice(uint coreidx, uint voiceidx)
 
 		voiceOut = ApplyVolume(StereoOut32(Value, Value), vc.Volume);
 	}
-
-	// SPU2 Note: The spu2 continues to process voices for eternity, always, so we
-	// have to run through all the motions of updating the voice regardless of it's
-	// audible status.  Otherwise IRQs might not trigger and emulation might fail.
-
-	UpdatePitch(coreidx, voiceidx);
-
-	ConsumeSamples(thiscore, voiceidx);
+	else
+	{
+		while (vc.SP >= 0)
+			GetNextDataDummy(thiscore, voiceidx); // Dummy is enough
+	}
 
 	// Write-back of raw voice data (post ADSR applied)
 	if (voiceidx == 1)
@@ -515,8 +533,7 @@ StereoOut32 V_Core::Mix(const VoiceMixSet& inVoices, const StereoOut32& Input, c
 	return TD + ApplyVolume(RV, FxVol);
 }
 
-static StereoOut32 DCFilter(StereoOut32 input)
-{
+static StereoOut32 DCFilter(StereoOut32 input) {
 	// A simple DC blocking high-pass filter
 	// Implementation from http://peabody.sapp.org/class/dmp2/lab/dcblock/
 	// The magic number 0x7f5c is ceil(INT16_MAX * 0.995)
@@ -617,9 +634,9 @@ __forceinline void spu2Mix()
 			if (SPU2::MsgCache())
 			{
 				SPU2::ConLog(" * SPU2 > CacheStats > Hits: %d  Misses: %d  Ignores: %d\n",
-					g_counter_cache_hits,
-					g_counter_cache_misses,
-					g_counter_cache_ignores);
+					   g_counter_cache_hits,
+					   g_counter_cache_misses,
+					   g_counter_cache_ignores);
 			}
 
 			g_counter_cache_hits =

pcsx2/SPU2/defs.h

@@ -256,16 +256,29 @@ struct V_Voice
 	// Sample pointer (19:12 bit fixed point)
 	s32 SP;
 
+	// Sample pointer for Cubic Interpolation
+	// Cubic interpolation mixes a sample behind Linear, so that it
+	// can have sample data to either side of the end points from which
+	// to extrapolate.  This SP represents that late sample position.
+	s32 SPc;
+
+	// Previous sample values - used for interpolation
+	// Inverted order of these members to match the access order in the
+	//   code (might improve cache hits).
+	s32 PV4;
+	s32 PV3;
+	s32 PV2;
+	s32 PV1;
+
 	// Last outputted audio value, used for voice modulation.
 	s32 OutX;
+	s32 NextCrest; // temp value for Crest calculation
 
 	// SBuffer now points directly to an ADPCM cache entry.
 	s16* SBuffer;
 
-	// Each voice has a buffer of decoded samples
-	s32 DecodeFifo[32];
-	u32 DecPosWrite;
-	u32 DecPosRead;
+	// sample position within the current decoded packet.
+	s32 SCurrent;
 
 	// it takes a few ticks for voices to start on the real SPU2?
 	void Start();

pcsx2/SPU2/spu2sys.cpp

@@ -181,6 +181,7 @@ void V_Core::Init(int index)
 		VoiceGates[v].WetR = -1;
 
 		Voices[v].Volume = V_VolumeSlideLR(0, 0); // V_VolumeSlideLR::Max;
+		Voices[v].SCurrent = 28;
 
 		Voices[v].ADSR.Counter = 0;
 		Voices[v].ADSR.Value = 0;
@@ -189,10 +190,6 @@ void V_Core::Init(int index)
 		Voices[v].NextA = 0x2801;
 		Voices[v].StartA = 0x2800;
 		Voices[v].LoopStartA = 0x2800;
-
-		memset(Voices[v].DecodeFifo, 0, sizeof(Voices[v].DecodeFifo));
-		Voices[v].DecPosRead = 0;
-		Voices[v].DecPosWrite = 0;
 	}
 
 	DMAICounter = 0;
@@ -215,18 +212,23 @@ void V_Voice::Start()
 	}
 
 	ADSR.Attack();
+	SCurrent = 28;
 	LoopMode = 0;
 
-	SP = 0;
+	// When SP >= 0 the next sample will be grabbed, we don't want this to happen
+	// instantly because in the case of pitch being 0 we want to delay getting
+	// the next block header. This is a hack to work around the fact that unlike
+	// the HW we don't update the block header on every cycle.
+	SP = -1;
 
 	LoopFlags = 0;
 	NextA = StartA | 1;
 	Prev1 = 0;
 	Prev2 = 0;
 
-	SBuffer = nullptr;
-	DecPosRead = 0;
-	DecPosWrite = 0;
+	PV1 = PV2 = 0;
+	PV3 = PV4 = 0;
+	NextCrest = -0x8000;
 }
 
 void V_Voice::Stop()
@@ -987,10 +989,12 @@ static void RegWrite_VoiceAddr(u16 value)
 			// Wallace And Gromit: Curse Of The Were-Rabbit.
 
 			thisvoice.NextA = ((u32)(value & 0x0F) << 16) | (thisvoice.NextA & 0xFFF8) | 1;
+			thisvoice.SCurrent = 28;
 			break;
 
 		case 5:
 			thisvoice.NextA = (thisvoice.NextA & 0x0F0000) | (value & 0xFFF8) | 1;
+			thisvoice.SCurrent = 28;
 			break;
 	}
 }
@@ -1208,6 +1212,7 @@ static void RegWrite_Core(u16 value)
 				for (uint v = 0; v < 24; ++v)
 				{
 					Cores[1].Voices[v].Volume = V_VolumeSlideLR(0, 0); // V_VolumeSlideLR::Max;
+					Cores[1].Voices[v].SCurrent = 28;
 
 					Cores[1].Voices[v].ADSR.Value = 0;
 					Cores[1].Voices[v].ADSR.Phase = 0;

pcsx2/SaveState.h

@@ -26,7 +26,7 @@ enum class FreezeAction
 // [SAVEVERSION+]
 // This informs the auto updater that the users savestates will be invalidated.
 
-static const u32 g_SaveVersion = (0x9A57 << 16) | 0x0000;
+static const u32 g_SaveVersion = (0x9A55 << 16) | 0x0000;
 
 
 // the freezing data between submodules and core

pcsx2/pcsx2.vcxproj

@@ -254,7 +254,6 @@
     <ClCompile Include="Host\SDLAudioStream.cpp" />
     <ClCompile Include="Hotkeys.cpp" />
     <ClCompile Include="ImGui\FullscreenUI.cpp" />
-    <ClCompile Include="ImGui\FullscreenUI_Settings.cpp" />
     <ClCompile Include="ImGui\ImGuiFullscreen.cpp" />
     <ClCompile Include="ImGui\ImGuiManager.cpp" />
     <ClCompile Include="ImGui\ImGuiOverlays.cpp" />
@@ -701,7 +700,6 @@
     <ClInclude Include="Host\AudioStream.h" />
     <ClInclude Include="Host\AudioStreamTypes.h" />
     <ClInclude Include="ImGui\FullscreenUI.h" />
-    <ClInclude Include="ImGui\FullscreenUI_Internal.h" />
     <ClInclude Include="ImGui\ImGuiAnimated.h" />
     <ClInclude Include="ImGui\ImGuiFullscreen.h" />
     <ClInclude Include="ImGui\ImGuiManager.h" />

pcsx2/pcsx2.vcxproj.filters

@@ -1352,9 +1352,6 @@
     <ClCompile Include="ImGui\FullscreenUI.cpp">
       <Filter>Misc\ImGui</Filter>
     </ClCompile>
-    <ClCompile Include="ImGui\FullscreenUI_Settings.cpp">
-      <Filter>Misc\ImGui</Filter>
-    </ClCompile>
     <ClCompile Include="ImGui\ImGuiFullscreen.cpp">
       <Filter>Misc\ImGui</Filter>
     </ClCompile>
@@ -2307,9 +2304,6 @@
     <ClInclude Include="ImGui\FullscreenUI.h">
       <Filter>Misc\ImGui</Filter>
     </ClInclude>
-    <ClInclude Include="ImGui\FullscreenUI_Internal.h">
-      <Filter>Misc\ImGui</Filter>
-    </ClInclude>
     <ClInclude Include="ImGui\ImGuiFullscreen.h">
       <Filter>Misc\ImGui</Filter>
     </ClInclude>

tools/generate_fullscreen_ui_translation_strings.py

@@ -5,110 +5,90 @@ import os
 START_IDENT = "// TRANSLATION-STRING-AREA-BEGIN"
 END_IDENT = "// TRANSLATION-STRING-AREA-END"
 
-src_files = [
-    os.path.join(os.path.dirname(__file__), "..", "pcsx2", "ImGui", "FullscreenUI.cpp"),
-    os.path.join(os.path.dirname(__file__), "..", "pcsx2", "ImGui", "FullscreenUI_Settings.cpp"),
-]
+src_file = os.path.join(os.path.dirname(__file__), "..", "pcsx2", "ImGui", "FullscreenUI.cpp")
 
-def extract_strings_from_source(source_content):
-    """Extract FSUI translation strings from source content."""
-    strings = []
-    for token in ["FSUI_STR", "FSUI_CSTR", "FSUI_FSTR", "FSUI_NSTR", "FSUI_VSTR", "FSUI_ICONSTR", "FSUI_ICONSTR_S"]:
-        token_len = len(token)
-        last_pos = 0
-        while True:
-            last_pos = source_content.find(token, last_pos)
-            if last_pos < 0:
-                break
+with open(src_file, "r") as f:
+    full_source = f.read()
 
-            if last_pos >= 8 and source_content[last_pos - 8:last_pos] == "#define ":
-                last_pos += len(token)
-                continue
+strings = []
+for token in ["FSUI_STR", "FSUI_CSTR", "FSUI_FSTR", "FSUI_NSTR", "FSUI_VSTR", "FSUI_ICONSTR", "FSUI_ICONSTR_S"]:
+    token_len = len(token)
+    last_pos = 0
+    while True:
+        last_pos = full_source.find(token, last_pos)
+        if last_pos < 0:
+            break
 
-            if source_content[last_pos + token_len] == '(':
-                start_pos = last_pos + token_len + 1
-                end_pos = source_content.find(")", start_pos)
-                s = source_content[start_pos:end_pos]
-
-                # Split into string arguments, removing "
-                string_args = [""]
-                arg = 0;
-                cpos = s.find(',')
-                pos = s.find('"')
-                while pos >= 0 or cpos >= 0:
-                    assert pos == 0 or s[pos - 1] != '\\'
-                    if cpos == -1 or pos < cpos:
-                        epos = pos
-                        while True:
-                            epos = s.find('"', epos + 1)
-                            # found ')' in string, extend s to next ')'
-                            if epos == -1:
-                                end_pos = source_content.find(")", end_pos + 1)
-                                s = source_content[start_pos:end_pos]
-                                epos = pos
-                                continue
-
-                            if s[epos - 1] == '\\':
-                                continue
-                            else:
-                                break
-
-                        assert epos > pos
-                        string_args[arg] += s[pos+1:epos]
-                        cpos = s.find(',', epos + 1)
-                        pos = s.find('"', epos + 1)
-                    else:
-                        arg += 1
-                        string_args.append("")
-                        cpos = s.find(',', cpos + 1)
-
-                print(string_args)
-
-                # FSUI_ICONSTR and FSUI_ICONSTR_S need to translate the only the second argument
-                # other defines take only a single argument
-                if len(string_args) >= 2:
-                    new_s = string_args[1]
-                else:
-                    new_s = string_args[0]
-
-                assert len(new_s) > 0
-
-                if new_s not in strings:
-                    strings.append(new_s)
+        if last_pos >= 8 and full_source[last_pos - 8:last_pos] == "#define ":
             last_pos += len(token)
-    return strings
+            continue
 
-def process_file(src_file):
-    """Process a single source file extract strings and update its translation area."""
-    print(f"\nProcessing: {src_file}")
-    
-    with open(src_file, "r") as f:
-        source = f.read()
+        if full_source[last_pos + token_len] == '(':
+            start_pos = last_pos + token_len + 1
+            end_pos = full_source.find(")", start_pos)
+            s = full_source[start_pos:end_pos]
 
-    start = source.find(START_IDENT)
-    end = source.find(END_IDENT)
-    
-    if start < 0 or end <= start:
-        print(f"  Warning: No translation string area found in {src_file}")
-        return 0
-    
-    source_without_area = source[:start] + source[end + len(END_IDENT):]
-    strings = extract_strings_from_source(source_without_area)
-    
-    print(f"  Found {len(strings)} unique strings.")
-    
-    new_area = ""
-    for string in strings:
-        new_area += f"TRANSLATE_NOOP(\"FullscreenUI\", \"{string}\");\n"
-    
-    new_source = source[:start + len(START_IDENT) + 1] + new_area + source[end:]
-    with open(src_file, "w") as f:
-        f.write(new_source)
-    
-    return len(strings)
+            # Split into sting arguments, removing "
+            string_args = [""]
+            arg = 0;
+            cpos = s.find(',')
+            pos = s.find('"')
+            while pos >= 0 or cpos >= 0:
+                assert pos == 0 or s[pos - 1] != '\\'
+                if cpos == -1 or pos < cpos:
+                    epos = pos
+                    while True:
+                        epos = s.find('"', epos + 1)
+                        # found ')' in string, extend s to next ')'
+                        if epos == -1:
+                            end_pos = full_source.find(")", end_pos + 1)
+                            s = full_source[start_pos:end_pos]
+                            epos = pos
+                            continue
 
-total_strings = 0
-for src_file in src_files:
-    total_strings += process_file(src_file)
+                        if s[epos - 1] == '\\':
+                            continue
+                        else:
+                            break
 
-print(f"\nTotal: {total_strings} unique strings across all files.")
+                    assert epos > pos
+                    string_args[arg] += s[pos+1:epos]
+                    cpos = s.find(',', epos + 1)
+                    pos = s.find('"', epos + 1)
+                else:
+                    arg += 1
+                    string_args.append("")
+                    cpos = s.find(',', cpos + 1)
+
+            print(string_args)
+
+            # FSUI_ICONSTR and FSUI_ICONSTR_S need to translate the only the second argument
+            # other defines take only a single argument
+            if len(string_args) >= 2:
+                new_s = string_args[1]
+            else:
+                new_s = string_args[0]
+
+            assert len(new_s) > 0
+
+            #assert (end_pos - start_pos) < 300
+            #if (end_pos - start_pos) >= 300:
+            #    print("WARNING: Long string")
+            #    print(new_s)
+            if new_s not in strings:
+                strings.append(new_s)
+        last_pos += len(token)
+
+print(f"Found {len(strings)} unique strings.")
+
+start = full_source.find(START_IDENT)
+end = full_source.find(END_IDENT)
+assert start >= 0 and end > start
+
+new_area = ""
+for string in list(strings):
+    new_area += f"TRANSLATE_NOOP(\"FullscreenUI\", \"{string}\");\n"
+
+full_source = full_source[:start+len(START_IDENT)+1] + new_area + full_source[end:]
+with open(src_file, "w") as f:
+    f.write(full_source)