RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-30 16:53:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a crash where ConstantVec nodes were being generated with the wrong

Browse Source 
type when the target did not support them.  Also teach Legalize how to
expand ConstantVecs.

This allows us to generate

_test:
        lwz r2, 12(r3)
        lwz r4, 8(r3)
        lwz r5, 4(r3)
        lwz r6, 0(r3)
        addi r2, r2, 4
        addi r4, r4, 3
        addi r5, r5, 2
        addi r6, r6, 1
        stw r2, 12(r3)
        stw r4, 8(r3)
        stw r5, 4(r3)
        stw r6, 0(r3)
        blr

For:

void %test(%v4i *%P) {
        %T = load %v4i* %P
        %S = add %v4i %T, <int 1, int 2, int 3, int 4>
        store %v4i %S, %v4i * %P
        ret void
}

On PowerPC.

llvm-svn: 24633
This commit is contained in:
Nate Begeman 2005-12-07 19:48:11 +00:00
parent 055ecd8533
commit 589dff9a20
2 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
View File

@ -3159,6 +3159,28 @@ void SelectionDAGLegalize::ExpandOp(SDOperand Op, SDOperand &Lo, SDOperand &Hi){
Hi = DAG.getConstant(Cst >> MVT::getSizeInBits(NVT), NVT);
break;
}
case ISD::ConstantVec: {
unsigned NumElements = Node->getNumOperands();
// If we only have two elements left in the constant vector, just break it
// apart into the two scalar constants it contains. Otherwise, bisect the
// ConstantVec, and return each half as a new ConstantVec.
// FIXME: this is hard coded as big endian, it may have to change to support
// SSE and Alpha MVI
if (NumElements == 2) {
Hi = Node->getOperand(0);
Lo = Node->getOperand(1);
} else {
NumElements /= 2;
std::vector<SDOperand> LoOps, HiOps;
for (unsigned I = 0, E = NumElements; I < E; ++I) {
HiOps.push_back(Node->getOperand(I));
LoOps.push_back(Node->getOperand(I+NumElements));
}
Lo = DAG.getNode(ISD::ConstantVec, MVT::Vector, LoOps);
Hi = DAG.getNode(ISD::ConstantVec, MVT::Vector, HiOps);
}
break;
}
case ISD::BUILD_PAIR:
// Legalize both operands. FIXME: in the future we should handle the case

10
lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
View File

@ -318,9 +318,15 @@ public:
}
// Handle the case where we have a 1-element vector, in which
// case we want to immediately turn it into a scalar constant.
if (Ops.size() == 1)
if (Ops.size() == 1) {
return N = Ops[0];
return N = DAG.getNode(ISD::ConstantVec, TVT, Ops);
} else if (TVT != MVT::Other && TLI.isTypeLegal(TVT)) {
return N = DAG.getNode(ISD::ConstantVec, TVT, Ops);
} else {
// If the packed type isn't legal, then create a ConstantVec node with
// generic Vector type instead.
return N = DAG.getNode(ISD::ConstantVec, MVT::Vector, Ops);
}
} else {
// Canonicalize all constant ints to be unsigned.
return N = DAG.getConstant(cast<ConstantIntegral>(C)->getRawValue(),VT);