RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-04-01 07:11:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[AddressSanitizer] Only instrument globals of default address space

Browse Source 
The address sanitizer ignore memory accesses from different address
spaces, however when instrumenting globals the check for different
address spaces is missing. This result in assertion failure. The fault
was found in an out of tree target.

The patch skip all globals of non default address space.

Reviewed By: leonardchan, vitalybuka

Differential Revision: https://reviews.llvm.org/D68790
This commit is contained in:
Karl-Johan Karlsson 2019-10-30 07:45:39 +01:00
parent 6f49436f61
commit d179aa00b3
2 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Transforms/Instrumentation/AddressSanitizer.cpp
View File

@ -1808,6 +1808,8 @@ bool ModuleAddressSanitizer::ShouldInstrumentGlobal(GlobalVariable *G) {
if (GlobalsMD.get(G).IsBlacklisted) return false;
if (!Ty->isSized()) return false;
if (!G->hasInitializer()) return false;
// Only instrument globals of default address spaces
if (G->getAddressSpace()) return false;
if (GlobalWasGeneratedByCompiler(G)) return false; // Our own globals.
// Two problems with thread-locals:
// - The address of the main thread's copy can't be computed at link-time.

31
test/Instrumentation/AddressSanitizer/global_addrspace.ll Normal file
View File

@ -0,0 +1,31 @@
; Only verify that asan don't crash on global variables of different
; address space. The global variable should be unmodified by asan.
; RUN: opt < %s -asan -asan-module -S | FileCheck %s
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@a = internal addrspace(42) global [1 x i32] zeroinitializer, align 4
; CHECK: @a = internal addrspace(42) global [1 x i32] zeroinitializer, align 4
define void @b(i32 %c) {
entry:
%conv = sext i32 %c to i64
%0 = inttoptr i64 %conv to i32 addrspace(42)*
%cmp = icmp ugt i32 addrspace(42)* %0, getelementptr inbounds ([1 x i32], [1 x i32] addrspace(42)* @a, i64 0, i64 0)
br i1 %cmp, label %if.then, label %if.end
if.then:
%call = tail call i32 (...) @e()
br label %if.end
if.end:
ret void
}
declare i32 @e(...)
!llvm.asan.globals = !{!0}
!0 = !{[1 x i32] addrspace(42)* @a, null, !"a", i1 false, i1 false}