RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-29 15:04:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
41,475 Commits 4 Branches 5 Tags 634 MiB
60dc0b5cbe
Commit Graph

4492 Commits

Author SHA1 Message Date
Evan Cheng
7218339189 Fix PR2296. Do not transform x86_sse2_storel_dq into a full-width store. 
llvm-svn: 53666
 2008-07-16 07:28:14 +00:00
Owen Anderson
e12f7904ff Revert this, as it seems to still be broken. 
llvm-svn: 53627
 2008-07-15 17:59:02 +00:00
Owen Anderson
73bdb28e89 Enable local PRE by default. 
llvm-svn: 53616
 2008-07-15 16:28:23 +00:00
Owen Anderson
f1b3898e7f Have GVN do a pre-pass over the CFG that folds away unconditional branches where possible. This allows local PRE to be more aggressive. 
llvm-svn: 53615
 2008-07-15 16:28:06 +00:00
Matthijs Kooijman
f9532fe71b Allow deadargelim to change return types even though now values were dead. This 
again canonicalizes {i32} into i32 and {} into void.

llvm-svn: 53610
 2008-07-15 14:42:31 +00:00
Matthijs Kooijman
18c6979fed Revert r53606. It turns out that explicitely tracking the liveness of the 
return value as a whole in deadargelim is really not needed now that we simply
rebuild the old return value and actually prevents some canonicalization from
taking place.

This revert stops deadargelim from changing {i32} into i32 for now, but I'll
fix that next.

llvm-svn: 53609
 2008-07-15 14:39:36 +00:00
Matthijs Kooijman
f940585c1c Make deadargelim a bit less smart, so it doesn't choke on nested structs as 
return values that are still (partially) live. Instead of updating all uses of
a call instruction after removing some elements, it now just rebuilds the
original struct (With undef gaps where the unused values were) and leaves it to
instcombine to clean this up.

The added testcase still fails currently, but this is due to instcombine which
isn't good enough yet. I will fix that part next.

llvm-svn: 53608
 2008-07-15 14:03:10 +00:00
Matthijs Kooijman
50a2233b45 Don't use isa when we can reuse a previous dyn_cast. 
llvm-svn: 53607
 2008-07-15 13:39:08 +00:00
Matthijs Kooijman
4b75601340 Make DeadArgElim keep liveness of the return value as a whole in addition to 
only the liveness of partial return values (for functions returning a struct).
This is more explicit to prevent unwanted changes in the return value. 

In particular, deadargelim now canonicalizes a function returning {i32} to
returning i32 and {} to void, if the struct returned is not used in its
entirety, but only the single element is used.

llvm-svn: 53606
 2008-07-15 13:36:06 +00:00
Matthijs Kooijman
86a46174fe Let DAE keep a list of live functions, instead of simply marking all arguments 
and return values live for those functions. This doesn't change anything yet,
but prepares for the coming commits.

llvm-svn: 53601
 2008-07-15 09:11:16 +00:00
Matthijs Kooijman
caa3ed0c99 Split DAE::MarkLive into MarkLive and PropagateLiveness. 
llvm-svn: 53600
 2008-07-15 09:00:17 +00:00
Matthijs Kooijman
31b7208f7d Pass around const RetOrArg references instead of copying values. Also, mark 
RetOrArg::getDescription() as const.

llvm-svn: 53599
 2008-07-15 08:56:49 +00:00
Matthijs Kooijman
937016427b Simplify debug code by using RetOrArg::getDescription(). 
llvm-svn: 53598
 2008-07-15 08:53:36 +00:00
Matthijs Kooijman
c9c8644910 Fix indentation (intentionally left out of the previous commit). 
llvm-svn: 53592
 2008-07-15 08:47:32 +00:00
Matthijs Kooijman
52acc10fdc Move the deadargelim code for intrinsically alive functions into its own 
method, to slightly simplify control flow.

llvm-svn: 53591
 2008-07-15 08:45:12 +00:00
Dan Gohman
8280b2e66e Fix uninitialized use of the Changed variable. 
llvm-svn: 53564
 2008-07-14 17:55:01 +00:00
Chris Lattner
8a9725bffe Reapply r53540, now with the matching header! 
llvm-svn: 53557
 2008-07-14 17:32:59 +00:00
Duncan Sands
63940a7330 Revert r53540 - it does not compile. 
llvm-svn: 53549
 2008-07-14 07:59:28 +00:00
Chris Lattner
6841e1dc33 If a function calls setjmp, never inline it into other functions. This is 
a hack around the fact that we don't represent the CFG correctly for sj/lj.
It fixes PR2486.

llvm-svn: 53540
 2008-07-14 00:46:56 +00:00
Chris Lattner
f8e9922213 simplify some code, shuffle and insertelt always return a vector. 
llvm-svn: 53538
 2008-07-14 00:32:20 +00:00
Chris Lattner
14faada3a3 Fix PR2506 by being a bit more careful about reverse fact propagation when 
disproving a condition.  This actually compiles the existing testcase
(udiv_select_to_select_shift) to:

define i64 @test(i64 %X, i1 %Cond) {
entry:
	%divisor1.t = lshr i64 %X, 3		; <i64> [#uses=1]
	%quotient2 = lshr i64 %X, 3		; <i64> [#uses=1]
	%sum = add i64 %divisor1.t, %quotient2		; <i64> [#uses=1]
	ret i64 %sum
}

instead of:

define i64 @test(i64 %X, i1 %Cond) {
entry:
	%quotient1.v = select i1 %Cond, i64 3, i64 4		; <i64> [#uses=1]
	%quotient1 = lshr i64 %X, %quotient1.v		; <i64> [#uses=1]
	%quotient2 = lshr i64 %X, 3		; <i64> [#uses=1]
	%sum = add i64 %quotient1, %quotient2		; <i64> [#uses=1]
	ret i64 %sum
}

llvm-svn: 53534
 2008-07-14 00:15:52 +00:00
Chris Lattner
3444f4d4c4 Fix mishandling of the infinite loop case when merging two blocks. This 
fixes PR2540.

llvm-svn: 53533
 2008-07-13 22:23:11 +00:00
Chris Lattner
7cb257551f more refactoring. Use early exits instead of really complex logic. 
No functionality change.

llvm-svn: 53532
 2008-07-13 22:04:41 +00:00
Chris Lattner
a4a80e0092 improve comments. 
llvm-svn: 53531
 2008-07-13 21:55:46 +00:00
Chris Lattner
824fbca1ee factor another large hunk of code out into its own function. 
No functionality change.

llvm-svn: 53530
 2008-07-13 21:53:26 +00:00
Chris Lattner
67bf4acd15 Final bit of simplification for FoldBranchToCommonDest. 
llvm-svn: 53528
 2008-07-13 21:20:19 +00:00
Chris Lattner
3346d311c7 simplify logic a bit 
llvm-svn: 53527
 2008-07-13 21:15:11 +00:00
Chris Lattner
2ac1854097 Refactor some code out into its own helper function, getting rid of crazy multiline 
conditionals and commenting the code better.

No functionality change.

llvm-svn: 53526
 2008-07-13 21:12:01 +00:00
Nick Lewycky
3fb5816774 Enhance analysis of srem. 
Remove dead code analyzing urem. 'urem' of power-of-2 is canonicalized to an
'and' instruction.

llvm-svn: 53506
 2008-07-12 05:04:38 +00:00
Dan Gohman
d1342570f2 Use find instead of lower_bound. 
llvm-svn: 53474
 2008-07-11 20:58:19 +00:00
Owen Anderson
cc861329ee Don't call lookupNumber more than we have to. 
llvm-svn: 53470
 2008-07-11 20:05:13 +00:00
Nick Lewycky
cafc3d583d Document 'mask' in this calculation. 
llvm-svn: 53454
 2008-07-11 08:16:26 +00:00
Nick Lewycky
12c88a28f5 Remove misleading constant from comment. 
llvm-svn: 53452
 2008-07-11 07:36:19 +00:00
Nick Lewycky
8cd0f2058e Add another optimization from PR2330. Also catch some missing cases that are 
similar.

llvm-svn: 53451
 2008-07-11 07:20:53 +00:00
Chris Lattner
07bfade2d4 a missed optimization that Eli spotted 
llvm-svn: 53449
 2008-07-11 06:40:29 +00:00
Chris Lattner
34b0895d4d another bug in the same line. 
llvm-svn: 53448
 2008-07-11 06:38:16 +00:00
Chris Lattner
3cdb6789b9 fix a bug spotted by Eli's eagle eyes 
llvm-svn: 53447
 2008-07-11 06:36:01 +00:00
Chris Lattner
3d40848bfd simplify and merge a bunch of code. Instead of comparing against 
the min/max values for an integer type, compare against the min/max
values we can prove contain the input.  This might be a tighter bound,
so this is general goodness.

llvm-svn: 53446
 2008-07-11 05:40:05 +00:00
Chris Lattner
d1198896ae fold away (x <= cst) earlier, allowing us to not have to 
handle them in some code.

llvm-svn: 53445
 2008-07-11 05:08:55 +00:00
Chris Lattner
16b8ae98c1 Fix folding of icmp's of i1 where the comparison is signed. The code 
was using the algorithm for folding unsigned comparisons which is
completely wrong.  This has been broken since the signless types change.

llvm-svn: 53444
 2008-07-11 04:20:58 +00:00
Chris Lattner
f3f6b6d7af Fix a bogus optimization: folding (slt (zext i1 A to i32), 1) -> (slt i1 A, true) 
This cause a regression in InstCombine/JavaCompare, which was doing the right
thing on accident.  To handle the missed case, generalize the comparisons based
on masked bits a little bit to handle comparisons against the max value. For 
example, we can now xform (slt i32 (and X, 4), 4) -> (setne i32 (and X, 4), 4)

llvm-svn: 53443
 2008-07-11 04:09:09 +00:00
Matthijs Kooijman
ca5124a630 Restructure dead argument elimination, try #3 :-) 
Rewrite the DeadArgumentElimination pass, to use a more explicit tracking of
dependencies between return values and/or arguments. Also make the handling of
arguments and return values the same.

The pass now looks properly inside returned structs, but only at the first
level (ie, not inside nested structs).

This version fixed a few more bugs and was cleaned up a bit. It now passes all
of LLVM's testing, and should still pass SPEC2006. There is still a minor bug
with regard to returning nested structs. Since there is currently nothing that
emits such IR, I will fix that in a seperate commit (partly because it requires
a non-trivial fix).

llvm-svn: 53400
 2008-07-10 10:24:08 +00:00
Nick Lewycky
26ccb8e9a8 Fix overzealous optimization. Thanks to Duncan Sands for pointing out my error! 
llvm-svn: 53393
 2008-07-10 05:51:40 +00:00
Nick Lewycky
a7d102aca3 Simplify, suggested by Chris Lattner. 
llvm-svn: 53283
 2008-07-09 07:35:26 +00:00
Nick Lewycky
6341c5a7ec Fold (a < 8) && (b < 8) into (a|b) < 8 for unsigned less or greater than. 
llvm-svn: 53282
 2008-07-09 07:29:11 +00:00
Nick Lewycky
38fa84fa12 Fold ((1 << a) & 1) to (a == 0). 
llvm-svn: 53276
 2008-07-09 05:20:13 +00:00
Nick Lewycky
2a6469c9a5 Reduce x - y to -y when we know the 'x' part will get masked off anyways. 
llvm-svn: 53271
 2008-07-09 04:32:37 +00:00
Devang Patel
2b56d5281d If loop induction variable's start value is less then its exit value then do not split the loop. 
llvm-svn: 53265
 2008-07-09 00:12:01 +00:00
Chris Lattner
c144216d78 Fix PR2496, a really nasty bug which involved sinking volatile loads 
into phis.  This is actually the same bug as PR2262 /
2008-04-29-VolatileLoadDontMerge.ll, but I missed checking the first 
predecessor for multiple successors.  Testcase here:
InstCombine/2008-07-08-VolatileLoadMerge.ll

llvm-svn: 53240
 2008-07-08 17:18:32 +00:00
Evan Cheng
cf3a4ad46d Fix two serious LSR bugs. 
1. LSR runOnLoop is always returning false regardless if any transformation is made.
2. AddUsersIfInteresting can create new instructions that are added to DeadInsts. But there is a later early exit which prevents them from being freed.

llvm-svn: 53193
 2008-07-07 19:51:32 +00:00
Dan Gohman
c97817aac3 Make DenseMap's insert return a pair, to more closely resemble std::map. 
llvm-svn: 53177
 2008-07-07 17:46:23 +00:00
Nick Lewycky
94f9c5a42e Fix missed optimization opportunity when analyzing cast of mul and select. 
llvm-svn: 53151
 2008-07-05 21:19:34 +00:00
Owen Anderson
035bf4d2ca Use information already present in the ValueTable to fast-fail when we know there won't be a value number match. This speeds up GVN on a case where there are very few redundancies by ~25%. 
llvm-svn: 53108
 2008-07-03 17:44:33 +00:00
Devang Patel
dcfd567cc5 Do not try to update dominator info while manipulating CFG. This code does not handle all cases and keeps invalid dom info around some cases, which misleads other passes down stream. 
Right now, dom info is recaluclated in the end if the loop is switched.

llvm-svn: 53106
 2008-07-03 17:37:52 +00:00
Owen Anderson
1acfb69ad7 Remove the ability for ADCE to remove unreachable blocks in loop nests, because, as Eli pointed out, SimplifyCFG already does this. 
llvm-svn: 53104
 2008-07-03 17:21:41 +00:00
Bill Wendling
c4b5d8e1c3 Remove unused function. 
llvm-svn: 53090
 2008-07-03 07:10:03 +00:00
Devang Patel
6dd6992a45 Preserve dom info. 
llvm-svn: 53089
 2008-07-03 07:04:22 +00:00
Devang Patel
7a65306299 Remove extra FIXME 
llvm-svn: 53087
 2008-07-03 06:50:04 +00:00
Devang Patel
889fe6f848 Reconstruct dom info, if loop is unswitched. 
llvm-svn: 53086
 2008-07-03 06:48:21 +00:00
Devang Patel
f999e47e64 LoopUnswitch does not preserve dominator info in all cases. 
llvm-svn: 53085
 2008-07-03 05:55:03 +00:00
Devang Patel
f9e8484756 Undo previous patch. It is not that simple to fix dom info here. 
llvm-svn: 53062
 2008-07-03 00:08:13 +00:00
Devang Patel
db4a6944ec Preserve dom info while simplifing loop after the unswitch. 
llvm-svn: 53052
 2008-07-02 22:58:54 +00:00
Owen Anderson
9a7d657786 Use df_ext_iterator to capture the reachable set without allocating an extra set. 
Also, move large sets and vectors out of instance variables and onto the stack,
and give them more reasonable sizes.

llvm-svn: 53044
 2008-07-02 18:41:09 +00:00
Owen Anderson
0b0017e514 Avoid a redundant call. 
llvm-svn: 53040
 2008-07-02 18:15:31 +00:00
Owen Anderson
e20158affb Add support to ADCE for pruning unreachable blocks. This addresses the final 
part of PR2509.

llvm-svn: 53038
 2008-07-02 18:05:19 +00:00
Owen Anderson
764fe3df94 Use DenseSet rather than SmallPtrSet for the alive set. Using SmallPtrSet 
with a huge "size" parameter is actually quite inefficient.

llvm-svn: 53034
 2008-07-02 17:32:04 +00:00
Owen Anderson
5747d627e0 A better fix for PR2503 that doesn't pessimize GVN in the presence of unreachable blocks. 
llvm-svn: 53032
 2008-07-02 17:20:16 +00:00
Devang Patel
5d8e832471 reuse vectors. 
llvm-svn: 53007
 2008-07-02 01:44:29 +00:00
Devang Patel
9140e998b4 Fix comment. 
llvm-svn: 53006
 2008-07-02 01:31:19 +00:00
Devang Patel
68d9a25bcd Preserve loop data so that it is not fetched everytime it is needed. 
Keep track of currentLoop.

llvm-svn: 53005
 2008-07-02 01:18:13 +00:00
Evan Cheng
2005804de6 - Re-apply 52748 and friends with fix. GetConstantStringInfo() returns an empty string for ConstantAggregateZero case which surprises selectiondag. 
- Correctly handle memcpy from constant string which is zero-initialized.

llvm-svn: 52891
 2008-06-30 07:31:25 +00:00
Anton Korobeynikov
6f260767ec Revert (52748 and friends): 
Move GetConstantStringInfo to lib/Analysis. Remove
string output routine from Constant. Update all
callers. Change debug intrinsic api slightly to
accomodate move of routine, these now return values
instead of strings.

This unbreaks llvm-gcc bootstrap.

llvm-svn: 52884
 2008-06-29 17:57:03 +00:00
Eric Christopher
155c3679f6 Remove unused function. 
llvm-svn: 52749
 2008-06-26 01:19:35 +00:00
Eric Christopher
4f05c48718 Move GetConstantStringInfo to lib/Analysis. Remove 
string output routine from Constant. Update all
callers. Change debug intrinsic api slightly to
accomodate move of routine, these now return values
instead of strings.

llvm-svn: 52748
 2008-06-26 00:31:12 +00:00
Evan Cheng
5ed0e42cc3 Restore DeadArgElim back to 52570. It's breaking 447.dealII. 
llvm-svn: 52736
 2008-06-25 18:10:09 +00:00
Duncan Sands
93aacd5b48 Pacify gcc-4.3. 
llvm-svn: 52723
 2008-06-25 16:31:18 +00:00
Matthijs Kooijman
45bffc6580 Fix a (false) warning on darwin. 
llvm-svn: 52705
 2008-06-25 08:12:16 +00:00
Matthijs Kooijman
9b78534b71 Fix some cosmetics in comments. 
llvm-svn: 52704
 2008-06-25 08:10:21 +00:00
Evan Cheng
9a3db8fb91 - Use O(1) check of basic block size limit. 
- Avoid speculatively execute vector ops.

llvm-svn: 52703
 2008-06-25 07:50:12 +00:00
Chris Lattner
73b52018e9 Fix PR2488, a case where we deleted stack restores too aggressively. 
llvm-svn: 52702
 2008-06-25 05:59:28 +00:00
Dan Gohman
b9384c5e87 Revert 52645, the loop unroller changes. It caused a regression in 252.eon. 
llvm-svn: 52688
 2008-06-24 20:44:42 +00:00
Dan Gohman
e9f0a28c64 Fix a typo in a comment. 
llvm-svn: 52687
 2008-06-24 18:00:21 +00:00
Matthijs Kooijman
ff03ea8aeb Commit the new DeadArgElim pass again, this time with the gcc bootstrap failures fixed. 
Also add a testcase to reproduce the gcc bootstrap failure in very much reduced form.

llvm-svn: 52677
 2008-06-24 16:30:26 +00:00
Matthijs Kooijman
bb456f6b42 Rename a few variables to be more consistent. 
llvm-svn: 52672
 2008-06-24 09:14:10 +00:00
Dan Gohman
11d367fd0c Use use_empty() instead of getNumUses(), avoiding a use list traversal. 
llvm-svn: 52651
 2008-06-23 23:23:49 +00:00
Dan Gohman
24ec9f54bc Fix spelling and grammar in a comment. 
llvm-svn: 52648
 2008-06-23 22:11:52 +00:00
Dan Gohman
7f6ee1cd4b Revamp the loop unroller, extending it to correctly update PHI nodes 
in the presence of out-of-loop users of in-loop values and the trip
count is not a known multiple of the unroll count, and to be a bit
simpler overall. This fixes PR2253.

llvm-svn: 52645
 2008-06-23 21:29:41 +00:00
Evan Cheng
174f11c202 Disable PRE. It's breaking bootstrapping. 
llvm-svn: 52643
 2008-06-23 21:22:35 +00:00
Owen Anderson
0dcae02ad4 Tighten the conditions under which we do PRE, remove some unneeded code, and correct our preserved analyses list, since we 
do now change the CFG by splitting critical edges during PRE.

llvm-svn: 52631
 2008-06-23 17:49:45 +00:00
Chris Lattner
b992911447 minor tidying of comments. 
llvm-svn: 52630
 2008-06-23 17:11:23 +00:00
Owen Anderson
7d4e8f976c At Chris' suggestion, move the liveness and worklist datastructures into 
instance variables so they can be allocated just once, and reuse the worklist
as the dead list as well.

llvm-svn: 52618
 2008-06-23 06:13:12 +00:00
Dan Gohman
62d8bc0480 Improve LSR's dead-phi detection to handle use-def cycles 
with more than two nodes.

llvm-svn: 52617
 2008-06-22 20:44:02 +00:00
Dan Gohman
4ada89e819 Use Loop::block_iterator. 
llvm-svn: 52616
 2008-06-22 20:18:58 +00:00
Chris Lattner
d80c865a09 Fix PR2369 by making scalarrepl more careful about promoting 
structures.  Its default threshold is to promote things that are
smaller than 128 bytes, which is sane.  However, it is not sane
to do this for things that turn into 128 *registers*.  Add a cap
on the number of registers introduced, defaulting to 128/4=32.

llvm-svn: 52611
 2008-06-22 17:46:21 +00:00
Eli Friedman
369401ef95 Fix for PR2479: correctly optimize expressions like (a > 13) & (a == 
15).

See also PR1800, which is about the signed case.

llvm-svn: 52608
 2008-06-21 23:36:13 +00:00
Dan Gohman
91a43b082c Use Instruction::eraseFromParent(). 
llvm-svn: 52606
 2008-06-21 22:08:46 +00:00
Chris Lattner
5b0bc729b3 Fix warning when assertions disabled. 
llvm-svn: 52590
 2008-06-21 19:49:01 +00:00
Evan Cheng
2ff47edc37 Enable PRE. 
llvm-svn: 52574
 2008-06-21 07:26:53 +00:00
Evan Cheng
b65bceda9c Back out Matthijs' DAE patches. It's miscompiling gcc driver. 
llvm-svn: 52570
 2008-06-21 00:31:44 +00:00
Dan Gohman
6a75f18b3b Clean up a use of std::distance. 
llvm-svn: 52544
 2008-06-20 17:11:32 +00:00
Dan Gohman
fcc6f11fc3 Tidy up some commments and use the getAggregateOperand and 
getInsertedValueOperand accessors. Thanks Matthijs!

llvm-svn: 52543
 2008-06-20 16:41:17 +00:00
Dan Gohman
3968f90c4c Fix the conditions under which SCCP should examine insertvalue 
instructions. Thanks to Matthijs Kooijman for pointing this out!

llvm-svn: 52542
 2008-06-20 16:39:44 +00:00
Matthijs Kooijman
54efc9f60e 80 column and trailing whitespace fixes. 
llvm-svn: 52539
 2008-06-20 15:34:07 +00:00
Matthijs Kooijman
7a75a306ff Don't let DeadArgumentElimination attempt to update callers when the return 
type wasn't changed.

llvm-svn: 52538
 2008-06-20 15:25:43 +00:00
Matthijs Kooijman
9a9a6f1122 Don't let DeadArgElimination change the return type ({} into void and {T} 
into T) when no return values are actually dead.

llvm-svn: 52537
 2008-06-20 15:16:45 +00:00
Matthijs Kooijman
1d019c28b3 Explicitely track if any arguments or return values were removed in 
DeadArgumentElimination and assert that the function type does not change if
nothing was changed. This should catch subtle changes in function type that are
not intended.

llvm-svn: 52536
 2008-06-20 14:28:52 +00:00
Matthijs Kooijman
35ac78c162 Remove debug output. 
llvm-svn: 52535
 2008-06-20 14:03:35 +00:00
Matthijs Kooijman
a3222e3730 Recommit r52459, rewriting of the dead argument elimination pass. 
This is a fixed version that no longer uses multimap::equal_range, which
resulted in a pointer invalidation problem.

Also, DAE::InspectedFunctions was not really necessary, so it got removed.

Lastly, this version no longer applies the extra arg hack on functions who did
not have any arguments to start with.

llvm-svn: 52532
 2008-06-20 09:36:16 +00:00
Owen Anderson
5213d215e0 Really disable PRE. 
llvm-svn: 52531
 2008-06-20 08:59:13 +00:00
Chris Lattner
e588f546c5 Fix PR2471, which is a bug involving an invalid promotion from a conditional load. 
llvm-svn: 52525
 2008-06-20 05:12:56 +00:00
Owen Anderson
3231e506cb Change around the data structures used to store availability sets, resulting in a GVN+PRE that is faster that GVN alone was before. 
llvm-svn: 52521
 2008-06-20 01:15:47 +00:00
Dan Gohman
b4ee9dfc2d Teach SCCP about insertvalue and extractvalue, and about 
propagating constants across aggregate return values when
insertvalue and extractvalue are used.

llvm-svn: 52520
 2008-06-20 01:15:44 +00:00
Dan Gohman
029d1e045e Teach InlineFunction how to differentiate between multiple-value 
return statements and aggregate returns so that it handles both
correctly.

llvm-svn: 52519
 2008-06-20 01:03:44 +00:00
Evan Cheng
d4c055e1f8 Disable PRE for now. It seems to be breaking llvm-gcc bootstrapping. 
llvm-svn: 52518
 2008-06-20 01:01:07 +00:00
Owen Anderson
c979fcf8ff Add a hidden -disable-pre flag for testing purposes. This should be removed 
once benchmarking is completed.

llvm-svn: 52506
 2008-06-19 19:57:25 +00:00
Owen Anderson
35fb8dbfef PRE requires that critical edges be split. 
llvm-svn: 52505
 2008-06-19 19:54:19 +00:00
Bill Wendling
68bdf9f6d4 Remove dead code causing a warning. 
llvm-svn: 52502
 2008-06-19 18:00:44 +00:00
Dan Gohman
98d028eb42 Use the common API for adding instructions to basic blocks instead of 
using BasicBlock::getInstList.

llvm-svn: 52500
 2008-06-19 17:53:32 +00:00
Owen Anderson
87d761460e Be sure to remove values from the value numbering table after we delete them. 
This fixes a failure on povray.

llvm-svn: 52499
 2008-06-19 17:53:26 +00:00
Dan Gohman
a18aa3f3a2 Use Instruction::moveBefore instead of manipulating the instruction list 
directly.

llvm-svn: 52498
 2008-06-19 17:47:47 +00:00
Dan Gohman
01679b25c0 Avoid using BasicBlock::getInstList directly in a few places. 
llvm-svn: 52497
 2008-06-19 17:37:25 +00:00
Owen Anderson
aa850d32db Revert support for insertvalue and extractvalue instructions for the moment. 
GVN expects that all inputs which to an instruction fall somewhere in the value
hierarchy, which isn't true for these.

llvm-svn: 52496
 2008-06-19 17:25:39 +00:00
Dan Gohman
68c5bdd4f5 Delete dead code. 
llvm-svn: 52494
 2008-06-19 17:18:39 +00:00
Matthijs Kooijman
41c5b9a77c Use a CallSite to find the nth argument of a call/invoke instruction instead of 
using getOperand() directly. This makes things work with invoke instructions as
well.

llvm-svn: 52489
 2008-06-19 08:53:24 +00:00
Owen Anderson
5b8d39569b Add support for extractvalue and insertvalue instructions in GVN. 
llvm-svn: 52472
 2008-06-18 21:59:00 +00:00
Owen Anderson
3f78e260c1 Add local PRE to GVN. This only operates in cases where it would not increase code size, namely when the instantiated expression 
would only need to be created in one predecessor.

llvm-svn: 52471
 2008-06-18 21:41:49 +00:00
Chris Lattner
f9d9f0ec4c Fix the regressions on sext-misc.ll my patch yesterday caused. 
llvm-svn: 52466
 2008-06-18 18:11:55 +00:00
Owen Anderson
e680ac8dcb Revert r52459, which was causing an infinite loop or massive slowdown on MultiSource/Applications/SPASS, and possibly others as well. 
Please reapply once this is fixed.

llvm-svn: 52465
 2008-06-18 17:32:16 +00:00
Dan Gohman
82f9df016e Move LSR's private isZero function to a public SCEV member 
function, and make use of it in several places.

llvm-svn: 52463
 2008-06-18 16:23:07 +00:00
Matthijs Kooijman
b7e2818227 Rewrite the DeadArgumentElimination pass, to use a more explicit tracking of 
dependencies between return values and/or arguments. Also make the handling of
arguments and return values the same.

The pass now looks properly inside returned structs, but only at the first                                                                                     
level (ie, not inside nested structs).

Also add a testcase for testing various variations of (multiple) dead rerturn
values.

llvm-svn: 52459
 2008-06-18 11:12:53 +00:00
Matthijs Kooijman
8177832230 Reapply r52397 (make IPConstProp promote returned arguments), but fixed this 
time. Sorry for the trouble!

This time, also add a testcase, which I should have done in the first place...

llvm-svn: 52455
 2008-06-18 08:30:37 +00:00
Matthijs Kooijman
bb59138fa6 Reapply r52396, it was unrelated to the breakage (that was caused by r52397, my 
commit after this).

llvm-svn: 52453
 2008-06-18 08:09:27 +00:00
Chris Lattner
93da79f7a1 implement some simple bswap optimizations, rdar://5992453 
llvm-svn: 52442
 2008-06-18 04:33:20 +00:00
Chris Lattner
7e403da191 make truncate/sext elimination capable of changing phi's. This 
implements rdar://6013816 and the testcase in Transforms/InstCombine/sext-misc.ll.

llvm-svn: 52440
 2008-06-18 04:00:49 +00:00
Devang Patel
8f157a3670 Preserve dominance frontier while trivially unswitching loop. 
llvm-svn: 52438
 2008-06-18 02:16:38 +00:00
Owen Anderson
c1ac0c1c41 We don't want to find dependencies within the same block in this case. It leads to incorrect results because 
we're detecting something at or after the call we're querying on.

llvm-svn: 52433
 2008-06-17 22:27:06 +00:00
Chris Lattner
4be2e72cc5 revert recent patch which is causing widespread breakage. 
llvm-svn: 52415
 2008-06-17 17:06:43 +00:00
Duncan Sands
ec220a7c48 Fix typo that changed the logic to something wrong. 
Spotted by Nick Lewycky.

llvm-svn: 52411
 2008-06-17 15:55:30 +00:00
Matthijs Kooijman
dd32cb58b5 Learn IPConstProp to propagate arguments that are directly returned. Strictly 
speaking these are not constant values. However, when a function always returns
one of its arguments, then from the point of view of each caller the return
value is constant (or at least a known value) and can be replaced.

llvm-svn: 52397
 2008-06-17 12:20:24 +00:00
Matthijs Kooijman
f0adaf34a1 Learn IPConstProp to look at individual return values and propagate them 
individually.

Also learn IPConstProp how returning first class aggregates work, in addition
to old style multiple return instructions.

Modify the return-constants testscase to confirm this behaviour.

llvm-svn: 52396
 2008-06-17 12:02:52 +00:00
Dan Gohman
c1fd5f170b Refine the change in r52258 for avoiding use-before-def conditions 
when changing the stride of a comparison so that it's slightly
more precise, by having it scan the instruction list to determine
if there is a use of the condition after the point where the
condition will be inserted.

llvm-svn: 52371
 2008-06-16 22:34:15 +00:00
Evan Cheng
7b87eb0128 Switch over to SetVector to ensure same order of iterations do not vary across runs. 
llvm-svn: 52361
 2008-06-16 21:08:17 +00:00
Evan Cheng
6c6518787b Iterating over SmallPtrSet is not deterministic. 
llvm-svn: 52339
 2008-06-16 18:17:09 +00:00
Matthijs Kooijman
238b1e8d69 Pass around Instruction* instead of Instruction& in FindInsertedValue and friends. 
llvm-svn: 52318
 2008-06-16 13:13:08 +00:00
Matthijs Kooijman
dedcf00fcc 80 column fixes. 
llvm-svn: 52316
 2008-06-16 12:57:37 +00:00
Matthijs Kooijman
1dd7d9cdc1 Move FindScalarValue from InstructionCombining.cpp to ValueTracking.cpp. While 
I'm at it, rename it to FindInsertedValue.

The only functional change is that newly created instructions are no longer
added to instcombine's worklist, but that is not really necessary anyway (and
I'll commit some improvements next that will completely remove the need).

llvm-svn: 52315
 2008-06-16 12:48:21 +00:00
Chris Lattner
ac4fe3f51c Fix the crash on SimplifyLibCalls/2005-05-20-sprintf-crash.ll 
llvm-svn: 52295
 2008-06-16 04:10:21 +00:00
Chris Lattner
f9d43c9853 Fix a case where tailcallelim wouldn't set the changed bit when it made a change. 
llvm-svn: 52267
 2008-06-14 00:49:48 +00:00
Eli Friedman
11d4c94933 Don't skip over instructions other than loads that might read memory 
when trying to sink stores.

llvm-svn: 52259
 2008-06-13 22:02:12 +00:00
Dan Gohman
7f1fcc4339 Protect ChangeCompareStride from situations in which it is possible 
for it to generate use-before-def IR, such as in this testcase.

llvm-svn: 52258
 2008-06-13 21:43:41 +00:00
Eli Friedman
d38a639deb Make sure SimplifyStoreAtEndOfBlock doesn't mess with loops; the 
structure checks are incorrect if the blocks aren't distinct.
Fixes PR2435.

llvm-svn: 52257
 2008-06-13 21:17:49 +00:00
Wojciech Matyjewicz
d3d353dd68 Use recently added getTruncateOrZeroExtend method to make the code shorter. 
llvm-svn: 52251
 2008-06-13 17:02:03 +00:00
Gabor Greif
10de8c6c59 fix a minor deviation from the original in my previous commit 
llvm-svn: 52247
 2008-06-12 21:51:29 +00:00
Gabor Greif
509b3a75f4 op_iterator-ify some loops, low hanging fruit only, there is more 
llvm-svn: 52246
 2008-06-12 21:37:33 +00:00
Evan Cheng
5897328890 Do not speculatively execute an instruction by hoisting it to its predecessor BB if any of its operands are defined but not used in BB. The transformation will prevent the operand from being sunk into the use block. 
llvm-svn: 52244
 2008-06-12 21:15:59 +00:00
Evan Cheng
b0d847cf05 Revert 52223. 
llvm-svn: 52243
 2008-06-12 20:55:39 +00:00
Owen Anderson
22a982f9eb Switch GVN to use ScopedHashTable. 
llvm-svn: 52242
 2008-06-12 19:25:32 +00:00
Gabor Greif
a90427821b op_iterator-ify some loops, fix 80col violations 
llvm-svn: 52226
 2008-06-11 21:38:51 +00:00
Evan Cheng
7b7a321f64 For now, avoid generating FP select instructions in order to speculatively execute integer arithmetic instructions. FP selects are more likely to be expensive (even compared to branch on fcmp). This is not a wonderful solution but I rather err on the side of conservative. 
This fixes the heapsort performance regressions.

llvm-svn: 52224
 2008-06-11 19:18:20 +00:00
Evan Cheng
9b0c0a0f00 Avoid duplicating loop header which leads to unnatural loops (and just seem like general badness to me, likely to cause code explosion). 
Patch by Florian Brandner.

llvm-svn: 52223
 2008-06-11 19:07:54 +00:00
Matthijs Kooijman
0f9df32e12 Teach instruction combining about the extractvalue. It can succesfully fold 
useless insert-extract chains, similar to how it folds them for vectors.

Add a testcase for this.

llvm-svn: 52217
 2008-06-11 14:05:05 +00:00
Matthijs Kooijman
511d6a5cd3 Clarify a comment. 
llvm-svn: 52212
 2008-06-11 09:00:12 +00:00
Gabor Greif
519129edc8 op_iterator-ify loops 
llvm-svn: 52191
 2008-06-10 22:03:26 +00:00
Chris Lattner
806f0a8411 lower calls to abs to inline code, PR2337 
llvm-svn: 52138
 2008-06-09 08:26:51 +00:00
Chris Lattner
7864575654 Fix PR2411, where ip constant prop would propagate the 
result of a weak function.

llvm-svn: 52137
 2008-06-09 07:58:07 +00:00
Duncan Sands
fe2a970a5c Remove comparison methods for MVT. The main cause 
of apint codegen failure is the DAG combiner doing
the wrong thing because it was comparing MVT's using
< rather than comparing the number of bits.  Removing
the < method makes this mistake impossible to commit.
Instead, add helper methods for comparing bits and use
them.

llvm-svn: 52098
 2008-06-08 20:54:56 +00:00
Chris Lattner
4a896996cb Limit the icmp+phi merging optimization to the cases where it is profitable: 
don't make i1 phis when it won't be possible to eliminate them.

llvm-svn: 52097
 2008-06-08 20:52:11 +00:00
Evan Cheng
c7ed1b9258 Speculatively execute a block when the the block is the then part of a triangle shape and it contains a single, side effect free, cheap instruction. The branch is eliminated by adding a select instruction. i.e. 
Turn                                                                                                                                                                                                       
BB:                                                                                                                                                                                                        
    %t1 = icmp                                                                                                                                                                                             
    br i1 %t1, label %BB1, label %BB2                                                                                                                                                                      
BB1:                                                                                                                                                                                                       
    %t3 = add %t2, c                                                                                                                                                                                       
    br label BB2                                                                                                                                                                                           
BB2:                                                                                                                                                                                                       
=>                                                                                                                                                                                                         
BB:                                                                                                                                                                                                        
    %t1 = icmp                                                                                                                                                                                             
    %t4 = add %t2, c                                                                                                                                                                                       
    %t3 = select i1 %t1, %t2, %t3

llvm-svn: 52073
 2008-06-07 08:52:29 +00:00
Devang Patel
523ef2c2ea LoopSimplify preserves AA. 
llvm-svn: 52053
 2008-06-06 17:50:58 +00:00
Duncan Sands
d634afe3aa Wrap MVT::ValueType in a struct to get type safety 
and better control the abstraction.  Rename the type
to MVT.  To update out-of-tree patches, the main
thing to do is to rename MVT::ValueType to MVT, and
rewrite expressions like MVT::getSizeInBits(VT) in
the form VT.getSizeInBits().  Use VT.getSimpleVT()
to extract a MVT::SimpleValueType for use in switch
statements (you will get an assert failure if VT is
an extended value type - these shouldn't exist after
type legalization).
This results in a small speedup of codegen and no
new testsuite failures (x86-64 linux).

llvm-svn: 52044
 2008-06-06 12:08:01 +00:00
Zhou Sheng
06fc769e52 As Chris suggested, handle the situation if ShAmt larger than BitWidth, 
otherwise, opt might crash.

llvm-svn: 52041
 2008-06-06 08:32:05 +00:00
Zhou Sheng
eaa93efd52 If BitWidth equals to ShtAmt, the RHSKnownZero[BitWidth-ShiftAmt-1] will 
crash the opt. Just fix this.

Test case in llvm/test/Transforms/InstCombine/2008-06-05-ashr-crash.ll

llvm-svn: 52003
 2008-06-05 14:23:44 +00:00
Matthijs Kooijman
6e1c286f53 Learn ScalarReplAggregrates how stores and loads of first class aggregrates 
work and how to replace them into individual values. Also, when trying to
replace an aggregrate that is used by load or store with a single (large)
integer, don't crash (but don't replace the aggregrate either).

Also adds a testcase for both structs and arrays.

llvm-svn: 51997
 2008-06-05 12:51:53 +00:00
Matthijs Kooijman
775c91b2f5 Let StructRetPromotion check if all if its users are really calls or invokesn, 
not other instructions. This fixes a crash with the added testcase.

llvm-svn: 51992
 2008-06-05 08:57:20 +00:00
Matthijs Kooijman
df97b7b4a2 Let StructRetPromotion check if it's users are really calling it and not 
passing its pointer. Fixes test with added testcase.

llvm-svn: 51991
 2008-06-05 08:48:32 +00:00
Matthijs Kooijman
8e980a31d5 Use use_iterator::getOperandNo instead of CallSite::hasArgument to check if a 
function is passed as an argument instead of called. Also do this check a bit
earlier.

llvm-svn: 51990
 2008-06-05 08:34:25 +00:00
Matthijs Kooijman
1fd76cd396 Update comments and documentation to reflect that GCSE and ValueNumbering are 
deprecated by the GVN and GVNPRE passes.

llvm-svn: 51983
 2008-06-05 07:55:49 +00:00
Owen Anderson
264b60b69d Remove unneeded #include. 
llvm-svn: 51955
 2008-06-04 18:28:10 +00:00
Matthijs Kooijman
a03f85df05 Replace two manual loops with calls to CallSite::hasArguments (no functional changes). 
llvm-svn: 51947
 2008-06-04 16:57:50 +00:00
Duncan Sands
5a6c6a92c1 Change packed struct layout so that field sizes 
are the same as in unpacked structs, only field
positions differ.  This only matters for structs
containing x86 long double or an apint; it may
cause backwards compatibility problems if someone
has bitcode containing a packed struct with a
field of one of those types.
The issue is that only 10 bytes are needed to
hold an x86 long double: the store size is 10
bytes, but the ABI size is 12 or 16 bytes (linux/
darwin) which comes from rounding the store size
up by the alignment.  Because it seemed silly not
to pack an x86 long double into 10 bytes in a
packed struct, this is what was done.  I now
think this was a mistake.  Reserving the ABI size
for an x86 long double field even in a packed
struct makes things more uniform: the ABI size is
now always used when reserving space for a type.
This means that developers are less likely to
make mistakes.  It also makes life easier for the
CBE which otherwise could not represent all LLVM
packed structs (PR2402).
Front-end people might need to adjust the way
they create LLVM structs - see following change
to llvm-gcc.

llvm-svn: 51928
 2008-06-04 08:21:45 +00:00
Owen Anderson
2a072a6923 LoopIndexSplit can sometimes result in cases where a block in its own domfrontier. 
Don't crash when we encounter one of these.

llvm-svn: 51915
 2008-06-03 18:29:48 +00:00
Dan Gohman
5c60e1fdff Fix whitespace in whitespace-significant pseudocode in a comment. 
llvm-svn: 51890
 2008-06-03 00:57:21 +00:00
Devang Patel
b1798d2be0 Update dom tree. Fix PR 2372. 
llvm-svn: 51887
 2008-06-02 22:52:56 +00:00
Chris Lattner
ea60f0ccc3 move CannotBeNegativeZero to ValueTracking. Simplify some signbit comparisons. 
llvm-svn: 51864
 2008-06-02 01:29:46 +00:00
Chris Lattner
4960857273 move ComputeMaskedBits, MaskedValueIsZero, and ComputeNumSignBits 
out of instcombine into a new file in libanalysis.  This also teaches
ComputeNumSignBits about the number of sign bits in a constantint.

llvm-svn: 51863
 2008-06-02 01:18:21 +00:00
Owen Anderson
7700de3137 Fix two issues that Eli Friedman pointed out, where would misoptimized code like: 
char a[200];
init(a, a+200);

OR

int a[200];
char* b = (char*)a;
char* c = (char*)a;
foo(b, c);

llvm-svn: 51850
 2008-06-01 22:26:26 +00:00
Owen Anderson
00e422b2ea Don't remove the memcpy when call slot substitution fails. 
llvm-svn: 51848
 2008-06-01 21:52:16 +00:00
Duncan Sands
d14212a3e1 When simplifying a call to a bitcast function, tighten up 
the conditions for performing the transform when only the
function declaration is available: no longer allow turning
i32 into i64 for example.  Only allow changing between
pointer types, and between pointer types and integers of
the same size.  For return values ptr -> intptr was already
allowed; I added ptr -> ptr and intptr -> ptr while there.
As shown by a recent objc testcase, changing the way
parameters/return values are passed can be fatal when calling
code written in assembler that directly manipulates call
arguments and return values unless the transform has no
impact on the way they are passed at the codegen level.
While it is possible to imagine an ABI that treats integers
of pointer size differently to pointers, I don't think LLVM
supports any so the transform should now be safe while still
being useful.

llvm-svn: 51834
 2008-06-01 07:38:42 +00:00
Nick Lewycky
1bcd80adf7 Peer through sext/zext when looking for not(cmp). 
llvm-svn: 51819
 2008-05-31 19:01:33 +00:00
Nick Lewycky
b30afdb62b Add more i1 optimizations. add, sub, mul, s/udiv on i1 are now simplified away. 
llvm-svn: 51817
 2008-05-31 17:59:52 +00:00
Nick Lewycky
cdcdcddc85 Adding i1 is always Xor. 
llvm-svn: 51816
 2008-05-31 17:10:28 +00:00
Gabor Greif
d931decf37 rewrite operand loops to use iterators 
llvm-svn: 51789
 2008-05-30 21:24:22 +00:00
Owen Anderson
40022e00ef Since LCSSA switched over to DenseMap, we have to be more careful to avoid iterator invalidation. Fixes PR2385. 
llvm-svn: 51777
 2008-05-30 17:31:01 +00:00
Matthijs Kooijman
861df1986d Use eraseFromParent() instead of doing that manually in two places. 
llvm-svn: 51770
 2008-05-30 12:35:46 +00:00
Dan Gohman
d8b84813d5 const-ify getOpcode. 
llvm-svn: 51698
 2008-05-29 19:53:46 +00:00
Duncan Sands
18fb7b1fa3 Add a newline at the end of this file. 
llvm-svn: 51680
 2008-05-29 14:38:23 +00:00
Owen Anderson
bd3940abc7 Replace the old ADCE implementation with a new one that more simply solves 
the one case that ADCE catches that normal DCE doesn't: non-induction variable
loop computations.

This implementation handles this problem without using postdominators.

llvm-svn: 51668
 2008-05-29 08:45:13 +00:00
Owen Anderson
ccaf62ac5e Remove debugging code. 
llvm-svn: 51666
 2008-05-29 08:15:48 +00:00
Gabor Greif
b320ae0f07 convert more operand loops to iterator formulation 
llvm-svn: 51663
 2008-05-29 01:59:18 +00:00
Chris Lattner
7a7da4f9c3 Implement PR2370: memmove(x,x,size) -> noop. 
llvm-svn: 51636
 2008-05-28 05:30:41 +00:00