6 Commits

Author SHA1 Message Date
Chris Bieneman
89c9fe49ef Re-land: [MachO] Fixing ub in MachO BinaryFormat
This re-lands r333797 with a fix for big endian systems.

Original commit message:

This isn't encountered anywhere inside LLVM, so I wrote a test case to expose the issue and verify that it is fixed.

The basic problem is that the macho_load_command union contains all load comamnd structs. Load command structs in 32-bit macho files can be 32-bit aligned instead of 64-bit aligned.

There are some strange circumstances in which this can be exposed in a 64-bit macho if the load commands are invalid or if a 32-bit aligned load command is used. In the past we've worked around this type of problem with changes like r264232.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@333854 91177308-0d34-0410-b5e6-96231b3b80d8
2018-06-03 20:33:42 +00:00
Chris Bieneman
893c5df3e3 Revert "Re-land: [MachO] Fixing ub in MachO BinaryFormat"
This reverts commit r333803.

Still breaking on big endian. Will sort this out later.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@333805 91177308-0d34-0410-b5e6-96231b3b80d8
2018-06-01 23:09:37 +00:00
Chris Bieneman
a380a4e5ba Re-land: [MachO] Fixing ub in MachO BinaryFormat
This re-lands r333797 with a fix for big endian systems.

Original commit message:

This isn't encountered anywhere inside LLVM, so I wrote a test case to expose the issue and verify that it is fixed.

The basic problem is that the macho_load_command union contains all load comamnd structs. Load command structs in 32-bit macho files can be 32-bit aligned instead of 64-bit aligned.

There are some strange circumstances in which this can be exposed in a 64-bit macho if the load commands are invalid or if a 32-bit aligned load command is used. In the past we've worked around this type of problem with changes like r264232.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@333803 91177308-0d34-0410-b5e6-96231b3b80d8
2018-06-01 22:52:59 +00:00
Chris Bieneman
612077896b Revert "[MachO] Fixing ub in MachO BinaryFormat"
This reverts commit r333797.

This patch is failing on BigEndian bots. I will fix and re-land:

http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/19505/

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@333799 91177308-0d34-0410-b5e6-96231b3b80d8
2018-06-01 22:28:23 +00:00
Chris Bieneman
ca723b633f [MachO] Fixing ub in MachO BinaryFormat
This isn't encountered anywhere inside LLVM, so I wrote a test case to expose the issue and verify that it is fixed.

The basic problem is that the macho_load_command union contains all load comamnd structs. Load command structs in 32-bit macho files can be 32-bit aligned instead of 64-bit aligned.

There are some strange circumstances in which this can be exposed in a 64-bit macho if the load commands are invalid or if a 32-bit aligned load command is used. In the past we've worked around this type of problem with changes like r264232.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@333797 91177308-0d34-0410-b5e6-96231b3b80d8
2018-06-01 22:07:36 +00:00
Zachary Turner
19ca2b0f9d Move Object format code to lib/BinaryFormat.
This creates a new library called BinaryFormat that has all of
the headers from llvm/Support containing structure and layout
definitions for various types of binary formats like dwarf, coff,
elf, etc as well as the code for identifying a file from its
magic.

Differential Revision: https://reviews.llvm.org/D33843

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@304864 91177308-0d34-0410-b5e6-96231b3b80d8
2017-06-07 03:48:56 +00:00