Commit Graph
621 Commits
Author SHA1 Message Date
Ken VanDine efef589d0d Merge remote-tracking branch 'refs/remotes/origin/fix/validate-release-artifacts' into fix/validate-release-artifacts 2026-07-02 10:32:06 -04:00
Ken VanDineandClaude Sonnet 5 6296594e1b ci: prune stale release assets from families dropped in the current run
The release is reused across runs against the same tag (idempotent
create-or-get). If a family (e.g. rocm-therock) was complete and
published in an earlier run but the current run finds it incomplete and
drops it locally, its assets from that earlier run were never removed —
the release would keep looking complete for a family this run couldn't
actually reproduce.

The upload step now reconciles existing release assets against the
current ./artifact file set: anything not fully uploaded (a broken
partial upload, as before) or not present in this run's file set (stale
leftovers from a dropped family) gets deleted before uploading.

Addresses review feedback on lemonade-sdk/stable-diffusion.cpp#14. The
always() fix requested in the same review was already applied in
03e249d.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-07-02 10:31:42 -04:00
Ken VanDineandClaude Sonnet 5 40969fbb32 ci: run release job even when a build job fails
Without always(), GitHub Actions' default skip-if-a-needed-job-failed
behavior meant a single failed build job (e.g. one CUDA sm_* matrix leg,
several of which use fail-fast: false) could skip the release job
outright, before the per-family completeness check ever ran — silently
producing no release instead of a correct partial one.

The other issue found in the equivalent llama.cpp fix (a hard-fail step
that could block unrelated families) doesn't apply here: this workflow
has no cross-job merge step comparable to llama.cpp's Windows CPU-into-
other-zips step, so there's nothing else that needs the same treatment.

Follow-up to #14.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-07-02 10:31:42 -04:00
Ken VanDineandClaude Sonnet 5 f41bf4f420 ci: fail release if expected artifacts are missing, per backend family
Port the artifact-completeness gate from lemonade-sdk/llama.cpp#16 to
this repo's release job, adapted to its build matrix:

- cuda: 8 sm_* variants on ubuntu x64 + windows x64, plus sm_121-only
  on ubuntu arm64 (GB10) — 17 files total.
- rocm-therock: TheRock nightly ROCm 7.13.0 on windows + ubuntu.
- rocm-hipsdk: official/legacy HIP SDK ROCm on windows (7.1.1) +
  ubuntu (7.2.1) — kept separate from rocm-therock since they're
  different SDKs, not just different platforms of the same backend.
- cpu: ubuntu + windows avx2 builds.
- metal: macos-14 + macos-latest builds.

Each family is all-or-nothing: if any artifact in a family is
missing, every artifact for that family is dropped from the release
so a release never contains a partial/inconsistent set (e.g. CUDA
split across sm_* or platforms). Other families are unaffected by a
gap in one. A release with zero artifacts overall is never created.

Also brings the release/upload mechanism up to parity with
llama.cpp's: an idempotent create-or-get-release step (safe to
re-run after a partial failure) and a retrying, resumable asset
upload, replacing the old anzz1/action-create-release +
github-script@v3 flow.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-07-02 10:31:42 -04:00
Ken VanDine 1206d2da21 Merge pull request #15 from lemonade-sdk/fix/windows-cuda-bigobj
ci(windows-cuda): pass /bigobj to fix C1128 build failure
2026-07-02 16:30:15 +02:00
Ken VanDineandClaude Sonnet 5 bd5e37fcb9 ci: prune stale release assets from families dropped in the current run
The release is reused across runs against the same tag (idempotent
create-or-get). If a family (e.g. rocm-therock) was complete and
published in an earlier run but the current run finds it incomplete and
drops it locally, its assets from that earlier run were never removed —
the release would keep looking complete for a family this run couldn't
actually reproduce.

The upload step now reconciles existing release assets against the
current ./artifact file set: anything not fully uploaded (a broken
partial upload, as before) or not present in this run's file set (stale
leftovers from a dropped family) gets deleted before uploading.

Addresses review feedback on lemonade-sdk/stable-diffusion.cpp#14. The
always() fix requested in the same review was already applied in
03e249d.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-07-02 10:00:29 -04:00
Ken VanDine bd1c5f2d43 ci(windows-cuda): pass /bigobj to fix C1128 build failure
stable-diffusion.cpp's Windows CUDA build fails with:

  fatal error C1128: number of sections exceeded object file format
  limit: compile with /bigobj

src/stable-diffusion.cpp combined with the CUDA backend's generated
code exceeds MSVC's default COFF section limit per object file. The
windows-latest-cmake job already works around the same class of issue
with -DCMAKE_CXX_FLAGS='/bigobj'; apply the same flag to the CUDA
build.
2026-07-02 09:42:22 -04:00
Ken VanDineandClaude Sonnet 5 03e249db83 ci: run release job even when a build job fails
Without always(), GitHub Actions' default skip-if-a-needed-job-failed
behavior meant a single failed build job (e.g. one CUDA sm_* matrix leg,
several of which use fail-fast: false) could skip the release job
outright, before the per-family completeness check ever ran — silently
producing no release instead of a correct partial one.

The other issue found in the equivalent llama.cpp fix (a hard-fail step
that could block unrelated families) doesn't apply here: this workflow
has no cross-job merge step comparable to llama.cpp's Windows CPU-into-
other-zips step, so there's nothing else that needs the same treatment.

Follow-up to #14.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-07-02 09:39:12 -04:00
Ken VanDineandClaude Sonnet 5 15ba36d3e6 ci: fail release if expected artifacts are missing, per backend family
Port the artifact-completeness gate from lemonade-sdk/llama.cpp#16 to
this repo's release job, adapted to its build matrix:

- cuda: 8 sm_* variants on ubuntu x64 + windows x64, plus sm_121-only
  on ubuntu arm64 (GB10) — 17 files total.
- rocm-therock: TheRock nightly ROCm 7.13.0 on windows + ubuntu.
- rocm-hipsdk: official/legacy HIP SDK ROCm on windows (7.1.1) +
  ubuntu (7.2.1) — kept separate from rocm-therock since they're
  different SDKs, not just different platforms of the same backend.
- cpu: ubuntu + windows avx2 builds.
- metal: macos-14 + macos-latest builds.

Each family is all-or-nothing: if any artifact in a family is
missing, every artifact for that family is dropped from the release
so a release never contains a partial/inconsistent set (e.g. CUDA
split across sm_* or platforms). Other families are unaffected by a
gap in one. A release with zero artifacts overall is never created.

Also brings the release/upload mechanism up to parity with
llama.cpp's: an idempotent create-or-get-release step (safe to
re-run after a partial failure) and a retrying, resumable asset
upload, replacing the old anzz1/action-create-release +
github-script@v3 flow.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-07-02 09:23:26 -04:00
Ken VanDine db4801452e Merge pull request #13 from lemonade-sdk/kenvandine/arm64_cuda
ci: add sm_121 (GB10) CUDA arch for x86 and arm64
master-696-db48014 master-741-db48014 master-737-db48014 master-726-db48014 master-722-db48014 master-721-db48014 master-719-db48014 master-714-db48014 master-710-db48014 master-707-db48014 master-703-db48014 master-691-db48014 master-685-db48014
2026-06-11 23:17:25 +02:00
Ken VanDineandCopilot Autofix powered by AI 8cd9abef0f Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
2026-06-11 17:16:58 -04:00
Ken VanDineandCopilot 9e10190500 ci: bump Jimver/cuda-toolkit to v0.2.35 with CUDA 12.9.1
v0.2.22 does not include CUDA 12.9.x; v0.2.24 was the first release to
add it. Bump to latest v0.2.35 and use 12.9.1 (latest 12.9 patch).

Co-authored-by: Copilot <[email protected]>
2026-06-11 16:45:10 -04:00
Ken VanDineandCopilot f19563e9e3 ci: upgrade CUDA to 12.9 for sm_121 support
sm_121 (GB10/Blackwell) requires CUDA 12.9. Update ubuntu-latest-cuda,
windows-latest-cuda, and ubuntu-arm64-cuda jobs accordingly.

Co-authored-by: Copilot <[email protected]>
2026-06-11 16:15:03 -04:00
Ken VanDineandCopilot a8ec287fa5 ci: add sm_121 (GB10) CUDA arch for x86 and arm64
- Add sm_121 to ubuntu-latest-cuda and windows-latest-cuda matrices
- Add new ubuntu-arm64-cuda job targeting ubuntu-24.04-arm runner with sm_121
- Use CUDA sbsa (ARM64) package repo for arm64 CUDA Toolkit install
- Add ubuntu-arm64-cuda to release job needs

Co-authored-by: Copilot <[email protected]>
2026-06-11 15:29:38 -04:00
Ken VanDine bf6b2efbd1 Merge pull request #12 from kenvandine/windows-cuda-fix
fix(cuda): add -DGGML_CUDA=ON to Windows CUDA build
master-685-bf6b2ef
2026-06-10 04:10:20 +02:00
Ken VanDineandCopilot fb10de9a5c fix(cuda): add -DGGML_CUDA=ON to Windows CUDA build
The Windows CUDA cmake invocation was missing -DGGML_CUDA=ON, which
meant the ggml CUDA backend was never compiled in. Without it, the
build silently falls back to CPU even when the CUDA toolkit is
installed. This is the same fix already applied to the Linux CUDA
build in commit 6a68a98.

Fixes: lemonade-sdk/lemonade#2171 (sdcpp:cuda falls back to CPU on Windows + RTX 4090)

Co-authored-by: Copilot <[email protected]>
2026-06-09 21:42:34 -04:00
Ken VanDine b638fe9228 Merge pull request #11 from Phqen1x/lemonade
Standardize and fix CUDA artifact naming and packaging
master-679-b638fe9 master-685-b638fe9 master-672-b638fe9
2026-06-05 17:03:03 +02:00
Drew VanDine 2de7212d11 Merge pull request #13 from Phqen1x/fix-cuda-bundling
Fix cuda bundling
2026-06-05 09:09:10 -04:00
Drew VanDineandClaude Sonnet 4.6 6a68a98599 ci: fix CUDA compilation and bundle all ggml shared libs
Add -DGGML_CUDA=ON and -DCMAKE_CUDA_COMPILER explicitly to the Linux
CUDA cmake invocation so CUDA is actually compiled instead of silently
falling back to CPU when auto-detection fails.

Widen the ggml artifact collection from libggml-cuda.so only to
libggml*.so* (Linux) and ggml*.dll (Windows) to capture all ggml shared
libraries (core, base backend, cuda backend) regardless of where cmake
places them in the build tree.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-06-05 09:08:23 -04:00
Ken VanDine c2cc188ff3 Merge pull request #10 from Phqen1x/bundle-ggml-cuda
ci: bundle libggml-cuda.so/ggml-cuda.dll in CUDA release artifacts
master-672-c2cc188
2026-06-04 22:35:49 +02:00
Drew VanDineandClaude Sonnet 4.6 df4efd59c6 ci: bundle libggml-cuda.so/ggml-cuda.dll in CUDA release artifacts
The ggml CUDA backend is built as a shared library plugin when
SD_BUILD_SHARED_LIBS=ON. Bundle it alongside the CUDA runtime libs so
that CUDA inference works out of the box without the plugin being
missing at runtime.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-06-04 16:22:51 -04:00
Ken VanDine e3937d9654 Merge pull request #8 from kenvandine/add_ci_check
ci: validate release build on pull requests
master-672-e3937d9 master-669-e3937d9 master-666-e3937d9
2026-06-01 14:43:50 +02:00
Ken VanDine c00c8b87dc Merge pull request #9 from lemonade-sdk/copilot/fix-code-review-comment
ci: scope `contents: write` to release job only
2026-06-01 14:42:55 +02:00
copilot-swe-agent[bot] c3af5c187b Fix: use least-privilege permissions in CI workflow 2026-06-01 12:41:37 +00:00
copilot-swe-agent[bot] c6ebd5f180 Initial plan 2026-06-01 12:39:46 +00:00
Ken VanDineandClaude Opus 4.8 429bf57c94 ci: validate release build on pull requests
Add a pull_request trigger to build.yml so the release build is
validated on PRs, mirroring lemonade-sdk/llama.cpp. The pack/upload
and release jobs remain gated on schedule/create_release, so nothing
is published on a PR run.

Scope the trigger to the workflow file itself: the build jobs clone
source from upstream (leejet/stable-diffusion.cpp), so only changes
to this workflow can affect a PR run's outcome.

On PRs, the CUDA matrices build a single representative arch (sm_89)
instead of all seven; packaging logic is identical across sm_*, and
the full matrix still runs on schedule/dispatch.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
2026-06-01 07:41:33 -04:00
Ken VanDine da0c3b3764 Merge pull request #7 from Phqen1x/lemonade
Adding CUDA Support for stable-diffusion.cpp
2026-06-01 13:28:36 +02:00
Drew VanDine c0335cf7a0 Merge pull request #11 from Phqen1x/fix-powershell-parser
ci: fix PowerShell parser error in Windows CUDA pack step
2026-05-31 23:14:14 -04:00
copilot-swe-agent[bot] 9cffd0da35 Merge origin/lemonade into fix-powershell-parser 2026-06-01 03:10:30 +00:00
Drew VanDineandClaude Sonnet 4.6 7437d050c0 ci: fix PowerShell parser error in Windows CUDA pack step
Use multi-line array literal format for $runtimeDllPatterns and remove
the trailing backslash from the Copy-Item destination path, which was
causing an 'Unexpected token }' parser error at the foreach closing brace.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 23:07:24 -04:00
Drew VanDine 3930b7bc5b Merge pull request #10 from Phqen1x/fix-cuda-clone-ref
ci: pin CUDA clone steps to ref: master
2026-05-31 22:55:33 -04:00
Drew VanDineandClaude Sonnet 4.6 fa19b4115b ci: pin CUDA clone steps to ref: master
Without an explicit ref, actions/checkout makes a GitHub API call to
determine the default branch of leejet/stable-diffusion.cpp. With 14
parallel CUDA jobs all doing this simultaneously this call can fail,
presenting as a checkout error. Pinning to master skips the API call.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 22:53:11 -04:00
Ken VanDineandCopilot Autofix powered by AI 73bb113fc7 Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
2026-05-31 22:38:08 -04:00
Drew VanDine fc97199a70 Merge pull request #9 from Phqen1x/match-lemonade-cuda-bundling
ci: match lemonade-sdk/llama.cpp CUDA library bundling
2026-05-31 22:11:13 -04:00
Drew VanDineandClaude Sonnet 4.6 8018705329 ci: match lemonade-sdk/llama.cpp CUDA library bundling
Linux:
- Add libcudart.so*, libnvJitLink.so* to bundled runtime libs
- Use cp -av (preserves symlinks) instead of cp -v
- RPATH step now patches all ELF files via file(1) instead of glob

Windows:
- Add curand and nvjitlink to CUDA toolkit sub-packages
- Copy cudart64, cublas64, cublasLt64, curand64, nvJitLink DLLs
  from CUDA_PATH\bin before zipping

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 22:09:36 -04:00
Drew VanDine b7b403fb5f Merge pull request #8 from Phqen1x/fix-cuda-runtime-bundling
ci: bundle CUDA runtime libs for portability on both platforms
2026-05-31 21:55:55 -04:00
Drew VanDineandClaude Sonnet 4.6 cb80321973 ci: bundle CUDA runtime libs for portability on both platforms
Linux: add libcudart.so* to the bundled runtime libraries so binaries
can run on systems without a matching CUDA toolkit installed.

Windows: add id to cuda-toolkit step and robocopy cudart64/cublas64/
cublasLt64 DLLs into the zip so the build runs on machines without a
pre-installed CUDA runtime.

Addresses Copilot review comments on lemonade-sdk/stable-diffusion.cpp#7.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 21:55:41 -04:00
Drew VanDine fbb3d4e710 Merge pull request #7 from Phqen1x/fix-windows-cuda-back-to-zip
ci: revert Windows CUDA artifacts back to .zip
2026-05-31 20:03:42 -04:00
Drew VanDineandClaude Sonnet 4.6 c69f4790fa ci: revert Windows CUDA artifacts back to .zip
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 20:03:15 -04:00
Drew VanDine 855bd5e005 Merge pull request #6 from Phqen1x/fix-windows-cuda-format
ci: package Windows CUDA artifacts as .7z
2026-05-31 19:59:02 -04:00
Drew VanDineandClaude Sonnet 4.6 b55463d29b ci: package Windows CUDA artifacts as .7z (matches Lemonade expectation)
Lemonade's sd_server.cpp builds the Windows CUDA download URL with a
.7z extension. The CI was producing .zip, causing a 404 on download
which presented as an extraction failure.

Also adds .7z to the release upload script allowlist.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 19:58:49 -04:00
Drew VanDine 10a7ba771b Merge pull request #5 from Phqen1x/fix-cuda-names-final
ci: standardize CUDA artifact names and compression formats
2026-05-31 16:11:07 -04:00
Drew VanDineandClaude Sonnet 4.6 36778b2765 ci: standardize CUDA artifact names and compression formats
Linux:   sd-master-{hash}-ubuntu-cuda-sm_XX-x64.tar.xz
Windows: sd-master-{hash}-windows-cuda-sm_XX-x64.zip

Also adds .tar.xz support to the release upload script.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 16:10:52 -04:00
Drew VanDine 2791d9d088 Merge pull request #4 from Phqen1x/revert-cuda-artifact-names
ci: revert CUDA artifact names to original sd-*-bin-* format
2026-05-31 16:04:52 -04:00
Drew VanDineandClaude Sonnet 4.6 cb32062435 ci: revert CUDA artifact names to original sd-*-bin-* format
Restores the filenames introduced in the initial CUDA PR:
  sd-master-{hash}-bin-Linux-Ubuntu-22.04-x86_64-cuda-{sm}.zip
  sd-master-{hash}-bin-win-cuda-{sm}-x64.zip

Reverts the intermediate ubuntu-cuda-* and windows-cuda-* name
experiments, and drops the .tar.xz branch from the release upload script.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 16:04:17 -04:00
Drew VanDine 19bfe7d065 Merge pull request #3 from Phqen1x/fix-cuda-artifact-names-2
ci: use sd-{branch}-{hash}-ubuntu/windows-cuda-{sm}-x64 artifact names
2026-05-31 15:55:06 -04:00
Drew VanDineandClaude Sonnet 4.6 adb7fd07ec ci: use sd-{branch}-{hash}-ubuntu/windows-cuda-{sm}-x64 artifact names
Renames CUDA artifacts to match the format Lemonade SDK expects:
  sd-master-148f69f-ubuntu-cuda-sm_89-x64.tar.xz
  sd-master-148f69f-windows-cuda-sm_89-x64.zip

Also restores the sd-* download pattern in the release job and keeps
.tar.xz support in the upload script.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 15:54:35 -04:00
Drew VanDine 9356241a7d Merge pull request #2 from Phqen1x/fix-cuda-artifact-names
ci: fix CUDA artifact names to match Lemonade SDK expectations
2026-05-31 15:48:16 -04:00
Drew VanDineandClaude Sonnet 4.6 a0d011290f ci: fix CUDA artifact names to match Lemonade SDK expectations
Linux CUDA artifacts are now named ubuntu-cuda-sm_XX-x64.tar.xz and
Windows CUDA artifacts are named windows-cuda-sm_XX-x64.zip, matching
the filenames Lemonade SDK constructs when downloading from releases.

Also removes the sd-* pattern filter from the release download step so
CUDA artifacts (which don't carry the sd- prefix) are included, and
adds .tar.xz support to the release upload script.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-31 15:47:35 -04:00
Drew VanDine 80af588b41 Merge pull request #1 from Phqen1x/cuda-support
ci: add Linux and Windows CUDA builds per compute capability
2026-05-31 12:00:43 -04:00