When the subtitle toggle controls are disabled for a game, don't
read the value and then set config values based on it.
This caused "Override global audio settings" to always set "subtitles"
and "mute_speech" even when the controls were disabled.
Fixes bug #13007 where "Override global audio settings" always
mutes the speech clips in Hoyle4.
SSCI doesn't return zero; it doesn't return anything. This shouldn't
affect any games since no scripts should depend on a non-existent
return value, but this discrepancy came up while investigating a
fan script that accidentally relies on this.
The groovie engine is unconditionally trying to acess the
`Audio::makeMP3Stream` method, which won't exist if ScummVM is
being compiled without MAD. Other consumers use this `#ifdef` to
determine if they should try to call it, so I've made the same
change here.
This commit adds a fallback for the GOG version of I Have No Mouth... This
version is missing the AdLib instrument definition files which are necessary
to use the Miles driver. If these files are missing, the regular AdLib driver
is used, which has built-in instrument definitions. A warning is shown so the
user knows the music is inaccurate without the missing files.
The text positioning seemed to be correct in all cases I checked (which
admittedly weren't all of them). The original spaces characters
differently, but I would say that the original does it wrong. I typed
the same text in ResEdit, and it came out the way ScummVM draws it.
I see no reason for being that bug compatible with the original.
I didn't think anyone would notice that the lines of the Indy 3 text
boxes were spaced slightly differently in ScummVM than in the original.
I realized it wouldn't be as tricky as first thought to fix that, though
I may clean it up a bit later.
This fixes a tiny part of bug #12983.
The documentation for CpMac indicates that since Mac OS X 10.4
we can use cp instead, and thet CpMac will be deprecated. It looks
like it was finally removed in Xcode 13 as this is no longer
installed as part of the Xcode command line tools.
Also make sure links are preserved when using cp in the bundle make
target. The -P option is the default on macOS and the various Linux
I checked, but this may not be the case on all systems.
