142260 Commits

Author SHA1 Message Date
Alexander Izmailov
5f5874ff84 MM: XEEN: Annotate item generation code 2023-05-22 21:30:00 -07:00
Alexander Izmailov
dfdd6b2f6c XEEN: fix behavior when deleting all the characters 2023-05-22 20:54:31 -07:00
PushmePullyu
d18a4adaa2 ULTIMA: ULTIMA6: Fix crash in FM-Towns converse gump
MsgScroll::parse_token(): Skip token parsing when length is 0.

Prevents failed assertion when opening a converse gump with
the FM-Towns data files installed and game style set to "new style":

engines/ultima/shared/std/string.h:93:
 char& Ultima::Std::string::operator[](size_t):
 Assertion `idx < _size' failed.

The call chain is as follows:
ConverseGump::parse_token()
  parse_fm_towns_token(token) // <-- this can truncate string token->s
                                     to length 0
  MsgScroll::parse_token(token) // <-- token->s[0] is accessed here
                                       without checking length
2023-05-22 20:35:22 -07:00
PushmePullyu
e4c5c52fba ULTIMA: ULTIMA6: Fix out-of-bounds read in FM-Towns sound decoder
FMtownsDecoderStream::readBuffer():
Do not treat the contents of raw_audio_buf as 16-bit values
via READ_LE_UINT16. The FM-Towns audio consists of 8-bit samples,
so no endianness handling is needed.

This fixes an out-of-bounds read when the last element of
unsigned char *raw_audio_buf is accessed as an uint16.

The bug does not result in bad audio, since the additional bits are
zeroed in FMtownsDecoderStream::convertSample().
2023-05-22 20:32:20 -07:00
PushmePullyu
c4970c95dc ULTIMA: ULTIMA6: Fix crash in GUI on surface blit
SDL_LoadBMP: Return ManagedSurfaces with their PixelFormat
matching that of the screen.

This fixes a crash when a surface created from a bitmap is blitted
to the screen surface in a GUI dialog.
("ERROR: Surface::transBlitFrom: bytesPerPixel must be 1, 2, or 4")

The bug was introduced in commit
b458cedca493bcfdfba81bb66554251245489762
"IMAGE: Speed up 16/24/32bpp BMP decoding"
2023-05-22 20:16:16 -07:00
elasota
e980e80e53 VCRUISE: Add parsing and handling of "smpl" chunks in Schizm WAV files, which determine sound loop behavior 2023-05-22 21:54:41 -04:00
elasota
3b1246a4a4 VCRUISE: Correct changeL opcode behavior to fix the airship nav computer without also causing the infinite loop bug 2023-05-22 21:53:11 -04:00
elasota
ecd3d1b71f VCRUISE: Fix animation skip not working. Fix sounds started with SndPlayEx looping. 2023-05-22 21:53:11 -04:00
elasota
fee9e6e8a8 VCRUISE: Run one frame of the rotate animation after changing characters after heroSetPos if there are no idle animations to hopefully fix the wrong frame displaying. Also allow animations with sound to show the tray in Schizm. 2023-05-22 21:53:11 -04:00
elasota
c7b9bc1fc1 VCRUISE: Avoid reloading scripts from forced screen changes if the room didn't actually change 2023-05-22 21:53:11 -04:00
elasota
f2f4db29e5 VCRUISE: Adjust initial frame timing to absorb disk seeks without skipping as much. Prune unused functions and strings from scripts. 2023-05-22 21:53:11 -04:00
elasota
db396739fb VCRUISE: Remove obsolete comment 2023-05-22 21:53:11 -04:00
elasota
e4e5b2acfd VCRUISE: Add SndToBack opcode. 2023-05-22 21:53:10 -04:00
elasota
fb1a286204 VCRUISE: Fix wrong animation playing after entering the statue. Fix crash when solving bell puzzle. Fix heroSetPos error. Fix GetDigit not working correctly. 2023-05-22 21:53:10 -04:00
elasota
2b570b3605 VCRUISE: Increase gyro limit to 5, fixes crash in Schizm height meter puzzle. 2023-05-22 21:53:10 -04:00
ScummVM-Translations
c5a6c2883e I18N: Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: ScummVM/scummvm
Translate-URL: https://translations.scummvm.org/projects/scummvm/scummvm/
2023-05-22 23:43:16 +00:00
D G Turner
a944cc1af8 VCRUISE: Fix Parantheses Needed GCC Compiler Warning
This will need checking for correct grouping by elasota, so have
added FIXME comment.
2023-05-23 00:41:55 +01:00
ScummVM-Translations
3dee7bc8a8 I18N: Update translations templates 2023-05-22 22:12:19 +00:00
Donovan Watteau
605a184e6b DRAGONS: Print less noisy debug output by default 2023-05-22 23:12:07 +01:00
Orgad Shaneh
37fd4056a7 Sync scumm-md5.txt
Amends 48bcf5dc4b2b34bec15fb7377d297071a41dd5ea.
2023-05-23 00:04:39 +02:00
D G Turner
e092ea2a69 WATCHMAKER: Add FIXME Comment Regarding Sequence Point Issue
No functional change.
2023-05-22 23:02:04 +01:00
D G Turner
5300cc6d0a WATCHMAKER: Fix Sequence Point GCC Compiler Warning
This should be checked for the correct logic, as I am unsure if this
code sequence is the intended one. However, this is better than code
with sequence point ambiguity.
2023-05-22 22:56:43 +01:00
Paul Gilbert
b2d6206d37 MM: MM1: Remove debugging lines from Protect view 2023-05-21 21:16:01 -07:00
Paul Gilbert
0016fe5feb MM: MM1: Update minimap after moving before specials trigger 2023-05-21 21:02:27 -07:00
Paul Gilbert
9e28b236aa MM: MM1: Show Unlock message when door not present 2023-05-21 20:43:36 -07:00
Paul Gilbert
1db125aa8e MM: MM1: Further tweaks to interface buttons 2023-05-21 20:33:22 -07:00
Paul Gilbert
de0d431074 MM: MM1: Remove debug code for cycling interaction portraits 2023-05-21 19:29:48 -07:00
Paul Gilbert
4713caa3fa MM: MM1: Setting up interface buttons 2023-05-21 19:29:47 -07:00
Paul Gilbert
33b452a3a0 MM: MM1: Added F5/F7 keys to open save/load dialog 2023-05-21 19:29:46 -07:00
D G Turner
89b0580181 WATCHMAKER: Minor Refactor To Reduce GCC Compiler Warnings 2023-05-21 22:15:44 +01:00
ScummVM-Translations
5e8d9b71cb I18N: Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: ScummVM/scummvm
Translate-URL: https://translations.scummvm.org/projects/scummvm/scummvm/
2023-05-21 20:30:42 +00:00
Filippos Karapetis
a1eed24c22 SCI: More work on the Hoyle 5 poker logic 2023-05-21 23:30:12 +03:00
ScummVM-Translations
51d89f4a78 I18N: Update translations templates 2023-05-21 19:17:50 +00:00
AndywinXp
f484ad6545 SCUMM: SAMNMAX: Fix bug #14467
This was caused by the fact that the pre and post save screen scripts
were not being called, and this messed up the cursor state with savegames
created as quicksaves.

Also, renamed the variables containing said scripts numbers, so that
they are a little bit more meaningful now.
2023-05-21 21:17:36 +02:00
AndywinXp
a5fe613c3f SCUMM: SAMNMAX: Post-load fix for savegames presenting bug #14467
The root cause of the issue is not solved yet, but this would allow for the
affected savegames to still work.
2023-05-21 20:16:14 +02:00
AndywinXp
1a23804e52 SCUMM: SAMNMAX: Don't run post-load script for non-available quicksaves
Fixes part of #14467
2023-05-21 20:16:14 +02:00
AndywinXp
9926908983 SCUMM: SAMNMAX: Fix bug #14468
I really have no idea why I wrote the code in such a way that
it attempted to load stuff that was never saved in the first place,
and I guess we'll never know. Findings by athrxx!
2023-05-21 20:16:14 +02:00
ScummVM-Translations
c2cbe69d88 I18N: Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: ScummVM/scummvm
Translate-URL: https://translations.scummvm.org/projects/scummvm/scummvm/
2023-05-21 17:38:04 +00:00
Filippos Karapetis
40fb0c793c WATCHMAKER: Improve error handling and fix some compiler warnings
asserts aren't enabled in release builds, so solely relying on them for
error handling is not recommended
2023-05-21 20:37:31 +03:00
ScummVM-Translations
12da77457f I18N: Update translations templates 2023-05-21 11:31:26 +00:00
antoniou79
c162980d4d TOON: Save facing for characters
Saved game version increased to 6

Also added some comments and minor code formatting changes
2023-05-21 14:31:08 +03:00
D G Turner
d5eea395bb DIRECTOR: Restore Redundant Declaration Warning Fix in Grammar Parser Code
This is emitted by GCC if -Wredundant-decls is passed.

The Bison source files to generate this header should be modified to
fix this, but I am unclear on the required workflow.
2023-05-21 11:45:27 +01:00
neuromancer
9b5c57100d FREESCAPE: improved parsing of castle demo for amiga 2023-05-21 10:32:20 +02:00
neuromancer
1362dfe76e FREESCAPE: improved parsing of castle demo for amiga 2023-05-21 10:32:20 +02:00
neuromancer
37b6e9fb02 FREESCAPE: added start animation opcode 2023-05-21 10:32:20 +02:00
Filippos Karapetis
11d8771cf0 GROOVIE: Don't use uninitialized variable in triangle game logic 2023-05-21 11:27:47 +03:00
Paul Gilbert
305ec4f187 MM: MM1: Clicking on options button shows GMM 2023-05-20 22:00:31 -07:00
Paul Gilbert
bc58b0e83a MM: MM1: Change Views::Maps to Views::Interactions
This is for consistency with the ViewsEnh namespace
2023-05-20 21:22:48 -07:00
Paul Gilbert
829669fc35 MM: MM1: Changes for map 54 2023-05-20 21:14:59 -07:00
Paul Gilbert
2bdc525abe MM: MM1: Changes for wall messages 2023-05-20 21:14:58 -07:00