Eugene Sandulenko
8e409622f8
CREDITS: Add Lubomyr to Android porters
2016-05-17 19:30:07 +02:00
Eugene Sandulenko
921efd6880
KYRA: Remove redundant code.
...
item variable value is less than 33, that is, 32 max. item+1 is never > 33.
Thus, the clapping code is redundant.
2016-05-17 19:12:14 +02:00
Eugene Sandulenko
fcc94778e4
CINE: Remove useless code.
...
var_2 used to be always NULL after while() loop, thus, the first if()
condition is always false.
2016-05-17 19:11:07 +02:00
Eugene Sandulenko
f6283094ac
AGI: Remove useless code.
...
We set vtEntries to SCREENOBJECTS_MAX, thus, the loop
for (i = vtEntries; i < SCREENOBJECTS_MAX; i++) is a no-op.
2016-05-17 19:04:59 +02:00
Eugene Sandulenko
33abb6118f
ALL: Change main engine header guard defines to <directory>_<engine>_H
...
Recently we started to use this as new semantics, although in the past
we used simly <engine>_H. Now these guard defines are consistent with
rest of the files which are used in the engines.
2016-05-17 18:21:30 +02:00
Eugene Sandulenko
3aafeee19c
SCUMM HE: Started work on Complex Array Operations
2016-05-17 18:21:29 +02:00
Lothar Serra Mari
487a8103d4
NEWS/DE: Mention the lock-up fix for in-game animations in lab
2016-05-17 10:36:10 +02:00
Filippos Karapetis
41eb8ec50e
NEWS: Mention the lock-up fix for in-game animations in lab
2016-05-17 11:25:16 +03:00
Filippos Karapetis
b2ec7acbf7
LAB: Fix waiting for sounds embedded in animations
...
A regression of 75d1385c8d
2016-05-17 11:22:27 +03:00
Kirben
22e5fe8b4e
SCUMM: Add missing break in o70_startSound.
2016-05-17 16:11:04 +10:00
Kirben
e5ffd75330
AGOS: Fix potential buffer overflow.
2016-05-17 15:30:18 +10:00
Eugene Sandulenko
356ac37471
SCI: Removing redundant virtual destructor as per LordHoto's suggestion
2016-05-16 21:48:49 +02:00
Eugene Sandulenko
875f591704
SHERLOCK: Further clarification of virtual destructors. Thanks to LordHoto.
2016-05-16 19:52:34 +02:00
Eugene Sandulenko
03344d926f
SCI: Make the Window destructor actually virtual
2016-05-16 17:51:18 +02:00
Eugene Sandulenko
cbb403ff55
SHERLOCK: Remove non-virtual destructor which prevents the superclass one from execution.
2016-05-16 16:56:57 +02:00
Eugene Sandulenko
f6d8e0f5ed
SCI: Add virtual destructor
2016-05-16 16:56:57 +02:00
Eugene Sandulenko
1d5a127011
SAGA: Add safeguard warning for text access.
2016-05-16 16:56:57 +02:00
Eugene Sandulenko
c341738ab8
SAGA: Fix potential buffer overrun.
...
If we have _statusTextInputPos as 256, we're doing incrementing to 257
and storing 0 there. This will lead to memory overwrite.
2016-05-16 16:56:57 +02:00
Eugene Sandulenko
dd1838a3cb
LURE: Fix potential buffer overrun introduced in 8577606
2016-05-16 16:56:57 +02:00
Eugene Sandulenko
1de6a461ab
SCUMM HE: Clarify comment
2016-05-16 16:56:57 +02:00
Lothar Serra Mari
c46163dd31
NEWS: Add release date for 1.8.1
2016-05-16 11:58:46 +02:00
Eugene Sandulenko
97a2a9c622
Merge pull request #710 from vandalo/master
...
COMMON: Fix wrong warning message
2016-05-16 10:18:00 +02:00
Eugene Sandulenko
b46bb55444
Merge pull request #722 from Abde-/master
...
GUI: Redraw Widget when setAlign() called
2016-05-16 10:09:09 +02:00
Eugene Sandulenko
2cd0a99e2b
Merge pull request #745 from Cruel/3ds
...
3DS: New Backend
2016-05-16 10:05:00 +02:00
Eugene Sandulenko
9178fba4d7
Merge pull request #747 from salty-horse/gob_headers
...
GOB: Reduce audio header dependencies
2016-05-16 10:01:32 +02:00
Lothar Serra Mari
c3c78c17a9
Merge branch 'master' of https://github.com/scummvm/scummvm
2016-05-16 07:26:11 +02:00
Lothar Serra Mari
07a1bf5af2
DOCUMENTATION: Recommend HFSExplorer instead of HFVExplorer
...
for extracting Mac gamefiles. HFVExplorer seems a "little bit"
outdated, whereas HFSExplorer is under active development.
2016-05-16 07:20:29 +02:00
Johannes Schickel
2317e3fa58
KYRA: Simplify Kyra1 audio track filename handling
2016-05-15 16:13:25 +02:00
Johannes Schickel
18193d170e
Revert "KYRA: Plug memory leak"
...
This reverts commit 9909cc615d
.
This will likely cause invalid memory reads because it frees the last output
buffer which is used to keep files in memory. There is a possible memory leak
here, when the input data is not well formed. However, fixing this takes some
more effort than the solution in the reverted commit.
2016-05-15 15:48:17 +02:00
Johannes Schickel
3664caa29c
KYRA: Silence analysis tools about possible memory leaks
2016-05-15 15:45:05 +02:00
Johannes Schickel
109c54c95b
Revert "KYRA: Plug memory leak"
...
This reverts commit c22ca8ffb5
.
This revision caused invalid memory reads in Kyra1 DOS+FM-TOWNS.
2016-05-15 15:39:05 +02:00
Eugene Sandulenko
c22ca8ffb5
KYRA: Plug memory leak
2016-05-15 13:19:27 +02:00
Eugene Sandulenko
9909cc615d
KYRA: Plug memory leak
2016-05-15 13:14:37 +02:00
Eugene Sandulenko
7526cf82f2
FULLPIPE: Plug memory leak
2016-05-15 13:07:23 +02:00
Eugene Sandulenko
6858dbe2c2
ACCESS: Fix memory leak
2016-05-15 12:35:23 +02:00
Eugene Sandulenko
a3d1ecb7d1
JANITORIAL: Remove trailing spaces
2016-05-15 12:34:32 +02:00
Eugene Sandulenko
1b7bb9ee6d
ACCESS: Plug memory leak
2016-05-15 12:30:52 +02:00
Eugene Sandulenko
20433e3476
ACCESS: Plug memory leak
2016-05-15 12:29:35 +02:00
Eugene Sandulenko
33184e822d
AUDIO: Plug potential memory leak
2016-05-15 12:26:15 +02:00
Eugene Sandulenko
384e45424e
SCUMM HE: Document o100_arrayOps()
2016-05-15 10:56:42 +02:00
Eugene Sandulenko
8d611a061e
SCUMM HE: Show stub warnings
2016-05-15 10:56:12 +02:00
Eugene Sandulenko
05419d7c35
SCUMM HE: Hid another noisy debug message
2016-05-15 10:54:59 +02:00
Eugene Sandulenko
6d941a3594
SCUMM HE: Marked sprite subopcodes and better field names
2016-05-14 15:58:21 +02:00
Eugene Sandulenko
cc6be145b7
SCUMM HE: Fixes and comments to video playback code
2016-05-14 15:29:11 +02:00
Eugene Sandulenko
a65617daa2
SCUMM HE: Hid noisy debug output deeper
2016-05-14 15:28:49 +02:00
Eugene Sandulenko
8156201f28
WINTERMUTE: Remove redundant check.
...
If new() was unsuccessful, then we should bail out immediately,
but we always assume we have enough memory for ScummVM.
2016-05-14 11:48:33 +02:00
Eugene Sandulenko
e482fd8a1a
SWORD1: Remove redundant check.
...
We're doing assert() in the same function.
2016-05-14 11:44:36 +02:00
Eugene Sandulenko
b83672070a
SKY: Add safety check
2016-05-14 11:42:43 +02:00
Eugene Sandulenko
a088d1fb10
PRINCE: Remove redundant check
2016-05-14 11:34:41 +02:00
Eugene Sandulenko
4435902f1e
PEGASUS: Add safety check.
...
The code which follows in the method has this check, assuming that
a null dereference is potentially possible.
2016-05-14 11:31:51 +02:00