libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-17 23:27:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
72,645 Commits 5 Branches 5 Tags 1.8 GiB
921efd6880
Commit Graph

2824 Commits

Author SHA1 Message Date
Eugene Sandulenko
921efd6880 KYRA: Remove redundant code. 
item variable value is less than 33, that is, 32 max. item+1 is never > 33.
Thus, the clapping code is redundant.
 2016-05-17 19:12:14 +02:00
Johannes Schickel
2317e3fa58 KYRA: Simplify Kyra1 audio track filename handling 2016-05-15 16:13:25 +02:00
Johannes Schickel
18193d170e Revert "KYRA: Plug memory leak" 
This reverts commit 9909cc615d.

This will likely cause invalid memory reads because it frees the last output
buffer which is used to keep files in memory. There is a possible memory leak
here, when the input data is not well formed. However, fixing this takes some
more effort than the solution in the reverted commit.
 2016-05-15 15:48:17 +02:00
Johannes Schickel
3664caa29c KYRA: Silence analysis tools about possible memory leaks 2016-05-15 15:45:05 +02:00
Johannes Schickel
109c54c95b Revert "KYRA: Plug memory leak" 
This reverts commit c22ca8ffb5.

This revision caused invalid memory reads in Kyra1 DOS+FM-TOWNS.
 2016-05-15 15:39:05 +02:00
Eugene Sandulenko
c22ca8ffb5 KYRA: Plug memory leak 2016-05-15 13:19:27 +02:00
Eugene Sandulenko
9909cc615d KYRA: Plug memory leak 2016-05-15 13:14:37 +02:00
Johannes Schickel
30cae4d12d KYRA: Initialize variable before usage. 
Thanks to salty-horse for reporting.
 2016-04-15 00:26:17 +02:00
Ori Avtalion
3564032330 JANITORIAL: Reduce audio header dependencies 2016-04-14 16:10:21 +03:00
Ori Avtalion
253e18c440 JANITORIAL: Reduce GUI header dependencies 2016-04-14 13:30:14 +03:00
athrxx
97a69022fd KYRA: (LOL) fix bug #7104 (LOL-CD: mixing sfx and voice mode does not work) 2016-04-03 13:06:16 +02:00
Matthew Hoops
aa6ff44440 BACKENDS: Only expose one set of functions for AudioCDManager 
Engines should only have to call one set of functions and not decide between the two. In fact, the 'emulation' API was documented to just call the 'real CD' API.
 2016-03-13 13:57:19 +01:00
Matthew Hoops
fc8480c845 KYRA: Ensure openCD() is called 2016-03-13 13:53:20 +01:00
Johannes Schickel
9059189e35 KYRA: Formatting fixes. 2016-02-27 17:28:01 +01:00
Johannes Schickel
e8847195b9 KYRA: Remove ADGF_TESTING from EoB 1+2. 2016-02-27 17:28:01 +01:00
Johannes Schickel
56fc42c2f7 KYRA: Let listSaves return list sorted on slot numbers. 2016-02-25 21:39:45 +01:00
Alexandre Detiste
6c298e964f JANITORIAL: Typos detected with lintian & grep 2016-02-15 18:27:02 +01:00
Johannes Schickel
4012482561 KYRA: Run astyle on sound.cpp. 2016-02-09 09:54:04 +01:00
Johannes Schickel
a74341508f KYRA: Cleanup listing of actual save slots in GUI::updateSaveFileList. 2016-01-26 17:00:38 +01:00
Johannes Schickel
4d7dda0b5c KYRA: Only request actual save slots in listSaves. 2016-01-26 16:35:30 +01:00
athrxx
13f30fb46b KYRA: (LOK/PC-98) - add missing string resource 2015-11-10 18:38:33 +01:00
athrxx
4ec41c291e AUDIO: (FM-TOWNS) - cleanup euphony code 
(rework parts of the code + improve naming of variables/functions)
 2015-11-09 18:41:06 +01:00
Matthew Hoops
bed9da8b9d AUDIO: Remove all AudioStream access to OPL 2015-07-07 20:19:47 -04:00
Matthew Hoops
5803dffead KYRA: Use the built-in OPL timer 2015-07-07 20:19:43 -04:00
Matthew Hoops
2e8f9dcec9 AUDIO: Remove the sample rate configuration from the OPL code 2015-07-07 20:19:42 -04:00
Matthew Hoops
f1f29302f5 AUDIO: Remove the legacy OPL API 2015-07-07 20:19:42 -04:00
Torbjörn Andersson
6d08055db3 KYRA: Update comment since the file it pointed to moved 
Also, ScummVM does have a more modern FMOPL implementation now, so
there's no need to bring up other implementations.
 2015-05-21 22:49:29 +02:00
Filippos Karapetis
ceab7a8742 KYRA: Remove trailing whitespace 2014-10-28 16:07:16 +02:00
athrxx
f76e02e5d6 KYRA: (EOB) - add support for Italian fan translation of EOB I 2014-10-11 19:28:14 +02:00
Thierry Crozat
d89a5a6352 KYRA: Update list of files that contain translatable strings 2014-10-04 01:02:44 +01:00
D G Turner
261d15d007 KYRA (LOL): Fix bug #6727 due to incorrect assertion range. 
This was the bug with "Engine assertion at various dialogues if no items
in inventory".
 2014-09-07 09:32:12 +01:00
Johannes Schickel
183f8eea43 KYRA: Slight cleanup. 2014-08-24 00:57:39 +02:00
Johannes Schickel
2f547a887c KYRA: Constify base type for some pointers in AdLibDriver. 2014-08-24 00:57:39 +02:00
Johannes Schickel
c5dfe1d917 KYRA: Add safety checks for getProgram/getInstrument return values. 
This fixes a crash in Hand of Fate when scaring off the rat by using the
swampsnake potion on Zanthia. This crash is timing sensitive since the game is
stopping the offending sound resource at this point. If it still gets to the
instruction setting up an invalid instrument, it will crash ScummVM with in
invalid read.
 2014-08-24 00:57:39 +02:00
Johannes Schickel
3612f88025 KYRA: Extend safety check inside AdLibDriver::getProgram. 
This also removes an TODO and replaces it with a comment explaining this
safety check.
 2014-08-24 00:52:34 +02:00
Johannes Schickel
96a901d1fb KYRA: Adpot debugger command function naming to match our guidelines. 2014-05-27 02:04:08 +02:00
Johannes Schickel
30d64edac4 ALL: Make Debugger command function names conform to our guidelines. 2014-05-27 02:04:08 +02:00
Johannes Schickel
ae4ffe01f0 ALL: Rename Debugger::DCmd_Register to Debugger::registerCmd. 2014-05-27 02:04:08 +02:00
Johannes Schickel
daa8d57a86 ALL: Rename Debugger::DebugPrintf to Debugger::debugPrintf. 2014-05-27 02:04:07 +02:00
Johannes Schickel
9cc4c42024 KYRA: Extend HACK to select CD audio for Kyra2 TOWNS. 
Formerly we only checked track1.$EXT but we also support track01.$EXT. Guess
this is a good example why we need to reconsider how we will handle detection
of presense of CD audio tracks in general...
 2014-04-18 23:58:22 +02:00
athrxx
e53a2b18e9 KYRA: (LOL) - fix LoLEngine::updateCompass() 2014-03-17 21:32:43 +01:00
athrxx
2e8f2ba822 KYRA: fix static resources in Russian fan translation 
(some messed up strings)
 2014-03-17 21:32:41 +01:00
Johannes Schickel
90dbc2e4c3 KYRA: Slight constant name cleanup. 2014-02-24 01:38:24 +01:00
Johannes Schickel
b79c2156d0 KYRA: Make GPL headers consistent in themselves. 2014-02-18 02:39:35 +01:00
Johannes Schickel
08738ac697 KYRA: Fix monster idle animation in EoB 1+2. (bug #6523) 
The bug mentioned is called "EOB1: Monster idle animation broken".
 2014-02-07 15:25:05 +01:00
Johannes Schickel
cfb0492cbb KYRA: Fix scrolling credits in HoF. 2014-02-05 15:07:40 +01:00
Johannes Schickel
fd312ddfe3 KYRA: Slight formatting fix. 2014-01-18 03:27:57 +01:00
Torbjörn Andersson
18ef3ed6b3 KYRA: Make pointers to VQAHeader const 
This is just to enforce the idea that VQADecoder owns the VQAHeader
and that the audio/video tracks are only allowed to look at it, not
change it.
 2014-01-18 03:18:40 +01:00
Torbjörn Andersson
16d36224e2 KYRA: Restructure the VQA decoder, as suggested by clone2727 
Untangled the audio and video track from each other, and the parsing
of the stream from the decoding of its data. Also fixed a memory leak
as it turns out deleting a Surface doesn't free its data. You have to
call free() in it.

I have only checked the intro, not every cutscene, but that seems to
work fine at least.
 2014-01-18 03:18:40 +01:00
Torbjörn Andersson
238aa2be2a KYRA: Let the VQA decoder draw directly to the backend 
As an alternative to using the Screen class's functions, we can let
the VQA decoder draw directly to the backend. This won't work if the
game uses "hi-res mode", but I don't think that's ever the case for
Malcolm's Revenge. I believe the KyraEngine_MR::playVQA() function
ensures that the screen is properly updated after the movie has
finished.

This almost limits the VQA rewrite to vqa.cpp and vqa.h. Whether it's
better this way than changing the Screen functions to take a 'pitch'
parameter...? I don't know. But it's an alternative.
 2014-01-18 03:18:40 +01:00